From: Vignesh R <vigneshr@ti.com> To: Mark Brown <broonie@kernel.org> Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org> Subject: Re: [PATCH 2/2] spi: spi-ti-qspi: Use bounce buffer if read buffer is not DMA'ble Date: Mon, 3 Apr 2017 11:52:27 +0530 [thread overview] Message-ID: <f16fb10d-a659-a9e3-d48c-9350f7656421@ti.com> (raw) In-Reply-To: <201704030704.3H2aUqA0%fengguang.wu@intel.com> On Monday 03 April 2017 05:03 AM, kbuild test robot wrote: > Hi Vignesh, > > [auto build test WARNING on spi/for-next] > [also build test WARNING on v4.11-rc4 next-20170331] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Vignesh-R/spi-ti-qspi-Handle-vmalloc-d-buffers/20170403-030332 > base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next > config: x86_64-allmodconfig (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > All warnings (new ones prefixed by >>): Thanks for the report. I will fix below warnings in the next version. > > include/linux/compiler.h:264:8: sparse: attribute 'no_sanitize_address': unknown attribute > drivers/spi/spi-ti-qspi.c:449:35: sparse: incompatible types in comparison expression (different type sizes) > drivers/spi/spi-ti-qspi.c: In function 'ti_qspi_dma_bounce_buffer': >>> drivers/spi/spi-ti-qspi.c:440:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > unsigned int to = (unsigned int)msg->buf; > ^ > In file included from drivers/spi/spi-ti-qspi.c:16:0: > include/linux/kernel.h:755:16: warning: comparison of distinct pointer types lacks a cast > (void) (&min1 == &min2); \ > ^ > include/linux/kernel.h:758:2: note: in expansion of macro '__min' > __min(typeof(x), typeof(y), \ > ^~~~~ >>> drivers/spi/spi-ti-qspi.c:449:21: note: in expansion of macro 'min' > size_t xfer_len = min(QSPI_DMA_BUFFER_SIZE, readsize); > ^~~ >>> drivers/spi/spi-ti-qspi.c:455:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > memcpy((void *)to, qspi->rx_bb_addr, xfer_len); > ^ > > sparse warnings: (new ones prefixed by >>) > > include/linux/compiler.h:264:8: sparse: attribute 'no_sanitize_address': unknown attribute >>> drivers/spi/spi-ti-qspi.c:449:35: sparse: incompatible types in comparison expression (different type sizes) > drivers/spi/spi-ti-qspi.c: In function 'ti_qspi_dma_bounce_buffer': > drivers/spi/spi-ti-qspi.c:440:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > unsigned int to = (unsigned int)msg->buf; > ^ > In file included from drivers/spi/spi-ti-qspi.c:16:0: > include/linux/kernel.h:755:16: warning: comparison of distinct pointer types lacks a cast > (void) (&min1 == &min2); \ > ^ > include/linux/kernel.h:758:2: note: in expansion of macro '__min' > __min(typeof(x), typeof(y), \ > ^~~~~ > drivers/spi/spi-ti-qspi.c:449:21: note: in expansion of macro 'min' > size_t xfer_len = min(QSPI_DMA_BUFFER_SIZE, readsize); > ^~~ > drivers/spi/spi-ti-qspi.c:455:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > memcpy((void *)to, qspi->rx_bb_addr, xfer_len); > ^ > > vim +440 drivers/spi/spi-ti-qspi.c > > 434 } > 435 > 436 static int ti_qspi_dma_bounce_buffer(struct ti_qspi *qspi, > 437 struct spi_flash_read_message *msg) > 438 { > 439 size_t readsize = msg->len; > > 440 unsigned int to = (unsigned int)msg->buf; > 441 dma_addr_t dma_src = qspi->mmap_phys_base + msg->from; > 442 int ret = 0; > 443 > 444 /* > 445 * Use bounce buffer as FS like jffs2, ubifs may pass > 446 * buffers that does not belong to kernel lowmem region. > 447 */ > 448 while (readsize != 0) { > > 449 size_t xfer_len = min(QSPI_DMA_BUFFER_SIZE, readsize); > 450 > 451 ret = ti_qspi_dma_xfer(qspi, qspi->rx_bb_dma_addr, > 452 dma_src, xfer_len); > 453 if (ret != 0) > 454 return ret; > > 455 memcpy((void *)to, qspi->rx_bb_addr, xfer_len); > 456 readsize -= xfer_len; > 457 dma_src += xfer_len; > 458 to += xfer_len; > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > -- Regards Vignesh
WARNING: multiple messages have this Message-ID (diff)
From: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org> To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH 2/2] spi: spi-ti-qspi: Use bounce buffer if read buffer is not DMA'ble Date: Mon, 3 Apr 2017 11:52:27 +0530 [thread overview] Message-ID: <f16fb10d-a659-a9e3-d48c-9350f7656421@ti.com> (raw) In-Reply-To: <201704030704.3H2aUqA0%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> On Monday 03 April 2017 05:03 AM, kbuild test robot wrote: > Hi Vignesh, > > [auto build test WARNING on spi/for-next] > [also build test WARNING on v4.11-rc4 next-20170331] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Vignesh-R/spi-ti-qspi-Handle-vmalloc-d-buffers/20170403-030332 > base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next > config: x86_64-allmodconfig (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > All warnings (new ones prefixed by >>): Thanks for the report. I will fix below warnings in the next version. > > include/linux/compiler.h:264:8: sparse: attribute 'no_sanitize_address': unknown attribute > drivers/spi/spi-ti-qspi.c:449:35: sparse: incompatible types in comparison expression (different type sizes) > drivers/spi/spi-ti-qspi.c: In function 'ti_qspi_dma_bounce_buffer': >>> drivers/spi/spi-ti-qspi.c:440:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > unsigned int to = (unsigned int)msg->buf; > ^ > In file included from drivers/spi/spi-ti-qspi.c:16:0: > include/linux/kernel.h:755:16: warning: comparison of distinct pointer types lacks a cast > (void) (&min1 == &min2); \ > ^ > include/linux/kernel.h:758:2: note: in expansion of macro '__min' > __min(typeof(x), typeof(y), \ > ^~~~~ >>> drivers/spi/spi-ti-qspi.c:449:21: note: in expansion of macro 'min' > size_t xfer_len = min(QSPI_DMA_BUFFER_SIZE, readsize); > ^~~ >>> drivers/spi/spi-ti-qspi.c:455:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > memcpy((void *)to, qspi->rx_bb_addr, xfer_len); > ^ > > sparse warnings: (new ones prefixed by >>) > > include/linux/compiler.h:264:8: sparse: attribute 'no_sanitize_address': unknown attribute >>> drivers/spi/spi-ti-qspi.c:449:35: sparse: incompatible types in comparison expression (different type sizes) > drivers/spi/spi-ti-qspi.c: In function 'ti_qspi_dma_bounce_buffer': > drivers/spi/spi-ti-qspi.c:440:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > unsigned int to = (unsigned int)msg->buf; > ^ > In file included from drivers/spi/spi-ti-qspi.c:16:0: > include/linux/kernel.h:755:16: warning: comparison of distinct pointer types lacks a cast > (void) (&min1 == &min2); \ > ^ > include/linux/kernel.h:758:2: note: in expansion of macro '__min' > __min(typeof(x), typeof(y), \ > ^~~~~ > drivers/spi/spi-ti-qspi.c:449:21: note: in expansion of macro 'min' > size_t xfer_len = min(QSPI_DMA_BUFFER_SIZE, readsize); > ^~~ > drivers/spi/spi-ti-qspi.c:455:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > memcpy((void *)to, qspi->rx_bb_addr, xfer_len); > ^ > > vim +440 drivers/spi/spi-ti-qspi.c > > 434 } > 435 > 436 static int ti_qspi_dma_bounce_buffer(struct ti_qspi *qspi, > 437 struct spi_flash_read_message *msg) > 438 { > 439 size_t readsize = msg->len; > > 440 unsigned int to = (unsigned int)msg->buf; > 441 dma_addr_t dma_src = qspi->mmap_phys_base + msg->from; > 442 int ret = 0; > 443 > 444 /* > 445 * Use bounce buffer as FS like jffs2, ubifs may pass > 446 * buffers that does not belong to kernel lowmem region. > 447 */ > 448 while (readsize != 0) { > > 449 size_t xfer_len = min(QSPI_DMA_BUFFER_SIZE, readsize); > 450 > 451 ret = ti_qspi_dma_xfer(qspi, qspi->rx_bb_dma_addr, > 452 dma_src, xfer_len); > 453 if (ret != 0) > 454 return ret; > > 455 memcpy((void *)to, qspi->rx_bb_addr, xfer_len); > 456 readsize -= xfer_len; > 457 dma_src += xfer_len; > 458 to += xfer_len; > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > -- Regards Vignesh -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-03 6:22 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-31 11:49 [PATCH 0/2] spi-ti-qspi: Handle vmalloc'd buffers Vignesh R 2017-03-31 11:49 ` Vignesh R 2017-03-31 11:49 ` Vignesh R 2017-03-31 11:49 ` [PATCH 1/2] spi: Add can_dma like interface for spi_flash_read Vignesh R 2017-03-31 11:49 ` Vignesh R 2017-04-21 17:29 ` Applied "spi: Add can_dma like interface for spi_flash_read" to the spi tree Mark Brown 2017-04-21 17:29 ` Mark Brown 2017-04-21 17:29 ` Mark Brown 2017-03-31 11:49 ` [PATCH 2/2] spi: spi-ti-qspi: Use bounce buffer if read buffer is not DMA'ble Vignesh R 2017-03-31 11:49 ` Vignesh R 2017-04-02 23:33 ` kbuild test robot 2017-04-02 23:33 ` kbuild test robot 2017-04-02 23:33 ` kbuild test robot 2017-04-03 6:22 ` Vignesh R [this message] 2017-04-03 6:22 ` Vignesh R 2017-04-04 10:56 ` kbuild test robot 2017-04-04 10:56 ` kbuild test robot 2017-04-04 10:56 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f16fb10d-a659-a9e3-d48c-9350f7656421@ti.com \ --to=vigneshr@ti.com \ --cc=broonie@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.