All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: Add missing firmware entry for HAINAN
@ 2018-11-19 11:55 Takashi Iwai
       [not found] ` <20181119115512.18844-1-tiwai-l3A5Bk7waGM@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2018-11-19 11:55 UTC (permalink / raw)
  To: Alex Deucher, Christian König, David Zhou
  Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

Due to lack of MODULE_FIRMWARE() with hainan_mc.bin, the driver
doesn't work properly in initrd.  Let's add it.

Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1116239
Fixes: 8eaf2b1faaf4 ("drm/amdgpu: switch firmware path for SI parts")
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
index e1c2b4e9c7b2..73ad02aea2b2 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
@@ -46,6 +46,7 @@ MODULE_FIRMWARE("amdgpu/tahiti_mc.bin");
 MODULE_FIRMWARE("amdgpu/pitcairn_mc.bin");
 MODULE_FIRMWARE("amdgpu/verde_mc.bin");
 MODULE_FIRMWARE("amdgpu/oland_mc.bin");
+MODULE_FIRMWARE("amdgpu/hainan_mc.bin");
 MODULE_FIRMWARE("amdgpu/si58_mc.bin");
 
 #define MC_SEQ_MISC0__MT__MASK   0xf0000000
-- 
2.19.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/amdgpu: Add missing firmware entry for HAINAN
       [not found] ` <20181119115512.18844-1-tiwai-l3A5Bk7waGM@public.gmane.org>
@ 2018-11-19 12:03   ` Christian König
  2018-11-19 19:23     ` Alex Deucher
  0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2018-11-19 12:03 UTC (permalink / raw)
  To: Takashi Iwai, Alex Deucher, Christian König, David Zhou
  Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

Am 19.11.18 um 12:55 schrieb Takashi Iwai:
> Due to lack of MODULE_FIRMWARE() with hainan_mc.bin, the driver
> doesn't work properly in initrd.  Let's add it.
>
> Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1116239
> Fixes: 8eaf2b1faaf4 ("drm/amdgpu: switch firmware path for SI parts")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> index e1c2b4e9c7b2..73ad02aea2b2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> @@ -46,6 +46,7 @@ MODULE_FIRMWARE("amdgpu/tahiti_mc.bin");
>   MODULE_FIRMWARE("amdgpu/pitcairn_mc.bin");
>   MODULE_FIRMWARE("amdgpu/verde_mc.bin");
>   MODULE_FIRMWARE("amdgpu/oland_mc.bin");
> +MODULE_FIRMWARE("amdgpu/hainan_mc.bin");
>   MODULE_FIRMWARE("amdgpu/si58_mc.bin");
>   
>   #define MC_SEQ_MISC0__MT__MASK   0xf0000000

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/amdgpu: Add missing firmware entry for HAINAN
  2018-11-19 12:03   ` Christian König
@ 2018-11-19 19:23     ` Alex Deucher
  0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2018-11-19 19:23 UTC (permalink / raw)
  To: Christian Koenig
  Cc: Deucher, Alexander, Maling list - DRI developers, amd-gfx list

On Mon, Nov 19, 2018 at 7:03 AM Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> Am 19.11.18 um 12:55 schrieb Takashi Iwai:
> > Due to lack of MODULE_FIRMWARE() with hainan_mc.bin, the driver
> > doesn't work properly in initrd.  Let's add it.
> >
> > Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1116239
> > Fixes: 8eaf2b1faaf4 ("drm/amdgpu: switch firmware path for SI parts")
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>

Applied.  thanks!

Alex

> > ---
> >   drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> > index e1c2b4e9c7b2..73ad02aea2b2 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> > @@ -46,6 +46,7 @@ MODULE_FIRMWARE("amdgpu/tahiti_mc.bin");
> >   MODULE_FIRMWARE("amdgpu/pitcairn_mc.bin");
> >   MODULE_FIRMWARE("amdgpu/verde_mc.bin");
> >   MODULE_FIRMWARE("amdgpu/oland_mc.bin");
> > +MODULE_FIRMWARE("amdgpu/hainan_mc.bin");
> >   MODULE_FIRMWARE("amdgpu/si58_mc.bin");
> >
> >   #define MC_SEQ_MISC0__MT__MASK   0xf0000000
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-19 19:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-19 11:55 [PATCH] drm/amdgpu: Add missing firmware entry for HAINAN Takashi Iwai
     [not found] ` <20181119115512.18844-1-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-11-19 12:03   ` Christian König
2018-11-19 19:23     ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.