* [PATCH] crypto: atmel-i2c: Drop unused id parameter from atmel_i2c_probe()
@ 2023-01-31 8:13 ` Uwe Kleine-König
0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2023-01-31 8:13 UTC (permalink / raw)
To: Tudor Ambarus, Herbert Xu, David S. Miller
Cc: Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, linux-crypto,
linux-arm-kernel, kernel
id is unused in atmel_i2c_probe() and the callers have extra efforts to
determine the right parameter. So drop the parameter simplifying both
atmel_i2c_probe() and its callers.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
just found a nice optimisation while grepping for something else in the
tree ...
Best regards
Uwe
drivers/crypto/atmel-ecc.c | 3 +--
drivers/crypto/atmel-i2c.c | 2 +-
drivers/crypto/atmel-i2c.h | 2 +-
drivers/crypto/atmel-sha204a.c | 3 +--
4 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
index 12205e2b53b4..aac64b555204 100644
--- a/drivers/crypto/atmel-ecc.c
+++ b/drivers/crypto/atmel-ecc.c
@@ -313,11 +313,10 @@ static struct kpp_alg atmel_ecdh_nist_p256 = {
static int atmel_ecc_probe(struct i2c_client *client)
{
- const struct i2c_device_id *id = i2c_client_get_device_id(client);
struct atmel_i2c_client_priv *i2c_priv;
int ret;
- ret = atmel_i2c_probe(client, id);
+ ret = atmel_i2c_probe(client);
if (ret)
return ret;
diff --git a/drivers/crypto/atmel-i2c.c b/drivers/crypto/atmel-i2c.c
index 66e27f71e37e..83a9093eff25 100644
--- a/drivers/crypto/atmel-i2c.c
+++ b/drivers/crypto/atmel-i2c.c
@@ -324,7 +324,7 @@ static int device_sanity_check(struct i2c_client *client)
return ret;
}
-int atmel_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id)
+int atmel_i2c_probe(struct i2c_client *client)
{
struct atmel_i2c_client_priv *i2c_priv;
struct device *dev = &client->dev;
diff --git a/drivers/crypto/atmel-i2c.h b/drivers/crypto/atmel-i2c.h
index c1fdc04eac07..c0bd429ee2c7 100644
--- a/drivers/crypto/atmel-i2c.h
+++ b/drivers/crypto/atmel-i2c.h
@@ -167,7 +167,7 @@ struct atmel_i2c_work_data {
struct atmel_i2c_cmd cmd;
};
-int atmel_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id);
+int atmel_i2c_probe(struct i2c_client *client);
void atmel_i2c_enqueue(struct atmel_i2c_work_data *work_data,
void (*cbk)(struct atmel_i2c_work_data *work_data,
diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
index 272a06f0b588..4403dbb0f0b1 100644
--- a/drivers/crypto/atmel-sha204a.c
+++ b/drivers/crypto/atmel-sha204a.c
@@ -93,11 +93,10 @@ static int atmel_sha204a_rng_read(struct hwrng *rng, void *data, size_t max,
static int atmel_sha204a_probe(struct i2c_client *client)
{
- const struct i2c_device_id *id = i2c_client_get_device_id(client);
struct atmel_i2c_client_priv *i2c_priv;
int ret;
- ret = atmel_i2c_probe(client, id);
+ ret = atmel_i2c_probe(client);
if (ret)
return ret;
base-commit: f160a0e64f0f80a82f797ea7aa007e41ba8ed441
--
2.39.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] crypto: atmel-i2c: Drop unused id parameter from atmel_i2c_probe()
@ 2023-01-31 8:13 ` Uwe Kleine-König
0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2023-01-31 8:13 UTC (permalink / raw)
To: Tudor Ambarus, Herbert Xu, David S. Miller
Cc: Alexandre Belloni, linux-crypto, kernel, Claudiu Beznea,
linux-arm-kernel
id is unused in atmel_i2c_probe() and the callers have extra efforts to
determine the right parameter. So drop the parameter simplifying both
atmel_i2c_probe() and its callers.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
just found a nice optimisation while grepping for something else in the
tree ...
Best regards
Uwe
drivers/crypto/atmel-ecc.c | 3 +--
drivers/crypto/atmel-i2c.c | 2 +-
drivers/crypto/atmel-i2c.h | 2 +-
drivers/crypto/atmel-sha204a.c | 3 +--
4 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
index 12205e2b53b4..aac64b555204 100644
--- a/drivers/crypto/atmel-ecc.c
+++ b/drivers/crypto/atmel-ecc.c
@@ -313,11 +313,10 @@ static struct kpp_alg atmel_ecdh_nist_p256 = {
static int atmel_ecc_probe(struct i2c_client *client)
{
- const struct i2c_device_id *id = i2c_client_get_device_id(client);
struct atmel_i2c_client_priv *i2c_priv;
int ret;
- ret = atmel_i2c_probe(client, id);
+ ret = atmel_i2c_probe(client);
if (ret)
return ret;
diff --git a/drivers/crypto/atmel-i2c.c b/drivers/crypto/atmel-i2c.c
index 66e27f71e37e..83a9093eff25 100644
--- a/drivers/crypto/atmel-i2c.c
+++ b/drivers/crypto/atmel-i2c.c
@@ -324,7 +324,7 @@ static int device_sanity_check(struct i2c_client *client)
return ret;
}
-int atmel_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id)
+int atmel_i2c_probe(struct i2c_client *client)
{
struct atmel_i2c_client_priv *i2c_priv;
struct device *dev = &client->dev;
diff --git a/drivers/crypto/atmel-i2c.h b/drivers/crypto/atmel-i2c.h
index c1fdc04eac07..c0bd429ee2c7 100644
--- a/drivers/crypto/atmel-i2c.h
+++ b/drivers/crypto/atmel-i2c.h
@@ -167,7 +167,7 @@ struct atmel_i2c_work_data {
struct atmel_i2c_cmd cmd;
};
-int atmel_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id);
+int atmel_i2c_probe(struct i2c_client *client);
void atmel_i2c_enqueue(struct atmel_i2c_work_data *work_data,
void (*cbk)(struct atmel_i2c_work_data *work_data,
diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
index 272a06f0b588..4403dbb0f0b1 100644
--- a/drivers/crypto/atmel-sha204a.c
+++ b/drivers/crypto/atmel-sha204a.c
@@ -93,11 +93,10 @@ static int atmel_sha204a_rng_read(struct hwrng *rng, void *data, size_t max,
static int atmel_sha204a_probe(struct i2c_client *client)
{
- const struct i2c_device_id *id = i2c_client_get_device_id(client);
struct atmel_i2c_client_priv *i2c_priv;
int ret;
- ret = atmel_i2c_probe(client, id);
+ ret = atmel_i2c_probe(client);
if (ret)
return ret;
base-commit: f160a0e64f0f80a82f797ea7aa007e41ba8ed441
--
2.39.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: atmel-i2c: Drop unused id parameter from atmel_i2c_probe()
2023-01-31 8:13 ` Uwe Kleine-König
@ 2023-01-31 9:14 ` Tudor Ambarus
-1 siblings, 0 replies; 6+ messages in thread
From: Tudor Ambarus @ 2023-01-31 9:14 UTC (permalink / raw)
To: Uwe Kleine-König, Herbert Xu, David S. Miller
Cc: Alexandre Belloni, linux-crypto, kernel, Claudiu Beznea,
linux-arm-kernel
On 31.01.2023 10:13, Uwe Kleine-König wrote:
> id is unused in atmel_i2c_probe() and the callers have extra efforts to
> determine the right parameter. So drop the parameter simplifying both
> atmel_i2c_probe() and its callers.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
thanks!
> ---
> Hello,
>
> just found a nice optimisation while grepping for something else in the
> tree ...
>
> Best regards
> Uwe
>
> drivers/crypto/atmel-ecc.c | 3 +--
> drivers/crypto/atmel-i2c.c | 2 +-
> drivers/crypto/atmel-i2c.h | 2 +-
> drivers/crypto/atmel-sha204a.c | 3 +--
> 4 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
> index 12205e2b53b4..aac64b555204 100644
> --- a/drivers/crypto/atmel-ecc.c
> +++ b/drivers/crypto/atmel-ecc.c
> @@ -313,11 +313,10 @@ static struct kpp_alg atmel_ecdh_nist_p256 = {
>
> static int atmel_ecc_probe(struct i2c_client *client)
> {
> - const struct i2c_device_id *id = i2c_client_get_device_id(client);
> struct atmel_i2c_client_priv *i2c_priv;
> int ret;
>
> - ret = atmel_i2c_probe(client, id);
> + ret = atmel_i2c_probe(client);
> if (ret)
> return ret;
>
> diff --git a/drivers/crypto/atmel-i2c.c b/drivers/crypto/atmel-i2c.c
> index 66e27f71e37e..83a9093eff25 100644
> --- a/drivers/crypto/atmel-i2c.c
> +++ b/drivers/crypto/atmel-i2c.c
> @@ -324,7 +324,7 @@ static int device_sanity_check(struct i2c_client *client)
> return ret;
> }
>
> -int atmel_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id)
> +int atmel_i2c_probe(struct i2c_client *client)
> {
> struct atmel_i2c_client_priv *i2c_priv;
> struct device *dev = &client->dev;
> diff --git a/drivers/crypto/atmel-i2c.h b/drivers/crypto/atmel-i2c.h
> index c1fdc04eac07..c0bd429ee2c7 100644
> --- a/drivers/crypto/atmel-i2c.h
> +++ b/drivers/crypto/atmel-i2c.h
> @@ -167,7 +167,7 @@ struct atmel_i2c_work_data {
> struct atmel_i2c_cmd cmd;
> };
>
> -int atmel_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id);
> +int atmel_i2c_probe(struct i2c_client *client);
>
> void atmel_i2c_enqueue(struct atmel_i2c_work_data *work_data,
> void (*cbk)(struct atmel_i2c_work_data *work_data,
> diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
> index 272a06f0b588..4403dbb0f0b1 100644
> --- a/drivers/crypto/atmel-sha204a.c
> +++ b/drivers/crypto/atmel-sha204a.c
> @@ -93,11 +93,10 @@ static int atmel_sha204a_rng_read(struct hwrng *rng, void *data, size_t max,
>
> static int atmel_sha204a_probe(struct i2c_client *client)
> {
> - const struct i2c_device_id *id = i2c_client_get_device_id(client);
> struct atmel_i2c_client_priv *i2c_priv;
> int ret;
>
> - ret = atmel_i2c_probe(client, id);
> + ret = atmel_i2c_probe(client);
> if (ret)
> return ret;
>
>
> base-commit: f160a0e64f0f80a82f797ea7aa007e41ba8ed441
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: atmel-i2c: Drop unused id parameter from atmel_i2c_probe()
@ 2023-01-31 9:14 ` Tudor Ambarus
0 siblings, 0 replies; 6+ messages in thread
From: Tudor Ambarus @ 2023-01-31 9:14 UTC (permalink / raw)
To: Uwe Kleine-König, Herbert Xu, David S. Miller
Cc: Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, linux-crypto,
linux-arm-kernel, kernel
On 31.01.2023 10:13, Uwe Kleine-König wrote:
> id is unused in atmel_i2c_probe() and the callers have extra efforts to
> determine the right parameter. So drop the parameter simplifying both
> atmel_i2c_probe() and its callers.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
thanks!
> ---
> Hello,
>
> just found a nice optimisation while grepping for something else in the
> tree ...
>
> Best regards
> Uwe
>
> drivers/crypto/atmel-ecc.c | 3 +--
> drivers/crypto/atmel-i2c.c | 2 +-
> drivers/crypto/atmel-i2c.h | 2 +-
> drivers/crypto/atmel-sha204a.c | 3 +--
> 4 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
> index 12205e2b53b4..aac64b555204 100644
> --- a/drivers/crypto/atmel-ecc.c
> +++ b/drivers/crypto/atmel-ecc.c
> @@ -313,11 +313,10 @@ static struct kpp_alg atmel_ecdh_nist_p256 = {
>
> static int atmel_ecc_probe(struct i2c_client *client)
> {
> - const struct i2c_device_id *id = i2c_client_get_device_id(client);
> struct atmel_i2c_client_priv *i2c_priv;
> int ret;
>
> - ret = atmel_i2c_probe(client, id);
> + ret = atmel_i2c_probe(client);
> if (ret)
> return ret;
>
> diff --git a/drivers/crypto/atmel-i2c.c b/drivers/crypto/atmel-i2c.c
> index 66e27f71e37e..83a9093eff25 100644
> --- a/drivers/crypto/atmel-i2c.c
> +++ b/drivers/crypto/atmel-i2c.c
> @@ -324,7 +324,7 @@ static int device_sanity_check(struct i2c_client *client)
> return ret;
> }
>
> -int atmel_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id)
> +int atmel_i2c_probe(struct i2c_client *client)
> {
> struct atmel_i2c_client_priv *i2c_priv;
> struct device *dev = &client->dev;
> diff --git a/drivers/crypto/atmel-i2c.h b/drivers/crypto/atmel-i2c.h
> index c1fdc04eac07..c0bd429ee2c7 100644
> --- a/drivers/crypto/atmel-i2c.h
> +++ b/drivers/crypto/atmel-i2c.h
> @@ -167,7 +167,7 @@ struct atmel_i2c_work_data {
> struct atmel_i2c_cmd cmd;
> };
>
> -int atmel_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id);
> +int atmel_i2c_probe(struct i2c_client *client);
>
> void atmel_i2c_enqueue(struct atmel_i2c_work_data *work_data,
> void (*cbk)(struct atmel_i2c_work_data *work_data,
> diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
> index 272a06f0b588..4403dbb0f0b1 100644
> --- a/drivers/crypto/atmel-sha204a.c
> +++ b/drivers/crypto/atmel-sha204a.c
> @@ -93,11 +93,10 @@ static int atmel_sha204a_rng_read(struct hwrng *rng, void *data, size_t max,
>
> static int atmel_sha204a_probe(struct i2c_client *client)
> {
> - const struct i2c_device_id *id = i2c_client_get_device_id(client);
> struct atmel_i2c_client_priv *i2c_priv;
> int ret;
>
> - ret = atmel_i2c_probe(client, id);
> + ret = atmel_i2c_probe(client);
> if (ret)
> return ret;
>
>
> base-commit: f160a0e64f0f80a82f797ea7aa007e41ba8ed441
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: atmel-i2c: Drop unused id parameter from atmel_i2c_probe()
2023-01-31 8:13 ` Uwe Kleine-König
@ 2023-02-10 9:45 ` Herbert Xu
-1 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2023-02-10 9:45 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Tudor Ambarus, David S. Miller, Nicolas Ferre, Alexandre Belloni,
Claudiu Beznea, linux-crypto, linux-arm-kernel, kernel
On Tue, Jan 31, 2023 at 09:13:51AM +0100, Uwe Kleine-König wrote:
> id is unused in atmel_i2c_probe() and the callers have extra efforts to
> determine the right parameter. So drop the parameter simplifying both
> atmel_i2c_probe() and its callers.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> just found a nice optimisation while grepping for something else in the
> tree ...
>
> Best regards
> Uwe
>
> drivers/crypto/atmel-ecc.c | 3 +--
> drivers/crypto/atmel-i2c.c | 2 +-
> drivers/crypto/atmel-i2c.h | 2 +-
> drivers/crypto/atmel-sha204a.c | 3 +--
> 4 files changed, 4 insertions(+), 6 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: atmel-i2c: Drop unused id parameter from atmel_i2c_probe()
@ 2023-02-10 9:45 ` Herbert Xu
0 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2023-02-10 9:45 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Alexandre Belloni, David S. Miller, Tudor Ambarus, linux-crypto,
kernel, Claudiu Beznea, linux-arm-kernel
On Tue, Jan 31, 2023 at 09:13:51AM +0100, Uwe Kleine-König wrote:
> id is unused in atmel_i2c_probe() and the callers have extra efforts to
> determine the right parameter. So drop the parameter simplifying both
> atmel_i2c_probe() and its callers.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> just found a nice optimisation while grepping for something else in the
> tree ...
>
> Best regards
> Uwe
>
> drivers/crypto/atmel-ecc.c | 3 +--
> drivers/crypto/atmel-i2c.c | 2 +-
> drivers/crypto/atmel-i2c.h | 2 +-
> drivers/crypto/atmel-sha204a.c | 3 +--
> 4 files changed, 4 insertions(+), 6 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-02-10 9:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-31 8:13 [PATCH] crypto: atmel-i2c: Drop unused id parameter from atmel_i2c_probe() Uwe Kleine-König
2023-01-31 8:13 ` Uwe Kleine-König
2023-01-31 9:14 ` Tudor Ambarus
2023-01-31 9:14 ` Tudor Ambarus
2023-02-10 9:45 ` Herbert Xu
2023-02-10 9:45 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.