All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>,
	virtualization@lists.linux-foundation.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	linux-kernel@vger.kernel.org, Laurent Vivier <lvivier@redhat.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Eli Cohen <elic@nvidia.com>
Subject: Re: [PATCH v2 01/17] vdpa: remove unnecessary 'default n' in Kconfig entries
Date: Mon, 30 Nov 2020 11:01:16 +0800	[thread overview]
Message-ID: <f1ac66eb-e0f9-96c7-0282-f661d10b7378@redhat.com> (raw)
In-Reply-To: <20201126144950.92850-2-sgarzare@redhat.com>


On 2020/11/26 下午10:49, Stefano Garzarella wrote:
> 'default n' is not necessary since it is already the default when
> nothing is specified.
>
> Suggested-by: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>


Acked-by: Jason Wang <jasowang@redhat.com>


> ---
>   drivers/vdpa/Kconfig | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
> index 358f6048dd3c..4019ceb88181 100644
> --- a/drivers/vdpa/Kconfig
> +++ b/drivers/vdpa/Kconfig
> @@ -14,7 +14,6 @@ config VDPA_SIM
>   	select DMA_OPS
>   	select VHOST_RING
>   	select GENERIC_NET_UTILS
> -	default n
>   	help
>   	  vDPA networking device simulator which loop TX traffic back
>   	  to RX. This device is used for testing, prototyping and
> @@ -23,7 +22,6 @@ config VDPA_SIM
>   config IFCVF
>   	tristate "Intel IFC VF vDPA driver"
>   	depends on PCI_MSI
> -	default n
>   	help
>   	  This kernel module can drive Intel IFC VF NIC to offload
>   	  virtio dataplane traffic to hardware.
> @@ -41,7 +39,6 @@ config MLX5_VDPA_NET
>   	tristate "vDPA driver for ConnectX devices"
>   	select MLX5_VDPA
>   	depends on MLX5_CORE
> -	default n
>   	help
>   	  VDPA network driver for ConnectX6 and newer. Provides offloading
>   	  of virtio net datapath such that descriptors put on the ring will


WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>,
	virtualization@lists.linux-foundation.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	linux-kernel@vger.kernel.org,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Eli Cohen <elic@nvidia.com>
Subject: Re: [PATCH v2 01/17] vdpa: remove unnecessary 'default n' in Kconfig entries
Date: Mon, 30 Nov 2020 11:01:16 +0800	[thread overview]
Message-ID: <f1ac66eb-e0f9-96c7-0282-f661d10b7378@redhat.com> (raw)
In-Reply-To: <20201126144950.92850-2-sgarzare@redhat.com>


On 2020/11/26 下午10:49, Stefano Garzarella wrote:
> 'default n' is not necessary since it is already the default when
> nothing is specified.
>
> Suggested-by: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>


Acked-by: Jason Wang <jasowang@redhat.com>


> ---
>   drivers/vdpa/Kconfig | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
> index 358f6048dd3c..4019ceb88181 100644
> --- a/drivers/vdpa/Kconfig
> +++ b/drivers/vdpa/Kconfig
> @@ -14,7 +14,6 @@ config VDPA_SIM
>   	select DMA_OPS
>   	select VHOST_RING
>   	select GENERIC_NET_UTILS
> -	default n
>   	help
>   	  vDPA networking device simulator which loop TX traffic back
>   	  to RX. This device is used for testing, prototyping and
> @@ -23,7 +22,6 @@ config VDPA_SIM
>   config IFCVF
>   	tristate "Intel IFC VF vDPA driver"
>   	depends on PCI_MSI
> -	default n
>   	help
>   	  This kernel module can drive Intel IFC VF NIC to offload
>   	  virtio dataplane traffic to hardware.
> @@ -41,7 +39,6 @@ config MLX5_VDPA_NET
>   	tristate "vDPA driver for ConnectX devices"
>   	select MLX5_VDPA
>   	depends on MLX5_CORE
> -	default n
>   	help
>   	  VDPA network driver for ConnectX6 and newer. Provides offloading
>   	  of virtio net datapath such that descriptors put on the ring will

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2020-11-30  3:02 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 14:49 [PATCH v2 00/17] vdpa: generalize vdpa simulator Stefano Garzarella
2020-11-26 14:49 ` Stefano Garzarella
2020-11-26 14:49 ` [PATCH v2 01/17] vdpa: remove unnecessary 'default n' in Kconfig entries Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-30  3:01   ` Jason Wang [this message]
2020-11-30  3:01     ` Jason Wang
2020-11-26 14:49 ` [PATCH v2 02/17] vdpa_sim: remove unnecessary headers inclusion Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-30  3:04   ` Jason Wang
2020-11-30  3:04     ` Jason Wang
2020-11-30 11:10     ` Stefano Garzarella
2020-11-30 11:10       ` Stefano Garzarella
2020-11-26 14:49 ` [PATCH v2 03/17] vdpa_sim: remove hard-coded virtq count Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-30  3:05   ` Jason Wang
2020-11-30  3:05     ` Jason Wang
2020-11-26 14:49 ` [PATCH v2 04/17] vdpa_sim: remove the limit of IOTLB entries Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-30  3:07   ` Jason Wang
2020-11-30  3:07     ` Jason Wang
2020-11-30 11:24     ` Stefano Garzarella
2020-11-30 11:24       ` Stefano Garzarella
2020-11-26 14:49 ` [PATCH v2 05/17] vdpa_sim: rename vdpasim_config_ops variables Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-30  3:07   ` Jason Wang
2020-11-30  3:07     ` Jason Wang
2020-11-26 14:49 ` [PATCH v2 06/17] vdpa_sim: add struct vdpasim_dev_attr for device attributes Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-30  3:09   ` Jason Wang
2020-11-30  3:09     ` Jason Wang
2020-11-26 14:49 ` [PATCH v2 07/17] vdpa_sim: add device id field in vdpasim_dev_attr Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-30  3:10   ` Jason Wang
2020-11-30  3:10     ` Jason Wang
2020-11-26 14:49 ` [PATCH v2 08/17] vdpa_sim: add supported_features " Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-30  3:14   ` Jason Wang
2020-11-30  3:14     ` Jason Wang
2020-11-26 14:49 ` [PATCH v2 09/17] vdpa_sim: add work_fn " Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-30  3:16   ` Jason Wang
2020-11-30  3:16     ` Jason Wang
2020-11-26 14:49 ` [PATCH v2 10/17] vdpa_sim: store parsed MAC address in a buffer Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-30  3:20   ` Jason Wang
2020-11-30  3:20     ` Jason Wang
2020-11-26 14:49 ` [PATCH v2 11/17] vdpa_sim: make 'config' generic and usable for any device type Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-26 14:49 ` [PATCH v2 12/17] vdpa_sim: add get_config callback in vdpasim_dev_attr Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-30  3:25   ` Jason Wang
2020-11-30  3:25     ` Jason Wang
2020-11-30 14:14     ` Stefano Garzarella
2020-11-30 14:14       ` Stefano Garzarella
2020-12-01  3:44       ` Jason Wang
2020-12-01  3:44         ` Jason Wang
2020-12-01 10:52         ` Stefano Garzarella
2020-12-01 10:52           ` Stefano Garzarella
2020-11-26 14:49 ` [PATCH v2 13/17] vdpa_sim: set vringh notify callback Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-30  3:27   ` Jason Wang
2020-11-30  3:27     ` Jason Wang
2020-11-30 14:16     ` Stefano Garzarella
2020-11-30 14:16       ` Stefano Garzarella
2020-11-26 14:49 ` [PATCH v2 14/17] vdpa_sim: use kvmalloc to allocate vdpasim->buffer Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-26 14:49 ` [PATCH v2 15/17] vdpa_sim: make vdpasim->buffer size configurable Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-26 14:49 ` [PATCH v2 16/17] vdpa_sim: split vdpasim_virtqueue's iov field in out_iov and in_iov Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-30  3:29   ` Jason Wang
2020-11-30  3:29     ` Jason Wang
2020-11-26 14:49 ` [PATCH v2 17/17] vdpa: split vdpasim to core and net modules Stefano Garzarella
2020-11-26 14:49   ` Stefano Garzarella
2020-11-30  3:31   ` Jason Wang
2020-11-30  3:31     ` Jason Wang
2020-11-30 14:17     ` Stefano Garzarella
2020-11-30 14:17       ` Stefano Garzarella
2020-11-26 15:12 ` [PATCH v2 00/17] vdpa: generalize vdpa simulator Max Gurtovoy
2020-11-26 15:24   ` Stefano Garzarella
2020-11-26 15:24     ` Stefano Garzarella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1ac66eb-e0f9-96c7-0282-f661d10b7378@redhat.com \
    --to=jasowang@redhat.com \
    --cc=elic@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=mgurtovoy@nvidia.com \
    --cc=mst@redhat.com \
    --cc=sgarzare@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.