All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@nbd.name>
To: "bo.jiao" <bo.jiao@mediatek.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	Ryder Lee <ryder.lee@mediatek.com>,
	Sujuan Chen <sujuan.chen@mediatek.com>,
	"lian . chen" <lian.chen@mediatek.com>,
	Shayne Chen <shayne.chen@mediatek.com>,
	Evelyn Tsai <evelyn.tsai@mediatek.com>,
	linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] mt76: mt7915: disable RX_HDR_TRANS_SHORT
Date: Thu, 21 Apr 2022 23:14:21 +0200	[thread overview]
Message-ID: <f1b944f5-b440-d32e-84b9-7cb140b0adc6@nbd.name> (raw)
In-Reply-To: <5b0f28fa67b27151a59ea42d9f60e29919f36f36.camel@mediatek.com>


Hi,

On 21.04.22 03:44, bo.jiao wrote:
> hi felix:
> 
> mt7915_mac_fill_rx:
> 	......
> 
> 	if (!status->wcid || !ieee80211_is_data_qos(fc))
> 		return 0;
> 
> 	status->aggr = unicast &&
> 		       !ieee80211_is_qos_nullfunc(fc);
> 	status->qos_ctl = qos_ctl;
> 	status->seqno = IEEE80211_SEQ_TO_SN(seq_ctrl);
> 
> 	return 0;
> 
> it will be returned by the condition !ieee80211_is_data_qos(fc) when
> receive non-Qos (null) data, and the status->aggr/status-
>>qos_ctl/status->seqno keep the default value 0.
> 
> mt76_rx_aggr_reorder:
> 	....
> 
> 	sta = wcid_to_sta(wcid);
> 	if (!sta)
> 		return;
> 
> 	if (!status->aggr && !(status->flag & RX_FLAG_8023)) {
> 		mt76_rx_aggr_check_ctl(skb, frames);
> 		return;
> 	}
> 
> 	....
> 
> those packet will be forced to do rx reorder and may incorrectly update
> tid->head.
> https://patchwork.kernel.org/project/linux-wireless/patch/2022042010503
> 8.36443-1-nbd@nbd.name/
> Your replacement patch did not include this change.
> +	if (!status->aggr)
> +		return;
> +
> 
> Thanks.
I posted this patch: https://patchwork.kernel.org/project/linux-wireless/patch/20220420112524.52430-1-nbd@nbd.name/

- Felix

WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@nbd.name>
To: "bo.jiao" <bo.jiao@mediatek.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	Ryder Lee <ryder.lee@mediatek.com>,
	Sujuan Chen <sujuan.chen@mediatek.com>,
	"lian . chen" <lian.chen@mediatek.com>,
	Shayne Chen <shayne.chen@mediatek.com>,
	Evelyn Tsai <evelyn.tsai@mediatek.com>,
	linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] mt76: mt7915: disable RX_HDR_TRANS_SHORT
Date: Thu, 21 Apr 2022 23:14:21 +0200	[thread overview]
Message-ID: <f1b944f5-b440-d32e-84b9-7cb140b0adc6@nbd.name> (raw)
In-Reply-To: <5b0f28fa67b27151a59ea42d9f60e29919f36f36.camel@mediatek.com>


Hi,

On 21.04.22 03:44, bo.jiao wrote:
> hi felix:
> 
> mt7915_mac_fill_rx:
> 	......
> 
> 	if (!status->wcid || !ieee80211_is_data_qos(fc))
> 		return 0;
> 
> 	status->aggr = unicast &&
> 		       !ieee80211_is_qos_nullfunc(fc);
> 	status->qos_ctl = qos_ctl;
> 	status->seqno = IEEE80211_SEQ_TO_SN(seq_ctrl);
> 
> 	return 0;
> 
> it will be returned by the condition !ieee80211_is_data_qos(fc) when
> receive non-Qos (null) data, and the status->aggr/status-
>>qos_ctl/status->seqno keep the default value 0.
> 
> mt76_rx_aggr_reorder:
> 	....
> 
> 	sta = wcid_to_sta(wcid);
> 	if (!sta)
> 		return;
> 
> 	if (!status->aggr && !(status->flag & RX_FLAG_8023)) {
> 		mt76_rx_aggr_check_ctl(skb, frames);
> 		return;
> 	}
> 
> 	....
> 
> those packet will be forced to do rx reorder and may incorrectly update
> tid->head.
> https://patchwork.kernel.org/project/linux-wireless/patch/2022042010503
> 8.36443-1-nbd@nbd.name/
> Your replacement patch did not include this change.
> +	if (!status->aggr)
> +		return;
> +
> 
> Thanks.
I posted this patch: https://patchwork.kernel.org/project/linux-wireless/patch/20220420112524.52430-1-nbd@nbd.name/

- Felix

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  reply	other threads:[~2022-04-21 21:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20  7:11 [PATCH] mt76: mt7915: disable RX_HDR_TRANS_SHORT Bo Jiao
2022-04-20  7:11 ` Bo Jiao
2022-04-20 11:25 ` Felix Fietkau
2022-04-20 11:25   ` Felix Fietkau
2022-04-21  1:44   ` bo.jiao
2022-04-21 21:14     ` Felix Fietkau [this message]
2022-04-21 21:14       ` Felix Fietkau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1b944f5-b440-d32e-84b9-7cb140b0adc6@nbd.name \
    --to=nbd@nbd.name \
    --cc=bo.jiao@mediatek.com \
    --cc=evelyn.tsai@mediatek.com \
    --cc=lian.chen@mediatek.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=ryder.lee@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    --cc=sujuan.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.