From: Ayush Sawal <ayush.sawal@chelsio.com>
To: Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: ayush.sawal@asicdesigners.com, David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, secdev@chelsio.com, lkp@intel.com
Subject: Re: [PATCH net V2] Crypto/chcr: Registering cxgb4 to xfrmdev_ops
Date: Mon, 27 Jul 2020 15:29:50 +0530 [thread overview]
Message-ID: <f1f8ed22-9821-08cb-995c-7500355f2680@chelsio.com> (raw)
In-Reply-To: <20200727091627.GX20687@gauss3.secunet.de>
On 7/27/2020 2:46 PM, Steffen Klassert wrote:
> On Sat, Jul 25, 2020 at 04:20:34PM +1000, Herbert Xu wrote:
>> On Fri, Jul 24, 2020 at 05:01:08PM -0700, David Miller wrote:
>>> Please start submitting chcr patches to the crypto subsystem, where it
>>> belongs, instead of the networking GIT trees.
>> Hi Dave:
>>
>> I think this patch belongs to the networking tree. The reason is
>> that it's related to xfrm offload which has nothing to do with the
>> Crypto API.
> Hm, I think some of this code is just misplaced under drivers/crypto.
> All functions in 'drivers/crypto/chelsio/chcr_ipsec.c' implement
> networking (IPsec). So it should be under drivers/net, then it
> can be merged via the net or net-next tree as usual for network
> drivers.
Ok,
We have started the work towards shifting inline ipsec, nic tls & chtls
code present in drivers/crypto/chelsio/ into
drivers/net/ethernet/chelsio/. Only co-processor code will exist in the
drivers/crypto/chelsio directory.
Thanks,
Ayush
>> Do xfrm offload drivers usually go through the networking tree or
>> would it be better directed through the xfrm tree?
> The drivers go through the networking trees, and I think it should
> stay like this. Otherwise we would create needless merge conflicts.
>
next prev parent reply other threads:[~2020-07-27 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 8:41 [PATCH net V2] Crypto/chcr: Registering cxgb4 to xfrmdev_ops Ayush Sawal
2020-07-25 0:01 ` David Miller
2020-07-25 6:20 ` Herbert Xu
2020-07-27 9:16 ` Steffen Klassert
2020-07-27 9:59 ` Ayush Sawal [this message]
2020-07-28 13:01 ` Vinay Kumar Yadav
2020-07-29 0:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1f8ed22-9821-08cb-995c-7500355f2680@chelsio.com \
--to=ayush.sawal@chelsio.com \
--cc=ayush.sawal@asicdesigners.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=secdev@chelsio.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.