All of lore.kernel.org
 help / color / mirror / Atom feed
* [PULL] topic/hdr-formats
@ 2019-03-07  9:48 Maarten Lankhorst
  2019-03-07 17:12 ` Adam Jackson
                   ` (3 more replies)
  0 siblings, 4 replies; 13+ messages in thread
From: Maarten Lankhorst @ 2019-03-07  9:48 UTC (permalink / raw)
  To: Joonas Lahtinen, Sean Paul
  Cc: dim-tools, Maxime Ripard, intel-gfx, dri-devel, Rodrigo Vivi

Hi Sean and Joonas,

Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?

Cheers,
Maarten

topic/hdr-formats-2019-03-07:
Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
The following changes since commit 4b057e73f28f1df13b77b77a52094238ffdf8abd:

  Merge tag 'drm-misc-fixes-2019-02-22' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2019-03-05 08:14:22 +1000)

are available in the Git repository at:

  git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdr-formats-2019-03-07

for you to fetch changes up to 296e9b19eff6157e1e4f130fa436e105c45725e9:

  drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes (2019-03-05 12:49:00 +0100)

----------------------------------------------------------------
Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.

----------------------------------------------------------------
Juha-Pekka Heikkila (3):
      drm/i915: Add P010, P012, P016 plane control definitions
      drm/i915: Preparations for enabling P010, P012, P016 formats
      drm/i915: Enable P010, P012, P016 formats for primary and sprite planes

Swati Sharma (3):
      drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc
      drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions
      drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes

 drivers/gpu/drm/drm_fourcc.c              |   6 ++
 drivers/gpu/drm/i915/i915_reg.h           |   9 +++
 drivers/gpu/drm/i915/intel_atomic_plane.c |   2 +-
 drivers/gpu/drm/i915/intel_display.c      |  57 ++++++++++++++--
 drivers/gpu/drm/i915/intel_drv.h          |   1 +
 drivers/gpu/drm/i915/intel_pm.c           |  14 ++--
 drivers/gpu/drm/i915/intel_sprite.c       | 108 ++++++++++++++++++++++++++++--
 include/uapi/drm/drm_fourcc.h             |  16 +++++
 8 files changed, 194 insertions(+), 19 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PULL] topic/hdr-formats
  2019-03-07  9:48 [PULL] topic/hdr-formats Maarten Lankhorst
@ 2019-03-07 17:12 ` Adam Jackson
  2019-03-11 11:19   ` Maarten Lankhorst
  2019-03-07 17:46 ` Sean Paul
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 13+ messages in thread
From: Adam Jackson @ 2019-03-07 17:12 UTC (permalink / raw)
  To: Maarten Lankhorst, Joonas Lahtinen, Sean Paul
  Cc: Maxime Ripard, intel-gfx, dim-tools, dri-devel

On Thu, 2019-03-07 at 10:48 +0100, Maarten Lankhorst wrote:
> Hi Sean and Joonas,
> 
> Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?

Could you also add Kevin Strasser's patch for FP16 formats? For that
matter I'd like to see FP32 added too, but I don't think there's been a
patch sent for that yet.

- ajax

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PULL] topic/hdr-formats
  2019-03-07  9:48 [PULL] topic/hdr-formats Maarten Lankhorst
  2019-03-07 17:12 ` Adam Jackson
@ 2019-03-07 17:46 ` Sean Paul
  2019-03-08 12:45   ` Maarten Lankhorst
  2019-03-08 15:40 ` Sean Paul
  2019-03-11 11:57 ` Joonas Lahtinen
  3 siblings, 1 reply; 13+ messages in thread
From: Sean Paul @ 2019-03-07 17:46 UTC (permalink / raw)
  To: Maarten Lankhorst
  Cc: dim-tools, Maxime Ripard, Sean Paul, intel-gfx, dri-devel, Rodrigo Vivi

On Thu, Mar 07, 2019 at 10:48:24AM +0100, Maarten Lankhorst wrote:
> Hi Sean and Joonas,
> 
> Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?
> 
> Cheers,
> Maarten
> 
> topic/hdr-formats-2019-03-07:

Mentioned on IRC, but will do so here as well. The key that signed this tag
isn't published. While I'm pretty sure that you are you, I would feel better if
you could publish and verify the key id for me.

Sean

> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
> The following changes since commit 4b057e73f28f1df13b77b77a52094238ffdf8abd:
> 
>   Merge tag 'drm-misc-fixes-2019-02-22' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2019-03-05 08:14:22 +1000)
> 
> are available in the Git repository at:
> 
>   git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdr-formats-2019-03-07
> 
> for you to fetch changes up to 296e9b19eff6157e1e4f130fa436e105c45725e9:
> 
>   drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes (2019-03-05 12:49:00 +0100)
> 
> ----------------------------------------------------------------
> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
> 
> ----------------------------------------------------------------
> Juha-Pekka Heikkila (3):
>       drm/i915: Add P010, P012, P016 plane control definitions
>       drm/i915: Preparations for enabling P010, P012, P016 formats
>       drm/i915: Enable P010, P012, P016 formats for primary and sprite planes
> 
> Swati Sharma (3):
>       drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc
>       drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions
>       drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes
> 
>  drivers/gpu/drm/drm_fourcc.c              |   6 ++
>  drivers/gpu/drm/i915/i915_reg.h           |   9 +++
>  drivers/gpu/drm/i915/intel_atomic_plane.c |   2 +-
>  drivers/gpu/drm/i915/intel_display.c      |  57 ++++++++++++++--
>  drivers/gpu/drm/i915/intel_drv.h          |   1 +
>  drivers/gpu/drm/i915/intel_pm.c           |  14 ++--
>  drivers/gpu/drm/i915/intel_sprite.c       | 108 ++++++++++++++++++++++++++++--
>  include/uapi/drm/drm_fourcc.h             |  16 +++++
>  8 files changed, 194 insertions(+), 19 deletions(-)

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PULL] topic/hdr-formats
  2019-03-07 17:46 ` Sean Paul
@ 2019-03-08 12:45   ` Maarten Lankhorst
  0 siblings, 0 replies; 13+ messages in thread
From: Maarten Lankhorst @ 2019-03-08 12:45 UTC (permalink / raw)
  To: Sean Paul; +Cc: dim-tools, Maxime Ripard, intel-gfx, dri-devel

Op 07-03-2019 om 18:46 schreef Sean Paul:
> On Thu, Mar 07, 2019 at 10:48:24AM +0100, Maarten Lankhorst wrote:
>> Hi Sean and Joonas,
>>
>> Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?
>>
>> Cheers,
>> Maarten
>>
>> topic/hdr-formats-2019-03-07:
> Mentioned on IRC, but will do so here as well. The key that signed this tag
> isn't published. While I'm pretty sure that you are you, I would feel better if
> you could publish and verify the key id for me.

Key should be on keyservers.

But if you're paranoid.. https://db.debian.org/ and look me up, and download the gpg key there. :)

>
>> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
>> The following changes since commit 4b057e73f28f1df13b77b77a52094238ffdf8abd:
>>
>>   Merge tag 'drm-misc-fixes-2019-02-22' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2019-03-05 08:14:22 +1000)
>>
>> are available in the Git repository at:
>>
>>   git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdr-formats-2019-03-07
>>
>> for you to fetch changes up to 296e9b19eff6157e1e4f130fa436e105c45725e9:
>>
>>   drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes (2019-03-05 12:49:00 +0100)
>>
>> ----------------------------------------------------------------
>> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
>>
>> ----------------------------------------------------------------
>> Juha-Pekka Heikkila (3):
>>       drm/i915: Add P010, P012, P016 plane control definitions
>>       drm/i915: Preparations for enabling P010, P012, P016 formats
>>       drm/i915: Enable P010, P012, P016 formats for primary and sprite planes
>>
>> Swati Sharma (3):
>>       drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc
>>       drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions
>>       drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes
>>
>>  drivers/gpu/drm/drm_fourcc.c              |   6 ++
>>  drivers/gpu/drm/i915/i915_reg.h           |   9 +++
>>  drivers/gpu/drm/i915/intel_atomic_plane.c |   2 +-
>>  drivers/gpu/drm/i915/intel_display.c      |  57 ++++++++++++++--
>>  drivers/gpu/drm/i915/intel_drv.h          |   1 +
>>  drivers/gpu/drm/i915/intel_pm.c           |  14 ++--
>>  drivers/gpu/drm/i915/intel_sprite.c       | 108 ++++++++++++++++++++++++++++--
>>  include/uapi/drm/drm_fourcc.h             |  16 +++++
>>  8 files changed, 194 insertions(+), 19 deletions(-)


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PULL] topic/hdr-formats
  2019-03-07  9:48 [PULL] topic/hdr-formats Maarten Lankhorst
  2019-03-07 17:12 ` Adam Jackson
  2019-03-07 17:46 ` Sean Paul
@ 2019-03-08 15:40 ` Sean Paul
  2019-03-11 11:57 ` Joonas Lahtinen
  3 siblings, 0 replies; 13+ messages in thread
From: Sean Paul @ 2019-03-08 15:40 UTC (permalink / raw)
  To: Maarten Lankhorst
  Cc: dim-tools, Maxime Ripard, Sean Paul, intel-gfx, dri-devel, Rodrigo Vivi

On Thu, Mar 07, 2019 at 10:48:24AM +0100, Maarten Lankhorst wrote:
> Hi Sean and Joonas,
> 
> Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?
> 

Applied to drm-misc-next, thanks for sending this out.

Sean

> Cheers,
> Maarten
> 
> topic/hdr-formats-2019-03-07:
> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
> The following changes since commit 4b057e73f28f1df13b77b77a52094238ffdf8abd:
> 
>   Merge tag 'drm-misc-fixes-2019-02-22' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2019-03-05 08:14:22 +1000)
> 
> are available in the Git repository at:
> 
>   git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdr-formats-2019-03-07
> 
> for you to fetch changes up to 296e9b19eff6157e1e4f130fa436e105c45725e9:
> 
>   drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes (2019-03-05 12:49:00 +0100)
> 
> ----------------------------------------------------------------
> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
> 
> ----------------------------------------------------------------
> Juha-Pekka Heikkila (3):
>       drm/i915: Add P010, P012, P016 plane control definitions
>       drm/i915: Preparations for enabling P010, P012, P016 formats
>       drm/i915: Enable P010, P012, P016 formats for primary and sprite planes
> 
> Swati Sharma (3):
>       drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc
>       drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions
>       drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes
> 
>  drivers/gpu/drm/drm_fourcc.c              |   6 ++
>  drivers/gpu/drm/i915/i915_reg.h           |   9 +++
>  drivers/gpu/drm/i915/intel_atomic_plane.c |   2 +-
>  drivers/gpu/drm/i915/intel_display.c      |  57 ++++++++++++++--
>  drivers/gpu/drm/i915/intel_drv.h          |   1 +
>  drivers/gpu/drm/i915/intel_pm.c           |  14 ++--
>  drivers/gpu/drm/i915/intel_sprite.c       | 108 ++++++++++++++++++++++++++++--
>  include/uapi/drm/drm_fourcc.h             |  16 +++++
>  8 files changed, 194 insertions(+), 19 deletions(-)

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PULL] topic/hdr-formats
  2019-03-07 17:12 ` Adam Jackson
@ 2019-03-11 11:19   ` Maarten Lankhorst
  2019-03-11 17:52     ` Adam Jackson
  0 siblings, 1 reply; 13+ messages in thread
From: Maarten Lankhorst @ 2019-03-11 11:19 UTC (permalink / raw)
  To: Adam Jackson, Joonas Lahtinen, Sean Paul, Kevin Strasser
  Cc: Maxime Ripard, intel-gfx, dim-tools, dri-devel

Hey,

Op 07-03-2019 om 18:12 schreef Adam Jackson:
> On Thu, 2019-03-07 at 10:48 +0100, Maarten Lankhorst wrote:
>> Hi Sean and Joonas,
>>
>> Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?
> Could you also add Kevin Strasser's patch for FP16 formats? For that
> matter I'd like to see FP32 added too, but I don't think there's been a
> patch sent for that yet.

Added kevin to CC.

Is the mesa side considered completely reviewed then?

If so, I wouldn't mind sending a second pull req for fp16 support this week.

~Maarten

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PULL] topic/hdr-formats
  2019-03-07  9:48 [PULL] topic/hdr-formats Maarten Lankhorst
                   ` (2 preceding siblings ...)
  2019-03-08 15:40 ` Sean Paul
@ 2019-03-11 11:57 ` Joonas Lahtinen
  2019-03-11 12:05   ` Maarten Lankhorst
  3 siblings, 1 reply; 13+ messages in thread
From: Joonas Lahtinen @ 2019-03-11 11:57 UTC (permalink / raw)
  To: Maarten Lankhorst, Sean Paul
  Cc: dim-tools, Maxime Ripard, intel-gfx, dri-devel, Rodrigo Vivi

Quoting Maarten Lankhorst (2019-03-07 11:48:24)
> Hi Sean and Joonas,
> 
> Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?

I was travelling on Fri, so sorry for delay. This is now pulled to dinq,
too.

Regards, Joonas

> 
> Cheers,
> Maarten
> 
> topic/hdr-formats-2019-03-07:
> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
> The following changes since commit 4b057e73f28f1df13b77b77a52094238ffdf8abd:
> 
>   Merge tag 'drm-misc-fixes-2019-02-22' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2019-03-05 08:14:22 +1000)
> 
> are available in the Git repository at:
> 
>   git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdr-formats-2019-03-07
> 
> for you to fetch changes up to 296e9b19eff6157e1e4f130fa436e105c45725e9:
> 
>   drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes (2019-03-05 12:49:00 +0100)
> 
> ----------------------------------------------------------------
> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
> 
> ----------------------------------------------------------------
> Juha-Pekka Heikkila (3):
>       drm/i915: Add P010, P012, P016 plane control definitions
>       drm/i915: Preparations for enabling P010, P012, P016 formats
>       drm/i915: Enable P010, P012, P016 formats for primary and sprite planes
> 
> Swati Sharma (3):
>       drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc
>       drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions
>       drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes
> 
>  drivers/gpu/drm/drm_fourcc.c              |   6 ++
>  drivers/gpu/drm/i915/i915_reg.h           |   9 +++
>  drivers/gpu/drm/i915/intel_atomic_plane.c |   2 +-
>  drivers/gpu/drm/i915/intel_display.c      |  57 ++++++++++++++--
>  drivers/gpu/drm/i915/intel_drv.h          |   1 +
>  drivers/gpu/drm/i915/intel_pm.c           |  14 ++--
>  drivers/gpu/drm/i915/intel_sprite.c       | 108 ++++++++++++++++++++++++++++--
>  include/uapi/drm/drm_fourcc.h             |  16 +++++
>  8 files changed, 194 insertions(+), 19 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PULL] topic/hdr-formats
  2019-03-11 11:57 ` Joonas Lahtinen
@ 2019-03-11 12:05   ` Maarten Lankhorst
  0 siblings, 0 replies; 13+ messages in thread
From: Maarten Lankhorst @ 2019-03-11 12:05 UTC (permalink / raw)
  To: Joonas Lahtinen, Sean Paul; +Cc: dim-tools, Maxime Ripard, intel-gfx, dri-devel

Op 11-03-2019 om 12:57 schreef Joonas Lahtinen:
> Quoting Maarten Lankhorst (2019-03-07 11:48:24)
>> Hi Sean and Joonas,
>>
>> Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?
> I was travelling on Fri, so sorry for delay. This is now pulled to dinq,
> too.
>
> Regards, Joonas
>
Thanks. :)

~Maarten

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PULL] topic/hdr-formats
  2019-03-11 11:19   ` Maarten Lankhorst
@ 2019-03-11 17:52     ` Adam Jackson
  2019-03-11 18:02       ` Daniel Vetter
  0 siblings, 1 reply; 13+ messages in thread
From: Adam Jackson @ 2019-03-11 17:52 UTC (permalink / raw)
  To: Maarten Lankhorst, Joonas Lahtinen, Sean Paul, Kevin Strasser
  Cc: dim-tools, Maxime Ripard, intel-gfx, dri-devel

On Mon, 2019-03-11 at 12:19 +0100, Maarten Lankhorst wrote:
> Hey,
> 
> Op 07-03-2019 om 18:12 schreef Adam Jackson:
> > On Thu, 2019-03-07 at 10:48 +0100, Maarten Lankhorst wrote:
> > > Hi Sean and Joonas,
> > > 
> > > Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?
> > Could you also add Kevin Strasser's patch for FP16 formats? For that
> > matter I'd like to see FP32 added too, but I don't think there's been a
> > patch sent for that yet.
> 
> Added kevin to CC.
> 
> Is the mesa side considered completely reviewed then?

Is that strictly necessary for just adding a fourcc? I get wanting to
see a real userspace consumer first, but this is just allocating some
magic numbers not promising that a certain ioctl behaves a certain way.

That said, I did say r-b for the Mesa series as a whole. Daniel Stone
had some comments on 13/13 that made it sound like it (that specific
patch) was unnecessary/undesirable, but everything before that looked
great to me, and even if we only merged the first 12 we'd still have
FP16 wired through for the gbm EGL platform, meaning HDR scanout could
actually be a thing.

- ajax

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PULL] topic/hdr-formats
  2019-03-11 17:52     ` Adam Jackson
@ 2019-03-11 18:02       ` Daniel Vetter
  0 siblings, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2019-03-11 18:02 UTC (permalink / raw)
  To: Adam Jackson
  Cc: dim-tools, Maxime Ripard, intel-gfx, Kevin Strasser, dri-devel,
	Rodrigo Vivi, Sean Paul

On Mon, Mar 11, 2019 at 01:52:13PM -0400, Adam Jackson wrote:
> On Mon, 2019-03-11 at 12:19 +0100, Maarten Lankhorst wrote:
> > Hey,
> > 
> > Op 07-03-2019 om 18:12 schreef Adam Jackson:
> > > On Thu, 2019-03-07 at 10:48 +0100, Maarten Lankhorst wrote:
> > > > Hi Sean and Joonas,
> > > > 
> > > > Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?
> > > Could you also add Kevin Strasser's patch for FP16 formats? For that
> > > matter I'd like to see FP32 added too, but I don't think there's been a
> > > patch sent for that yet.
> > 
> > Added kevin to CC.
> > 
> > Is the mesa side considered completely reviewed then?
> 
> Is that strictly necessary for just adding a fourcc? I get wanting to
> see a real userspace consumer first, but this is just allocating some
> magic numbers not promising that a certain ioctl behaves a certain way.

It's a bit a grey area, since uapi/drm/drm_fourcc.h is both a simple magic
number registry for userspace and also the source of truth for what that's
supposed to mean for AddFB. Which is uapi. Having the full mesa->kms
pipeline gives a bit more assurance we didn't flip something somewhere by
accident or some other silliness.

So for i915.ko stuff we've been pretty strict with this, just to make sure
we don't ship broken stuff. But we definitely merged other patches without
anything being able to consume/produce those formats in userspace (well
anything open source at least), fitting the magic number registry.

Imo this is an area each driver team can decide on how they want to handle
it (with my maintainer hat on).
-Daniel
> 
> That said, I did say r-b for the Mesa series as a whole. Daniel Stone
> had some comments on 13/13 that made it sound like it (that specific
> patch) was unnecessary/undesirable, but everything before that looked
> great to me, and even if we only merged the first 12 we'd still have
> FP16 wired through for the gbm EGL platform, meaning HDR scanout could
> actually be a thing.
> 
> - ajax
> 
> _______________________________________________
> dim-tools mailing list
> dim-tools@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dim-tools

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PULL] topic/hdr-formats
  2019-03-13 11:21 Maarten Lankhorst
  2019-03-13 18:20 ` Sean Paul
@ 2019-03-18 15:22 ` Joonas Lahtinen
  1 sibling, 0 replies; 13+ messages in thread
From: Joonas Lahtinen @ 2019-03-18 15:22 UTC (permalink / raw)
  To: Maarten Lankhorst, Sean Paul
  Cc: dim-tools, Maxime Ripard, intel-gfx, dri-devel, Kevin Strasser,
	Rodrigo Vivi

Quoting Maarten Lankhorst (2019-03-13 13:21:46)
> Hey Sean and Joonas,
> 
> One more pull request for the hdr-formats topic branch. FP16 support
> is now also implemented.
> 
> Can this be pulled to drm-misc-next and dinq?

Pulled to drm-intel-next-queued.

Regards, Joonas

> 
> ~Maarten
> 
> topic/hdr-formats-2019-03-13:
> Add support for floating point half-width formats.
> The following changes since commit 296e9b19eff6157e1e4f130fa436e105c45725e9:
> 
>   drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes (2019-03-05 12:49:00 +0100)
> 
> are available in the Git repository at:
> 
>   git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdr-formats-2019-03-13
> 
> for you to fetch changes up to a94bed60cb73962f344ead14b2ee7613280432c6:
> 
>   drm/i915/icl: Implement half float formats (2019-03-13 11:23:12 +0100)
> 
> ----------------------------------------------------------------
> Add support for floating point half-width formats.
> 
> ----------------------------------------------------------------
> Kevin Strasser (3):
>       drm/fourcc: Add 64 bpp half float formats
>       drm/i915: Refactor icl_is_hdr_plane
>       drm/i915/icl: Implement half float formats
> 
>  drivers/gpu/drm/drm_fourcc.c         |  4 ++
>  drivers/gpu/drm/i915/intel_atomic.c  |  3 +-
>  drivers/gpu/drm/i915/intel_display.c | 29 +++++++++++++-
>  drivers/gpu/drm/i915/intel_drv.h     |  7 ++--
>  drivers/gpu/drm/i915/intel_sprite.c  | 78 +++++++++++++++++++++++++++++++++---
>  include/uapi/drm/drm_fourcc.h        | 11 +++++
>  6 files changed, 120 insertions(+), 12 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PULL] topic/hdr-formats
  2019-03-13 11:21 Maarten Lankhorst
@ 2019-03-13 18:20 ` Sean Paul
  2019-03-18 15:22 ` Joonas Lahtinen
  1 sibling, 0 replies; 13+ messages in thread
From: Sean Paul @ 2019-03-13 18:20 UTC (permalink / raw)
  To: Maarten Lankhorst
  Cc: dim-tools, Maxime Ripard, Sean Paul, intel-gfx, Kevin Strasser,
	dri-devel, Rodrigo Vivi

On Wed, Mar 13, 2019 at 12:21:46PM +0100, Maarten Lankhorst wrote:
> Hey Sean and Joonas,
> 
> One more pull request for the hdr-formats topic branch. FP16 support
> is now also implemented.
> 
> Can this be pulled to drm-misc-next and dinq?

Merged in drm-misc-next.

Sean

> 
> ~Maarten
> 
> topic/hdr-formats-2019-03-13:
> Add support for floating point half-width formats.
> The following changes since commit 296e9b19eff6157e1e4f130fa436e105c45725e9:
> 
>   drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes (2019-03-05 12:49:00 +0100)
> 
> are available in the Git repository at:
> 
>   git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdr-formats-2019-03-13
> 
> for you to fetch changes up to a94bed60cb73962f344ead14b2ee7613280432c6:
> 
>   drm/i915/icl: Implement half float formats (2019-03-13 11:23:12 +0100)
> 
> ----------------------------------------------------------------
> Add support for floating point half-width formats.
> 
> ----------------------------------------------------------------
> Kevin Strasser (3):
>       drm/fourcc: Add 64 bpp half float formats
>       drm/i915: Refactor icl_is_hdr_plane
>       drm/i915/icl: Implement half float formats
> 
>  drivers/gpu/drm/drm_fourcc.c         |  4 ++
>  drivers/gpu/drm/i915/intel_atomic.c  |  3 +-
>  drivers/gpu/drm/i915/intel_display.c | 29 +++++++++++++-
>  drivers/gpu/drm/i915/intel_drv.h     |  7 ++--
>  drivers/gpu/drm/i915/intel_sprite.c  | 78 +++++++++++++++++++++++++++++++++---
>  include/uapi/drm/drm_fourcc.h        | 11 +++++
>  6 files changed, 120 insertions(+), 12 deletions(-)

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PULL] topic/hdr-formats
@ 2019-03-13 11:21 Maarten Lankhorst
  2019-03-13 18:20 ` Sean Paul
  2019-03-18 15:22 ` Joonas Lahtinen
  0 siblings, 2 replies; 13+ messages in thread
From: Maarten Lankhorst @ 2019-03-13 11:21 UTC (permalink / raw)
  To: Joonas Lahtinen, Sean Paul
  Cc: dim-tools, Maxime Ripard, intel-gfx, dri-devel, Kevin Strasser,
	Rodrigo Vivi

Hey Sean and Joonas,

One more pull request for the hdr-formats topic branch. FP16 support
is now also implemented.

Can this be pulled to drm-misc-next and dinq?

~Maarten

topic/hdr-formats-2019-03-13:
Add support for floating point half-width formats.
The following changes since commit 296e9b19eff6157e1e4f130fa436e105c45725e9:

  drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes (2019-03-05 12:49:00 +0100)

are available in the Git repository at:

  git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdr-formats-2019-03-13

for you to fetch changes up to a94bed60cb73962f344ead14b2ee7613280432c6:

  drm/i915/icl: Implement half float formats (2019-03-13 11:23:12 +0100)

----------------------------------------------------------------
Add support for floating point half-width formats.

----------------------------------------------------------------
Kevin Strasser (3):
      drm/fourcc: Add 64 bpp half float formats
      drm/i915: Refactor icl_is_hdr_plane
      drm/i915/icl: Implement half float formats

 drivers/gpu/drm/drm_fourcc.c         |  4 ++
 drivers/gpu/drm/i915/intel_atomic.c  |  3 +-
 drivers/gpu/drm/i915/intel_display.c | 29 +++++++++++++-
 drivers/gpu/drm/i915/intel_drv.h     |  7 ++--
 drivers/gpu/drm/i915/intel_sprite.c  | 78 +++++++++++++++++++++++++++++++++---
 include/uapi/drm/drm_fourcc.h        | 11 +++++
 6 files changed, 120 insertions(+), 12 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2019-03-18 15:22 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-07  9:48 [PULL] topic/hdr-formats Maarten Lankhorst
2019-03-07 17:12 ` Adam Jackson
2019-03-11 11:19   ` Maarten Lankhorst
2019-03-11 17:52     ` Adam Jackson
2019-03-11 18:02       ` Daniel Vetter
2019-03-07 17:46 ` Sean Paul
2019-03-08 12:45   ` Maarten Lankhorst
2019-03-08 15:40 ` Sean Paul
2019-03-11 11:57 ` Joonas Lahtinen
2019-03-11 12:05   ` Maarten Lankhorst
2019-03-13 11:21 Maarten Lankhorst
2019-03-13 18:20 ` Sean Paul
2019-03-18 15:22 ` Joonas Lahtinen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.