* [PATCH -next] mmc: sdhci-omap: Make sdhci_omap_reset static
@ 2019-03-22 14:11 ` Yue Haibing
0 siblings, 0 replies; 6+ messages in thread
From: Yue Haibing @ 2019-03-22 14:11 UTC (permalink / raw)
To: adrian.hunter, kishon, ulf.hansson; +Cc: linux-kernel, linux-mmc, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
drivers/mmc/host/sdhci-omap.c:788:6: warning:
symbol 'sdhci_omap_reset' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/mmc/host/sdhci-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
index 5bbed47..649c03f 100644
--- a/drivers/mmc/host/sdhci-omap.c
+++ b/drivers/mmc/host/sdhci-omap.c
@@ -785,7 +785,7 @@ static void sdhci_omap_set_uhs_signaling(struct sdhci_host *host,
sdhci_omap_start_clock(omap_host);
}
-void sdhci_omap_reset(struct sdhci_host *host, u8 mask)
+static void sdhci_omap_reset(struct sdhci_host *host, u8 mask)
{
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
struct sdhci_omap_host *omap_host = sdhci_pltfm_priv(pltfm_host);
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] mmc: sdhci-omap: Make sdhci_omap_reset static
2019-03-22 14:11 ` Yue Haibing
@ 2019-03-22 14:19 ` Faiz Abbas
-1 siblings, 0 replies; 6+ messages in thread
From: Faiz Abbas @ 2019-03-22 14:19 UTC (permalink / raw)
To: Yue Haibing, adrian.hunter, kishon, ulf.hansson; +Cc: linux-kernel, linux-mmc
Hi,
On 22/03/19 7:41 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/mmc/host/sdhci-omap.c:788:6: warning:
> symbol 'sdhci_omap_reset' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Faiz Abbas <faiz_abbas@ti.com>
Thanks,
Faiz
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] mmc: sdhci-omap: Make sdhci_omap_reset static
@ 2019-03-22 14:19 ` Faiz Abbas
0 siblings, 0 replies; 6+ messages in thread
From: Faiz Abbas @ 2019-03-22 14:19 UTC (permalink / raw)
To: Yue Haibing, adrian.hunter, kishon, ulf.hansson; +Cc: linux-kernel, linux-mmc
Hi,
On 22/03/19 7:41 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/mmc/host/sdhci-omap.c:788:6: warning:
> symbol 'sdhci_omap_reset' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Faiz Abbas <faiz_abbas@ti.com>
Thanks,
Faiz
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] mmc: sdhci-omap: Make sdhci_omap_reset static
2019-03-22 14:11 ` Yue Haibing
(?)
(?)
@ 2019-03-25 10:17 ` Adrian Hunter
-1 siblings, 0 replies; 6+ messages in thread
From: Adrian Hunter @ 2019-03-25 10:17 UTC (permalink / raw)
To: Yue Haibing, kishon, ulf.hansson; +Cc: linux-kernel, linux-mmc
On 22/03/19 4:11 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/mmc/host/sdhci-omap.c:788:6: warning:
> symbol 'sdhci_omap_reset' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index 5bbed47..649c03f 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -785,7 +785,7 @@ static void sdhci_omap_set_uhs_signaling(struct sdhci_host *host,
> sdhci_omap_start_clock(omap_host);
> }
>
> -void sdhci_omap_reset(struct sdhci_host *host, u8 mask)
> +static void sdhci_omap_reset(struct sdhci_host *host, u8 mask)
> {
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> struct sdhci_omap_host *omap_host = sdhci_pltfm_priv(pltfm_host);
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] mmc: sdhci-omap: Make sdhci_omap_reset static
2019-03-22 14:11 ` Yue Haibing
` (2 preceding siblings ...)
(?)
@ 2019-03-25 13:27 ` Ulf Hansson
-1 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2019-03-25 13:27 UTC (permalink / raw)
To: Yue Haibing; +Cc: Adrian Hunter, Kishon, Linux Kernel Mailing List, linux-mmc
On Fri, 22 Mar 2019 at 15:15, Yue Haibing <yuehaibing@huawei.com> wrote:
>
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/mmc/host/sdhci-omap.c:788:6: warning:
> symbol 'sdhci_omap_reset' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index 5bbed47..649c03f 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -785,7 +785,7 @@ static void sdhci_omap_set_uhs_signaling(struct sdhci_host *host,
> sdhci_omap_start_clock(omap_host);
> }
>
> -void sdhci_omap_reset(struct sdhci_host *host, u8 mask)
> +static void sdhci_omap_reset(struct sdhci_host *host, u8 mask)
> {
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> struct sdhci_omap_host *omap_host = sdhci_pltfm_priv(pltfm_host);
> --
> 2.7.0
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread