* Re: [PATCH] ZYNQ: platsmp: Return -ENOMEM after a failed ioremap() call in zynq_cpun_start()
@ 2020-04-30 9:00 Markus Elfring
2020-04-30 9:19 ` Michal Simek
0 siblings, 1 reply; 5+ messages in thread
From: Markus Elfring @ 2020-04-30 9:00 UTC (permalink / raw)
To: Xu Wang, linux-arm-kernel; +Cc: linux-kernel, Russell King, Michal Simek
> In ioremap we should return -ENOMEM when it reports an
> memory allocation failure.
I suggest to improve this change description.
Will the tag “Fixes” be relevant because of the adjusted error code?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=1d2cc5ac6f6668cc15216d51051103c61467d7e8#n183
Regards,
Markus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ZYNQ: platsmp: Return -ENOMEM after a failed ioremap() call in zynq_cpun_start()
2020-04-30 9:00 [PATCH] ZYNQ: platsmp: Return -ENOMEM after a failed ioremap() call in zynq_cpun_start() Markus Elfring
@ 2020-04-30 9:19 ` Michal Simek
0 siblings, 0 replies; 5+ messages in thread
From: Michal Simek @ 2020-04-30 9:19 UTC (permalink / raw)
To: Markus Elfring, Xu Wang, linux-arm-kernel
Cc: linux-kernel, Russell King, Michal Simek
On 30. 04. 20 11:00, Markus Elfring wrote:
>> In ioremap we should return -ENOMEM when it reports an
>> memory allocation failure.
>
> I suggest to improve this change description.
>
> Will the tag “Fixes” be relevant because of the adjusted error code?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=1d2cc5ac6f6668cc15216d51051103c61467d7e8#n183
I don't think this was found by bisection because arm smp code cares
only about 0 - success and !0. I would expect any static program
analysis tool like coccinelle.
Would be good to rewrite that commit message and simply say that
failures from ioremaps returns -ENOMEM.
Thanks,
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ZYNQ: platsmp: Return -ENOMEM after a failed ioremap() call in zynq_cpun_start()
@ 2020-04-30 9:19 ` Michal Simek
0 siblings, 0 replies; 5+ messages in thread
From: Michal Simek @ 2020-04-30 9:19 UTC (permalink / raw)
To: Markus Elfring, Xu Wang, linux-arm-kernel
Cc: Michal Simek, linux-kernel, Russell King
On 30. 04. 20 11:00, Markus Elfring wrote:
>> In ioremap we should return -ENOMEM when it reports an
>> memory allocation failure.
>
> I suggest to improve this change description.
>
> Will the tag “Fixes” be relevant because of the adjusted error code?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=1d2cc5ac6f6668cc15216d51051103c61467d7e8#n183
I don't think this was found by bisection because arm smp code cares
only about 0 - success and !0. I would expect any static program
analysis tool like coccinelle.
Would be good to rewrite that commit message and simply say that
failures from ioremaps returns -ENOMEM.
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ZYNQ: platsmp: Return -ENOMEM after a failed ioremap() call in zynq_cpun_start()
2020-04-30 9:19 ` Michal Simek
@ 2020-04-30 10:37 ` Markus Elfring
-1 siblings, 0 replies; 5+ messages in thread
From: Markus Elfring @ 2020-04-30 10:37 UTC (permalink / raw)
To: Michal Simek, Xu Wang, linux-arm-kernel; +Cc: linux-kernel, Russell King
> I would expect any static program analysis tool like coccinelle.
Would you like to help any more for the possibility that advanced
source code analysis can point questionable error codes out?
Regards,
Markus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ZYNQ: platsmp: Return -ENOMEM after a failed ioremap() call in zynq_cpun_start()
@ 2020-04-30 10:37 ` Markus Elfring
0 siblings, 0 replies; 5+ messages in thread
From: Markus Elfring @ 2020-04-30 10:37 UTC (permalink / raw)
To: Michal Simek, Xu Wang, linux-arm-kernel; +Cc: linux-kernel, Russell King
> I would expect any static program analysis tool like coccinelle.
Would you like to help any more for the possibility that advanced
source code analysis can point questionable error codes out?
Regards,
Markus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-30 10:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30 9:00 [PATCH] ZYNQ: platsmp: Return -ENOMEM after a failed ioremap() call in zynq_cpun_start() Markus Elfring
2020-04-30 9:19 ` Michal Simek
2020-04-30 9:19 ` Michal Simek
2020-04-30 10:37 ` Markus Elfring
2020-04-30 10:37 ` Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.