From: Thomas Zimmermann <tzimmermann@suse.de> To: Chris Wilson <chris@chris-wilson.co.uk>, airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com Cc: intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com> Subject: Re: [PATCH v5 1/5] drm/i915: Remove references to struct drm_device.pdev Date: Wed, 27 Jan 2021 14:27:35 +0100 [thread overview] Message-ID: <f2d5376c-bb69-6abc-8a17-cd9adb7c8be8@suse.de> (raw) In-Reply-To: <161175197533.2943.2162038120755672032@build.alporthouse.com> [-- Attachment #1.1.1: Type: text/plain, Size: 1977 bytes --] Hi Am 27.01.21 um 13:52 schrieb Chris Wilson: > Quoting Thomas Zimmermann (2021-01-27 12:41:31) >> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c >> index 0188f877cab2..2a07a008de2e 100644 >> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c >> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c >> @@ -146,7 +146,6 @@ struct drm_i915_private *mock_gem_device(void) >> } >> >> pci_set_drvdata(pdev, i915); >> - i915->drm.pdev = pdev; > > Strictly this removal is still too early. Though it's a mock device and > we shouldn't be touching the pci_dev that often, semantically those > accesses are not removed until later. I just didn't notice this instance. I'll add it to the other patch. Sorry. Best regards Thomas > >> >> dev_pm_domain_set(&pdev->dev, &pm_domain); >> pm_runtime_enable(&pdev->dev); >> diff --git a/drivers/gpu/drm/i915/selftests/mock_gtt.c b/drivers/gpu/drm/i915/selftests/mock_gtt.c >> index 7270fc8ca801..5c7ae40bba63 100644 >> --- a/drivers/gpu/drm/i915/selftests/mock_gtt.c >> +++ b/drivers/gpu/drm/i915/selftests/mock_gtt.c >> @@ -74,7 +74,7 @@ struct i915_ppgtt *mock_ppgtt(struct drm_i915_private *i915, const char *name) >> ppgtt->vm.i915 = i915; >> ppgtt->vm.total = round_down(U64_MAX, PAGE_SIZE); >> ppgtt->vm.file = ERR_PTR(-ENODEV); >> - ppgtt->vm.dma = &i915->drm.pdev->dev; >> + ppgtt->vm.dma = i915->drm.dev; > > We can remove this shorthand later. > -Chris > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 840 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de> To: Chris Wilson <chris@chris-wilson.co.uk>, airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com Cc: intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v5 1/5] drm/i915: Remove references to struct drm_device.pdev Date: Wed, 27 Jan 2021 14:27:35 +0100 [thread overview] Message-ID: <f2d5376c-bb69-6abc-8a17-cd9adb7c8be8@suse.de> (raw) In-Reply-To: <161175197533.2943.2162038120755672032@build.alporthouse.com> [-- Attachment #1.1.1: Type: text/plain, Size: 1977 bytes --] Hi Am 27.01.21 um 13:52 schrieb Chris Wilson: > Quoting Thomas Zimmermann (2021-01-27 12:41:31) >> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c >> index 0188f877cab2..2a07a008de2e 100644 >> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c >> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c >> @@ -146,7 +146,6 @@ struct drm_i915_private *mock_gem_device(void) >> } >> >> pci_set_drvdata(pdev, i915); >> - i915->drm.pdev = pdev; > > Strictly this removal is still too early. Though it's a mock device and > we shouldn't be touching the pci_dev that often, semantically those > accesses are not removed until later. I just didn't notice this instance. I'll add it to the other patch. Sorry. Best regards Thomas > >> >> dev_pm_domain_set(&pdev->dev, &pm_domain); >> pm_runtime_enable(&pdev->dev); >> diff --git a/drivers/gpu/drm/i915/selftests/mock_gtt.c b/drivers/gpu/drm/i915/selftests/mock_gtt.c >> index 7270fc8ca801..5c7ae40bba63 100644 >> --- a/drivers/gpu/drm/i915/selftests/mock_gtt.c >> +++ b/drivers/gpu/drm/i915/selftests/mock_gtt.c >> @@ -74,7 +74,7 @@ struct i915_ppgtt *mock_ppgtt(struct drm_i915_private *i915, const char *name) >> ppgtt->vm.i915 = i915; >> ppgtt->vm.total = round_down(U64_MAX, PAGE_SIZE); >> ppgtt->vm.file = ERR_PTR(-ENODEV); >> - ppgtt->vm.dma = &i915->drm.pdev->dev; >> + ppgtt->vm.dma = i915->drm.dev; > > We can remove this shorthand later. > -Chris > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 840 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-27 13:27 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-27 12:41 [PATCH v5 0/5] drm: Move struct drm_device.pdev to legacy Thomas Zimmermann 2021-01-27 12:41 ` [Intel-gfx] " Thomas Zimmermann 2021-01-27 12:41 ` [PATCH v5 1/5] drm/i915: Remove references to struct drm_device.pdev Thomas Zimmermann 2021-01-27 12:41 ` [Intel-gfx] " Thomas Zimmermann 2021-01-27 12:52 ` Chris Wilson 2021-01-27 12:52 ` [Intel-gfx] " Chris Wilson 2021-01-27 13:27 ` Thomas Zimmermann [this message] 2021-01-27 13:27 ` Thomas Zimmermann 2021-01-27 12:41 ` [PATCH v5 2/5] drm/i915/gt: " Thomas Zimmermann 2021-01-27 12:41 ` [Intel-gfx] " Thomas Zimmermann 2021-01-27 12:41 ` [PATCH v5 3/5] drm/i915/gvt: " Thomas Zimmermann 2021-01-27 12:41 ` [Intel-gfx] " Thomas Zimmermann 2021-01-27 12:41 ` [PATCH v5 4/5] drm/i915: Don't assign " Thomas Zimmermann 2021-01-27 12:41 ` [Intel-gfx] " Thomas Zimmermann 2021-01-27 12:54 ` Chris Wilson 2021-01-27 12:54 ` Chris Wilson 2021-01-27 12:41 ` [PATCH v5 5/5] drm: Move struct drm_device.pdev to legacy section Thomas Zimmermann 2021-01-27 12:41 ` [Intel-gfx] " Thomas Zimmermann 2021-01-27 17:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm: Move struct drm_device.pdev to legacy (rev5) Patchwork 2021-01-27 21:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f2d5376c-bb69-6abc-8a17-cd9adb7c8be8@suse.de \ --to=tzimmermann@suse.de \ --cc=airlied@linux.ie \ --cc=chris@chris-wilson.co.uk \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=intel-gvt-dev@lists.freedesktop.org \ --cc=jani.nikula@linux.intel.com \ --cc=joonas.lahtinen@linux.intel.com \ --cc=rodrigo.vivi@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.