* [PATCH] KVM: Documentation: remove VM mmap documentation
@ 2017-04-24 9:16 Jann Horn
2017-04-24 10:25 ` David Hildenbrand
2017-04-27 21:40 ` Jonathan Corbet
0 siblings, 2 replies; 5+ messages in thread
From: Jann Horn @ 2017-04-24 9:16 UTC (permalink / raw)
To: Paolo Bonzini, Radim Krčmář, Jonathan Corbet
Cc: kvm, linux-doc, Gleb Natapov
Since commit 80f5b5e700fa9c ("KVM: remove vm mmap method"), the VM mmap
handler is gone. Remove the corresponding documentation.
Signed-off-by: Jann Horn <jannh@google.com>
---
Documentation/virtual/kvm/api.txt | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
index fd106899afd1..e59af374aa86 100644
--- a/Documentation/virtual/kvm/api.txt
+++ b/Documentation/virtual/kvm/api.txt
@@ -110,11 +110,7 @@ Type: system ioctl
Parameters: machine type identifier (KVM_VM_*)
Returns: a VM fd that can be used to control the new virtual machine.
-The new VM has no virtual cpus and no memory. An mmap() of a VM fd
-will access the virtual machine's physical address space; offset zero
-corresponds to guest physical address zero. Use of mmap() on a VM fd
-is discouraged if userspace memory allocation (KVM_CAP_USER_MEMORY) is
-available.
+The new VM has no virtual cpus and no memory.
You most certainly want to use 0 as machine type.
In order to create user controlled virtual machines on S390, check
--
2.12.2.816.g2cccc81164-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] KVM: Documentation: remove VM mmap documentation
2017-04-24 9:16 [PATCH] KVM: Documentation: remove VM mmap documentation Jann Horn
@ 2017-04-24 10:25 ` David Hildenbrand
2017-04-27 21:40 ` Jonathan Corbet
1 sibling, 0 replies; 5+ messages in thread
From: David Hildenbrand @ 2017-04-24 10:25 UTC (permalink / raw)
To: Jann Horn, Paolo Bonzini, Radim Krčmář, Jonathan Corbet
Cc: kvm, linux-doc, Gleb Natapov
On 24.04.2017 11:16, Jann Horn wrote:
> as no virtual cpus and no memory. An mmap() of a VM fd
> -will access the virtual machine's physical address space; offset zero
> -corresponds to guest physical address zero. Use of mmap() on a VM fd
> -is discouraged if userspace memory allocation (KVM_CAP_USER_MEMORY) is
> -available.
> +The new VM has no virtual cpus and no memory.
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] KVM: Documentation: remove VM mmap documentation
2017-04-24 9:16 [PATCH] KVM: Documentation: remove VM mmap documentation Jann Horn
2017-04-24 10:25 ` David Hildenbrand
@ 2017-04-27 21:40 ` Jonathan Corbet
2017-04-27 21:57 ` Jonathan Corbet
1 sibling, 1 reply; 5+ messages in thread
From: Jonathan Corbet @ 2017-04-27 21:40 UTC (permalink / raw)
To: Jann Horn
Cc: Paolo Bonzini, Radim Krčmář, kvm, linux-doc, Gleb Natapov
On Mon, 24 Apr 2017 11:16:49 +0200
Jann Horn <jannh@google.com> wrote:
> Since commit 80f5b5e700fa9c ("KVM: remove vm mmap method"), the VM mmap
> handler is gone. Remove the corresponding documentation.
Applied to the docs tree, thanks.
jon
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] KVM: Documentation: remove VM mmap documentation
2017-04-27 21:40 ` Jonathan Corbet
@ 2017-04-27 21:57 ` Jonathan Corbet
2017-04-28 9:52 ` Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Corbet @ 2017-04-27 21:57 UTC (permalink / raw)
To: Jann Horn
Cc: Paolo Bonzini, Radim Krčmář, kvm, linux-doc, Gleb Natapov
On Thu, 27 Apr 2017 15:40:42 -0600
Jonathan Corbet <corbet@lwn.net> wrote:
> On Mon, 24 Apr 2017 11:16:49 +0200
> Jann Horn <jannh@google.com> wrote:
>
> > Since commit 80f5b5e700fa9c ("KVM: remove vm mmap method"), the VM mmap
> > handler is gone. Remove the corresponding documentation.
>
> Applied to the docs tree, thanks.
Actually, I've unapplied it since it leads to conflicts with the kvm
tree, and poor Stephen has already had to fix up too many of those for me
this time around. Paolo, maybe you'd like to pick it up and reconcile
things?
Thanks,
jon
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] KVM: Documentation: remove VM mmap documentation
2017-04-27 21:57 ` Jonathan Corbet
@ 2017-04-28 9:52 ` Paolo Bonzini
0 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2017-04-28 9:52 UTC (permalink / raw)
To: Jonathan Corbet, Jann Horn
Cc: Radim Krčmář, kvm, linux-doc, Gleb Natapov
On 27/04/2017 23:57, Jonathan Corbet wrote:
> On Thu, 27 Apr 2017 15:40:42 -0600
> Jonathan Corbet <corbet@lwn.net> wrote:
>
>> On Mon, 24 Apr 2017 11:16:49 +0200
>> Jann Horn <jannh@google.com> wrote:
>>
>>> Since commit 80f5b5e700fa9c ("KVM: remove vm mmap method"), the VM mmap
>>> handler is gone. Remove the corresponding documentation.
>>
>> Applied to the docs tree, thanks.
>
> Actually, I've unapplied it since it leads to conflicts with the kvm
> tree, and poor Stephen has already had to fix up too many of those for me
> this time around. Paolo, maybe you'd like to pick it up and reconcile
> things?
Yes, I'll apply it for 4.12.
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-28 9:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-24 9:16 [PATCH] KVM: Documentation: remove VM mmap documentation Jann Horn
2017-04-24 10:25 ` David Hildenbrand
2017-04-27 21:40 ` Jonathan Corbet
2017-04-27 21:57 ` Jonathan Corbet
2017-04-28 9:52 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.