[PATCH 0/6] MAINTAINERS: Update patterns

[PATCH 0/6] MAINTAINERS: Update patterns

[Joe Perches]

Just some housekeeping.

Joe Perches (6):
  MAINTAINERS: Update MSM pattern
  MAINTAINERS: Update CPU FREQUENCY patterns
  MAINTAINERS: Update HIGH RESOLUTION TIMERS patterns
  MAINTAINERS: Remove unused PERFORMANCE EVENTS pattern
  MAINTAINERS: Update USB HID/HIDBP DRIVERS pattern
  MAINTAINERS: Remove section USB SE401 DRIVER

 MAINTAINERS |   15 +++------------
 1 files changed, 3 insertions(+), 12 deletions(-)

-- 
1.7.5.rc3.dirty

[PATCH 1/6] MAINTAINERS: Update MSM pattern

[Joe Perches]

Video MSM is still in staging.

cc: David Brown <davidb@codeaurora.org>
cc: Daniel Walker <dwalker@fifo99.com>
cc: Bryan Huntsman <bryanh@codeaurora.org>
Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 29801f7..ae06910 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -926,7 +926,7 @@ F:	drivers/mmc/host/msm_sdcc.c
 F:	drivers/mmc/host/msm_sdcc.h
 F:	drivers/tty/serial/msm_serial.h
 F:	drivers/tty/serial/msm_serial.c
-F:	drivers/platform/msm/
+F:	drivers/staging/msm/
 F:	drivers/*/pm8???-*
 F:	include/linux/mfd/pm8xxx/
 T:	git git://codeaurora.org/quic/kernel/davidb/linux-msm.git
-- 
1.7.5.rc3.dirty

[PATCH 2/6] MAINTAINERS: Update CPU FREQUENCY patterns

[Joe Perches]

Commit bb0a56ecc4ba ("[CPUFREQ] Move x86 drivers to drivers/cpufreq/")
moved the files, remove the old pattern.

cc: Dave Jones <davej@redhat.com>
Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index ae06910..5d43f2b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1889,7 +1889,6 @@ L:	cpufreq@vger.kernel.org
 W:	http://www.codemonkey.org.uk/projects/cpufreq/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/davej/cpufreq.git
 S:	Maintained
-F:	arch/x86/kernel/cpu/cpufreq/
 F:	drivers/cpufreq/
 F:	include/linux/cpufreq.h
 
-- 
1.7.5.rc3.dirty

[PATCH 3/6] MAINTAINERS: Update HIGH RESOLUTION TIMERS patterns

[Joe Perches]

clockchips.h was typoed as clockevents.h

cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5d43f2b..ab6340f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2993,7 +2993,7 @@ F:	kernel/hrtimer.c
 F:	kernel/time/clockevents.c
 F:	kernel/time/tick*.*
 F:	kernel/time/timer_*.c
-F:	include/linux/clockevents.h
+F:	include/linux/clockchips.h
 F:	include/linux/hrtimer.h
 
 HIGH-SPEED SCC DRIVER FOR AX.25
-- 
1.7.5.rc3.dirty

[PATCH 4/6] MAINTAINERS: Remove unused PERFORMANCE EVENTS pattern

[Joe Perches]

No arch/*/lib/perf_event* files exist so remove the pattern.

cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
cc: Paul Mackerras <paulus@samba.org>
cc: Ingo Molnar <mingo@elte.hu>
cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index ab6340f..6f6a8ef 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4908,7 +4908,6 @@ F:	arch/*/kernel/perf_event*.c
 F:	arch/*/kernel/*/perf_event*.c
 F:	arch/*/kernel/*/*/perf_event*.c
 F:	arch/*/include/asm/perf_event.h
-F:	arch/*/lib/perf_event*.c
 F:	arch/*/kernel/perf_callchain.c
 F:	tools/perf/
 
-- 
1.7.5.rc3.dirty

[PATCH 5/6] MAINTAINERS: Update USB HID/HIDBP DRIVERS pattern

[Joe Perches]

It was moved by commit 1a978c50c6cf
("HID: Move hiddev.txt to the new Documentation/hid directory")
so update the MAINTAINERS pattern too.

cc: Jiri Kosina <jkosina@suse.cz>
cc: Alan Ott <alan@signal11.us>
Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6f6a8ef..49d9fb1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6458,7 +6458,7 @@ M:	Jiri Kosina <jkosina@suse.cz>
 L:	linux-usb@vger.kernel.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git
 S:	Maintained
-F:	Documentation/usb/hiddev.txt
+F:	Documentation/hid/hiddev.txt
 F:	drivers/hid/usbhid/
 
 USB ISP116X DRIVER
-- 
1.7.5.rc3.dirty

[PATCH 6/6] MAINTAINERS: Remove section USB SE401 DRIVER

[Joe Perches]

Commit b287db119edb ("[media] se401: remove last V4L1 driver")
removed the driver, so remove the section from MAINTAINERS.

cc: Hans Verkuil <hverkuil@xs4all.nl>
cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 49d9fb1..07b6bcd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6524,13 +6524,6 @@ W:	http://pegasus2.sourceforge.net/
 S:	Maintained
 F:	drivers/net/usb/rtl8150.c
 
-USB SE401 DRIVER
-L:	linux-usb@vger.kernel.org
-W:	http://www.chello.nl/~j.vreeken/se401/
-S:	Orphan
-F:	Documentation/video4linux/se401.txt
-F:	drivers/staging/se401/
-
 USB SERIAL BELKIN F5U103 DRIVER
 M:	William Greathouse <wgreathouse@smva.com>
 L:	linux-usb@vger.kernel.org
-- 
1.7.5.rc3.dirty

Re: [PATCH 1/6] MAINTAINERS: Update MSM pattern

[David Brown]

On Wed, Jun 01 2011, Joe Perches wrote:

> Video MSM is still in staging.

It also appears to be in drivers/video/msm

Carl, do we need the staging driver any more?

I don't have any problem removing the drivers/platform/msm line, since
that now appears to have been an ill-formed idea, but I'd rather just
get rid of the staging video driver.

David

> cc: David Brown <davidb@codeaurora.org>
> cc: Daniel Walker <dwalker@fifo99.com>
> cc: Bryan Huntsman <bryanh@codeaurora.org>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  MAINTAINERS |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 29801f7..ae06910 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -926,7 +926,7 @@ F:	drivers/mmc/host/msm_sdcc.c
>  F:	drivers/mmc/host/msm_sdcc.h
>  F:	drivers/tty/serial/msm_serial.h
>  F:	drivers/tty/serial/msm_serial.c
> -F:	drivers/platform/msm/
> +F:	drivers/staging/msm/
>  F:	drivers/*/pm8???-*
>  F:	include/linux/mfd/pm8xxx/
>  T:	git git://codeaurora.org/quic/kernel/davidb/linux-msm.git

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [PATCH 4/6] MAINTAINERS: Remove unused PERFORMANCE EVENTS pattern

[Ingo Molnar]

* Joe Perches <joe@perches.com> wrote:

> No arch/*/lib/perf_event* files exist so remove the pattern.
> 
> cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> cc: Paul Mackerras <paulus@samba.org>
> cc: Ingo Molnar <mingo@elte.hu>
> cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  MAINTAINERS |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ab6340f..6f6a8ef 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4908,7 +4908,6 @@ F:	arch/*/kernel/perf_event*.c
>  F:	arch/*/kernel/*/perf_event*.c
>  F:	arch/*/kernel/*/*/perf_event*.c
>  F:	arch/*/include/asm/perf_event.h
> -F:	arch/*/lib/perf_event*.c
>  F:	arch/*/kernel/perf_callchain.c
>  F:	tools/perf/

The arch/*/lib/ hierarchy is a common place to put stuff into, it 
does not hurt at all to have it mentioned.

In Linux there's 10+ really important, not yet implemented features 
to implement, there's 100+ under-maintained subsystems to maintain, 
there's 1000+ not yet fixed bugs to fix, there's 10,000+ ugly driver 
files to be improved and there's 1,000,000+ stylistic errors to fix.

Mucking with the MAINTAINERS file on the level you did in this patch 
comes some time after we've fixed the 1,000,000+ stylistic errors.

Could you please stop mucking with these patterns and start dealing 
with some of the more important problems we have?

Thanks,

	Ingo

Re: [PATCH 4/6] MAINTAINERS: Remove unused PERFORMANCE EVENTS pattern

[Joe Perches]

On Thu, 2011-06-02 at 09:40 +0200, Ingo Molnar wrote:
> * Joe Perches <joe@perches.com> wrote:
> > No arch/*/lib/perf_event* files exist so remove the pattern.
> The arch/*/lib/ hierarchy is a common place to put stuff into, it 
> does not hurt at all to have it mentioned.

Every once in awhile I run a script on MAINTAINERS
and fix up defects found by the script.

Dead code is dead code.
This was unused as of commit e360adbe2924.

> stop mucking with these patterns and start dealing 
> with some of the more important problems we have?

My time, my choice on what to do with it.

Re: [PATCH 4/6] MAINTAINERS: Remove unused PERFORMANCE EVENTS pattern

[Ingo Molnar]

* Joe Perches <joe@perches.com> wrote:

> On Thu, 2011-06-02 at 09:40 +0200, Ingo Molnar wrote:
> > * Joe Perches <joe@perches.com> wrote:
> > > No arch/*/lib/perf_event* files exist so remove the pattern.
> > The arch/*/lib/ hierarchy is a common place to put stuff into, it 
> > does not hurt at all to have it mentioned.
> 
> Every once in awhile I run a script on MAINTAINERS
> and fix up defects found by the script.
>
> Dead code is dead code.
> This was unused as of commit e360adbe2924.

NAK, i've outlined my reasons:

 - It's an obvious pattern to put librarized functionality in there
   and should an architecture grow a file there in the future it
   will be included automatically.

 - What we are interested in are false positives (files included that
   should not be matched) and false negatives (files belonging to a
   subsystm not included) - this pattern is none of those.

> > stop mucking with these patterns and start dealing with some of 
> > the more important problems we have?
> 
> My time, my choice on what to do with it.

Yes, but this time you are also wasting my time with such a stupid 
patch, so it's not just your time wasted anymore.

Thanks,

	Ingo

Re: [PATCH 1/6] MAINTAINERS: Update MSM pattern

[Carl Vanderlip]

> On Wed, Jun 01 2011, Joe Perches wrote:
>
>> Video MSM is still in staging.
>
> It also appears to be in drivers/video/msm
>
> Carl, do we need the staging driver any more?
>
> I don't have any problem removing the drivers/platform/msm line, since
> that now appears to have been an ill-formed idea, but I'd rather just
> get rid of the staging video driver.
>
> David
>

The staging video driver can be removed. While the current driver is
moving along the same dev path as the staging driver originally did, I
don't believe it is a goal to converge to the staging driver in its
current form.

 -Carl V.

>> cc: David Brown <davidb@codeaurora.org>
>> cc: Daniel Walker <dwalker@fifo99.com>
>> cc: Bryan Huntsman <bryanh@codeaurora.org>
>> Signed-off-by: Joe Perches <joe@perches.com>
>> ---
>>  MAINTAINERS |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 29801f7..ae06910 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -926,7 +926,7 @@ F:	drivers/mmc/host/msm_sdcc.c
>>  F:	drivers/mmc/host/msm_sdcc.h
>>  F:	drivers/tty/serial/msm_serial.h
>>  F:	drivers/tty/serial/msm_serial.c
>> -F:	drivers/platform/msm/
>> +F:	drivers/staging/msm/
>>  F:	drivers/*/pm8???-*
>>  F:	include/linux/mfd/pm8xxx/
>>  T:	git git://codeaurora.org/quic/kernel/davidb/linux-msm.git
>
> --
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
>


-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [PATCH 5/6] MAINTAINERS: Update USB HID/HIDBP DRIVERS pattern

[Jiri Kosina]

On Wed, 1 Jun 2011, Joe Perches wrote:

> It was moved by commit 1a978c50c6cf
> ("HID: Move hiddev.txt to the new Documentation/hid directory")
> so update the MAINTAINERS pattern too.

Good catch.

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs