From: Jeff Johnson <quic_jjohnson@quicinc.com> To: Kalle Valo <kvalo@kernel.org>, <ath11k@lists.infradead.org> Cc: <linux-wireless@vger.kernel.org> Subject: Re: [PATCH 1/2] ath11k: mac: fix too long line Date: Tue, 3 May 2022 08:17:55 -0700 [thread overview] Message-ID: <f2f27831-03eb-3788-5855-649c0f33c785@quicinc.com> (raw) In-Reply-To: <20220503060415.24499-1-kvalo@kernel.org> On 5/2/2022 11:04 PM, Kalle Valo wrote: > From: Kalle Valo <quic_kvalo@quicinc.com> > > checkpatch warns: > > drivers/net/wireless/ath/ath11k/mac.c:7760: line length of 91 exceeds 90 columns > > This was introduced by commit 046d2e7c50e3 ("mac80211: prepare sta handling for > MLO support"). > > Compile tested only. > > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> > --- > drivers/net/wireless/ath/ath11k/mac.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c > index c76cac5d6849..32fb0142124d 100644 > --- a/drivers/net/wireless/ath/ath11k/mac.c > +++ b/drivers/net/wireless/ath/ath11k/mac.c > @@ -7735,6 +7735,7 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b > bool he_fixed_rate = false, vht_fixed_rate = false; > struct ath11k_peer *peer, *tmp; > const u16 *vht_mcs_mask, *he_mcs_mask; > + struct ieee80211_link_sta *deflink; > u8 vht_nss, he_nss; > bool ret = true; > > @@ -7757,13 +7758,16 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b > spin_lock_bh(&ar->ab->base_lock); > list_for_each_entry_safe(peer, tmp, &ar->ab->peers, list) { > if (peer->sta) { > - if (vht_fixed_rate && (!peer->sta->deflink.vht_cap.vht_supported || > - peer->sta->deflink.rx_nss < vht_nss)) { > + deflink = &peer->sta->deflink; is there a reason to not declare deflink here? then its scope of definition would equal the scope of usage > + > + if (vht_fixed_rate && (!deflink->vht_cap.vht_supported || > + deflink->rx_nss < vht_nss)) { > ret = false; > goto out; > } > - if (he_fixed_rate && (!peer->sta->deflink.he_cap.has_he || > - peer->sta->deflink.rx_nss < he_nss)) { > + > + if (he_fixed_rate && (!deflink->he_cap.has_he || > + deflink->rx_nss < he_nss)) { > ret = false; > goto out; > } > > base-commit: f39af96d352dd4f36a4a43601ea90561e17e5ca6
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Johnson <quic_jjohnson@quicinc.com> To: Kalle Valo <kvalo@kernel.org>, <ath11k@lists.infradead.org> Cc: <linux-wireless@vger.kernel.org> Subject: Re: [PATCH 1/2] ath11k: mac: fix too long line Date: Tue, 3 May 2022 08:17:55 -0700 [thread overview] Message-ID: <f2f27831-03eb-3788-5855-649c0f33c785@quicinc.com> (raw) In-Reply-To: <20220503060415.24499-1-kvalo@kernel.org> On 5/2/2022 11:04 PM, Kalle Valo wrote: > From: Kalle Valo <quic_kvalo@quicinc.com> > > checkpatch warns: > > drivers/net/wireless/ath/ath11k/mac.c:7760: line length of 91 exceeds 90 columns > > This was introduced by commit 046d2e7c50e3 ("mac80211: prepare sta handling for > MLO support"). > > Compile tested only. > > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> > --- > drivers/net/wireless/ath/ath11k/mac.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c > index c76cac5d6849..32fb0142124d 100644 > --- a/drivers/net/wireless/ath/ath11k/mac.c > +++ b/drivers/net/wireless/ath/ath11k/mac.c > @@ -7735,6 +7735,7 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b > bool he_fixed_rate = false, vht_fixed_rate = false; > struct ath11k_peer *peer, *tmp; > const u16 *vht_mcs_mask, *he_mcs_mask; > + struct ieee80211_link_sta *deflink; > u8 vht_nss, he_nss; > bool ret = true; > > @@ -7757,13 +7758,16 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b > spin_lock_bh(&ar->ab->base_lock); > list_for_each_entry_safe(peer, tmp, &ar->ab->peers, list) { > if (peer->sta) { > - if (vht_fixed_rate && (!peer->sta->deflink.vht_cap.vht_supported || > - peer->sta->deflink.rx_nss < vht_nss)) { > + deflink = &peer->sta->deflink; is there a reason to not declare deflink here? then its scope of definition would equal the scope of usage > + > + if (vht_fixed_rate && (!deflink->vht_cap.vht_supported || > + deflink->rx_nss < vht_nss)) { > ret = false; > goto out; > } > - if (he_fixed_rate && (!peer->sta->deflink.he_cap.has_he || > - peer->sta->deflink.rx_nss < he_nss)) { > + > + if (he_fixed_rate && (!deflink->he_cap.has_he || > + deflink->rx_nss < he_nss)) { > ret = false; > goto out; > } > > base-commit: f39af96d352dd4f36a4a43601ea90561e17e5ca6 -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2022-05-03 15:18 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-03 6:04 [PATCH 1/2] ath11k: mac: fix too long line Kalle Valo 2022-05-03 6:04 ` Kalle Valo 2022-05-03 6:04 ` [PATCH 2/2] ath10k: mac: fix too long lines Kalle Valo 2022-05-03 6:04 ` Kalle Valo 2022-05-03 15:22 ` Jeff Johnson 2022-05-03 15:22 ` Jeff Johnson 2022-05-03 15:17 ` Jeff Johnson [this message] 2022-05-03 15:17 ` [PATCH 1/2] ath11k: mac: fix too long line Jeff Johnson 2022-05-04 5:58 ` Kalle Valo 2022-05-04 5:58 ` Kalle Valo 2022-05-04 16:30 ` Jeff Johnson 2022-05-04 16:30 ` Jeff Johnson 2022-05-06 9:04 ` Kalle Valo 2022-05-06 9:04 ` Kalle Valo 2022-05-06 6:17 ` Kalle Valo 2022-05-06 6:17 ` Kalle Valo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f2f27831-03eb-3788-5855-649c0f33c785@quicinc.com \ --to=quic_jjohnson@quicinc.com \ --cc=ath11k@lists.infradead.org \ --cc=kvalo@kernel.org \ --cc=linux-wireless@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.