All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jiri Kosina <trivial@kernel.org>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Bruce Allan <bruce.w.allan@intel.com>,
	Carolyn Wyborny <carolyn.wyborny@intel.com>,
	Don Skidmore <donald.c.skidmore@intel.com>,
	Greg Rose <gregory.v.rose@intel.com>,
	PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>,
	Alex Duyck <alexander.h.duyck@intel.com>,
	John Ronciak <john.ronciak@intel.com>,
	e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 20/49] drivers/net/e1000e: Use vzalloc
Date: Thu,  4 Nov 2010 20:07:44 -0700	[thread overview]
Message-ID: <f2fa68e9dc6ba623ed7d54ae49fd20e07bccc780.1288925424.git.joe@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1011031108260.11625@router.home>
In-Reply-To: <cover.1288925424.git.joe@perches.com>

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/e1000e/netdev.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index c4ca162..9922edb 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -2059,10 +2059,9 @@ int e1000e_setup_tx_resources(struct e1000_adapter *adapter)
 	int err = -ENOMEM, size;
 
 	size = sizeof(struct e1000_buffer) * tx_ring->count;
-	tx_ring->buffer_info = vmalloc(size);
+	tx_ring->buffer_info = vzalloc(size);
 	if (!tx_ring->buffer_info)
 		goto err;
-	memset(tx_ring->buffer_info, 0, size);
 
 	/* round up to nearest 4K */
 	tx_ring->size = tx_ring->count * sizeof(struct e1000_tx_desc);
@@ -2095,10 +2094,9 @@ int e1000e_setup_rx_resources(struct e1000_adapter *adapter)
 	int i, size, desc_len, err = -ENOMEM;
 
 	size = sizeof(struct e1000_buffer) * rx_ring->count;
-	rx_ring->buffer_info = vmalloc(size);
+	rx_ring->buffer_info = vzalloc(size);
 	if (!rx_ring->buffer_info)
 		goto err;
-	memset(rx_ring->buffer_info, 0, size);
 
 	for (i = 0; i < rx_ring->count; i++) {
 		buffer_info = &rx_ring->buffer_info[i];
-- 
1.7.3.1.g432b3.dirty


WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Jiri Kosina <trivial@kernel.org>
Cc: e1000-devel@lists.sourceforge.net,
	Bruce Allan <bruce.w.allan@intel.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	linux-kernel@vger.kernel.org,
	Greg Rose <gregory.v.rose@intel.com>,
	John Ronciak <john.ronciak@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	netdev@vger.kernel.org
Subject: [PATCH 20/49] drivers/net/e1000e: Use vzalloc
Date: Thu,  4 Nov 2010 20:07:44 -0700	[thread overview]
Message-ID: <f2fa68e9dc6ba623ed7d54ae49fd20e07bccc780.1288925424.git.joe@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1011031108260.11625@router.home>
In-Reply-To: <cover.1288925424.git.joe@perches.com>

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/e1000e/netdev.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index c4ca162..9922edb 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -2059,10 +2059,9 @@ int e1000e_setup_tx_resources(struct e1000_adapter *adapter)
 	int err = -ENOMEM, size;
 
 	size = sizeof(struct e1000_buffer) * tx_ring->count;
-	tx_ring->buffer_info = vmalloc(size);
+	tx_ring->buffer_info = vzalloc(size);
 	if (!tx_ring->buffer_info)
 		goto err;
-	memset(tx_ring->buffer_info, 0, size);
 
 	/* round up to nearest 4K */
 	tx_ring->size = tx_ring->count * sizeof(struct e1000_tx_desc);
@@ -2095,10 +2094,9 @@ int e1000e_setup_rx_resources(struct e1000_adapter *adapter)
 	int i, size, desc_len, err = -ENOMEM;
 
 	size = sizeof(struct e1000_buffer) * rx_ring->count;
-	rx_ring->buffer_info = vmalloc(size);
+	rx_ring->buffer_info = vzalloc(size);
 	if (!rx_ring->buffer_info)
 		goto err;
-	memset(rx_ring->buffer_info, 0, size);
 
 	for (i = 0; i < rx_ring->count; i++) {
 		buffer_info = &rx_ring->buffer_info[i];
-- 
1.7.3.1.g432b3.dirty


------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a 
Billion" shares his insights and actions to help propel your 
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired

  parent reply	other threads:[~2010-11-05  3:08 UTC|newest]

Thread overview: 152+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-30 21:35 [PATCH] cgroup: Avoid a memset by using vzalloc Jesper Juhl
2010-10-30 21:35 ` Jesper Juhl
2010-10-30 23:34 ` Minchan Kim
2010-10-30 23:34   ` Minchan Kim
2010-10-31 17:33   ` Balbir Singh
2010-10-31 17:33     ` Balbir Singh
2010-11-01  5:40     ` Jesper Juhl
2010-11-01  5:40       ` Jesper Juhl
2010-11-03 14:38       ` Christoph Lameter
2010-11-03 14:38         ` Christoph Lameter
2010-11-03 15:20         ` jovi zhang
2010-11-03 15:20           ` jovi zhang
2010-11-03 15:48           ` Joe Perches
2010-11-03 15:48             ` Joe Perches
2010-11-03 16:10             ` Christoph Lameter
2010-11-03 16:10               ` Christoph Lameter
2010-11-04 21:43               ` Jesper Juhl
2010-11-04 21:43                 ` Jesper Juhl
     [not found]               ` <alpine.DEB.2.00.1011031108260.11625-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org>
2010-11-04 21:43                 ` Jesper Juhl
2010-11-05  3:07                 ` [PATCH 00/49] Use vzalloc not vmalloc/kmemset Joe Perches
2010-11-05  3:07                 ` [PATCH 12/49] drivers/infiniband: Use vzalloc Joe Perches
2010-11-05  3:07                   ` Joe Perches
     [not found]                   ` <2a6dc4ae9321aef16372b34fc65ceda93190af0a.1288925424.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2011-01-12 19:12                     ` Roland Dreier
2011-01-12 19:12                       ` Roland Dreier
2010-11-05  3:08                 ` [PATCH 44/49] mm: " Joe Perches
2010-11-05  3:07               ` [PATCH 00/49] Use vzalloc not vmalloc/kmemset Joe Perches
2010-11-05  3:07                 ` Joe Perches
2010-11-05  3:07                 ` Joe Perches
2010-11-05  3:07                 ` Joe Perches
2010-11-05  3:07                 ` Joe Perches
2010-11-05  3:07                 ` [PATCH 01/49] arch/ia64: Use vzalloc Joe Perches
2010-11-05  3:07                   ` Joe Perches
2010-11-05  3:07                 ` [PATCH 02/49] arch/mips: " Joe Perches
2010-11-05 10:51                   ` Ralf Baechle
2010-11-05  3:07                 ` [PATCH 03/49] arch/powerpc: " Joe Perches
2010-11-05  3:07                   ` Joe Perches
2010-11-05  3:07                   ` Joe Perches
2010-11-05 13:08                   ` [Cbe-oss-dev] " Jeremy Kerr
2010-11-05 13:08                     ` Jeremy Kerr
2010-11-05 13:08                     ` Jeremy Kerr
2010-11-05  3:07                 ` [PATCH 04/49] arch/s390: " Joe Perches
2010-11-05  3:07                 ` [PATCH 05/49] arch/x86: " Joe Perches
2010-11-05  4:22                   ` Takuya Yoshikawa
2010-11-05  3:07                 ` [PATCH 06/49] crypto: " Joe Perches
2010-11-05  3:07                   ` Joe Perches
2010-11-27  8:31                   ` Herbert Xu
2010-11-27  8:31                     ` Herbert Xu
2010-11-05  3:07                 ` [PATCH 07/49] drivers/atm: " Joe Perches
2010-11-05  3:07                 ` [PATCH 08/49] drivers/block: " Joe Perches
2010-11-05  3:07                 ` [PATCH 09/49] drivers/char: " Joe Perches
2010-11-05  3:07                 ` [PATCH 10/49] drivers/gpu: " Joe Perches
2010-11-05  3:07                   ` Joe Perches
2010-11-05  9:29                   ` Thomas Hellstrom
2010-11-05  3:07                 ` [PATCH 11/49] drivers/hid: " Joe Perches
2010-11-05  3:07                 ` [PATCH 13/49] drivers/isdn: " Joe Perches
2010-11-05  3:07                 ` [PATCH 14/49] drivers/md: " Joe Perches
2010-11-05  3:07                   ` Joe Perches
2011-01-17 20:28                   ` Mike Snitzer
2010-11-05  3:07                 ` [PATCH 15/49] drivers/media: " Joe Perches
2010-11-05  3:07                 ` [PATCH 16/49] drivers/mtd: " Joe Perches
2010-11-05  3:07                   ` Joe Perches
2010-11-13 11:19                   ` Artem Bityutskiy
2010-11-13 11:19                     ` Artem Bityutskiy
2010-11-05  3:07                 ` [PATCH 17/49] drivers/net/cxgb3: " Joe Perches
2010-11-05  3:07                 ` [PATCH 18/49] drivers/net/cxgb4: " Joe Perches
2010-11-05  3:07                 ` [PATCH 19/49] drivers/net/e1000: " Joe Perches
2010-11-05  3:07                   ` Joe Perches
2010-11-05  3:07                 ` Joe Perches [this message]
2010-11-05  3:07                   ` [PATCH 20/49] drivers/net/e1000e: " Joe Perches
2010-11-05  3:07                 ` [PATCH 21/49] drivers/net/ehea: " Joe Perches
2010-11-05  3:07                 ` [PATCH 22/49] drivers/net/igb: " Joe Perches
2010-11-05  3:07                   ` Joe Perches
2010-11-05  3:07                 ` [PATCH 23/49] drivers/net/igbvf: " Joe Perches
2010-11-05  3:07                   ` Joe Perches
2010-11-05 11:58                   ` Rose, Gregory V
2010-11-05 11:58                     ` Rose, Gregory V
2010-11-05  3:07                 ` [PATCH 24/49] drivers/net/ixgb: " Joe Perches
2010-11-05  3:07                   ` Joe Perches
2010-11-05  3:07                 ` [PATCH 25/49] drivers/net/ixgbe: " Joe Perches
2010-11-05  3:07                   ` Joe Perches
2010-11-05  3:07                 ` [PATCH 26/49] drivers/net/ixgbevf: " Joe Perches
2010-11-05  3:07                   ` Joe Perches
2010-11-05 11:59                   ` Rose, Gregory V
2010-11-05 11:59                     ` Rose, Gregory V
2010-11-05  3:07                 ` [PATCH 27/49] drivers/net/netxen: " Joe Perches
2010-11-05  5:18                   ` Amit Salecha
2010-11-05  3:07                 ` [PATCH 28/49] drivers/net/pch_gbe: " Joe Perches
2010-11-05  3:07                 ` [PATCH 29/49] drivers/net/qlcnic: " Joe Perches
2010-11-05  3:07                 ` [PATCH 30/49] drivers/net/sfc: " Joe Perches
2010-11-05  3:07                 ` [PATCH 31/49] drivers/net/vxge: " Joe Perches
2010-11-05  3:07                 ` [PATCH 32/49] drivers/net/bnx2.c: " Joe Perches
2010-11-05  3:07                 ` [PATCH 33/49] drivers/s390: " Joe Perches
2010-11-05  3:07                 ` [PATCH 34/49] drivers/scsi: " Joe Perches
2010-11-05  3:07                 ` [PATCH 35/49] drivers/staging: " Joe Perches
2010-11-05  3:08                 ` [PATCH 36/49] drivers/video: " Joe Perches
2010-11-05  5:27                   ` Dave Young
2010-11-05  5:31                     ` Joe Perches
2010-11-08 16:43                   ` Konrad Rzeszutek Wilk
2010-11-05  3:08                 ` [PATCH 37/49] fs/ext4: " Joe Perches
2010-11-05  7:02                   ` Andreas Dilger
2010-11-05  7:18                     ` [PATCH V2 " Joe Perches
2010-12-20  3:22                       ` Ted Ts'o
2010-11-05  3:08                 ` [PATCH 38/49] fs/jffs2: " Joe Perches
2010-11-05  3:08                   ` Joe Perches
2010-11-13 11:19                   ` Artem Bityutskiy
2010-11-13 11:19                     ` Artem Bityutskiy
2010-11-05  3:08                 ` [PATCH 39/49] fs/reiserfs: " Joe Perches
2010-11-05  3:08                 ` [PATCH 40/49] fs/udf: " Joe Perches
2010-11-05  9:11                   ` Jan Kara
2010-11-05  9:15                     ` Peter Bortas
2010-11-05  9:30                       ` Jan Kara
2010-11-05  3:08                 ` [PATCH 41/49] fs/xfs: " Joe Perches
2010-11-05  3:08                   ` Joe Perches
2010-11-05 17:09                   ` Alex Elder
2010-11-05 17:09                     ` Alex Elder
2010-11-05  3:08                 ` [PATCH 42/49] include/linux/coda_linux.h: " Joe Perches
2010-11-05  3:08                 ` [PATCH 43/49] kernel: " Joe Perches
2010-11-05  3:08                 ` [PATCH 44/49] mm: " Joe Perches
2010-11-05  3:08                   ` Joe Perches
2010-11-05  3:08                 ` [PATCH 45/49] net/core/pktgen.c: " Joe Perches
2010-11-05  3:08                 ` [PATCH 46/49] net/netfilter: " Joe Perches
2010-11-05  6:30                   ` Eric Dumazet
2010-11-05  6:55                     ` Joe Perches
2010-11-05  7:16                       ` Eric Dumazet
2010-11-05  7:16                         ` Eric Dumazet
2010-11-05 17:01                         ` Jesper Juhl
2010-11-05 15:10                       ` Jiri Kosina
2010-11-05 15:25                         ` Joe Perches
2010-11-05  3:08                 ` [PATCH 47/49] net/rds: " Joe Perches
2010-11-05  3:08                 ` [PATCH 48/49] sound/oss/dev_table.c: " Joe Perches
2010-11-22  6:59                   ` Takashi Iwai
2010-11-22  6:59                     ` Takashi Iwai
2010-11-05  3:08                 ` [PATCH 49/49] virt/kvm/kvm_main.c: " Joe Perches
2010-11-05  4:25                   ` Takuya Yoshikawa
2010-11-05  4:44                     ` Joe Perches
2010-11-05  5:31                 ` [PATCH V2 36/49] drivers/video: " Joe Perches
2010-11-03 16:10             ` [PATCH] cgroup: Avoid a memset by using vzalloc Christoph Lameter
2010-11-03 16:37           ` Américo Wang
2010-11-03 16:37             ` Américo Wang
     [not found]           ` <AANLkTinhAQ7mNQWtjWCOWEHHwgUf+BynMM7jnVBMG32--JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-03 15:31             ` Christoph Lameter
2010-11-03 15:31               ` Christoph Lameter
2010-11-03 15:31               ` Christoph Lameter
2010-11-03 15:48             ` Joe Perches
2010-11-03 16:37             ` Américo Wang
     [not found]         ` <alpine.DEB.2.00.1011030937580.10599-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org>
2010-11-03 15:20           ` jovi zhang
     [not found]       ` <alpine.LNX.2.00.1011010639410.31190-h2p7t3/P30RzeRGmFJ5qR7ZzlVVXadcDXqFh9Ls21Oc@public.gmane.org>
2010-11-03 14:38         ` Christoph Lameter
     [not found]     ` <20101031173336.GA28141-SINUvgVNF2CyUtPGxGje5AC/G2K4zDHf@public.gmane.org>
2010-11-01  5:40       ` Jesper Juhl
     [not found]   ` <AANLkTi=nMU3ezNFD8LKBhJxr6CmW6-qHY_Mo3HRt6Os0-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-31 17:33     ` Balbir Singh
     [not found] ` <alpine.LNX.2.00.1010302333130.1572-h2p7t3/P30RzeRGmFJ5qR7ZzlVVXadcDXqFh9Ls21Oc@public.gmane.org>
2010-10-30 23:34   ` Minchan Kim
2010-11-01 22:00   ` Paul Menage
2010-11-01 22:00 ` Paul Menage
2010-11-01 22:00   ` Paul Menage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2fa68e9dc6ba623ed7d54ae49fd20e07bccc780.1288925424.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=bruce.w.allan@intel.com \
    --cc=carolyn.wyborny@intel.com \
    --cc=donald.c.skidmore@intel.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=gregory.v.rose@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.