All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Thiraviyam Mariyappan <tmariyap@codeaurora.org>,
	ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix incorrect nss config
Date: Mon, 27 Sep 2021 17:01:32 +0200	[thread overview]
Message-ID: <f300c9d2aae4b9b0e654f8a1e26c6e64beef7132.camel@sipsolutions.net> (raw)
In-Reply-To: <1632750104-1722-1-git-send-email-tmariyap@codeaurora.org>

On Mon, 2021-09-27 at 19:11 +0530, Thiraviyam Mariyappan wrote:
> In HE capabilities, HE-MCS Rx map field filled with value 0x3 for all eight
> spatial streams if txrx chains configured as incorrect value.
> This patch changes configure at least single spatial stream for HE-MCS
> 0 to 7 in all supported channel widths if nss configured as incorrect
> value.
> 
> Signed-off-by: Thiraviyam Mariyappan <tmariyap@codeaurora.org>
> ---
>  net/mac80211/he.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/net/mac80211/he.c b/net/mac80211/he.c
> index c05af70..ee113ff5 100644
> --- a/net/mac80211/he.c
> +++ b/net/mac80211/he.c
> @@ -151,6 +151,13 @@ ieee80211_he_cap_ie_to_sta_he_cap(struct ieee80211_sub_if_data *sdata,
>  		       &he_cap_ie[sizeof(he_cap->he_cap_elem) + mcs_nss_size],
>  		       he_ppe_size);
>  
> 
> +	if (he_cap->he_mcs_nss_supp.rx_mcs_80 == cpu_to_le16(0xFFFF)) {
> +		he_cap->has_he = false;
> +		sdata_info(sdata, "Ignoring HE IE from %pM due to incorrect rx_mcs_80\n",
> +			   sta->addr);
> +		return;
> +	}

Like so many other workarounds, this should probably come with a comment
as to _why_ we're doing this, ideally including the model/firmware
version ...

johannes


WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Thiraviyam Mariyappan <tmariyap@codeaurora.org>,
	 ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix incorrect nss config
Date: Mon, 27 Sep 2021 17:01:32 +0200	[thread overview]
Message-ID: <f300c9d2aae4b9b0e654f8a1e26c6e64beef7132.camel@sipsolutions.net> (raw)
In-Reply-To: <1632750104-1722-1-git-send-email-tmariyap@codeaurora.org>

On Mon, 2021-09-27 at 19:11 +0530, Thiraviyam Mariyappan wrote:
> In HE capabilities, HE-MCS Rx map field filled with value 0x3 for all eight
> spatial streams if txrx chains configured as incorrect value.
> This patch changes configure at least single spatial stream for HE-MCS
> 0 to 7 in all supported channel widths if nss configured as incorrect
> value.
> 
> Signed-off-by: Thiraviyam Mariyappan <tmariyap@codeaurora.org>
> ---
>  net/mac80211/he.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/net/mac80211/he.c b/net/mac80211/he.c
> index c05af70..ee113ff5 100644
> --- a/net/mac80211/he.c
> +++ b/net/mac80211/he.c
> @@ -151,6 +151,13 @@ ieee80211_he_cap_ie_to_sta_he_cap(struct ieee80211_sub_if_data *sdata,
>  		       &he_cap_ie[sizeof(he_cap->he_cap_elem) + mcs_nss_size],
>  		       he_ppe_size);
>  
> 
> +	if (he_cap->he_mcs_nss_supp.rx_mcs_80 == cpu_to_le16(0xFFFF)) {
> +		he_cap->has_he = false;
> +		sdata_info(sdata, "Ignoring HE IE from %pM due to incorrect rx_mcs_80\n",
> +			   sta->addr);
> +		return;
> +	}

Like so many other workarounds, this should probably come with a comment
as to _why_ we're doing this, ideally including the model/firmware
version ...

johannes


-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2021-09-27 15:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 13:41 [PATCH] mac80211: fix incorrect nss config Thiraviyam Mariyappan
2021-09-27 13:41 ` Thiraviyam Mariyappan
2021-09-27 15:01 ` Johannes Berg [this message]
2021-09-27 15:01   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f300c9d2aae4b9b0e654f8a1e26c6e64beef7132.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tmariyap@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.