All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 2/2] mx6sx: vining2000: pinmux usdhc4 reset
       [not found] <9dd396e113cef9ea0f54cdf967a978beb8061fca.1518432723.git.silvio.fricke@softing.com>
@ 2019-05-17 19:19 ` Marek Vasut
  2019-06-09  8:33   ` Stefano Babic
  0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2019-05-17 19:19 UTC (permalink / raw)
  To: u-boot

From: Christoph Fritz <chf.fritz@googlemail.com>

This patch configures pinmux for pin usdhc4 reset.

Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
---
 board/softing/vining_2000/vining_2000.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/board/softing/vining_2000/vining_2000.c b/board/softing/vining_2000/vining_2000.c
index 77c34e39be..30693c0cdf 100644
--- a/board/softing/vining_2000/vining_2000.c
+++ b/board/softing/vining_2000/vining_2000.c
@@ -58,6 +58,9 @@ DECLARE_GLOBAL_DATA_PTR;
 	PAD_CTL_PKE |  PAD_CTL_SPEED_MED | PAD_CTL_DSE_80ohm |	\
 	PAD_CTL_SRE_FAST)
 
+#define USDHC_RESET_CTRL (PAD_CTL_HYS | PAD_CTL_PUS_47K_UP |	\
+	PAD_CTL_PKE |  PAD_CTL_SPEED_MED | PAD_CTL_DSE_80ohm)
+
 #define GPIO_PAD_CTRL  (PAD_CTL_HYS | PAD_CTL_PUS_100K_UP |	\
 	PAD_CTL_PKE)
 
@@ -94,6 +97,7 @@ static iomux_v3_cfg_t const usdhc4_pads[] = {
 	MX6_PAD_SD4_DATA5__USDHC4_DATA5 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
 	MX6_PAD_SD4_DATA6__USDHC4_DATA6 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
 	MX6_PAD_SD4_DATA7__USDHC4_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
+	MX6_PAD_SD4_RESET_B__USDHC4_RESET_B | MUX_PAD_CTRL(USDHC_RESET_CTRL),
 };
 
 static iomux_v3_cfg_t const fec1_pads[] = {
-- 
2.16.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 2/2] mx6sx: vining2000: pinmux usdhc4 reset
  2019-05-17 19:19 ` [U-Boot] [PATCH 2/2] mx6sx: vining2000: pinmux usdhc4 reset Marek Vasut
@ 2019-06-09  8:33   ` Stefano Babic
  2019-06-09 13:43     ` Marek Vasut
  0 siblings, 1 reply; 4+ messages in thread
From: Stefano Babic @ 2019-06-09  8:33 UTC (permalink / raw)
  To: u-boot

Hi Marek,

On 17/05/19 21:19, Marek Vasut wrote:
> From: Christoph Fritz <chf.fritz@googlemail.com>
> 
> This patch configures pinmux for pin usdhc4 reset.
> 
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> ---
>  board/softing/vining_2000/vining_2000.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/board/softing/vining_2000/vining_2000.c b/board/softing/vining_2000/vining_2000.c

                     ^---- new path

> index 77c34e39be..30693c0cdf 100644
> --- a/board/softing/vining_2000/vining_2000.c
> +++ b/board/softing/vining_2000/vining_2000.c
> @@ -58,6 +58,9 @@ DECLARE_GLOBAL_DATA_PTR;
>  	PAD_CTL_PKE |  PAD_CTL_SPEED_MED | PAD_CTL_DSE_80ohm |	\
>  	PAD_CTL_SRE_FAST)
>  
> +#define USDHC_RESET_CTRL (PAD_CTL_HYS | PAD_CTL_PUS_47K_UP |	\
> +	PAD_CTL_PKE |  PAD_CTL_SPEED_MED | PAD_CTL_DSE_80ohm)
> +
>  #define GPIO_PAD_CTRL  (PAD_CTL_HYS | PAD_CTL_PUS_100K_UP |	\
>  	PAD_CTL_PKE)
>  
> @@ -94,6 +97,7 @@ static iomux_v3_cfg_t const usdhc4_pads[] = {
>  	MX6_PAD_SD4_DATA5__USDHC4_DATA5 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>  	MX6_PAD_SD4_DATA6__USDHC4_DATA6 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>  	MX6_PAD_SD4_DATA7__USDHC4_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
> +	MX6_PAD_SD4_RESET_B__USDHC4_RESET_B | MUX_PAD_CTRL(USDHC_RESET_CTRL),
>  };
>  
>  static iomux_v3_cfg_t const fec1_pads[] = {
> 

FYI: I am applying this together with the series "ARM: imx: Update
VINING|2000 to DM/DT". However, this patch applies after renaming the
vendor to softimg, and it cannot be applied (the series is a follow up
of this patch). It is also different from
the patch you applied on your own tree (you applied to samtec and not
softimg):

https://github.com/marex/u-boot-imx/commit/3bbd03e4edf419ff3eb00e58f6b4d73d216f8202

I have just applied this as you did before renaming, no need to repost -
I am just tracking while the applied patch differs from the one in
patchwork.

Regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 2/2] mx6sx: vining2000: pinmux usdhc4 reset
  2019-06-09  8:33   ` Stefano Babic
@ 2019-06-09 13:43     ` Marek Vasut
  0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2019-06-09 13:43 UTC (permalink / raw)
  To: u-boot

On 6/9/19 10:33 AM, Stefano Babic wrote:
> Hi Marek,
> 
> On 17/05/19 21:19, Marek Vasut wrote:
>> From: Christoph Fritz <chf.fritz@googlemail.com>
>>
>> This patch configures pinmux for pin usdhc4 reset.
>>
>> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
>> ---
>>  board/softing/vining_2000/vining_2000.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/board/softing/vining_2000/vining_2000.c b/board/softing/vining_2000/vining_2000.c
> 
>                      ^---- new path
> 
>> index 77c34e39be..30693c0cdf 100644
>> --- a/board/softing/vining_2000/vining_2000.c
>> +++ b/board/softing/vining_2000/vining_2000.c
>> @@ -58,6 +58,9 @@ DECLARE_GLOBAL_DATA_PTR;
>>  	PAD_CTL_PKE |  PAD_CTL_SPEED_MED | PAD_CTL_DSE_80ohm |	\
>>  	PAD_CTL_SRE_FAST)
>>  
>> +#define USDHC_RESET_CTRL (PAD_CTL_HYS | PAD_CTL_PUS_47K_UP |	\
>> +	PAD_CTL_PKE |  PAD_CTL_SPEED_MED | PAD_CTL_DSE_80ohm)
>> +
>>  #define GPIO_PAD_CTRL  (PAD_CTL_HYS | PAD_CTL_PUS_100K_UP |	\
>>  	PAD_CTL_PKE)
>>  
>> @@ -94,6 +97,7 @@ static iomux_v3_cfg_t const usdhc4_pads[] = {
>>  	MX6_PAD_SD4_DATA5__USDHC4_DATA5 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>>  	MX6_PAD_SD4_DATA6__USDHC4_DATA6 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>>  	MX6_PAD_SD4_DATA7__USDHC4_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>> +	MX6_PAD_SD4_RESET_B__USDHC4_RESET_B | MUX_PAD_CTRL(USDHC_RESET_CTRL),
>>  };
>>  
>>  static iomux_v3_cfg_t const fec1_pads[] = {
>>
> 
> FYI: I am applying this together with the series "ARM: imx: Update
> VINING|2000 to DM/DT". However, this patch applies after renaming the
> vendor to softimg, and it cannot be applied (the series is a follow up
> of this patch). It is also different from
> the patch you applied on your own tree (you applied to samtec and not
> softimg):
> 
> https://github.com/marex/u-boot-imx/commit/3bbd03e4edf419ff3eb00e58f6b4d73d216f8202
> 
> I have just applied this as you did before renaming, no need to repost -
> I am just tracking while the applied patch differs from the one in
> patchwork.

Ah hum, I guess bulk-posting so many conversions with cross-dependencies
wasn't so great.

Thanks. Let me know once you have some tree with the patches, so I can
retest that.

-- 
Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot]  [PATCH 2/2] mx6sx: vining2000: pinmux usdhc4 reset
@ 2019-06-10  9:40 sbabic at denx.de
  0 siblings, 0 replies; 4+ messages in thread
From: sbabic at denx.de @ 2019-06-10  9:40 UTC (permalink / raw)
  To: u-boot

> From: Christoph Fritz <chf.fritz@googlemail.com>
> This patch configures pinmux for pin usdhc4 reset.
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-10  9:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <9dd396e113cef9ea0f54cdf967a978beb8061fca.1518432723.git.silvio.fricke@softing.com>
2019-05-17 19:19 ` [U-Boot] [PATCH 2/2] mx6sx: vining2000: pinmux usdhc4 reset Marek Vasut
2019-06-09  8:33   ` Stefano Babic
2019-06-09 13:43     ` Marek Vasut
2019-06-10  9:40 sbabic at denx.de

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.