All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Anderson <sean.anderson@seco.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org,
	"David S . Miller" <davem@davemloft.net>,
	"Aymen Sghaier" <aymen.sghaier@nxp.com>,
	linux-arm-kernel@lists.infradead.org,
	"Marek Vasut" <marex@denx.de>,
	"Horia Geantă" <horia.geanta@nxp.com>
Subject: Re: [PATCH 2/2] crypto: mxs_dcp: Use sg_mapping_iter to copy data
Date: Fri, 25 Jun 2021 10:49:08 -0400	[thread overview]
Message-ID: <f3117c42-7918-3d32-059e-4e6c338a781a@seco.com> (raw)
In-Reply-To: <20210625001640.GA23887@gondor.apana.org.au>



On 6/24/21 8:16 PM, Herbert Xu wrote:
> On Thu, Jun 24, 2021 at 10:58:48AM -0400, Sean Anderson wrote:
>>
>> What exactly is the warning here? dst_iter.length is a size_t, and
>> actx->fill is a u32. So fill will be converted to a size_t before the
>> comparison, which is lossless.
> 
> It's just the way min works.  If you want to shut it up, you can
> either use a cast or min_t.

What version of sparse are you using? With sparse 0.6.2, gcc 9.3.0, and
with C=1 and W=2 I don't see this warning.

--Sean

WARNING: multiple messages have this Message-ID (diff)
From: Sean Anderson <sean.anderson@seco.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org,
	"David S . Miller" <davem@davemloft.net>,
	"Aymen Sghaier" <aymen.sghaier@nxp.com>,
	linux-arm-kernel@lists.infradead.org,
	"Marek Vasut" <marex@denx.de>,
	"Horia Geantă" <horia.geanta@nxp.com>
Subject: Re: [PATCH 2/2] crypto: mxs_dcp: Use sg_mapping_iter to copy data
Date: Fri, 25 Jun 2021 10:49:08 -0400	[thread overview]
Message-ID: <f3117c42-7918-3d32-059e-4e6c338a781a@seco.com> (raw)
In-Reply-To: <20210625001640.GA23887@gondor.apana.org.au>



On 6/24/21 8:16 PM, Herbert Xu wrote:
> On Thu, Jun 24, 2021 at 10:58:48AM -0400, Sean Anderson wrote:
>>
>> What exactly is the warning here? dst_iter.length is a size_t, and
>> actx->fill is a u32. So fill will be converted to a size_t before the
>> comparison, which is lossless.
> 
> It's just the way min works.  If you want to shut it up, you can
> either use a cast or min_t.

What version of sparse are you using? With sparse 0.6.2, gcc 9.3.0, and
with C=1 and W=2 I don't see this warning.

--Sean

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-25 14:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 21:14 [PATCH 1/2] crypto: mxs-dcp: Check for DMA mapping errors Sean Anderson
2021-06-18 21:14 ` Sean Anderson
2021-06-18 21:14 ` [PATCH 2/2] crypto: mxs_dcp: Use sg_mapping_iter to copy data Sean Anderson
2021-06-18 21:14   ` Sean Anderson
2021-06-24  6:56   ` Herbert Xu
2021-06-24  6:56     ` Herbert Xu
2021-06-24 14:58     ` Sean Anderson
2021-06-24 14:58       ` Sean Anderson
2021-06-25  0:16       ` Herbert Xu
2021-06-25  0:16         ` Herbert Xu
2021-06-25 14:49         ` Sean Anderson [this message]
2021-06-25 14:49           ` Sean Anderson
2021-06-26  3:00           ` Herbert Xu
2021-06-26  3:00             ` Herbert Xu
2021-06-28  3:25           ` Herbert Xu
2021-06-28  3:25             ` Herbert Xu
2021-06-28 17:44             ` Sean Anderson
2021-06-28 17:44               ` Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3117c42-7918-3d32-059e-4e6c338a781a@seco.com \
    --to=sean.anderson@seco.com \
    --cc=aymen.sghaier@nxp.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=marex@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.