* [PATCH] tools: kwboot: Always print kwboot version
@ 2021-11-05 22:30 Pali Rohár
2021-11-10 8:22 ` Stefan Roese
2021-11-10 13:52 ` Stefan Roese
0 siblings, 2 replies; 3+ messages in thread
From: Pali Rohár @ 2021-11-05 22:30 UTC (permalink / raw)
To: Stefan Roese; +Cc: Marek Behún, u-boot
It is useful to see kwboot version in the boot log output for debugging
purposes.
Signed-off-by: Pali Rohár <pali@kernel.org>
---
tools/kwboot.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/kwboot.c b/tools/kwboot.c
index 4e4d544efd3f..d22e6ea96a5c 100644
--- a/tools/kwboot.c
+++ b/tools/kwboot.c
@@ -1640,7 +1640,6 @@ err:
static void
kwboot_usage(FILE *stream, char *progname)
{
- fprintf(stream, "kwboot version %s\n", PLAIN_VERSION);
fprintf(stream,
"Usage: %s [OPTIONS] [-b <image> | -D <image> ] [-B <baud> ] <TTY>\n",
progname);
@@ -1685,6 +1684,8 @@ main(int argc, char **argv)
after_img_rsv = KWBOOT_XM_BLKSZ;
baudrate = 115200;
+ printf("kwboot version %s\n", PLAIN_VERSION);
+
kwboot_verbose = isatty(STDOUT_FILENO);
do {
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools: kwboot: Always print kwboot version
2021-11-05 22:30 [PATCH] tools: kwboot: Always print kwboot version Pali Rohár
@ 2021-11-10 8:22 ` Stefan Roese
2021-11-10 13:52 ` Stefan Roese
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2021-11-10 8:22 UTC (permalink / raw)
To: Pali Rohár; +Cc: Marek Behún, u-boot
On 05.11.21 23:30, Pali Rohár wrote:
> It is useful to see kwboot version in the boot log output for debugging
> purposes.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> tools/kwboot.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/kwboot.c b/tools/kwboot.c
> index 4e4d544efd3f..d22e6ea96a5c 100644
> --- a/tools/kwboot.c
> +++ b/tools/kwboot.c
> @@ -1640,7 +1640,6 @@ err:
> static void
> kwboot_usage(FILE *stream, char *progname)
> {
> - fprintf(stream, "kwboot version %s\n", PLAIN_VERSION);
> fprintf(stream,
> "Usage: %s [OPTIONS] [-b <image> | -D <image> ] [-B <baud> ] <TTY>\n",
> progname);
> @@ -1685,6 +1684,8 @@ main(int argc, char **argv)
> after_img_rsv = KWBOOT_XM_BLKSZ;
> baudrate = 115200;
>
> + printf("kwboot version %s\n", PLAIN_VERSION);
> +
> kwboot_verbose = isatty(STDOUT_FILENO);
>
> do {
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools: kwboot: Always print kwboot version
2021-11-05 22:30 [PATCH] tools: kwboot: Always print kwboot version Pali Rohár
2021-11-10 8:22 ` Stefan Roese
@ 2021-11-10 13:52 ` Stefan Roese
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2021-11-10 13:52 UTC (permalink / raw)
To: Pali Rohár; +Cc: Marek Behún, u-boot
On 05.11.21 23:30, Pali Rohár wrote:
> It is useful to see kwboot version in the boot log output for debugging
> purposes.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Applied to u-boot-marvell/master
Thanks,
Stefan
> ---
> tools/kwboot.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/kwboot.c b/tools/kwboot.c
> index 4e4d544efd3f..d22e6ea96a5c 100644
> --- a/tools/kwboot.c
> +++ b/tools/kwboot.c
> @@ -1640,7 +1640,6 @@ err:
> static void
> kwboot_usage(FILE *stream, char *progname)
> {
> - fprintf(stream, "kwboot version %s\n", PLAIN_VERSION);
> fprintf(stream,
> "Usage: %s [OPTIONS] [-b <image> | -D <image> ] [-B <baud> ] <TTY>\n",
> progname);
> @@ -1685,6 +1684,8 @@ main(int argc, char **argv)
> after_img_rsv = KWBOOT_XM_BLKSZ;
> baudrate = 115200;
>
> + printf("kwboot version %s\n", PLAIN_VERSION);
> +
> kwboot_verbose = isatty(STDOUT_FILENO);
>
> do {
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-10 13:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-05 22:30 [PATCH] tools: kwboot: Always print kwboot version Pali Rohár
2021-11-10 8:22 ` Stefan Roese
2021-11-10 13:52 ` Stefan Roese
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.