All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Document git-blame triple -C option
@ 2010-01-08 14:10 Ramkumar Ramachandra
  2010-01-08 15:36 ` Michael J Gruber
  0 siblings, 1 reply; 3+ messages in thread
From: Ramkumar Ramachandra @ 2010-01-08 14:10 UTC (permalink / raw)
  To: git

[-- Attachment #1: Type: text/plain, Size: 66 bytes --]

The git-blame -CCC option is undocumented. This patch fixes that.

[-- Attachment #2: 0001-Document-git-blame-triple-C-option.patch --]
[-- Type: text/x-patch, Size: 2251 bytes --]

From 2732bf40f7607941ce1d65ce4d0effc0e8a0a593 Mon Sep 17 00:00:00 2001
From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Fri, 8 Jan 2010 19:29:02 +0530
Subject: [PATCH] Document git-blame triple -C option

git-blame -CCC is explained in builin-blame.c line 2171, but is
unexplained in the documentation. This patch fixes that.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 Documentation/blame-options.txt |   13 +++++++------
 Documentation/git-blame.txt     |    2 +-
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/Documentation/blame-options.txt b/Documentation/blame-options.txt
index 1625ffc..e1abf1e 100644
--- a/Documentation/blame-options.txt
+++ b/Documentation/blame-options.txt
@@ -94,12 +94,13 @@ within a file for it to associate those lines with the parent
 commit.
 
 -C|<num>|::
-	In addition to `-M`, detect lines copied from other
-	files that were modified in the same commit.  This is
-	useful when you reorganize your program and move code
-	around across files.  When this option is given twice,
-	the command additionally looks for copies from all other
-	files in the parent for the commit that creates the file.
+	In addition to `-M`, detect lines copied from other files that
+	were modified in the same commit.  This is useful when you
+	reorganize your program and move code around across files.
+	When this option is given twice, the command additionally
+	looks for copies from other files in the commit that creates
+	the file. When this option is given thrice, the command
+	additionally looks for copies from other files in any commit.
 +
 <num> is optional but it is the lower bound on the number of
 alphanumeric characters that git must detect as moving
diff --git a/Documentation/git-blame.txt b/Documentation/git-blame.txt
index 8c7b7b0..25bc416 100644
--- a/Documentation/git-blame.txt
+++ b/Documentation/git-blame.txt
@@ -9,7 +9,7 @@ SYNOPSIS
 --------
 [verse]
 'git blame' [-c] [-b] [-l] [--root] [-t] [-f] [-n] [-s] [-p] [-w] [--incremental] [-L n,m]
-            [-S <revs-file>] [-M] [-C] [-C] [--since=<date>]
+            [-S <revs-file>] [-M] [-C] [-C] [-C] [--since=<date>]
 	    [<rev> | --contents <file> | --reverse <rev>] [--] <file>
 
 DESCRIPTION
-- 
1.6.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Document git-blame triple -C option
  2010-01-08 14:10 [PATCH] Document git-blame triple -C option Ramkumar Ramachandra
@ 2010-01-08 15:36 ` Michael J Gruber
  2010-01-08 18:58   ` Ramkumar Ramachandra
  0 siblings, 1 reply; 3+ messages in thread
From: Michael J Gruber @ 2010-01-08 15:36 UTC (permalink / raw)
  To: Ramkumar Ramachandra; +Cc: git

Ramkumar Ramachandra venit, vidit, dixit 08.01.2010 15:10:
> The git-blame -CCC option is undocumented. This patch fixes that.

Above you see why it is difficult to comment on attached patches.
They're not included!

You re-wrapped the existing documentation. Please don't do that, because
it makes it difficult to spot what you really changed.

It seems you added one sentence. Please don't use "thrice" for "three
times", that is very old English and sounds funny.

Michael

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Document git-blame triple -C option
  2010-01-08 15:36 ` Michael J Gruber
@ 2010-01-08 18:58   ` Ramkumar Ramachandra
  0 siblings, 0 replies; 3+ messages in thread
From: Ramkumar Ramachandra @ 2010-01-08 18:58 UTC (permalink / raw)
  To: Michael J Gruber; +Cc: git

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

> Above you see why it is difficult to comment on attached patches.
> They're not included!

I'm sorry, but I'm behind a HTTP proxy, and GMail mangles up patches.
I'm left with no choice but to attach the patches.

> You re-wrapped the existing documentation. Please don't do that, because
> it makes it difficult to spot what you really changed.

Okay. Corrected.

> It seems you added one sentence. Please don't use "thrice" for "three
> times", that is very old English and sounds funny.

Okay. I've also modified the second line (what happens when the option
is given twice) for clarity.

[-- Attachment #2: 0001-Document-git-blame-triple-C-option.patch --]
[-- Type: text/x-patch, Size: 1892 bytes --]

From 371705f64576ff7b8dc82bea19c714ce320097b9 Mon Sep 17 00:00:00 2001
From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Sat, 9 Jan 2010 00:18:07 +0530
Subject: [PATCH v2] Document git-blame triple -C option

git-blame -CCC is explained in builin-blame.c line 2171, but is
unexplained in the documentation. This patch fixes that.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 Documentation/blame-options.txt |    6 ++++--
 Documentation/git-blame.txt     |    2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/Documentation/blame-options.txt b/Documentation/blame-options.txt
index 1625ffc..4833cac 100644
--- a/Documentation/blame-options.txt
+++ b/Documentation/blame-options.txt
@@ -98,8 +98,10 @@ commit.
 	files that were modified in the same commit.  This is
 	useful when you reorganize your program and move code
 	around across files.  When this option is given twice,
-	the command additionally looks for copies from all other
-	files in the parent for the commit that creates the file.
+	the command additionally looks for copies from other
+	files in the commit that creates the file. When this
+	option is given three times, the command additionally
+	looks for copies from other files in any commit.
 +
 <num> is optional but it is the lower bound on the number of
 alphanumeric characters that git must detect as moving
diff --git a/Documentation/git-blame.txt b/Documentation/git-blame.txt
index 8c7b7b0..b786471 100644
--- a/Documentation/git-blame.txt
+++ b/Documentation/git-blame.txt
@@ -9,7 +9,7 @@ SYNOPSIS
 --------
 [verse]
 'git blame' [-c] [-b] [-l] [--root] [-t] [-f] [-n] [-s] [-p] [-w] [--incremental] [-L n,m]
-            [-S <revs-file>] [-M] [-C] [-C] [--since=<date>]
+	    [-S <revs-file>] [-M] [-C] [-C] [-C] [--since=<date>]
 	    [<rev> | --contents <file> | --reverse <rev>] [--] <file>
 
 DESCRIPTION
-- 
1.6.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-01-08 18:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-08 14:10 [PATCH] Document git-blame triple -C option Ramkumar Ramachandra
2010-01-08 15:36 ` Michael J Gruber
2010-01-08 18:58   ` Ramkumar Ramachandra

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.