[PATCH] doc: correct default scheduler in xen-command-line.pandoc

[PATCH] doc: correct default scheduler in xen-command-line.pandoc

[Juergen Gross]

We have switched to credit2. Let the documentation reflect that.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 docs/misc/xen-command-line.pandoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index d39bcee928..e24e3a45e4 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -1705,7 +1705,7 @@ with read and write permissions.
 ### sched
 > `= credit | credit2 | arinc653 | rtds | null`
 
-> Default: `sched=credit`
+> Default: `sched=credit2`
 
 Choose the default scheduler.
 
-- 
2.16.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] doc: correct default scheduler in xen-command-line.pandoc

[Andrew Cooper]

On 15/01/2019 11:35, Juergen Gross wrote:
> We have switched to credit2. Let the documentation reflect that.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  docs/misc/xen-command-line.pandoc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
> index d39bcee928..e24e3a45e4 100644
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -1705,7 +1705,7 @@ with read and write permissions.
>  ### sched
>  > `= credit | credit2 | arinc653 | rtds | null`
>  
> -> Default: `sched=credit`
> +> Default: `sched=credit2`
>  
>  Choose the default scheduler.
>  

Like XSM, this is Kconfig controlled, not a static default, and also
depends on the compiled schedulers.  This should read something like:

> Default: selectable via Kconfig.  Depends on enabled schedulers.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] doc: correct default scheduler in xen-command-line.pandoc

[Wei Liu]

On Tue, Jan 15, 2019 at 12:35:10PM +0100, Juergen Gross wrote:
> We have switched to credit2. Let the documentation reflect that.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] doc: correct default scheduler in xen-command-line.pandoc

[Juergen Gross]

On 15/01/2019 12:35, Juergen Gross wrote:
> We have switched to credit2. Let the documentation reflect that.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

And just for the records:

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] doc: correct default scheduler in xen-command-line.pandoc

[Juergen Gross]

On 15/01/2019 12:38, Andrew Cooper wrote:
> On 15/01/2019 11:35, Juergen Gross wrote:
>> We have switched to credit2. Let the documentation reflect that.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>>  docs/misc/xen-command-line.pandoc | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
>> index d39bcee928..e24e3a45e4 100644
>> --- a/docs/misc/xen-command-line.pandoc
>> +++ b/docs/misc/xen-command-line.pandoc
>> @@ -1705,7 +1705,7 @@ with read and write permissions.
>>  ### sched
>>  > `= credit | credit2 | arinc653 | rtds | null`
>>  
>> -> Default: `sched=credit`
>> +> Default: `sched=credit2`
>>  
>>  Choose the default scheduler.
>>  
> 
> Like XSM, this is Kconfig controlled, not a static default, and also
> depends on the compiled schedulers.  This should read something like:
> 
>> Default: selectable via Kconfig.  Depends on enabled schedulers.

The Kconfig default is credit2.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] doc: correct default scheduler in xen-command-line.pandoc

[Andrew Cooper]

On 15/01/2019 11:40, Juergen Gross wrote:
> On 15/01/2019 12:38, Andrew Cooper wrote:
>> On 15/01/2019 11:35, Juergen Gross wrote:
>>> We have switched to credit2. Let the documentation reflect that.
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>> ---
>>>  docs/misc/xen-command-line.pandoc | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
>>> index d39bcee928..e24e3a45e4 100644
>>> --- a/docs/misc/xen-command-line.pandoc
>>> +++ b/docs/misc/xen-command-line.pandoc
>>> @@ -1705,7 +1705,7 @@ with read and write permissions.
>>>  ### sched
>>>  > `= credit | credit2 | arinc653 | rtds | null`
>>>  
>>> -> Default: `sched=credit`
>>> +> Default: `sched=credit2`
>>>  
>>>  Choose the default scheduler.
>>>  
>> Like XSM, this is Kconfig controlled, not a static default, and also
>> depends on the compiled schedulers.  This should read something like:
>>
>>> Default: selectable via Kconfig.  Depends on enabled schedulers.
> The Kconfig default is credit2.

Only when credit2 is compiled in, which isn't even the the case for all
Kconfig fragments we have in tree.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] doc: correct default scheduler in xen-command-line.pandoc

[Juergen Gross]

On 15/01/2019 12:41, Andrew Cooper wrote:
> On 15/01/2019 11:40, Juergen Gross wrote:
>> On 15/01/2019 12:38, Andrew Cooper wrote:
>>> On 15/01/2019 11:35, Juergen Gross wrote:
>>>> We have switched to credit2. Let the documentation reflect that.
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>> ---
>>>>  docs/misc/xen-command-line.pandoc | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
>>>> index d39bcee928..e24e3a45e4 100644
>>>> --- a/docs/misc/xen-command-line.pandoc
>>>> +++ b/docs/misc/xen-command-line.pandoc
>>>> @@ -1705,7 +1705,7 @@ with read and write permissions.
>>>>  ### sched
>>>>  > `= credit | credit2 | arinc653 | rtds | null`
>>>>  
>>>> -> Default: `sched=credit`
>>>> +> Default: `sched=credit2`
>>>>  
>>>>  Choose the default scheduler.
>>>>  
>>> Like XSM, this is Kconfig controlled, not a static default, and also
>>> depends on the compiled schedulers.  This should read something like:
>>>
>>>> Default: selectable via Kconfig.  Depends on enabled schedulers.
>> The Kconfig default is credit2.
> 
> Only when credit2 is compiled in, which isn't even the the case for all
> Kconfig fragments we have in tree.

I still think it is sensible to specify an actual default here.

Adding other caveats for special Kconfig variants might be okay, but
this should be another patch then (post 4.12 probably).

In the end one of the features highlighted for 4.12 will be:

"Credit 2 is now the default scheduler".

Our documentation should reflect that.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] doc: correct default scheduler in xen-command-line.pandoc

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 1625 bytes --]

On Tue, 2019-01-15 at 11:41 +0000, Andrew Cooper wrote:
> On 15/01/2019 11:40, Juergen Gross wrote:
> > On 15/01/2019 12:38, Andrew Cooper wrote:
> > > On 15/01/2019 11:35, Juergen Gross wrote:
> > > > 
> > > > diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-
> > > > command-line.pandoc
> > > > index d39bcee928..e24e3a45e4 100644
> > > > --- a/docs/misc/xen-command-line.pandoc
> > > > +++ b/docs/misc/xen-command-line.pandoc
> > > > @@ -1705,7 +1705,7 @@ with read and write permissions.
> > > >  ### sched
> > > >  > `= credit | credit2 | arinc653 | rtds | null`
> > > >  
> > > > -> Default: `sched=credit`
> > > > +> Default: `sched=credit2`
> > > >  
> > > >  Choose the default scheduler.
> > > >  
> > > Like XSM, this is Kconfig controlled, not a static default, and
> > > also
> > > depends on the compiled schedulers.  This should read something
> > > like:
> > > 
> > > > Default: selectable via Kconfig.  Depends on enabled
> > > > schedulers.
> > The Kconfig default is credit2.
> 
> Only when credit2 is compiled in, which isn't even the the case for
> all
> Kconfig fragments we have in tree.
> 
So, basically, what you're saying is that we need a patch that removes
any mention to what the default is, right?

Like removing the line:

 Default: `sched=credit`

without replacing it with anything else?

Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel