From: Xiang Zheng <zhengxiang9@huawei.com> To: Peter Maydell <peter.maydell@linaro.org> Cc: Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Shannon Zhao <shannon.zhaosl@gmail.com>, Laszlo Ersek <lersek@redhat.com>, James Morse <james.morse@arm.com>, gengdongjiu <gengdongjiu@huawei.com>, Marcelo Tosatti <mtosatti@redhat.com>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, Jonathan Cameron <jonathan.cameron@huawei.com>, "xuwei (O)" <xuwei5@huawei.com>, kvm-devel <kvm@vger.kernel.org>, "QEMU Developers" <qemu-devel@nongnu.org>, qemu-arm <qemu-arm@nongnu.org>, Linuxarm <linuxarm@huawei.com>, <wanghaibin.wang@huawei.com> Subject: Re: [PATCH v19 3/5] ACPI: Add APEI GHES table generation support Date: Thu, 17 Oct 2019 14:20:37 +0800 [thread overview] Message-ID: <f35f10ec-c5e0-bcdc-48a9-ceb754cf1fc1@huawei.com> (raw) In-Reply-To: <CAFEAcA9CWPKF5XibFtZRwavVj4PboGoaM5368Omje6qrOjV3AQ@mail.gmail.com> On 2019/10/15 22:52, Peter Maydell wrote: > On Tue, 15 Oct 2019 at 15:02, Xiang Zheng <zhengxiang9@huawei.com> wrote: >> >> From: Dongjiu Geng <gengdongjiu@huawei.com> >> >> This patch implements APEI GHES Table generation via fw_cfg blobs. Now >> it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards, >> we can extend the supported types if needed. For the CPER section, >> currently it is memory section because kernel mainly wants userspace to >> handle the memory errors. >> >> This patch follows the spec ACPI 6.2 to build the Hardware Error Source >> table. For more detailed information, please refer to document: >> docs/specs/acpi_hest_ghes.rst >> >> Suggested-by: Laszlo Ersek <lersek@redhat.com> >> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com> >> Signed-off-by: Xiang Zheng <zhengxiang9@huawei.com> > >> + /* Error Status Address */ >> + build_append_gas(table_data, AML_SYSTEM_MEMORY, 0x40, 0, >> + 4 /* QWord access */, 0); > > Hi; this doesn't seem to compile with clang: > > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/acpi/acpi_ghes.c:330:34: > error: implicit conversion from > enumeration type 'AmlRegionSpace' to different enumeration type > 'AmlAddressSpace' > [-Werror,-Wenum-conversion] > build_append_gas(table_data, AML_SYSTEM_MEMORY, 0x40, 0, > ~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~ > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/acpi/acpi_ghes.c:351:34: > error: implicit conversion from > enumeration type 'AmlRegionSpace' to different enumeration type > 'AmlAddressSpace' > [-Werror,-Wenum-conversion] > build_append_gas(table_data, AML_SYSTEM_MEMORY, 0x40, 0, > ~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~ > 2 errors generated. > > Should these be AML_AS_SYSTEM_MEMORY, or should the build_append_gas() > function be taking an AmlRegionSpace rather than an AmlAddressSpace ? Yes, these should be AML_AS_SYSTEM_MEMORY, the first field of Generic Address Structure(GAS) is Address Space ID. I will fix these compile errors. > > thanks > -- PMM > > . > -- Thanks, Xiang
WARNING: multiple messages have this Message-ID (diff)
From: Xiang Zheng <zhengxiang9@huawei.com> To: Peter Maydell <peter.maydell@linaro.org> Cc: Eduardo Habkost <ehabkost@redhat.com>, kvm-devel <kvm@vger.kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, wanghaibin.wang@huawei.com, Marcelo Tosatti <mtosatti@redhat.com>, Linuxarm <linuxarm@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, gengdongjiu <gengdongjiu@huawei.com>, Shannon Zhao <shannon.zhaosl@gmail.com>, qemu-arm <qemu-arm@nongnu.org>, James Morse <james.morse@arm.com>, Jonathan Cameron <jonathan.cameron@huawei.com>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "xuwei \(O\)" <xuwei5@huawei.com>, Laszlo Ersek <lersek@redhat.com>, Richard Henderson <rth@twiddle.net> Subject: Re: [PATCH v19 3/5] ACPI: Add APEI GHES table generation support Date: Thu, 17 Oct 2019 14:20:37 +0800 [thread overview] Message-ID: <f35f10ec-c5e0-bcdc-48a9-ceb754cf1fc1@huawei.com> (raw) In-Reply-To: <CAFEAcA9CWPKF5XibFtZRwavVj4PboGoaM5368Omje6qrOjV3AQ@mail.gmail.com> On 2019/10/15 22:52, Peter Maydell wrote: > On Tue, 15 Oct 2019 at 15:02, Xiang Zheng <zhengxiang9@huawei.com> wrote: >> >> From: Dongjiu Geng <gengdongjiu@huawei.com> >> >> This patch implements APEI GHES Table generation via fw_cfg blobs. Now >> it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards, >> we can extend the supported types if needed. For the CPER section, >> currently it is memory section because kernel mainly wants userspace to >> handle the memory errors. >> >> This patch follows the spec ACPI 6.2 to build the Hardware Error Source >> table. For more detailed information, please refer to document: >> docs/specs/acpi_hest_ghes.rst >> >> Suggested-by: Laszlo Ersek <lersek@redhat.com> >> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com> >> Signed-off-by: Xiang Zheng <zhengxiang9@huawei.com> > >> + /* Error Status Address */ >> + build_append_gas(table_data, AML_SYSTEM_MEMORY, 0x40, 0, >> + 4 /* QWord access */, 0); > > Hi; this doesn't seem to compile with clang: > > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/acpi/acpi_ghes.c:330:34: > error: implicit conversion from > enumeration type 'AmlRegionSpace' to different enumeration type > 'AmlAddressSpace' > [-Werror,-Wenum-conversion] > build_append_gas(table_data, AML_SYSTEM_MEMORY, 0x40, 0, > ~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~ > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/acpi/acpi_ghes.c:351:34: > error: implicit conversion from > enumeration type 'AmlRegionSpace' to different enumeration type > 'AmlAddressSpace' > [-Werror,-Wenum-conversion] > build_append_gas(table_data, AML_SYSTEM_MEMORY, 0x40, 0, > ~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~ > 2 errors generated. > > Should these be AML_AS_SYSTEM_MEMORY, or should the build_append_gas() > function be taking an AmlRegionSpace rather than an AmlAddressSpace ? Yes, these should be AML_AS_SYSTEM_MEMORY, the first field of Generic Address Structure(GAS) is Address Space ID. I will fix these compile errors. > > thanks > -- PMM > > . > -- Thanks, Xiang
next prev parent reply other threads:[~2019-10-17 6:20 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-15 14:01 [PATCH v19 0/5] Add ARMv8 RAS virtualization support in QEMU Xiang Zheng 2019-10-15 14:01 ` Xiang Zheng 2019-10-15 14:01 ` [PATCH v19 1/5] hw/arm/virt: Introduce a RAS machine option Xiang Zheng 2019-10-15 14:01 ` Xiang Zheng 2019-10-15 14:01 ` [PATCH v19 2/5] docs: APEI GHES generation and CPER record description Xiang Zheng 2019-10-15 14:01 ` Xiang Zheng 2019-10-15 15:08 ` Peter Maydell 2019-10-15 15:08 ` Peter Maydell 2019-10-16 3:26 ` Xiang Zheng 2019-10-16 3:26 ` Xiang Zheng 2019-10-15 14:01 ` [PATCH v19 3/5] ACPI: Add APEI GHES table generation support Xiang Zheng 2019-10-15 14:01 ` Xiang Zheng 2019-10-15 14:52 ` Peter Maydell 2019-10-15 14:52 ` Peter Maydell 2019-10-17 6:20 ` Xiang Zheng [this message] 2019-10-17 6:20 ` Xiang Zheng 2019-10-15 14:01 ` [PATCH v19 4/5] KVM: Move hwpoison page related functions into kvm-all.c Xiang Zheng 2019-10-15 14:01 ` Xiang Zheng 2019-10-15 14:01 ` [PATCH v19 5/5] target-arm: kvm64: handle SIGBUS signal from kernel or KVM Xiang Zheng 2019-10-15 14:01 ` Xiang Zheng 2019-10-15 14:48 ` Peter Maydell 2019-10-15 14:48 ` Peter Maydell 2019-10-17 6:03 ` Xiang Zheng 2019-10-17 6:03 ` Xiang Zheng 2019-10-15 23:27 ` [PATCH v19 0/5] Add ARMv8 RAS virtualization support in QEMU no-reply 2019-10-15 23:27 ` no-reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f35f10ec-c5e0-bcdc-48a9-ceb754cf1fc1@huawei.com \ --to=zhengxiang9@huawei.com \ --cc=ehabkost@redhat.com \ --cc=gengdongjiu@huawei.com \ --cc=imammedo@redhat.com \ --cc=james.morse@arm.com \ --cc=jonathan.cameron@huawei.com \ --cc=kvm@vger.kernel.org \ --cc=lersek@redhat.com \ --cc=linuxarm@huawei.com \ --cc=mst@redhat.com \ --cc=mtosatti@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=shannon.zhaosl@gmail.com \ --cc=wanghaibin.wang@huawei.com \ --cc=xuwei5@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.