All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gpu: drm/tilcdc: Fix switch case fallthrough
@ 2019-07-17  5:09 ` Keerthy
  0 siblings, 0 replies; 4+ messages in thread
From: Keerthy @ 2019-07-17  5:09 UTC (permalink / raw)
  To: jsarha, tomi.valkeinen
  Cc: j-keerthy, airlied, daniel, dri-devel, t-kristo, linux-kernel

Fix the below build warning/Error

drivers/gpu/drm/tilcdc/tilcdc_crtc.c: In function ‘tilcdc_crtc_set_mode’:
drivers/gpu/drm/tilcdc/tilcdc_crtc.c:384:8: error: this statement may fall
through [-Werror=implicit-fallthrough=]
    reg |= LCDC_V2_TFT_24BPP_UNPACK;
    ~~~~^~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tilcdc/tilcdc_crtc.c:386:3: note: here
   case DRM_FORMAT_BGR888:
   ^~~~
cc1: all warnings being treated as errors
make[5]: *** [drivers/gpu/drm/tilcdc/tilcdc_crtc.o] Error 1
make[4]: *** [drivers/gpu/drm/tilcdc] Error 2
make[4]: *** Waiting for unfinished jobs....

Fixes: f6382f186d2982750 ("drm/tilcdc: Add tilcdc_crtc_mode_set_nofb()")
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
index 650d162e374b..c95b0652c6ab 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
@@ -382,7 +382,8 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc)
 		case DRM_FORMAT_XBGR8888:
 		case DRM_FORMAT_XRGB8888:
 			reg |= LCDC_V2_TFT_24BPP_UNPACK;
-			/* fallthrough */
+			reg |= LCDC_V2_TFT_24BPP_MODE;
+			break;
 		case DRM_FORMAT_BGR888:
 		case DRM_FORMAT_RGB888:
 			reg |= LCDC_V2_TFT_24BPP_MODE;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] gpu: drm/tilcdc: Fix switch case fallthrough
@ 2019-07-17  5:09 ` Keerthy
  0 siblings, 0 replies; 4+ messages in thread
From: Keerthy @ 2019-07-17  5:09 UTC (permalink / raw)
  To: jsarha, tomi.valkeinen
  Cc: j-keerthy, airlied, daniel, dri-devel, t-kristo, linux-kernel

Fix the below build warning/Error

drivers/gpu/drm/tilcdc/tilcdc_crtc.c: In function ‘tilcdc_crtc_set_mode’:
drivers/gpu/drm/tilcdc/tilcdc_crtc.c:384:8: error: this statement may fall
through [-Werror=implicit-fallthrough=]
    reg |= LCDC_V2_TFT_24BPP_UNPACK;
    ~~~~^~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tilcdc/tilcdc_crtc.c:386:3: note: here
   case DRM_FORMAT_BGR888:
   ^~~~
cc1: all warnings being treated as errors
make[5]: *** [drivers/gpu/drm/tilcdc/tilcdc_crtc.o] Error 1
make[4]: *** [drivers/gpu/drm/tilcdc] Error 2
make[4]: *** Waiting for unfinished jobs....

Fixes: f6382f186d2982750 ("drm/tilcdc: Add tilcdc_crtc_mode_set_nofb()")
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
index 650d162e374b..c95b0652c6ab 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
@@ -382,7 +382,8 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc)
 		case DRM_FORMAT_XBGR8888:
 		case DRM_FORMAT_XRGB8888:
 			reg |= LCDC_V2_TFT_24BPP_UNPACK;
-			/* fallthrough */
+			reg |= LCDC_V2_TFT_24BPP_MODE;
+			break;
 		case DRM_FORMAT_BGR888:
 		case DRM_FORMAT_RGB888:
 			reg |= LCDC_V2_TFT_24BPP_MODE;
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] gpu: drm/tilcdc: Fix switch case fallthrough
  2019-07-17  5:09 ` Keerthy
@ 2019-07-30  6:28   ` Tomi Valkeinen
  -1 siblings, 0 replies; 4+ messages in thread
From: Tomi Valkeinen @ 2019-07-30  6:28 UTC (permalink / raw)
  To: Keerthy, jsarha; +Cc: airlied, daniel, dri-devel, t-kristo, linux-kernel

On 17/07/2019 08:09, Keerthy wrote:
> Fix the below build warning/Error
> 
> drivers/gpu/drm/tilcdc/tilcdc_crtc.c: In function ‘tilcdc_crtc_set_mode’:
> drivers/gpu/drm/tilcdc/tilcdc_crtc.c:384:8: error: this statement may fall
> through [-Werror=implicit-fallthrough=]
>      reg |= LCDC_V2_TFT_24BPP_UNPACK;
>      ~~~~^~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/tilcdc/tilcdc_crtc.c:386:3: note: here
>     case DRM_FORMAT_BGR888:
>     ^~~~
> cc1: all warnings being treated as errors
> make[5]: *** [drivers/gpu/drm/tilcdc/tilcdc_crtc.o] Error 1
> make[4]: *** [drivers/gpu/drm/tilcdc] Error 2
> make[4]: *** Waiting for unfinished jobs....
> 
> Fixes: f6382f186d2982750 ("drm/tilcdc: Add tilcdc_crtc_mode_set_nofb()")
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>   drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] gpu: drm/tilcdc: Fix switch case fallthrough
@ 2019-07-30  6:28   ` Tomi Valkeinen
  0 siblings, 0 replies; 4+ messages in thread
From: Tomi Valkeinen @ 2019-07-30  6:28 UTC (permalink / raw)
  To: Keerthy, jsarha; +Cc: airlied, daniel, dri-devel, t-kristo, linux-kernel

On 17/07/2019 08:09, Keerthy wrote:
> Fix the below build warning/Error
> 
> drivers/gpu/drm/tilcdc/tilcdc_crtc.c: In function ‘tilcdc_crtc_set_mode’:
> drivers/gpu/drm/tilcdc/tilcdc_crtc.c:384:8: error: this statement may fall
> through [-Werror=implicit-fallthrough=]
>      reg |= LCDC_V2_TFT_24BPP_UNPACK;
>      ~~~~^~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/tilcdc/tilcdc_crtc.c:386:3: note: here
>     case DRM_FORMAT_BGR888:
>     ^~~~
> cc1: all warnings being treated as errors
> make[5]: *** [drivers/gpu/drm/tilcdc/tilcdc_crtc.o] Error 1
> make[4]: *** [drivers/gpu/drm/tilcdc] Error 2
> make[4]: *** Waiting for unfinished jobs....
> 
> Fixes: f6382f186d2982750 ("drm/tilcdc: Add tilcdc_crtc_mode_set_nofb()")
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>   drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-30  6:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-17  5:09 [PATCH] gpu: drm/tilcdc: Fix switch case fallthrough Keerthy
2019-07-17  5:09 ` Keerthy
2019-07-30  6:28 ` Tomi Valkeinen
2019-07-30  6:28   ` Tomi Valkeinen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.