All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] events: Improve the "perf samples too long" warning
@ 2014-03-08 18:02 Andy Lutomirski
  0 siblings, 0 replies; only message in thread
From: Andy Lutomirski @ 2014-03-08 18:02 UTC (permalink / raw)
  To: linux-kernel
  Cc: Arnaldo Carvalho de Melo, Ingo Molnar, Paul Mackerras,
	Peter Zijlstra, Paul Bolle, Markus Trippelsdorf, Mike Galbraith,
	Andy Lutomirski

The warning is not indicative of an actual problem, especially when
triggered by nmi_watchdog, so lower it to KERN_INFO.  While I'm at
it, clarify the message and reference the sysctl that controls it.

Signed-off-by: Andy Lutomirski <luto@amacapital.net>
---
 kernel/events/core.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 56003c6..245bdc0 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -263,9 +263,8 @@ void perf_sample_event_took(u64 sample_len_ns)
 	sysctl_perf_event_sample_rate = max_samples_per_tick * HZ;
 	perf_sample_period_ns = NSEC_PER_SEC / sysctl_perf_event_sample_rate;
 
-	printk_ratelimited(KERN_WARNING
-			"perf samples too long (%lld > %lld), lowering "
-			"kernel.perf_event_max_sample_rate to %d\n",
+	printk_ratelimited(KERN_INFO
+			"perf samples are too slow for kernel.perf_cpu_time_max_percent (%lldns > %lldns); lowering kernel.perf_event_max_sample_rate to %d\n",
 			avg_local_sample_len, allowed_ns,
 			sysctl_perf_event_sample_rate);
 
-- 
1.8.5.3


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-03-08 18:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-08 18:02 [PATCH] events: Improve the "perf samples too long" warning Andy Lutomirski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.