All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: net: nxp,sja1105: document spi-cpol
@ 2022-11-02 16:12 Krzysztof Kozlowski
  2022-11-02 18:35 ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-02 16:12 UTC (permalink / raw)
  To: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, netdev, devicetree,
	linux-kernel
  Cc: Krzysztof Kozlowski

Some boards use SJA1105 Ethernet Switch with SPI CPOL, so document this
to fix dtbs_check warnings:

  arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb: ethernet-switch@0: Unevaluated properties are not allowed ('spi-cpol' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml b/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
index 1e26d876d146..a73905a50ee5 100644
--- a/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
@@ -36,6 +36,8 @@ properties:
   reg:
     maxItems: 1
 
+  spi-cpol: true
+
   # Optional container node for the 2 internal MDIO buses of the SJA1110
   # (one for the internal 100base-T1 PHYs and the other for the single
   # 100base-TX PHY). The "reg" property does not have physical significance.
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: net: nxp,sja1105: document spi-cpol
  2022-11-02 16:12 [PATCH] dt-bindings: net: nxp,sja1105: document spi-cpol Krzysztof Kozlowski
@ 2022-11-02 18:35 ` Rob Herring
  2022-11-02 18:49   ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2022-11-02 18:35 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Andrew Lunn, Vladimir Oltean, Eric Dumazet, Paolo Abeni, netdev,
	devicetree, Vivien Didelot, Rob Herring, David S. Miller,
	Jakub Kicinski, Florian Fainelli, Krzysztof Kozlowski,
	linux-kernel


On Wed, 02 Nov 2022 12:12:11 -0400, Krzysztof Kozlowski wrote:
> Some boards use SJA1105 Ethernet Switch with SPI CPOL, so document this
> to fix dtbs_check warnings:
> 
>   arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb: ethernet-switch@0: Unevaluated properties are not allowed ('spi-cpol' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/


ethernet-switch@1: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'fsl,spi-cs-sck-delay', 'fsl,spi-sck-cs-delay', 'spi-cpha' were unexpected)
	arch/arm/boot/dts/ls1021a-tsn.dtb

switch@0: Unevaluated properties are not allowed ('clocks', 'reset-gpios', 'spi-cpha' were unexpected)
	arch/arm/boot/dts/imx6qp-prtwd3.dtb
	arch/arm/boot/dts/stm32mp151a-prtt1c.dtb


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: net: nxp,sja1105: document spi-cpol
  2022-11-02 18:35 ` Rob Herring
@ 2022-11-02 18:49   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-02 18:49 UTC (permalink / raw)
  To: Rob Herring
  Cc: Andrew Lunn, Vladimir Oltean, Eric Dumazet, Paolo Abeni, netdev,
	devicetree, Vivien Didelot, Rob Herring, David S. Miller,
	Jakub Kicinski, Florian Fainelli, Krzysztof Kozlowski,
	linux-kernel

On 02/11/2022 14:35, Rob Herring wrote:
> 
> On Wed, 02 Nov 2022 12:12:11 -0400, Krzysztof Kozlowski wrote:
>> Some boards use SJA1105 Ethernet Switch with SPI CPOL, so document this
>> to fix dtbs_check warnings:
>>
>>   arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb: ethernet-switch@0: Unevaluated properties are not allowed ('spi-cpol' was unexpected)
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml | 2 ++
>>  1 file changed, 2 insertions(+)
>>
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/patch/
> 
> 
> ethernet-switch@1: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'fsl,spi-cs-sck-delay', 'fsl,spi-sck-cs-delay', 'spi-cpha' were unexpected)
> 	arch/arm/boot/dts/ls1021a-tsn.dtb

I'll add cpha, but fsl,spi-cs-sck-delay are coming from unconverted
schema - spi-fsl-dspi.txt.

> 
> switch@0: Unevaluated properties are not allowed ('clocks', 'reset-gpios', 'spi-cpha' were unexpected)
> 	arch/arm/boot/dts/imx6qp-prtwd3.dtb
> 	arch/arm/boot/dts/stm32mp151a-prtt1c.dtb
> 

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-02 18:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-02 16:12 [PATCH] dt-bindings: net: nxp,sja1105: document spi-cpol Krzysztof Kozlowski
2022-11-02 18:35 ` Rob Herring
2022-11-02 18:49   ` Krzysztof Kozlowski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.