* [PATCH] arm: dts: pxa3xx: provide correct clk-names property for nand controller node
@ 2018-06-24 17:42 ` Daniel Mack
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Mack @ 2018-06-24 17:42 UTC (permalink / raw)
To: robert.jarzmik, haojian.zhuang
Cc: devicetree, robh+dt, Daniel Mack, linux-arm-kernel
The NAND driver looks for a clock named "core" and falls back to a pdev
clock that has a wrong rate if not set.
Signed-off-by: Daniel Mack <daniel@zonque.org>
---
arch/arm/boot/dts/pxa3xx.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/pxa3xx.dtsi b/arch/arm/boot/dts/pxa3xx.dtsi
index 3851057bc77d..7f65791c0559 100644
--- a/arch/arm/boot/dts/pxa3xx.dtsi
+++ b/arch/arm/boot/dts/pxa3xx.dtsi
@@ -134,6 +134,7 @@
compatible = "marvell,pxa3xx-nand-controller";
reg = <0x43100000 90>;
interrupts = <45>;
+ clock-names = "core";
clocks = <&clks CLK_NAND>;
dmas = <&pdma 97 3>;
dma-names = "data";
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] arm: dts: pxa3xx: provide correct clk-names property for nand controller node
@ 2018-06-24 17:42 ` Daniel Mack
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Mack @ 2018-06-24 17:42 UTC (permalink / raw)
To: linux-arm-kernel
The NAND driver looks for a clock named "core" and falls back to a pdev
clock that has a wrong rate if not set.
Signed-off-by: Daniel Mack <daniel@zonque.org>
---
arch/arm/boot/dts/pxa3xx.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/pxa3xx.dtsi b/arch/arm/boot/dts/pxa3xx.dtsi
index 3851057bc77d..7f65791c0559 100644
--- a/arch/arm/boot/dts/pxa3xx.dtsi
+++ b/arch/arm/boot/dts/pxa3xx.dtsi
@@ -134,6 +134,7 @@
compatible = "marvell,pxa3xx-nand-controller";
reg = <0x43100000 90>;
interrupts = <45>;
+ clock-names = "core";
clocks = <&clks CLK_NAND>;
dmas = <&pdma 97 3>;
dma-names = "data";
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] arm: dts: pxa3xx: provide correct clk-names property for nand controller node
2018-06-24 17:42 ` Daniel Mack
@ 2018-06-25 20:18 ` Robert Jarzmik
-1 siblings, 0 replies; 8+ messages in thread
From: Robert Jarzmik @ 2018-06-25 20:18 UTC (permalink / raw)
To: Daniel Mack; +Cc: devicetree, robh+dt, linux-arm-kernel, haojian.zhuang
Daniel Mack <daniel@zonque.org> writes:
> The NAND driver looks for a clock named "core" and falls back to a pdev
> clock that has a wrong rate if not set.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
Applied to pxa/dt with a small "line swap", ie. clock-names is one line below
"clocks" line.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] arm: dts: pxa3xx: provide correct clk-names property for nand controller node
@ 2018-06-25 20:18 ` Robert Jarzmik
0 siblings, 0 replies; 8+ messages in thread
From: Robert Jarzmik @ 2018-06-25 20:18 UTC (permalink / raw)
To: linux-arm-kernel
Daniel Mack <daniel@zonque.org> writes:
> The NAND driver looks for a clock named "core" and falls back to a pdev
> clock that has a wrong rate if not set.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
Applied to pxa/dt with a small "line swap", ie. clock-names is one line below
"clocks" line.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm: dts: pxa3xx: provide correct clk-names property for nand controller node
2018-06-25 20:18 ` Robert Jarzmik
@ 2018-09-19 16:20 ` Daniel Mack
-1 siblings, 0 replies; 8+ messages in thread
From: Daniel Mack @ 2018-09-19 16:20 UTC (permalink / raw)
To: Robert Jarzmik; +Cc: devicetree, robh+dt, linux-arm-kernel, haojian.zhuang
Hi Robert,
On 25/6/2018 10:18 PM, Robert Jarzmik wrote:
> Daniel Mack <daniel@zonque.org> writes:
>
>> The NAND driver looks for a clock named "core" and falls back to a pdev
>> clock that has a wrong rate if not set.
>>
>> Signed-off-by: Daniel Mack <daniel@zonque.org>
> Applied to pxa/dt with a small "line swap", ie. clock-names is one line below
> "clocks" line.
This patch got applied twice in mainline, as ce4313f318de and as
267a113cec97. Not sure what went wrong here, but the same property npow
occurs twice in the node, which leads to an error during dtb complication.
Could you queue a revert for ce4313f318de?
Thanks,
Daniel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] arm: dts: pxa3xx: provide correct clk-names property for nand controller node
@ 2018-09-19 16:20 ` Daniel Mack
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Mack @ 2018-09-19 16:20 UTC (permalink / raw)
To: linux-arm-kernel
Hi Robert,
On 25/6/2018 10:18 PM, Robert Jarzmik wrote:
> Daniel Mack <daniel@zonque.org> writes:
>
>> The NAND driver looks for a clock named "core" and falls back to a pdev
>> clock that has a wrong rate if not set.
>>
>> Signed-off-by: Daniel Mack <daniel@zonque.org>
> Applied to pxa/dt with a small "line swap", ie. clock-names is one line below
> "clocks" line.
This patch got applied twice in mainline, as ce4313f318de and as
267a113cec97. Not sure what went wrong here, but the same property npow
occurs twice in the node, which leads to an error during dtb complication.
Could you queue a revert for ce4313f318de?
Thanks,
Daniel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm: dts: pxa3xx: provide correct clk-names property for nand controller node
2018-09-19 16:20 ` Daniel Mack
@ 2018-09-20 5:03 ` Daniel Mack
-1 siblings, 0 replies; 8+ messages in thread
From: Daniel Mack @ 2018-09-20 5:03 UTC (permalink / raw)
To: Robert Jarzmik; +Cc: devicetree, robh+dt, linux-arm-kernel
On 19/9/2018 6:20 PM, Daniel Mack wrote:
> On 25/6/2018 10:18 PM, Robert Jarzmik wrote:
>> Daniel Mack <daniel@zonque.org> writes:
>>
>>> The NAND driver looks for a clock named "core" and falls back to a pdev
>>> clock that has a wrong rate if not set.
>>>
>>> Signed-off-by: Daniel Mack <daniel@zonque.org>
>> Applied to pxa/dt with a small "line swap", ie. clock-names is one line below
>> "clocks" line.
>
> This patch got applied twice in mainline, as ce4313f318de and as
> 267a113cec97. Not sure what went wrong here, but the same property npow
> occurs twice in the node, which leads to an error during dtb complication.
Ooops, sorry. Forget it, all is good. I've messed up a local branch.
Sorry for the noise. :(
Daniel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] arm: dts: pxa3xx: provide correct clk-names property for nand controller node
@ 2018-09-20 5:03 ` Daniel Mack
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Mack @ 2018-09-20 5:03 UTC (permalink / raw)
To: linux-arm-kernel
On 19/9/2018 6:20 PM, Daniel Mack wrote:
> On 25/6/2018 10:18 PM, Robert Jarzmik wrote:
>> Daniel Mack <daniel@zonque.org> writes:
>>
>>> The NAND driver looks for a clock named "core" and falls back to a pdev
>>> clock that has a wrong rate if not set.
>>>
>>> Signed-off-by: Daniel Mack <daniel@zonque.org>
>> Applied to pxa/dt with a small "line swap", ie. clock-names is one line below
>> "clocks" line.
>
> This patch got applied twice in mainline, as ce4313f318de and as
> 267a113cec97. Not sure what went wrong here, but the same property npow
> occurs twice in the node, which leads to an error during dtb complication.
Ooops, sorry. Forget it, all is good. I've messed up a local branch.
Sorry for the noise. :(
Daniel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-09-20 5:03 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-24 17:42 [PATCH] arm: dts: pxa3xx: provide correct clk-names property for nand controller node Daniel Mack
2018-06-24 17:42 ` Daniel Mack
2018-06-25 20:18 ` Robert Jarzmik
2018-06-25 20:18 ` Robert Jarzmik
2018-09-19 16:20 ` Daniel Mack
2018-09-19 16:20 ` Daniel Mack
2018-09-20 5:03 ` Daniel Mack
2018-09-20 5:03 ` Daniel Mack
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.