From: Jason Wang <jasowang@redhat.com> To: Zhu Lingshan <lingshan.zhu@intel.com>, mst@redhat.com Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com> Subject: Re: [PATCH] vDPA/ifcvf: assign nr_vring to the MSI vector of config_intr by default Date: Wed, 13 Apr 2022 16:14:31 +0800 [thread overview] Message-ID: <f3f60d6e-a506-bd58-d763-848beb0e4c26@redhat.com> (raw) In-Reply-To: <20220408121013.54709-1-lingshan.zhu@intel.com> 在 2022/4/8 下午8:10, Zhu Lingshan 写道: > This commit assign struct ifcvf_hw.nr_vring to the MSIX vector of the > config interrupt by default in ifcvf_request_config_irq(). > ifcvf_hw.nr_vring is the most likely and the ideal case for > the device config interrupt handling, means every virtqueue has > an individual MSIX vector(0 ~ nr_vring - 1), and the config interrupt has > its own MSIX vector(number nr_vring). > > This change can also make GCC W = 2 happy, silence the > "uninitialized" warning. > > Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com> > Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/vdpa/ifcvf/ifcvf_main.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c > index 4366320fb68d..b500fb941dab 100644 > --- a/drivers/vdpa/ifcvf/ifcvf_main.c > +++ b/drivers/vdpa/ifcvf/ifcvf_main.c > @@ -290,13 +290,13 @@ static int ifcvf_request_config_irq(struct ifcvf_adapter *adapter) > struct ifcvf_hw *vf = &adapter->vf; > int config_vector, ret; > > + /* vector 0 ~ vf->nr_vring for vqs, num vf->nr_vring vector for config interrupt */ The comment is right before this patch, but probably wrong for MSIX_VECTOR_DEV_SHARED. > + config_vector = vf->nr_vring; > + > + /* re-use the vqs vector */ > if (vf->msix_vector_status == MSIX_VECTOR_DEV_SHARED) > return 0; > > - if (vf->msix_vector_status == MSIX_VECTOR_PER_VQ_AND_CONFIG) > - /* vector 0 ~ vf->nr_vring for vqs, num vf->nr_vring vector for config interrupt */ > - config_vector = vf->nr_vring; > - > if (vf->msix_vector_status == MSIX_VECTOR_SHARED_VQ_AND_CONFIG) > /* vector 0 for vqs and 1 for config interrupt */ > config_vector = 1; Actually, I prefer to use if ... else ... here. Thanks
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Zhu Lingshan <lingshan.zhu@intel.com>, mst@redhat.com Cc: netdev@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com>, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] vDPA/ifcvf: assign nr_vring to the MSI vector of config_intr by default Date: Wed, 13 Apr 2022 16:14:31 +0800 [thread overview] Message-ID: <f3f60d6e-a506-bd58-d763-848beb0e4c26@redhat.com> (raw) In-Reply-To: <20220408121013.54709-1-lingshan.zhu@intel.com> 在 2022/4/8 下午8:10, Zhu Lingshan 写道: > This commit assign struct ifcvf_hw.nr_vring to the MSIX vector of the > config interrupt by default in ifcvf_request_config_irq(). > ifcvf_hw.nr_vring is the most likely and the ideal case for > the device config interrupt handling, means every virtqueue has > an individual MSIX vector(0 ~ nr_vring - 1), and the config interrupt has > its own MSIX vector(number nr_vring). > > This change can also make GCC W = 2 happy, silence the > "uninitialized" warning. > > Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com> > Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/vdpa/ifcvf/ifcvf_main.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c > index 4366320fb68d..b500fb941dab 100644 > --- a/drivers/vdpa/ifcvf/ifcvf_main.c > +++ b/drivers/vdpa/ifcvf/ifcvf_main.c > @@ -290,13 +290,13 @@ static int ifcvf_request_config_irq(struct ifcvf_adapter *adapter) > struct ifcvf_hw *vf = &adapter->vf; > int config_vector, ret; > > + /* vector 0 ~ vf->nr_vring for vqs, num vf->nr_vring vector for config interrupt */ The comment is right before this patch, but probably wrong for MSIX_VECTOR_DEV_SHARED. > + config_vector = vf->nr_vring; > + > + /* re-use the vqs vector */ > if (vf->msix_vector_status == MSIX_VECTOR_DEV_SHARED) > return 0; > > - if (vf->msix_vector_status == MSIX_VECTOR_PER_VQ_AND_CONFIG) > - /* vector 0 ~ vf->nr_vring for vqs, num vf->nr_vring vector for config interrupt */ > - config_vector = vf->nr_vring; > - > if (vf->msix_vector_status == MSIX_VECTOR_SHARED_VQ_AND_CONFIG) > /* vector 0 for vqs and 1 for config interrupt */ > config_vector = 1; Actually, I prefer to use if ... else ... here. Thanks _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-04-13 8:14 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-08 12:10 [PATCH] vDPA/ifcvf: assign nr_vring to the MSI vector of config_intr by default Zhu Lingshan 2022-04-13 8:14 ` Jason Wang [this message] 2022-04-13 8:14 ` Jason Wang 2022-04-13 9:16 ` Zhu, Lingshan 2022-04-15 5:51 ` Jason Wang 2022-04-15 5:51 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f3f60d6e-a506-bd58-d763-848beb0e4c26@redhat.com \ --to=jasowang@redhat.com \ --cc=dan.carpenter@oracle.com \ --cc=lingshan.zhu@intel.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.