* Re: [PATCH] decodetree: Open files with encoding='utf-8'
2021-01-08 15:16 [PATCH] decodetree: Open files with encoding='utf-8' Philippe Mathieu-Daudé
@ 2021-01-08 15:25 ` 罗勇刚(Yonggang Luo)
2021-01-08 15:38 ` Peter Maydell
2021-01-08 22:51 ` Daniele Buono
2 siblings, 0 replies; 12+ messages in thread
From: 罗勇刚(Yonggang Luo) @ 2021-01-08 15:25 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Peter Maydell, Eduardo Habkost, Richard Henderson, qemu-level,
Cleber Rosa, Paolo Bonzini
[-- Attachment #1: Type: text/plain, Size: 1802 bytes --]
On Fri, Jan 8, 2021 at 7:18 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:
>
> When decodetree.py was added in commit 568ae7efae7, QEMU was
> using Python 2 which happily reads UTF-8 files in text mode.
> Python 3 requires either UTF-8 locale or an explicit encoding
> passed to open(). Now that Python 3 is required, explicit
> UTF-8 encoding for decodetree sources.
>
> This fixes:
>
> $ /usr/bin/python3 scripts/decodetree.py test.decode
> Traceback (most recent call last):
> File "scripts/decodetree.py", line 1397, in <module>
> main()
> File "scripts/decodetree.py", line 1308, in main
> parse_file(f, toppat)
> File "scripts/decodetree.py", line 994, in parse_file
> for line in f:
> File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
> return codecs.ascii_decode(input, self.errors)[0]
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 80:
> ordinal not in range(128)
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> scripts/decodetree.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/decodetree.py b/scripts/decodetree.py
> index 47aa9caf6d1..fa40903cff1 100644
> --- a/scripts/decodetree.py
> +++ b/scripts/decodetree.py
> @@ -1304,7 +1304,7 @@ def main():
>
> for filename in args:
> input_file = filename
> - f = open(filename, 'r')
> + f = open(filename, 'r', encoding='utf-8')
> parse_file(f, toppat)
> f.close()
>
> --
> 2.26.2
>
>
Reviewed-by: Yonggang Luo <l <peter.maydell@linaro.org>uoyonggang@gmail.com
>
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
[-- Attachment #2: Type: text/html, Size: 2676 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] decodetree: Open files with encoding='utf-8'
2021-01-08 15:16 [PATCH] decodetree: Open files with encoding='utf-8' Philippe Mathieu-Daudé
2021-01-08 15:25 ` 罗勇刚(Yonggang Luo)
@ 2021-01-08 15:38 ` Peter Maydell
2021-01-08 16:13 ` 罗勇刚(Yonggang Luo)
2021-01-08 16:44 ` Philippe Mathieu-Daudé
2021-01-08 22:51 ` Daniele Buono
2 siblings, 2 replies; 12+ messages in thread
From: Peter Maydell @ 2021-01-08 15:38 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Paolo Bonzini, Cleber Rosa, Richard Henderson, QEMU Developers,
Eduardo Habkost
On Fri, 8 Jan 2021 at 15:16, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> When decodetree.py was added in commit 568ae7efae7, QEMU was
> using Python 2 which happily reads UTF-8 files in text mode.
> Python 3 requires either UTF-8 locale or an explicit encoding
> passed to open(). Now that Python 3 is required, explicit
> UTF-8 encoding for decodetree sources.
>
> This fixes:
>
> $ /usr/bin/python3 scripts/decodetree.py test.decode
> Traceback (most recent call last):
> File "scripts/decodetree.py", line 1397, in <module>
> main()
> File "scripts/decodetree.py", line 1308, in main
> parse_file(f, toppat)
> File "scripts/decodetree.py", line 994, in parse_file
> for line in f:
> File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
> return codecs.ascii_decode(input, self.errors)[0]
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 80:
> ordinal not in range(128)
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> scripts/decodetree.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/decodetree.py b/scripts/decodetree.py
> index 47aa9caf6d1..fa40903cff1 100644
> --- a/scripts/decodetree.py
> +++ b/scripts/decodetree.py
> @@ -1304,7 +1304,7 @@ def main():
>
> for filename in args:
> input_file = filename
> - f = open(filename, 'r')
> + f = open(filename, 'r', encoding='utf-8')
> parse_file(f, toppat)
> f.close()
Should we also be opening the output file explicitly as
utf-8 ? (How do we say "write to sys.stdout as utf-8" for
the case where we're doing that?)
thanks
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] decodetree: Open files with encoding='utf-8'
2021-01-08 15:38 ` Peter Maydell
@ 2021-01-08 16:13 ` 罗勇刚(Yonggang Luo)
2021-01-08 16:43 ` Eduardo Habkost
2021-01-08 16:44 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 12+ messages in thread
From: 罗勇刚(Yonggang Luo) @ 2021-01-08 16:13 UTC (permalink / raw)
To: Peter Maydell
Cc: Eduardo Habkost, Richard Henderson, QEMU Developers,
Philippe Mathieu-Daudé,
Cleber Rosa, Paolo Bonzini
[-- Attachment #1: Type: text/plain, Size: 2171 bytes --]
On Sat, Jan 9, 2021 at 12:05 AM Peter Maydell <peter.maydell@linaro.org>
wrote:
>
> On Fri, 8 Jan 2021 at 15:16, Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:
> >
> > When decodetree.py was added in commit 568ae7efae7, QEMU was
> > using Python 2 which happily reads UTF-8 files in text mode.
> > Python 3 requires either UTF-8 locale or an explicit encoding
> > passed to open(). Now that Python 3 is required, explicit
> > UTF-8 encoding for decodetree sources.
> >
> > This fixes:
> >
> > $ /usr/bin/python3 scripts/decodetree.py test.decode
> > Traceback (most recent call last):
> > File "scripts/decodetree.py", line 1397, in <module>
> > main()
> > File "scripts/decodetree.py", line 1308, in main
> > parse_file(f, toppat)
> > File "scripts/decodetree.py", line 994, in parse_file
> > for line in f:
> > File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
> > return codecs.ascii_decode(input, self.errors)[0]
> > UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position
80:
> > ordinal not in range(128)
> >
> > Reported-by: Peter Maydell <peter.maydell@linaro.org>
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> > scripts/decodetree.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/decodetree.py b/scripts/decodetree.py
> > index 47aa9caf6d1..fa40903cff1 100644
> > --- a/scripts/decodetree.py
> > +++ b/scripts/decodetree.py
> > @@ -1304,7 +1304,7 @@ def main():
> >
> > for filename in args:
> > input_file = filename
> > - f = open(filename, 'r')
> > + f = open(filename, 'r', encoding='utf-8')
> > parse_file(f, toppat)
> > f.close()
>
> Should we also be opening the output file explicitly as
> utf-8 ? (How do we say "write to sys.stdout as utf-8" for
> the case where we're doing that?)
Can be done with
```
sys.stdout = io.TextIOWrapper(sys.stdout.buffer, encoding="utf8",
errors="ignore")
```
>
> thanks
> -- PMM
>
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
[-- Attachment #2: Type: text/html, Size: 2972 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] decodetree: Open files with encoding='utf-8'
2021-01-08 16:13 ` 罗勇刚(Yonggang Luo)
@ 2021-01-08 16:43 ` Eduardo Habkost
0 siblings, 0 replies; 12+ messages in thread
From: Eduardo Habkost @ 2021-01-08 16:43 UTC (permalink / raw)
To: 罗勇刚(Yonggang Luo)
Cc: Peter Maydell, Richard Henderson, QEMU Developers,
Philippe Mathieu-Daudé,
Cleber Rosa, Paolo Bonzini
On Sat, Jan 09, 2021 at 12:13:31AM +0800, 罗勇刚(Yonggang Luo) wrote:
> On Sat, Jan 9, 2021 at 12:05 AM Peter Maydell <peter.maydell@linaro.org>
> wrote:
> >
> > On Fri, 8 Jan 2021 at 15:16, Philippe Mathieu-Daudé <f4bug@amsat.org>
> wrote:
> > >
> > > When decodetree.py was added in commit 568ae7efae7, QEMU was
> > > using Python 2 which happily reads UTF-8 files in text mode.
> > > Python 3 requires either UTF-8 locale or an explicit encoding
> > > passed to open(). Now that Python 3 is required, explicit
> > > UTF-8 encoding for decodetree sources.
> > >
> > > This fixes:
> > >
> > > $ /usr/bin/python3 scripts/decodetree.py test.decode
> > > Traceback (most recent call last):
> > > File "scripts/decodetree.py", line 1397, in <module>
> > > main()
> > > File "scripts/decodetree.py", line 1308, in main
> > > parse_file(f, toppat)
> > > File "scripts/decodetree.py", line 994, in parse_file
> > > for line in f:
> > > File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
> > > return codecs.ascii_decode(input, self.errors)[0]
> > > UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position
> 80:
> > > ordinal not in range(128)
> > >
> > > Reported-by: Peter Maydell <peter.maydell@linaro.org>
> > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > > ---
> > > scripts/decodetree.py | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/scripts/decodetree.py b/scripts/decodetree.py
> > > index 47aa9caf6d1..fa40903cff1 100644
> > > --- a/scripts/decodetree.py
> > > +++ b/scripts/decodetree.py
> > > @@ -1304,7 +1304,7 @@ def main():
> > >
> > > for filename in args:
> > > input_file = filename
> > > - f = open(filename, 'r')
> > > + f = open(filename, 'r', encoding='utf-8')
> > > parse_file(f, toppat)
> > > f.close()
> >
> > Should we also be opening the output file explicitly as
> > utf-8 ? (How do we say "write to sys.stdout as utf-8" for
> > the case where we're doing that?)
>
> Can be done with
> ```
> sys.stdout = io.TextIOWrapper(sys.stdout.buffer, encoding="utf8",
> errors="ignore")
> ```
In the specific case of decodetree, just assigning this to
`output_fd` is enough, and less hacky than overwriting
`sys.stdout`.
--
Eduardo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] decodetree: Open files with encoding='utf-8'
2021-01-08 15:38 ` Peter Maydell
2021-01-08 16:13 ` 罗勇刚(Yonggang Luo)
@ 2021-01-08 16:44 ` Philippe Mathieu-Daudé
2021-01-08 17:14 ` Peter Maydell
1 sibling, 1 reply; 12+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-08 16:44 UTC (permalink / raw)
To: Peter Maydell
Cc: Paolo Bonzini, Richard Henderson, QEMU Developers,
Eduardo Habkost, Cleber Rosa
On 1/8/21 4:38 PM, Peter Maydell wrote:
> On Fri, 8 Jan 2021 at 15:16, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> When decodetree.py was added in commit 568ae7efae7, QEMU was
>> using Python 2 which happily reads UTF-8 files in text mode.
>> Python 3 requires either UTF-8 locale or an explicit encoding
>> passed to open(). Now that Python 3 is required, explicit
>> UTF-8 encoding for decodetree sources.
>>
>> This fixes:
>>
>> $ /usr/bin/python3 scripts/decodetree.py test.decode
>> Traceback (most recent call last):
>> File "scripts/decodetree.py", line 1397, in <module>
>> main()
>> File "scripts/decodetree.py", line 1308, in main
>> parse_file(f, toppat)
>> File "scripts/decodetree.py", line 994, in parse_file
>> for line in f:
>> File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
>> return codecs.ascii_decode(input, self.errors)[0]
>> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 80:
>> ordinal not in range(128)
>>
>> Reported-by: Peter Maydell <peter.maydell@linaro.org>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> scripts/decodetree.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/decodetree.py b/scripts/decodetree.py
>> index 47aa9caf6d1..fa40903cff1 100644
>> --- a/scripts/decodetree.py
>> +++ b/scripts/decodetree.py
>> @@ -1304,7 +1304,7 @@ def main():
>>
>> for filename in args:
>> input_file = filename
>> - f = open(filename, 'r')
>> + f = open(filename, 'r', encoding='utf-8')
>> parse_file(f, toppat)
>> f.close()
>
> Should we also be opening the output file explicitly as
> utf-8 ? (How do we say "write to sys.stdout as utf-8" for
> the case where we're doing that?)
I have been wondering about it, but the content written
in the output file is plain C code using only ASCII,
which any locale is able to process. But indeed maybe
we prefer ignore the user locale... I'm not sure.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] decodetree: Open files with encoding='utf-8'
2021-01-08 16:44 ` Philippe Mathieu-Daudé
@ 2021-01-08 17:14 ` Peter Maydell
2021-01-08 18:02 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 12+ messages in thread
From: Peter Maydell @ 2021-01-08 17:14 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Paolo Bonzini, Richard Henderson, QEMU Developers,
Eduardo Habkost, Cleber Rosa
On Fri, 8 Jan 2021 at 16:44, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 1/8/21 4:38 PM, Peter Maydell wrote:
> > Should we also be opening the output file explicitly as
> > utf-8 ? (How do we say "write to sys.stdout as utf-8" for
> > the case where we're doing that?)
>
> I have been wondering about it, but the content written
> in the output file is plain C code using only ASCII,
> which any locale is able to process. But indeed maybe
> we prefer ignore the user locale... I'm not sure.
I'm not a python expert so I don't know what the usual thing
is here, but it seems to me better to insulate our build
process from what the user's locale happens to be set to,
even if it happens that we currently only output ASCII.
thanks
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] decodetree: Open files with encoding='utf-8'
2021-01-08 17:14 ` Peter Maydell
@ 2021-01-08 18:02 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 12+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-08 18:02 UTC (permalink / raw)
To: Peter Maydell
Cc: Paolo Bonzini, Cleber Rosa, Richard Henderson, QEMU Developers,
Eduardo Habkost
On 1/8/21 6:14 PM, Peter Maydell wrote:
> On Fri, 8 Jan 2021 at 16:44, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> On 1/8/21 4:38 PM, Peter Maydell wrote:
>>> Should we also be opening the output file explicitly as
>>> utf-8 ? (How do we say "write to sys.stdout as utf-8" for
>>> the case where we're doing that?)
>>
>> I have been wondering about it, but the content written
>> in the output file is plain C code using only ASCII,
>> which any locale is able to process. But indeed maybe
>> we prefer ignore the user locale... I'm not sure.
>
> I'm not a python expert so I don't know what the usual thing
> is here, but it seems to me better to insulate our build
> process from what the user's locale happens to be set to,
> even if it happens that we currently only output ASCII.
OK, I'll respin.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] decodetree: Open files with encoding='utf-8'
2021-01-08 15:16 [PATCH] decodetree: Open files with encoding='utf-8' Philippe Mathieu-Daudé
2021-01-08 15:25 ` 罗勇刚(Yonggang Luo)
2021-01-08 15:38 ` Peter Maydell
@ 2021-01-08 22:51 ` Daniele Buono
2021-01-12 21:11 ` Eduardo Habkost
2 siblings, 1 reply; 12+ messages in thread
From: Daniele Buono @ 2021-01-08 22:51 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Peter Maydell, Paolo Bonzini, Richard Henderson, Eduardo Habkost,
Cleber Rosa
I had a similar issue in the past with the acceptance tests.
Some VMs send UTF-8 output in their console and the acceptance test
script would bail out if the locale was not UTF-8.
I sent a patch on the ml but it probably got lost:
https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg06086.html
I can re-spin it if you guys are interested
On 1/8/2021 10:16 AM, Philippe Mathieu-Daudé wrote:
> When decodetree.py was added in commit 568ae7efae7, QEMU was
> using Python 2 which happily reads UTF-8 files in text mode.
> Python 3 requires either UTF-8 locale or an explicit encoding
> passed to open(). Now that Python 3 is required, explicit
> UTF-8 encoding for decodetree sources.
>
> This fixes:
>
> $ /usr/bin/python3 scripts/decodetree.py test.decode
> Traceback (most recent call last):
> File "scripts/decodetree.py", line 1397, in <module>
> main()
> File "scripts/decodetree.py", line 1308, in main
> parse_file(f, toppat)
> File "scripts/decodetree.py", line 994, in parse_file
> for line in f:
> File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
> return codecs.ascii_decode(input, self.errors)[0]
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 80:
> ordinal not in range(128)
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> scripts/decodetree.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/decodetree.py b/scripts/decodetree.py
> index 47aa9caf6d1..fa40903cff1 100644
> --- a/scripts/decodetree.py
> +++ b/scripts/decodetree.py
> @@ -1304,7 +1304,7 @@ def main():
>
> for filename in args:
> input_file = filename
> - f = open(filename, 'r')
> + f = open(filename, 'r', encoding='utf-8')
> parse_file(f, toppat)
> f.close()
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] decodetree: Open files with encoding='utf-8'
2021-01-08 22:51 ` Daniele Buono
@ 2021-01-12 21:11 ` Eduardo Habkost
2021-01-12 23:35 ` John Snow
0 siblings, 1 reply; 12+ messages in thread
From: Eduardo Habkost @ 2021-01-12 21:11 UTC (permalink / raw)
To: Daniele Buono
Cc: Peter Maydell, Richard Henderson, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, qemu-devel, Cleber Rosa,
Paolo Bonzini, John Snow
[CCing John, Wainer]
On Fri, Jan 08, 2021 at 05:51:41PM -0500, Daniele Buono wrote:
> I had a similar issue in the past with the acceptance tests.
> Some VMs send UTF-8 output in their console and the acceptance test
> script would bail out if the locale was not UTF-8.
>
> I sent a patch on the ml but it probably got lost:
> https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg06086.html
>
> I can re-spin it if you guys are interested
The mbox at
https://lore.kernel.org/qemu-devel/20200721125522.20511-1-dbuono@linux.vnet.ibm.com/
can still be applied cleanly, I don't think you need to resubmit.
However, we have no owner for tests/acceptance/avocado_qemu in
MAINTAINERS. Is anybody currently taking care of
tests/acceptance patches and making sure they are merged?
--
Eduardo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] decodetree: Open files with encoding='utf-8'
2021-01-12 21:11 ` Eduardo Habkost
@ 2021-01-12 23:35 ` John Snow
2021-01-12 23:44 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 12+ messages in thread
From: John Snow @ 2021-01-12 23:35 UTC (permalink / raw)
To: Eduardo Habkost, Daniele Buono
Cc: Peter Maydell, Richard Henderson, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, qemu-devel, Cleber Rosa,
Paolo Bonzini
On 1/12/21 4:11 PM, Eduardo Habkost wrote:
> [CCing John, Wainer]
>
> On Fri, Jan 08, 2021 at 05:51:41PM -0500, Daniele Buono wrote:
>> I had a similar issue in the past with the acceptance tests.
>> Some VMs send UTF-8 output in their console and the acceptance test
>> script would bail out if the locale was not UTF-8.
>>
>> I sent a patch on the ml but it probably got lost:
>> https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg06086.html
>>
>> I can re-spin it if you guys are interested
>
> The mbox at
> https://lore.kernel.org/qemu-devel/20200721125522.20511-1-dbuono@linux.vnet.ibm.com/
> can still be applied cleanly, I don't think you need to resubmit.
>
> However, we have no owner for tests/acceptance/avocado_qemu in
> MAINTAINERS. Is anybody currently taking care of
> tests/acceptance patches and making sure they are merged?
>
I touch these tests sometimes, but I know very little about avocado
overall, so I don't think it's going to be me taking point here.
(I don't mind taking a reviewer stanza for something like *.py, though.)
Acceptance (Integration) Testing with the Avocado framework
W: https://trello.com/b/6Qi1pxVn/avocado-qemu
R: Cleber Rosa <crosa@redhat.com>
R: Philippe Mathieu-Daudé <philmd@redhat.com>
R: Wainer dos Santos Moschetta <wainersm@redhat.com>
S: Odd Fixes
F: tests/acceptance/
Why is this only "Odd Fixes"? Isn't it new within the last ~2y? The
avocado_qemu module itself was largely written by Cleber, Philippe and Caio.
--js
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] decodetree: Open files with encoding='utf-8'
2021-01-12 23:35 ` John Snow
@ 2021-01-12 23:44 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 12+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-12 23:44 UTC (permalink / raw)
To: John Snow, Eduardo Habkost, Daniele Buono
Cc: Peter Maydell, Richard Henderson, qemu-devel,
Wainer dos Santos Moschetta, Cleber Rosa, Paolo Bonzini
On 1/13/21 12:35 AM, John Snow wrote:
> On 1/12/21 4:11 PM, Eduardo Habkost wrote:
>> [CCing John, Wainer]
>>
>> On Fri, Jan 08, 2021 at 05:51:41PM -0500, Daniele Buono wrote:
>>> I had a similar issue in the past with the acceptance tests.
>>> Some VMs send UTF-8 output in their console and the acceptance test
>>> script would bail out if the locale was not UTF-8.
>>>
>>> I sent a patch on the ml but it probably got lost:
>>> https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg06086.html
>>>
>>> I can re-spin it if you guys are interested
>>
>> The mbox at
>> https://lore.kernel.org/qemu-devel/20200721125522.20511-1-dbuono@linux.vnet.ibm.com/
>>
>> can still be applied cleanly, I don't think you need to resubmit.
>>
>> However, we have no owner for tests/acceptance/avocado_qemu in
>> MAINTAINERS. Is anybody currently taking care of
>> tests/acceptance patches and making sure they are merged?
[1] The answer to this question is below in [2]...
> I touch these tests sometimes, but I know very little about avocado
> overall, so I don't think it's going to be me taking point here.
>
> (I don't mind taking a reviewer stanza for something like *.py, though.)
>
> Acceptance (Integration) Testing with the Avocado framework
> W: https://trello.com/b/6Qi1pxVn/avocado-qemu
> R: Cleber Rosa <crosa@redhat.com>
> R: Philippe Mathieu-Daudé <philmd@redhat.com>
> R: Wainer dos Santos Moschetta <wainersm@redhat.com>
> S: Odd Fixes
> F: tests/acceptance/
>
> Why is this only "Odd Fixes"? Isn't it new within the last ~2y? The
> avocado_qemu module itself was largely written by Cleber, Philippe and
> Caio.
[2] The answer to this question is above in [1] :)
>
> --js
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread