[PATCH] nvme-core: fix comment to reflect right functions

[PATCH] nvme-core: fix comment to reflect right functions

[Chaitanya Kulkarni]

The functions and the attribute listed in the comment doesn't exists in
the code, (ns->logging_enabled, nvme_passthru_err_log_enabled_store()
and nvme_passthru_err_log_enabled_show())

Update the comment with right function names and a comment
ns->passthru_err_log_enabled, nvme_io_passthru_err_log_enabled_store()
and nvme_io_passthru_err_log_enabled_show().

Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
 drivers/nvme/host/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 975245527c1f..7db700b2ed00 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3762,8 +3762,8 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, struct nvme_ns_info *info)
 
 	/*
 	 * Set ns->disk->device->driver_data to ns so we can access
-	 * ns->logging_enabled in nvme_passthru_err_log_enabled_store() and
-	 * nvme_passthru_err_log_enabled_show().
+	 * ns->passthru_err_log_enabled in
+	 * nvme_io_passthru_err_log_enabled_[store | show]().
 	 */
 	dev_set_drvdata(disk_to_dev(ns->disk), ns);
 
-- 
2.40.0

Re: [PATCH] nvme-core: fix comment to reflect right functions

[alan.adamson]

Reviewed-by: Alan Adamson <alan.adamson@oracle.com>

On 2/5/24 4:30 PM, Chaitanya Kulkarni wrote:
> The functions and the attribute listed in the comment doesn't exists in
> the code, (ns->logging_enabled, nvme_passthru_err_log_enabled_store()
> and nvme_passthru_err_log_enabled_show())
>
> Update the comment with right function names and a comment
> ns->passthru_err_log_enabled, nvme_io_passthru_err_log_enabled_store()
> and nvme_io_passthru_err_log_enabled_show().
>
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
>   drivers/nvme/host/core.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 975245527c1f..7db700b2ed00 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -3762,8 +3762,8 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, struct nvme_ns_info *info)
>   
>   	/*
>   	 * Set ns->disk->device->driver_data to ns so we can access
> -	 * ns->logging_enabled in nvme_passthru_err_log_enabled_store() and
> -	 * nvme_passthru_err_log_enabled_show().
> +	 * ns->passthru_err_log_enabled in
> +	 * nvme_io_passthru_err_log_enabled_[store | show]().
>   	 */
>   	dev_set_drvdata(disk_to_dev(ns->disk), ns);
>   

Re: [PATCH] nvme-core: fix comment to reflect right functions

[Keith Busch]

On Mon, Feb 05, 2024 at 04:30:21PM -0800, Chaitanya Kulkarni wrote:
>  	/*
>  	 * Set ns->disk->device->driver_data to ns so we can access
> -	 * ns->logging_enabled in nvme_passthru_err_log_enabled_store() and
> -	 * nvme_passthru_err_log_enabled_show().
> +	 * ns->passthru_err_log_enabled in

Thanks, applied to nvme-6.8 with updated comment "ns->head->..."