All of lore.kernel.org
 help / color / mirror / Atom feed
* Bug in [PATCH] sparc: Align clone and signal stacks to 16 bytes
@ 2010-02-11 17:31 Blue Swirl
  2010-02-11 20:27 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Blue Swirl @ 2010-02-11 17:31 UTC (permalink / raw)
  To: sparclinux

Hi,

I just browsed sparc-linux list and spotted this bug in the patch:

 			childstack = (struct sparc_stackf __user *)
-				(sp & ~0x7UL);
+				(sp & ~0x15UL);
 			parentstack = (struct sparc_stackf __user *)

0x15UL is wrong, it should be either 0xfUL or 15UL.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Bug in [PATCH] sparc: Align clone and signal stacks to 16 bytes
  2010-02-11 17:31 Bug in [PATCH] sparc: Align clone and signal stacks to 16 bytes Blue Swirl
@ 2010-02-11 20:27 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-02-11 20:27 UTC (permalink / raw)
  To: sparclinux

From: Blue Swirl <blauwirbel@gmail.com>
Date: Thu, 11 Feb 2010 19:31:47 +0200

> Hi,
> 
> I just browsed sparc-linux list and spotted this bug in the patch:
> 
>  			childstack = (struct sparc_stackf __user *)
> -				(sp & ~0x7UL);
> +				(sp & ~0x15UL);
>  			parentstack = (struct sparc_stackf __user *)
> 
> 0x15UL is wrong, it should be either 0xfUL or 15UL.

Thanks, I'll fix that.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-11 20:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-11 17:31 Bug in [PATCH] sparc: Align clone and signal stacks to 16 bytes Blue Swirl
2010-02-11 20:27 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.