* [PATCH v2] dt-bindings: sram: Add 'clocks' as an optional property @ 2018-06-26 23:07 Fabio Estevam 2018-07-03 22:21 ` Rob Herring 0 siblings, 1 reply; 5+ messages in thread From: Fabio Estevam @ 2018-06-26 23:07 UTC (permalink / raw) To: robh+dt; +Cc: devicetree, p.zabel, vz, Fabio Estevam From: Fabio Estevam <fabio.estevam@nxp.com> Some SoCs (like i.MX53) need to specify the SRAM clock in the device tree via the clocks property. Add an entry to the optional property section. Reviewed-by: Vladimir Zapolskiy <vz@mleia.com> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> --- Changes since v1: - Add space before : and use the more common "list of phandle and clock specifier pairs" term - Vladimir Documentation/devicetree/bindings/sram/sram.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/sram/sram.txt b/Documentation/devicetree/bindings/sram/sram.txt index 267da44..ae6ca34 100644 --- a/Documentation/devicetree/bindings/sram/sram.txt +++ b/Documentation/devicetree/bindings/sram/sram.txt @@ -50,6 +50,8 @@ Optional properties in the area nodes: manipulation of the page attributes. - label : the name for the reserved partition, if omitted, the label is taken from the node name excluding the unit address. +- clocks : a list of phandle and clock specifier pairs that controls the + SRAM clock. Example: -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: sram: Add 'clocks' as an optional property 2018-06-26 23:07 [PATCH v2] dt-bindings: sram: Add 'clocks' as an optional property Fabio Estevam @ 2018-07-03 22:21 ` Rob Herring 2018-07-03 22:41 ` Fabio Estevam 2018-07-04 6:40 ` Vladimir Zapolskiy 0 siblings, 2 replies; 5+ messages in thread From: Rob Herring @ 2018-07-03 22:21 UTC (permalink / raw) To: Fabio Estevam; +Cc: devicetree, p.zabel, vz, Fabio Estevam On Tue, Jun 26, 2018 at 08:07:33PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@nxp.com> > > Some SoCs (like i.MX53) need to specify the SRAM clock in the > device tree via the clocks property. > > Add an entry to the optional property section. > > Reviewed-by: Vladimir Zapolskiy <vz@mleia.com> > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> > --- > Changes since v1: > - Add space before : and use the more common "list of phandle > and clock specifier pairs" term - Vladimir > > Documentation/devicetree/bindings/sram/sram.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sram/sram.txt b/Documentation/devicetree/bindings/sram/sram.txt > index 267da44..ae6ca34 100644 > --- a/Documentation/devicetree/bindings/sram/sram.txt > +++ b/Documentation/devicetree/bindings/sram/sram.txt > @@ -50,6 +50,8 @@ Optional properties in the area nodes: > manipulation of the page attributes. > - label : the name for the reserved partition, if omitted, the label > is taken from the node name excluding the unit address. > +- clocks : a list of phandle and clock specifier pairs that controls the > + SRAM clock. A list controlling THE (single) SRAM clock? Once we start needing clocks, power, or other setup, we really should have specific compatible strings (and binding docs) for the SRAM. I'll take a single clock though. Rob ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: sram: Add 'clocks' as an optional property 2018-07-03 22:21 ` Rob Herring @ 2018-07-03 22:41 ` Fabio Estevam 2018-07-04 6:40 ` Vladimir Zapolskiy 1 sibling, 0 replies; 5+ messages in thread From: Fabio Estevam @ 2018-07-03 22:41 UTC (permalink / raw) To: Rob Herring Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Philipp Zabel, Vladimir Zapolskiy, Fabio Estevam On Tue, Jul 3, 2018 at 7:21 PM, Rob Herring <robh@kernel.org> wrote: >> diff --git a/Documentation/devicetree/bindings/sram/sram.txt b/Documentation/devicetree/bindings/sram/sram.txt >> index 267da44..ae6ca34 100644 >> --- a/Documentation/devicetree/bindings/sram/sram.txt >> +++ b/Documentation/devicetree/bindings/sram/sram.txt >> @@ -50,6 +50,8 @@ Optional properties in the area nodes: >> manipulation of the page attributes. >> - label : the name for the reserved partition, if omitted, the label >> is taken from the node name excluding the unit address. >> +- clocks : a list of phandle and clock specifier pairs that controls the >> + SRAM clock. > > A list controlling THE (single) SRAM clock? Yes, it is a single SRAM clock. Will reword it. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: sram: Add 'clocks' as an optional property 2018-07-03 22:21 ` Rob Herring 2018-07-03 22:41 ` Fabio Estevam @ 2018-07-04 6:40 ` Vladimir Zapolskiy 2018-07-05 17:18 ` Rob Herring 1 sibling, 1 reply; 5+ messages in thread From: Vladimir Zapolskiy @ 2018-07-04 6:40 UTC (permalink / raw) To: Rob Herring, Fabio Estevam; +Cc: devicetree, p.zabel, vz, Fabio Estevam Hi Rob, Fabio, On 07/04/2018 01:21 AM, Rob Herring wrote: > On Tue, Jun 26, 2018 at 08:07:33PM -0300, Fabio Estevam wrote: >> From: Fabio Estevam <fabio.estevam@nxp.com> >> >> Some SoCs (like i.MX53) need to specify the SRAM clock in the >> device tree via the clocks property. >> >> Add an entry to the optional property section. >> >> Reviewed-by: Vladimir Zapolskiy <vz@mleia.com> >> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> >> --- >> Changes since v1: >> - Add space before : and use the more common "list of phandle >> and clock specifier pairs" term - Vladimir >> >> Documentation/devicetree/bindings/sram/sram.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sram/sram.txt b/Documentation/devicetree/bindings/sram/sram.txt >> index 267da44..ae6ca34 100644 >> --- a/Documentation/devicetree/bindings/sram/sram.txt >> +++ b/Documentation/devicetree/bindings/sram/sram.txt >> @@ -50,6 +50,8 @@ Optional properties in the area nodes: >> manipulation of the page attributes. >> - label : the name for the reserved partition, if omitted, the label >> is taken from the node name excluding the unit address. >> +- clocks : a list of phandle and clock specifier pairs that controls the >> + SRAM clock. > > A list controlling THE (single) SRAM clock? > > Once we start needing clocks, power, or other setup, we really should > have specific compatible strings (and binding docs) for the SRAM. I'll > take a single clock though. > There are SRAM devices, which take multiple power or clock supplies [1], where one clock or power domain control enables a segment on SRAM, however a number of (enabled) segments form a single continuous IO memory space, hence it could make sense to pluralize clocks in the generic document, particular device specifics can be described separately. [1] For reference IRAM on NXP LPC32xx has multiple power controls. -- Best wishes, Vladimir ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: sram: Add 'clocks' as an optional property 2018-07-04 6:40 ` Vladimir Zapolskiy @ 2018-07-05 17:18 ` Rob Herring 0 siblings, 0 replies; 5+ messages in thread From: Rob Herring @ 2018-07-05 17:18 UTC (permalink / raw) To: Vladimir Zapolskiy Cc: Fabio Estevam, devicetree, Philipp Zabel, Vladimir Zapolskiy, Fabio Estevam On Wed, Jul 4, 2018 at 12:40 AM Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> wrote: > > Hi Rob, Fabio, > > On 07/04/2018 01:21 AM, Rob Herring wrote: > > On Tue, Jun 26, 2018 at 08:07:33PM -0300, Fabio Estevam wrote: > >> From: Fabio Estevam <fabio.estevam@nxp.com> > >> > >> Some SoCs (like i.MX53) need to specify the SRAM clock in the > >> device tree via the clocks property. > >> > >> Add an entry to the optional property section. > >> > >> Reviewed-by: Vladimir Zapolskiy <vz@mleia.com> > >> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> > >> --- > >> Changes since v1: > >> - Add space before : and use the more common "list of phandle > >> and clock specifier pairs" term - Vladimir > >> > >> Documentation/devicetree/bindings/sram/sram.txt | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/sram/sram.txt b/Documentation/devicetree/bindings/sram/sram.txt > >> index 267da44..ae6ca34 100644 > >> --- a/Documentation/devicetree/bindings/sram/sram.txt > >> +++ b/Documentation/devicetree/bindings/sram/sram.txt > >> @@ -50,6 +50,8 @@ Optional properties in the area nodes: > >> manipulation of the page attributes. > >> - label : the name for the reserved partition, if omitted, the label > >> is taken from the node name excluding the unit address. > >> +- clocks : a list of phandle and clock specifier pairs that controls the > >> + SRAM clock. > > > > A list controlling THE (single) SRAM clock? > > > > Once we start needing clocks, power, or other setup, we really should > > have specific compatible strings (and binding docs) for the SRAM. I'll > > take a single clock though. > > > > There are SRAM devices, which take multiple power or clock supplies [1], > where one clock or power domain control enables a segment on SRAM, however > a number of (enabled) segments form a single continuous IO memory space, > hence it could make sense to pluralize clocks in the generic document, > particular device specifics can be described separately. The device specific part still has to say how many clocks and what they are, so having multiple clocks in the generic binding doesn't buy you anything. And I don't care to give the impression that we support multiple clocks with the generic binding. Rob ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-05 17:18 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-06-26 23:07 [PATCH v2] dt-bindings: sram: Add 'clocks' as an optional property Fabio Estevam 2018-07-03 22:21 ` Rob Herring 2018-07-03 22:41 ` Fabio Estevam 2018-07-04 6:40 ` Vladimir Zapolskiy 2018-07-05 17:18 ` Rob Herring
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.