From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <ryanhsu@qti.qualcomm.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
<ryanhsu@qti.qualcomm.com>
Subject: Re: [v3,1/2] ath10k: add the PCI PM core suspend/resume ops
Date: Thu, 31 Aug 2017 14:52:54 +0200 [thread overview]
Message-ID: <f4652c401e1f462d89b4611afe9bd623@euamsexm01a.eu.qualcomm.com> (raw)
In-Reply-To: <1503438455-6133-1-git-send-email-ryanhsu@qti.qualcomm.com>
ryanhsu@qti.qualcomm.com wrote:
> The actual PCI suspend/resume in ath10k has been handled in wow.c,
> but in the case of the device doesn't support remote wakeup,
> the .hif_suspend() and .hif_resume() will never be handled.
>
> ath10k_wow_op_suspend()
> {
> if (WARN_ON(!test_bit(ATH10K_FW_FEATURE_WOWLAN_SUPPORT,
> ar->running_fw->fw_file.fw_features))) {
> ret = 1;
> goto exit;
> }
>
> ....
>
> ret = ath10k_hif_suspend(ar);
> }
>
> So register the PCI PM core to support the suspend/resume if the device
> doesn't support remote wakeup.
>
> Signed-off-by: Ryan Hsu <ryanhsu@qti.qualcomm.com>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
This had a warning:
drivers/net/wireless/ath/ath10k/pci.c:3651:1: warning: symbol 'ath10k_pci_pm_ops' was not declared. Should it be static?
I fixed it in the pending branch by making it static:
static SIMPLE_DEV_PM_OPS(ath10k_pci_pm_ops,
ath10k_pci_pm_suspend,
ath10k_pci_pm_resume);
Please review.
--
https://patchwork.kernel.org/patch/9916215/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: ryanhsu@qti.qualcomm.com
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [v3,1/2] ath10k: add the PCI PM core suspend/resume ops
Date: Thu, 31 Aug 2017 14:52:54 +0200 [thread overview]
Message-ID: <f4652c401e1f462d89b4611afe9bd623@euamsexm01a.eu.qualcomm.com> (raw)
In-Reply-To: <1503438455-6133-1-git-send-email-ryanhsu@qti.qualcomm.com>
ryanhsu@qti.qualcomm.com wrote:
> The actual PCI suspend/resume in ath10k has been handled in wow.c,
> but in the case of the device doesn't support remote wakeup,
> the .hif_suspend() and .hif_resume() will never be handled.
>
> ath10k_wow_op_suspend()
> {
> if (WARN_ON(!test_bit(ATH10K_FW_FEATURE_WOWLAN_SUPPORT,
> ar->running_fw->fw_file.fw_features))) {
> ret = 1;
> goto exit;
> }
>
> ....
>
> ret = ath10k_hif_suspend(ar);
> }
>
> So register the PCI PM core to support the suspend/resume if the device
> doesn't support remote wakeup.
>
> Signed-off-by: Ryan Hsu <ryanhsu@qti.qualcomm.com>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
This had a warning:
drivers/net/wireless/ath/ath10k/pci.c:3651:1: warning: symbol 'ath10k_pci_pm_ops' was not declared. Should it be static?
I fixed it in the pending branch by making it static:
static SIMPLE_DEV_PM_OPS(ath10k_pci_pm_ops,
ath10k_pci_pm_suspend,
ath10k_pci_pm_resume);
Please review.
--
https://patchwork.kernel.org/patch/9916215/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2017-08-31 12:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 21:47 [PATCH v3 1/2] ath10k: add the PCI PM core suspend/resume ops ryanhsu
2017-08-22 21:47 ` ryanhsu
2017-08-22 21:47 ` [PATCH v3 2/2] ath10k: Configure and enable the wakeup capability ryanhsu
2017-08-22 21:47 ` ryanhsu
2017-08-31 12:52 ` Kalle Valo [this message]
2017-08-31 12:52 ` [v3,1/2] ath10k: add the PCI PM core suspend/resume ops Kalle Valo
2017-09-01 23:13 ` Ryan Hsu
2017-09-01 23:13 ` Ryan Hsu
2017-08-31 18:18 ` Kalle Valo
2017-08-31 18:18 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4652c401e1f462d89b4611afe9bd623@euamsexm01a.eu.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ryanhsu@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.