All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
To: hs@denx.de, u-boot@lists.denx.de
Cc: Simon Glass <sjg@chromium.org>,
	Alexandru Gagniuc <mr.nuke.me@gmail.com>,
	 Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>,
	Andrii Anisov <andrii_anisov@epam.com>,
	Aswath Govindraju <a-govindraju@ti.com>,
	Bin Meng <bmeng.cn@gmail.com>,
	Christian Gmeiner <christian.gmeiner@gmail.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Joel Stanley <joel@jms.id.au>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Masahisa Kojima <masahisa.kojima@linaro.org>,
	Patrick Delaunay <patrick.delaunay@foss.st.com>,
	Sean Anderson <seanga2@gmail.com>, Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH v4 1/8] lib: add crypt subsystem
Date: Thu, 8 Jul 2021 13:43:34 +0200	[thread overview]
Message-ID: <f468568b-530e-1869-ed64-e5ebdef08eee@eyet-services.de> (raw)
In-Reply-To: <83de7556-8766-b320-b1d0-7f76f96201a4@denx.de>

Hi Heiko,

thanks for the review!

On 7/8/21 5:56 AM, Heiko Schocher wrote:
> [...]
> 
>> diff --git a/lib/crypt/Makefile b/lib/crypt/Makefile
>> new file mode 100644
>> index 0000000000..290231064c
>> --- /dev/null
>> +++ b/lib/crypt/Makefile
>> @@ -0,0 +1,10 @@
>> +# SPDX-License-Identifier: GPL-2.0+
>> +#
>> +# Copyright (c) 2013, Google Inc.
>> +#
>> +# (C) Copyright 2000-2007
>> +# Wolfgang Denk, DENX Software Engineering, wd@denx.de.
> 
> Hmm... this is a new file ... I think you should add
> only your Copyright and drop the others... ?

thx, done


> [...]
> 
> I miss here the SPDX license identifier... also some hint, from which
> exact version this code is from ...

I've added this info in the next commit, this contains the vanilla
version. Is this ok?


Cheers,
Steffen

  reply	other threads:[~2021-07-08 11:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 23:09 [PATCH v4 0/8] common: Introduce crypt-style password support Steffen Jaeckel
2021-07-07 23:09 ` [PATCH v4 1/8] lib: add crypt subsystem Steffen Jaeckel
2021-07-08  3:56   ` Heiko Schocher
2021-07-08 11:43     ` Steffen Jaeckel [this message]
2021-07-08 11:50       ` Heiko Schocher
2021-07-07 23:09 ` [PATCH v4 2/8] lib: wrap crypt API to hide errno usage Steffen Jaeckel
2021-07-08  3:58   ` Heiko Schocher
2021-07-07 23:09 ` [PATCH v4 3/8] common: integrate crypt-based passwords Steffen Jaeckel
2021-07-08  4:00   ` Heiko Schocher
2021-07-07 23:09 ` [PATCH v4 4/8] common: Rename macro appropriately Steffen Jaeckel
2021-07-08  4:04   ` Heiko Schocher
2021-07-07 23:09 ` [PATCH v4 5/8] common: allow disabling of timeout for password entry Steffen Jaeckel
2021-07-07 23:09 ` [PATCH v4 6/8] common: add AUTOBOOT_FLUSH_STDIN option Steffen Jaeckel
2021-07-07 23:09 ` [PATCH v4 7/8] common: add support to fallback to plain SHA256 Steffen Jaeckel
2021-07-07 23:09 ` [PATCH v4 8/8] test: add first autoboot unit tests Steffen Jaeckel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f468568b-530e-1869-ed64-e5ebdef08eee@eyet-services.de \
    --to=jaeckel-floss@eyet-services.de \
    --cc=a-govindraju@ti.com \
    --cc=anastasiia_lukianenko@epam.com \
    --cc=andrii_anisov@epam.com \
    --cc=bmeng.cn@gmail.com \
    --cc=christian.gmeiner@gmail.com \
    --cc=hs@denx.de \
    --cc=joel@jms.id.au \
    --cc=m.szyprowski@samsung.com \
    --cc=masahisa.kojima@linaro.org \
    --cc=mr.nuke.me@gmail.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=seanga2@gmail.com \
    --cc=sjg@chromium.org \
    --cc=t-kristo@ti.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.