All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Mars Cheng <mars.cheng@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: CC Hwang <cc.hwang@mediatek.com>,
	Loda Chou <loda.chou@mediatek.com>,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	devicetree@vger.kernel.org, wsd_upstream@mediatek.com,
	linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/4] arm64: dts: mediatek: add mt6765 support
Date: Wed, 4 Jul 2018 08:35:14 +0100	[thread overview]
Message-ID: <f482708c-ea5e-5d81-a176-d69be9ccdf63@arm.com> (raw)
In-Reply-To: <1530669174-17623-5-git-send-email-mars.cheng@mediatek.com>

On 04/07/18 02:52, Mars Cheng wrote:
> This adds basic chip support for MT6765 SoC.
> 
> Signed-off-by: Mars Cheng <mars.cheng@mediatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/Makefile       |    1 +
>  arch/arm64/boot/dts/mediatek/mt6765-evb.dts |   33 ++++++
>  arch/arm64/boot/dts/mediatek/mt6765.dtsi    |  155 +++++++++++++++++++++++++++
>  3 files changed, 189 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt6765-evb.dts
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt6765.dtsi
> 

[...]

> +
> +		gic: interrupt-controller@c000000 {
> +			compatible = "arm,gic-v3";
> +			#interrupt-cells = <3>;
> +			#address-cells = <2>;
> +			#size-cells = <2>;
> +			#redistributor-regions = <1>;
> +			interrupt-parent = <&gic>;
> +			interrupt-controller;
> +			reg = <0 0x0c000000 0 0x40000>, // distributor
> +			      <0 0x0c100000 0 0x200000>, // redistributor
> +			      <0 0x0c400000 0 0x40000>; // gicc

For the second time: please add *all* the GIC CPU interface regions,
described in the Cortex-A53 TRM[1] (GICC, GICH, and GICV).

Thanks,

	M.

[1]
http://infocenter.arm.com/help/topic/com.arm.doc.ddi0500g/ch09s02s01.html
-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] arm64: dts: mediatek: add mt6765 support
Date: Wed, 4 Jul 2018 08:35:14 +0100	[thread overview]
Message-ID: <f482708c-ea5e-5d81-a176-d69be9ccdf63@arm.com> (raw)
In-Reply-To: <1530669174-17623-5-git-send-email-mars.cheng@mediatek.com>

On 04/07/18 02:52, Mars Cheng wrote:
> This adds basic chip support for MT6765 SoC.
> 
> Signed-off-by: Mars Cheng <mars.cheng@mediatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/Makefile       |    1 +
>  arch/arm64/boot/dts/mediatek/mt6765-evb.dts |   33 ++++++
>  arch/arm64/boot/dts/mediatek/mt6765.dtsi    |  155 +++++++++++++++++++++++++++
>  3 files changed, 189 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt6765-evb.dts
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt6765.dtsi
> 

[...]

> +
> +		gic: interrupt-controller at c000000 {
> +			compatible = "arm,gic-v3";
> +			#interrupt-cells = <3>;
> +			#address-cells = <2>;
> +			#size-cells = <2>;
> +			#redistributor-regions = <1>;
> +			interrupt-parent = <&gic>;
> +			interrupt-controller;
> +			reg = <0 0x0c000000 0 0x40000>, // distributor
> +			      <0 0x0c100000 0 0x200000>, // redistributor
> +			      <0 0x0c400000 0 0x40000>; // gicc

For the second time: please add *all* the GIC CPU interface regions,
described in the Cortex-A53 TRM[1] (GICC, GICH, and GICV).

Thanks,

	M.

[1]
http://infocenter.arm.com/help/topic/com.arm.doc.ddi0500g/ch09s02s01.html
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2018-07-04  7:35 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04  1:52 [PATCH 0/4] Add basic SoC support for mt6765 Mars Cheng
2018-07-04  1:52 ` Mars Cheng
2018-07-04  1:52 ` Mars Cheng
2018-07-04  1:52 ` [PATCH v3 1/4] dt-bindings: mediatek: add support for mt6765 reference board Mars Cheng
2018-07-04  1:52   ` Mars Cheng
2018-07-04  1:52   ` Mars Cheng
2018-07-05 23:22   ` Rob Herring
2018-07-05 23:22     ` Rob Herring
2018-07-04  1:52 ` [PATCH v3 2/4] dt-bindings: mtk-uart: add mt6765 uart bindings Mars Cheng
2018-07-04  1:52   ` Mars Cheng
2018-07-04  1:52   ` Mars Cheng
2018-07-05 23:22   ` Rob Herring
2018-07-05 23:22     ` Rob Herring
2018-07-04  1:52 ` [PATCH v3 3/4] dt-bindings: interrupt-controller: add binding for mt6765 Mars Cheng
2018-07-04  1:52   ` Mars Cheng
2018-07-04  1:52   ` Mars Cheng
2018-07-05 23:23   ` Rob Herring
2018-07-05 23:23     ` Rob Herring
2018-07-04  1:52 ` [PATCH v3 4/4] arm64: dts: mediatek: add mt6765 support Mars Cheng
2018-07-04  1:52   ` Mars Cheng
2018-07-04  1:52   ` Mars Cheng
2018-07-04  7:35   ` Marc Zyngier [this message]
2018-07-04  7:35     ` Marc Zyngier
2018-07-04  7:47     ` Mars Cheng
2018-07-04  7:47       ` Mars Cheng
2018-07-04  7:47       ` Mars Cheng
2018-07-04  7:59       ` Marc Zyngier
2018-07-04  7:59         ` Marc Zyngier
2018-07-04 11:38         ` Mars Cheng
2018-07-04 11:38           ` Mars Cheng
2018-07-04 11:38           ` Mars Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f482708c-ea5e-5d81-a176-d69be9ccdf63@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=cc.hwang@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=loda.chou@mediatek.com \
    --cc=mars.cheng@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.