All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: mt7621-dma: reindent to avoid '(' at the end of line
@ 2021-11-13  5:28 ` Liu Junqi
  0 siblings, 0 replies; 9+ messages in thread
From: Liu Junqi @ 2021-11-13  5:28 UTC (permalink / raw)
  To: gregkh
  Cc: linux-staging, linux-arm-kernel, linux-mediatek, linux-kernel, Liu Junqi

Fixed a coding style issue.

Signed-off-by: Liu Junqi <liujunqi@pku.edu.cn>
---
 drivers/staging/mt7621-dma/hsdma-mt7621.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
index 1424d01d434b..282fc807d0de 100644
--- a/drivers/staging/mt7621-dma/hsdma-mt7621.c
+++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c
@@ -455,9 +455,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
 	spin_unlock_bh(&chan->vchan.lock);
 }
 
-static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
-		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
-		size_t len, unsigned long flags)
+static struct dma_async_tx_descriptor
+*mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
+			   size_t len, unsigned long flags)
 {
 	struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
 	struct mtk_hsdma_desc *desc;
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] Staging: mt7621-dma: reindent to avoid '(' at the end of line
@ 2021-11-13  5:28 ` Liu Junqi
  0 siblings, 0 replies; 9+ messages in thread
From: Liu Junqi @ 2021-11-13  5:28 UTC (permalink / raw)
  To: gregkh
  Cc: linux-staging, linux-arm-kernel, linux-mediatek, linux-kernel, Liu Junqi

Fixed a coding style issue.

Signed-off-by: Liu Junqi <liujunqi@pku.edu.cn>
---
 drivers/staging/mt7621-dma/hsdma-mt7621.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
index 1424d01d434b..282fc807d0de 100644
--- a/drivers/staging/mt7621-dma/hsdma-mt7621.c
+++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c
@@ -455,9 +455,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
 	spin_unlock_bh(&chan->vchan.lock);
 }
 
-static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
-		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
-		size_t len, unsigned long flags)
+static struct dma_async_tx_descriptor
+*mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
+			   size_t len, unsigned long flags)
 {
 	struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
 	struct mtk_hsdma_desc *desc;
-- 
2.32.0


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] Staging: mt7621-dma: reindent to avoid '(' at the end of line
@ 2021-11-13  5:28 ` Liu Junqi
  0 siblings, 0 replies; 9+ messages in thread
From: Liu Junqi @ 2021-11-13  5:28 UTC (permalink / raw)
  To: gregkh
  Cc: linux-staging, linux-arm-kernel, linux-mediatek, linux-kernel, Liu Junqi

Fixed a coding style issue.

Signed-off-by: Liu Junqi <liujunqi@pku.edu.cn>
---
 drivers/staging/mt7621-dma/hsdma-mt7621.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
index 1424d01d434b..282fc807d0de 100644
--- a/drivers/staging/mt7621-dma/hsdma-mt7621.c
+++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c
@@ -455,9 +455,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
 	spin_unlock_bh(&chan->vchan.lock);
 }
 
-static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
-		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
-		size_t len, unsigned long flags)
+static struct dma_async_tx_descriptor
+*mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
+			   size_t len, unsigned long flags)
 {
 	struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
 	struct mtk_hsdma_desc *desc;
-- 
2.32.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] Staging: mt7621-dma: reindent to avoid '(' at the end of line
  2021-11-13  5:28 ` Liu Junqi
  (?)
@ 2021-11-13  8:02   ` Greg KH
  -1 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2021-11-13  8:02 UTC (permalink / raw)
  To: Liu Junqi; +Cc: linux-staging, linux-arm-kernel, linux-mediatek, linux-kernel

On Sat, Nov 13, 2021 at 01:28:15PM +0800, Liu Junqi wrote:
> Fixed a coding style issue.
> 
> Signed-off-by: Liu Junqi <liujunqi@pku.edu.cn>
> ---
>  drivers/staging/mt7621-dma/hsdma-mt7621.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> index 1424d01d434b..282fc807d0de 100644
> --- a/drivers/staging/mt7621-dma/hsdma-mt7621.c
> +++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> @@ -455,9 +455,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
>  	spin_unlock_bh(&chan->vchan.lock);
>  }
>  
> -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
> -		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> -		size_t len, unsigned long flags)
> +static struct dma_async_tx_descriptor
> +*mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,

No, this is now worse looking.  The original was not pretty, but better
than this.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] Staging: mt7621-dma: reindent to avoid '(' at the end of line
@ 2021-11-13  8:02   ` Greg KH
  0 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2021-11-13  8:02 UTC (permalink / raw)
  To: Liu Junqi; +Cc: linux-staging, linux-arm-kernel, linux-mediatek, linux-kernel

On Sat, Nov 13, 2021 at 01:28:15PM +0800, Liu Junqi wrote:
> Fixed a coding style issue.
> 
> Signed-off-by: Liu Junqi <liujunqi@pku.edu.cn>
> ---
>  drivers/staging/mt7621-dma/hsdma-mt7621.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> index 1424d01d434b..282fc807d0de 100644
> --- a/drivers/staging/mt7621-dma/hsdma-mt7621.c
> +++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> @@ -455,9 +455,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
>  	spin_unlock_bh(&chan->vchan.lock);
>  }
>  
> -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
> -		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> -		size_t len, unsigned long flags)
> +static struct dma_async_tx_descriptor
> +*mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,

No, this is now worse looking.  The original was not pretty, but better
than this.

thanks,

greg k-h

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] Staging: mt7621-dma: reindent to avoid '(' at the end of line
@ 2021-11-13  8:02   ` Greg KH
  0 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2021-11-13  8:02 UTC (permalink / raw)
  To: Liu Junqi; +Cc: linux-staging, linux-arm-kernel, linux-mediatek, linux-kernel

On Sat, Nov 13, 2021 at 01:28:15PM +0800, Liu Junqi wrote:
> Fixed a coding style issue.
> 
> Signed-off-by: Liu Junqi <liujunqi@pku.edu.cn>
> ---
>  drivers/staging/mt7621-dma/hsdma-mt7621.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> index 1424d01d434b..282fc807d0de 100644
> --- a/drivers/staging/mt7621-dma/hsdma-mt7621.c
> +++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> @@ -455,9 +455,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
>  	spin_unlock_bh(&chan->vchan.lock);
>  }
>  
> -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
> -		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> -		size_t len, unsigned long flags)
> +static struct dma_async_tx_descriptor
> +*mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,

No, this is now worse looking.  The original was not pretty, but better
than this.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] Staging: mt7621-dma: reindent to avoid '(' at the end of line
  2021-11-13  8:02   ` Greg KH
  (?)
@ 2021-11-13  8:19     ` Joe Perches
  -1 siblings, 0 replies; 9+ messages in thread
From: Joe Perches @ 2021-11-13  8:19 UTC (permalink / raw)
  To: Greg KH, Liu Junqi
  Cc: linux-staging, linux-arm-kernel, linux-mediatek, linux-kernel

On Sat, 2021-11-13 at 09:02 +0100, Greg KH wrote:
> On Sat, Nov 13, 2021 at 01:28:15PM +0800, Liu Junqi wrote:
> > Fixed a coding style issue.

This isn't really a fix, but instead is a change to make
the code more like typical coding style.

> > diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
[]
> > @@ -455,9 +455,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
> >  	spin_unlock_bh(&chan->vchan.lock);
> >  }
> >  
> > -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
> > -		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> > -		size_t len, unsigned long flags)
> > +static struct dma_async_tx_descriptor
> > +*mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> 
> No, this is now worse looking.  The original was not pretty, but better
> than this.

More typical would be to have the return value on a separate line
as using * on the start of a line is poor form in the kernel.

static struct dma_async_tx_descriptor *
mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
			  size_t len, unsigned long flags)
{
	...
}


^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] Staging: mt7621-dma: reindent to avoid '(' at the end of line
@ 2021-11-13  8:19     ` Joe Perches
  0 siblings, 0 replies; 9+ messages in thread
From: Joe Perches @ 2021-11-13  8:19 UTC (permalink / raw)
  To: Greg KH, Liu Junqi
  Cc: linux-staging, linux-arm-kernel, linux-mediatek, linux-kernel

On Sat, 2021-11-13 at 09:02 +0100, Greg KH wrote:
> On Sat, Nov 13, 2021 at 01:28:15PM +0800, Liu Junqi wrote:
> > Fixed a coding style issue.

This isn't really a fix, but instead is a change to make
the code more like typical coding style.

> > diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
[]
> > @@ -455,9 +455,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
> >  	spin_unlock_bh(&chan->vchan.lock);
> >  }
> >  
> > -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
> > -		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> > -		size_t len, unsigned long flags)
> > +static struct dma_async_tx_descriptor
> > +*mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> 
> No, this is now worse looking.  The original was not pretty, but better
> than this.

More typical would be to have the return value on a separate line
as using * on the start of a line is poor form in the kernel.

static struct dma_async_tx_descriptor *
mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
			  size_t len, unsigned long flags)
{
	...
}


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] Staging: mt7621-dma: reindent to avoid '(' at the end of line
@ 2021-11-13  8:19     ` Joe Perches
  0 siblings, 0 replies; 9+ messages in thread
From: Joe Perches @ 2021-11-13  8:19 UTC (permalink / raw)
  To: Greg KH, Liu Junqi
  Cc: linux-staging, linux-arm-kernel, linux-mediatek, linux-kernel

On Sat, 2021-11-13 at 09:02 +0100, Greg KH wrote:
> On Sat, Nov 13, 2021 at 01:28:15PM +0800, Liu Junqi wrote:
> > Fixed a coding style issue.

This isn't really a fix, but instead is a change to make
the code more like typical coding style.

> > diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
[]
> > @@ -455,9 +455,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
> >  	spin_unlock_bh(&chan->vchan.lock);
> >  }
> >  
> > -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
> > -		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> > -		size_t len, unsigned long flags)
> > +static struct dma_async_tx_descriptor
> > +*mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> 
> No, this is now worse looking.  The original was not pretty, but better
> than this.

More typical would be to have the return value on a separate line
as using * on the start of a line is poor form in the kernel.

static struct dma_async_tx_descriptor *
mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
			  size_t len, unsigned long flags)
{
	...
}


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-11-13 18:56 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-13  5:28 [PATCH] Staging: mt7621-dma: reindent to avoid '(' at the end of line Liu Junqi
2021-11-13  5:28 ` Liu Junqi
2021-11-13  5:28 ` Liu Junqi
2021-11-13  8:02 ` Greg KH
2021-11-13  8:02   ` Greg KH
2021-11-13  8:02   ` Greg KH
2021-11-13  8:19   ` Joe Perches
2021-11-13  8:19     ` Joe Perches
2021-11-13  8:19     ` Joe Perches

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.