* [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
@ 2023-06-13 8:34 ` Xu Yang
0 siblings, 0 replies; 24+ messages in thread
From: Xu Yang @ 2023-06-13 8:34 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: shawnguo, s.hauer, kernel, festevam, linux-imx, linux-phy,
devicetree, linux-arm-kernel, linux-usb, jun.li, xu.yang_2
Convert the binding to DT schema format. Besides, this also add clocks,
'#phy-cells', phy-3p0-supply and power-domains properties which are not
contained in txt file due to txt file lack updates.
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
Changes in v2:
- change filename to fsl,mxs-usbphy.yaml
- add other optional properties
- narrow fsl,anatop to imx6
- use additionalProperties
Changes in v3:
- fix indentation
- add clocks property to example
Changes in v4:
- remove [fsl,imx7ulp-usbphy, fsl,imx6ul-usbphy]
- limit item of reg and interrupts to 1
- sort enum items
- modify commit message
---
.../bindings/phy/fsl,mxs-usbphy.yaml | 125 ++++++++++++++++++
.../devicetree/bindings/phy/mxs-usb-phy.txt | 33 -----
2 files changed, 125 insertions(+), 33 deletions(-)
create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
new file mode 100644
index 000000000000..cc9f2bc7e6fb
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
@@ -0,0 +1,125 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/fsl,mxs-usbphy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale MXS USB Phy Device
+
+maintainers:
+ - Xu Yang <xu.yang_2@nxp.com>
+
+properties:
+ compatible:
+ oneOf:
+ - enum:
+ - fsl,imx23-usbphy
+ - fsl,imx7ulp-usbphy
+ - fsl,vf610-usbphy
+ - items:
+ - enum:
+ - fsl,imx28-usbphy
+ - fsl,imx6ul-usbphy
+ - fsl,imx6sl-usbphy
+ - fsl,imx6sx-usbphy
+ - fsl,imx6q-usbphy
+ - const: fsl,imx23-usbphy
+ - items:
+ - const: fsl,imx6sll-usbphy
+ - const: fsl,imx6ul-usbphy
+ - const: fsl,imx23-usbphy
+ - items:
+ - const: fsl,imx8dxl-usbphy
+ - const: fsl,imx7ulp-usbphy
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ '#phy-cells':
+ const: 0
+
+ power-domains:
+ maxItems: 1
+
+ fsl,anatop:
+ description:
+ phandle for anatop register, it is only for imx6 SoC series.
+ $ref: /schemas/types.yaml#/definitions/phandle
+
+ phy-3p0-supply:
+ description:
+ One of USB PHY's power supply. Can be used to keep a good signal
+ quality.
+
+ fsl,tx-cal-45-dn-ohms:
+ description:
+ Resistance (in ohms) of switchable high-speed trimming resistor
+ connected in parallel with the 45 ohm resistor that terminates
+ the DN output signal.
+ minimum: 35
+ maximum: 54
+ default: 45
+
+ fsl,tx-cal-45-dp-ohms:
+ description:
+ Resistance (in ohms) of switchable high-speed trimming resistor
+ connected in parallel with the 45 ohm resistor that terminates
+ the DP output signal.
+ minimum: 35
+ maximum: 54
+ default: 45
+
+ fsl,tx-d-cal:
+ description:
+ Current trimming value (as a percentage) of the 17.78 mA TX
+ reference current.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 79
+ maximum: 119
+ default: 100
+
+required:
+ - compatible
+ - reg
+ - clocks
+
+allOf:
+ - if:
+ properties:
+ compatible:
+ oneOf:
+ - enum:
+ - fsl,imx6q-usbphy
+ - fsl,imx6sl-usbphy
+ - fsl,imx6sx-usbphy
+ - fsl,imx6sll-usbphy
+ - fsl,vf610-usbphy
+ - items:
+ - const: fsl,imx6ul-usbphy
+ - const: fsl,imx23-usbphy
+ then:
+ required:
+ - fsl,anatop
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/imx6qdl-clock.h>
+
+ usbphy1: usb-phy@20c9000 {
+ compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
+ reg = <0x020c9000 0x1000>;
+ clocks = <&clks IMX6QDL_CLK_USBPHY1>;
+ interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+ fsl,anatop = <&anatop>;
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt b/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
deleted file mode 100644
index 70c813b0755f..000000000000
--- a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
+++ /dev/null
@@ -1,33 +0,0 @@
-* Freescale MXS USB Phy Device
-
-Required properties:
-- compatible: should contain:
- * "fsl,imx23-usbphy" for imx23 and imx28
- * "fsl,imx6q-usbphy" for imx6dq and imx6dl
- * "fsl,imx6sl-usbphy" for imx6sl
- * "fsl,vf610-usbphy" for Vybrid vf610
- * "fsl,imx6sx-usbphy" for imx6sx
- * "fsl,imx7ulp-usbphy" for imx7ulp
- * "fsl,imx8dxl-usbphy" for imx8dxl
- "fsl,imx23-usbphy" is still a fallback for other strings
-- reg: Should contain registers location and length
-- interrupts: Should contain phy interrupt
-- fsl,anatop: phandle for anatop register, it is only for imx6 SoC series
-
-Optional properties:
-- fsl,tx-cal-45-dn-ohms: Integer [35-54]. Resistance (in ohms) of switchable
- high-speed trimming resistor connected in parallel with the 45 ohm resistor
- that terminates the DN output signal. Default: 45
-- fsl,tx-cal-45-dp-ohms: Integer [35-54]. Resistance (in ohms) of switchable
- high-speed trimming resistor connected in parallel with the 45 ohm resistor
- that terminates the DP output signal. Default: 45
-- fsl,tx-d-cal: Integer [79-119]. Current trimming value (as a percentage) of
- the 17.78mA TX reference current. Default: 100
-
-Example:
-usbphy1: usb-phy@20c9000 {
- compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
- reg = <0x020c9000 0x1000>;
- interrupts = <0 44 0x04>;
- fsl,anatop = <&anatop>;
-};
--
2.34.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
@ 2023-06-13 8:34 ` Xu Yang
0 siblings, 0 replies; 24+ messages in thread
From: Xu Yang @ 2023-06-13 8:34 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: shawnguo, s.hauer, kernel, festevam, linux-imx, linux-phy,
devicetree, linux-arm-kernel, linux-usb, jun.li, xu.yang_2
Convert the binding to DT schema format. Besides, this also add clocks,
'#phy-cells', phy-3p0-supply and power-domains properties which are not
contained in txt file due to txt file lack updates.
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
Changes in v2:
- change filename to fsl,mxs-usbphy.yaml
- add other optional properties
- narrow fsl,anatop to imx6
- use additionalProperties
Changes in v3:
- fix indentation
- add clocks property to example
Changes in v4:
- remove [fsl,imx7ulp-usbphy, fsl,imx6ul-usbphy]
- limit item of reg and interrupts to 1
- sort enum items
- modify commit message
---
.../bindings/phy/fsl,mxs-usbphy.yaml | 125 ++++++++++++++++++
.../devicetree/bindings/phy/mxs-usb-phy.txt | 33 -----
2 files changed, 125 insertions(+), 33 deletions(-)
create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
new file mode 100644
index 000000000000..cc9f2bc7e6fb
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
@@ -0,0 +1,125 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/fsl,mxs-usbphy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale MXS USB Phy Device
+
+maintainers:
+ - Xu Yang <xu.yang_2@nxp.com>
+
+properties:
+ compatible:
+ oneOf:
+ - enum:
+ - fsl,imx23-usbphy
+ - fsl,imx7ulp-usbphy
+ - fsl,vf610-usbphy
+ - items:
+ - enum:
+ - fsl,imx28-usbphy
+ - fsl,imx6ul-usbphy
+ - fsl,imx6sl-usbphy
+ - fsl,imx6sx-usbphy
+ - fsl,imx6q-usbphy
+ - const: fsl,imx23-usbphy
+ - items:
+ - const: fsl,imx6sll-usbphy
+ - const: fsl,imx6ul-usbphy
+ - const: fsl,imx23-usbphy
+ - items:
+ - const: fsl,imx8dxl-usbphy
+ - const: fsl,imx7ulp-usbphy
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ '#phy-cells':
+ const: 0
+
+ power-domains:
+ maxItems: 1
+
+ fsl,anatop:
+ description:
+ phandle for anatop register, it is only for imx6 SoC series.
+ $ref: /schemas/types.yaml#/definitions/phandle
+
+ phy-3p0-supply:
+ description:
+ One of USB PHY's power supply. Can be used to keep a good signal
+ quality.
+
+ fsl,tx-cal-45-dn-ohms:
+ description:
+ Resistance (in ohms) of switchable high-speed trimming resistor
+ connected in parallel with the 45 ohm resistor that terminates
+ the DN output signal.
+ minimum: 35
+ maximum: 54
+ default: 45
+
+ fsl,tx-cal-45-dp-ohms:
+ description:
+ Resistance (in ohms) of switchable high-speed trimming resistor
+ connected in parallel with the 45 ohm resistor that terminates
+ the DP output signal.
+ minimum: 35
+ maximum: 54
+ default: 45
+
+ fsl,tx-d-cal:
+ description:
+ Current trimming value (as a percentage) of the 17.78 mA TX
+ reference current.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 79
+ maximum: 119
+ default: 100
+
+required:
+ - compatible
+ - reg
+ - clocks
+
+allOf:
+ - if:
+ properties:
+ compatible:
+ oneOf:
+ - enum:
+ - fsl,imx6q-usbphy
+ - fsl,imx6sl-usbphy
+ - fsl,imx6sx-usbphy
+ - fsl,imx6sll-usbphy
+ - fsl,vf610-usbphy
+ - items:
+ - const: fsl,imx6ul-usbphy
+ - const: fsl,imx23-usbphy
+ then:
+ required:
+ - fsl,anatop
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/imx6qdl-clock.h>
+
+ usbphy1: usb-phy@20c9000 {
+ compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
+ reg = <0x020c9000 0x1000>;
+ clocks = <&clks IMX6QDL_CLK_USBPHY1>;
+ interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+ fsl,anatop = <&anatop>;
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt b/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
deleted file mode 100644
index 70c813b0755f..000000000000
--- a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
+++ /dev/null
@@ -1,33 +0,0 @@
-* Freescale MXS USB Phy Device
-
-Required properties:
-- compatible: should contain:
- * "fsl,imx23-usbphy" for imx23 and imx28
- * "fsl,imx6q-usbphy" for imx6dq and imx6dl
- * "fsl,imx6sl-usbphy" for imx6sl
- * "fsl,vf610-usbphy" for Vybrid vf610
- * "fsl,imx6sx-usbphy" for imx6sx
- * "fsl,imx7ulp-usbphy" for imx7ulp
- * "fsl,imx8dxl-usbphy" for imx8dxl
- "fsl,imx23-usbphy" is still a fallback for other strings
-- reg: Should contain registers location and length
-- interrupts: Should contain phy interrupt
-- fsl,anatop: phandle for anatop register, it is only for imx6 SoC series
-
-Optional properties:
-- fsl,tx-cal-45-dn-ohms: Integer [35-54]. Resistance (in ohms) of switchable
- high-speed trimming resistor connected in parallel with the 45 ohm resistor
- that terminates the DN output signal. Default: 45
-- fsl,tx-cal-45-dp-ohms: Integer [35-54]. Resistance (in ohms) of switchable
- high-speed trimming resistor connected in parallel with the 45 ohm resistor
- that terminates the DP output signal. Default: 45
-- fsl,tx-d-cal: Integer [79-119]. Current trimming value (as a percentage) of
- the 17.78mA TX reference current. Default: 100
-
-Example:
-usbphy1: usb-phy@20c9000 {
- compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
- reg = <0x020c9000 0x1000>;
- interrupts = <0 44 0x04>;
- fsl,anatop = <&anatop>;
-};
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
@ 2023-06-13 8:34 ` Xu Yang
0 siblings, 0 replies; 24+ messages in thread
From: Xu Yang @ 2023-06-13 8:34 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: shawnguo, s.hauer, kernel, festevam, linux-imx, linux-phy,
devicetree, linux-arm-kernel, linux-usb, jun.li, xu.yang_2
Convert the binding to DT schema format. Besides, this also add clocks,
'#phy-cells', phy-3p0-supply and power-domains properties which are not
contained in txt file due to txt file lack updates.
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
Changes in v2:
- change filename to fsl,mxs-usbphy.yaml
- add other optional properties
- narrow fsl,anatop to imx6
- use additionalProperties
Changes in v3:
- fix indentation
- add clocks property to example
Changes in v4:
- remove [fsl,imx7ulp-usbphy, fsl,imx6ul-usbphy]
- limit item of reg and interrupts to 1
- sort enum items
- modify commit message
---
.../bindings/phy/fsl,mxs-usbphy.yaml | 125 ++++++++++++++++++
.../devicetree/bindings/phy/mxs-usb-phy.txt | 33 -----
2 files changed, 125 insertions(+), 33 deletions(-)
create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
new file mode 100644
index 000000000000..cc9f2bc7e6fb
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
@@ -0,0 +1,125 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/fsl,mxs-usbphy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale MXS USB Phy Device
+
+maintainers:
+ - Xu Yang <xu.yang_2@nxp.com>
+
+properties:
+ compatible:
+ oneOf:
+ - enum:
+ - fsl,imx23-usbphy
+ - fsl,imx7ulp-usbphy
+ - fsl,vf610-usbphy
+ - items:
+ - enum:
+ - fsl,imx28-usbphy
+ - fsl,imx6ul-usbphy
+ - fsl,imx6sl-usbphy
+ - fsl,imx6sx-usbphy
+ - fsl,imx6q-usbphy
+ - const: fsl,imx23-usbphy
+ - items:
+ - const: fsl,imx6sll-usbphy
+ - const: fsl,imx6ul-usbphy
+ - const: fsl,imx23-usbphy
+ - items:
+ - const: fsl,imx8dxl-usbphy
+ - const: fsl,imx7ulp-usbphy
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ '#phy-cells':
+ const: 0
+
+ power-domains:
+ maxItems: 1
+
+ fsl,anatop:
+ description:
+ phandle for anatop register, it is only for imx6 SoC series.
+ $ref: /schemas/types.yaml#/definitions/phandle
+
+ phy-3p0-supply:
+ description:
+ One of USB PHY's power supply. Can be used to keep a good signal
+ quality.
+
+ fsl,tx-cal-45-dn-ohms:
+ description:
+ Resistance (in ohms) of switchable high-speed trimming resistor
+ connected in parallel with the 45 ohm resistor that terminates
+ the DN output signal.
+ minimum: 35
+ maximum: 54
+ default: 45
+
+ fsl,tx-cal-45-dp-ohms:
+ description:
+ Resistance (in ohms) of switchable high-speed trimming resistor
+ connected in parallel with the 45 ohm resistor that terminates
+ the DP output signal.
+ minimum: 35
+ maximum: 54
+ default: 45
+
+ fsl,tx-d-cal:
+ description:
+ Current trimming value (as a percentage) of the 17.78 mA TX
+ reference current.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 79
+ maximum: 119
+ default: 100
+
+required:
+ - compatible
+ - reg
+ - clocks
+
+allOf:
+ - if:
+ properties:
+ compatible:
+ oneOf:
+ - enum:
+ - fsl,imx6q-usbphy
+ - fsl,imx6sl-usbphy
+ - fsl,imx6sx-usbphy
+ - fsl,imx6sll-usbphy
+ - fsl,vf610-usbphy
+ - items:
+ - const: fsl,imx6ul-usbphy
+ - const: fsl,imx23-usbphy
+ then:
+ required:
+ - fsl,anatop
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/imx6qdl-clock.h>
+
+ usbphy1: usb-phy@20c9000 {
+ compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
+ reg = <0x020c9000 0x1000>;
+ clocks = <&clks IMX6QDL_CLK_USBPHY1>;
+ interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+ fsl,anatop = <&anatop>;
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt b/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
deleted file mode 100644
index 70c813b0755f..000000000000
--- a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
+++ /dev/null
@@ -1,33 +0,0 @@
-* Freescale MXS USB Phy Device
-
-Required properties:
-- compatible: should contain:
- * "fsl,imx23-usbphy" for imx23 and imx28
- * "fsl,imx6q-usbphy" for imx6dq and imx6dl
- * "fsl,imx6sl-usbphy" for imx6sl
- * "fsl,vf610-usbphy" for Vybrid vf610
- * "fsl,imx6sx-usbphy" for imx6sx
- * "fsl,imx7ulp-usbphy" for imx7ulp
- * "fsl,imx8dxl-usbphy" for imx8dxl
- "fsl,imx23-usbphy" is still a fallback for other strings
-- reg: Should contain registers location and length
-- interrupts: Should contain phy interrupt
-- fsl,anatop: phandle for anatop register, it is only for imx6 SoC series
-
-Optional properties:
-- fsl,tx-cal-45-dn-ohms: Integer [35-54]. Resistance (in ohms) of switchable
- high-speed trimming resistor connected in parallel with the 45 ohm resistor
- that terminates the DN output signal. Default: 45
-- fsl,tx-cal-45-dp-ohms: Integer [35-54]. Resistance (in ohms) of switchable
- high-speed trimming resistor connected in parallel with the 45 ohm resistor
- that terminates the DP output signal. Default: 45
-- fsl,tx-d-cal: Integer [79-119]. Current trimming value (as a percentage) of
- the 17.78mA TX reference current. Default: 100
-
-Example:
-usbphy1: usb-phy@20c9000 {
- compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
- reg = <0x020c9000 0x1000>;
- interrupts = <0 44 0x04>;
- fsl,anatop = <&anatop>;
-};
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v4 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
2023-06-13 8:34 ` Xu Yang
(?)
@ 2023-06-13 8:34 ` Xu Yang
-1 siblings, 0 replies; 24+ messages in thread
From: Xu Yang @ 2023-06-13 8:34 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: shawnguo, s.hauer, kernel, festevam, linux-imx, linux-phy,
devicetree, linux-arm-kernel, linux-usb, jun.li, xu.yang_2
The imx8ulp and imx8qm are compatible with imx8dxl. This will add such
compatible.
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
Changes in v2:
- no change
Changes in v3:
- no change
Changes in v4:
- no change
---
Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
index cc9f2bc7e6fb..f4b1ca2fb562 100644
--- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
+++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
@@ -29,7 +29,10 @@ properties:
- const: fsl,imx6ul-usbphy
- const: fsl,imx23-usbphy
- items:
- - const: fsl,imx8dxl-usbphy
+ - enum:
+ - fsl,imx8dxl-usbphy
+ - fsl,imx8qm-usbphy
+ - fsl,imx8ulp-usbphy
- const: fsl,imx7ulp-usbphy
reg:
--
2.34.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v4 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
@ 2023-06-13 8:34 ` Xu Yang
0 siblings, 0 replies; 24+ messages in thread
From: Xu Yang @ 2023-06-13 8:34 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: shawnguo, s.hauer, kernel, festevam, linux-imx, linux-phy,
devicetree, linux-arm-kernel, linux-usb, jun.li, xu.yang_2
The imx8ulp and imx8qm are compatible with imx8dxl. This will add such
compatible.
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
Changes in v2:
- no change
Changes in v3:
- no change
Changes in v4:
- no change
---
Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
index cc9f2bc7e6fb..f4b1ca2fb562 100644
--- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
+++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
@@ -29,7 +29,10 @@ properties:
- const: fsl,imx6ul-usbphy
- const: fsl,imx23-usbphy
- items:
- - const: fsl,imx8dxl-usbphy
+ - enum:
+ - fsl,imx8dxl-usbphy
+ - fsl,imx8qm-usbphy
+ - fsl,imx8ulp-usbphy
- const: fsl,imx7ulp-usbphy
reg:
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v4 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
@ 2023-06-13 8:34 ` Xu Yang
0 siblings, 0 replies; 24+ messages in thread
From: Xu Yang @ 2023-06-13 8:34 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: shawnguo, s.hauer, kernel, festevam, linux-imx, linux-phy,
devicetree, linux-arm-kernel, linux-usb, jun.li, xu.yang_2
The imx8ulp and imx8qm are compatible with imx8dxl. This will add such
compatible.
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
Changes in v2:
- no change
Changes in v3:
- no change
Changes in v4:
- no change
---
Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
index cc9f2bc7e6fb..f4b1ca2fb562 100644
--- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
+++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
@@ -29,7 +29,10 @@ properties:
- const: fsl,imx6ul-usbphy
- const: fsl,imx23-usbphy
- items:
- - const: fsl,imx8dxl-usbphy
+ - enum:
+ - fsl,imx8dxl-usbphy
+ - fsl,imx8qm-usbphy
+ - fsl,imx8ulp-usbphy
- const: fsl,imx7ulp-usbphy
reg:
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
2023-06-13 8:34 ` Xu Yang
(?)
@ 2023-06-13 19:16 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 24+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-13 19:16 UTC (permalink / raw)
To: Xu Yang, robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: shawnguo, s.hauer, kernel, festevam, linux-imx, linux-phy,
devicetree, linux-arm-kernel, linux-usb, jun.li
On 13/06/2023 10:34, Xu Yang wrote:
> Convert the binding to DT schema format. Besides, this also add clocks,
> '#phy-cells', phy-3p0-supply and power-domains properties which are not
> contained in txt file due to txt file lack updates.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
@ 2023-06-13 19:16 ` Krzysztof Kozlowski
0 siblings, 0 replies; 24+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-13 19:16 UTC (permalink / raw)
To: Xu Yang, robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: shawnguo, s.hauer, kernel, festevam, linux-imx, linux-phy,
devicetree, linux-arm-kernel, linux-usb, jun.li
On 13/06/2023 10:34, Xu Yang wrote:
> Convert the binding to DT schema format. Besides, this also add clocks,
> '#phy-cells', phy-3p0-supply and power-domains properties which are not
> contained in txt file due to txt file lack updates.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
@ 2023-06-13 19:16 ` Krzysztof Kozlowski
0 siblings, 0 replies; 24+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-13 19:16 UTC (permalink / raw)
To: Xu Yang, robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: shawnguo, s.hauer, kernel, festevam, linux-imx, linux-phy,
devicetree, linux-arm-kernel, linux-usb, jun.li
On 13/06/2023 10:34, Xu Yang wrote:
> Convert the binding to DT schema format. Besides, this also add clocks,
> '#phy-cells', phy-3p0-supply and power-domains properties which are not
> contained in txt file due to txt file lack updates.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
2023-06-13 8:34 ` Xu Yang
(?)
@ 2023-06-20 15:29 ` Rob Herring
-1 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2023-06-20 15:29 UTC (permalink / raw)
To: Xu Yang
Cc: krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, linux-imx, linux-phy, devicetree, linux-arm-kernel,
linux-usb, jun.li
On Tue, Jun 13, 2023 at 04:34:44PM +0800, Xu Yang wrote:
> Convert the binding to DT schema format. Besides, this also add clocks,
> '#phy-cells', phy-3p0-supply and power-domains properties which are not
> contained in txt file due to txt file lack updates.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
>
> ---
> Changes in v2:
> - change filename to fsl,mxs-usbphy.yaml
> - add other optional properties
> - narrow fsl,anatop to imx6
> - use additionalProperties
> Changes in v3:
> - fix indentation
> - add clocks property to example
> Changes in v4:
> - remove [fsl,imx7ulp-usbphy, fsl,imx6ul-usbphy]
> - limit item of reg and interrupts to 1
> - sort enum items
> - modify commit message
> ---
> .../bindings/phy/fsl,mxs-usbphy.yaml | 125 ++++++++++++++++++
> .../devicetree/bindings/phy/mxs-usb-phy.txt | 33 -----
> 2 files changed, 125 insertions(+), 33 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
This should be applied by the PHY maintainers, but they weren't Cc'ed.
>
> diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> new file mode 100644
> index 000000000000..cc9f2bc7e6fb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> @@ -0,0 +1,125 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/fsl,mxs-usbphy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale MXS USB Phy Device
> +
> +maintainers:
> + - Xu Yang <xu.yang_2@nxp.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - fsl,imx23-usbphy
> + - fsl,imx7ulp-usbphy
> + - fsl,vf610-usbphy
> + - items:
> + - enum:
> + - fsl,imx28-usbphy
> + - fsl,imx6ul-usbphy
> + - fsl,imx6sl-usbphy
> + - fsl,imx6sx-usbphy
> + - fsl,imx6q-usbphy
> + - const: fsl,imx23-usbphy
> + - items:
> + - const: fsl,imx6sll-usbphy
> + - const: fsl,imx6ul-usbphy
> + - const: fsl,imx23-usbphy
> + - items:
> + - const: fsl,imx8dxl-usbphy
> + - const: fsl,imx7ulp-usbphy
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + '#phy-cells':
> + const: 0
> +
> + power-domains:
> + maxItems: 1
> +
> + fsl,anatop:
> + description:
> + phandle for anatop register, it is only for imx6 SoC series.
> + $ref: /schemas/types.yaml#/definitions/phandle
> +
> + phy-3p0-supply:
> + description:
> + One of USB PHY's power supply. Can be used to keep a good signal
> + quality.
> +
> + fsl,tx-cal-45-dn-ohms:
> + description:
> + Resistance (in ohms) of switchable high-speed trimming resistor
> + connected in parallel with the 45 ohm resistor that terminates
> + the DN output signal.
> + minimum: 35
> + maximum: 54
> + default: 45
> +
> + fsl,tx-cal-45-dp-ohms:
> + description:
> + Resistance (in ohms) of switchable high-speed trimming resistor
> + connected in parallel with the 45 ohm resistor that terminates
> + the DP output signal.
> + minimum: 35
> + maximum: 54
> + default: 45
> +
> + fsl,tx-d-cal:
> + description:
> + Current trimming value (as a percentage) of the 17.78 mA TX
> + reference current.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 79
> + maximum: 119
> + default: 100
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + oneOf:
> + - enum:
> + - fsl,imx6q-usbphy
> + - fsl,imx6sl-usbphy
> + - fsl,imx6sx-usbphy
> + - fsl,imx6sll-usbphy
> + - fsl,vf610-usbphy
> + - items:
> + - const: fsl,imx6ul-usbphy
> + - const: fsl,imx23-usbphy
> + then:
> + required:
> + - fsl,anatop
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/imx6qdl-clock.h>
> +
> + usbphy1: usb-phy@20c9000 {
> + compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
> + reg = <0x020c9000 0x1000>;
> + clocks = <&clks IMX6QDL_CLK_USBPHY1>;
> + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
> + fsl,anatop = <&anatop>;
> + };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt b/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
> deleted file mode 100644
> index 70c813b0755f..000000000000
> --- a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -* Freescale MXS USB Phy Device
> -
> -Required properties:
> -- compatible: should contain:
> - * "fsl,imx23-usbphy" for imx23 and imx28
> - * "fsl,imx6q-usbphy" for imx6dq and imx6dl
> - * "fsl,imx6sl-usbphy" for imx6sl
> - * "fsl,vf610-usbphy" for Vybrid vf610
> - * "fsl,imx6sx-usbphy" for imx6sx
> - * "fsl,imx7ulp-usbphy" for imx7ulp
> - * "fsl,imx8dxl-usbphy" for imx8dxl
> - "fsl,imx23-usbphy" is still a fallback for other strings
> -- reg: Should contain registers location and length
> -- interrupts: Should contain phy interrupt
> -- fsl,anatop: phandle for anatop register, it is only for imx6 SoC series
> -
> -Optional properties:
> -- fsl,tx-cal-45-dn-ohms: Integer [35-54]. Resistance (in ohms) of switchable
> - high-speed trimming resistor connected in parallel with the 45 ohm resistor
> - that terminates the DN output signal. Default: 45
> -- fsl,tx-cal-45-dp-ohms: Integer [35-54]. Resistance (in ohms) of switchable
> - high-speed trimming resistor connected in parallel with the 45 ohm resistor
> - that terminates the DP output signal. Default: 45
> -- fsl,tx-d-cal: Integer [79-119]. Current trimming value (as a percentage) of
> - the 17.78mA TX reference current. Default: 100
> -
> -Example:
> -usbphy1: usb-phy@20c9000 {
> - compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
> - reg = <0x020c9000 0x1000>;
> - interrupts = <0 44 0x04>;
> - fsl,anatop = <&anatop>;
> -};
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
@ 2023-06-20 15:29 ` Rob Herring
0 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2023-06-20 15:29 UTC (permalink / raw)
To: Xu Yang
Cc: krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, linux-imx, linux-phy, devicetree, linux-arm-kernel,
linux-usb, jun.li
On Tue, Jun 13, 2023 at 04:34:44PM +0800, Xu Yang wrote:
> Convert the binding to DT schema format. Besides, this also add clocks,
> '#phy-cells', phy-3p0-supply and power-domains properties which are not
> contained in txt file due to txt file lack updates.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
>
> ---
> Changes in v2:
> - change filename to fsl,mxs-usbphy.yaml
> - add other optional properties
> - narrow fsl,anatop to imx6
> - use additionalProperties
> Changes in v3:
> - fix indentation
> - add clocks property to example
> Changes in v4:
> - remove [fsl,imx7ulp-usbphy, fsl,imx6ul-usbphy]
> - limit item of reg and interrupts to 1
> - sort enum items
> - modify commit message
> ---
> .../bindings/phy/fsl,mxs-usbphy.yaml | 125 ++++++++++++++++++
> .../devicetree/bindings/phy/mxs-usb-phy.txt | 33 -----
> 2 files changed, 125 insertions(+), 33 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
This should be applied by the PHY maintainers, but they weren't Cc'ed.
>
> diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> new file mode 100644
> index 000000000000..cc9f2bc7e6fb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> @@ -0,0 +1,125 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/fsl,mxs-usbphy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale MXS USB Phy Device
> +
> +maintainers:
> + - Xu Yang <xu.yang_2@nxp.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - fsl,imx23-usbphy
> + - fsl,imx7ulp-usbphy
> + - fsl,vf610-usbphy
> + - items:
> + - enum:
> + - fsl,imx28-usbphy
> + - fsl,imx6ul-usbphy
> + - fsl,imx6sl-usbphy
> + - fsl,imx6sx-usbphy
> + - fsl,imx6q-usbphy
> + - const: fsl,imx23-usbphy
> + - items:
> + - const: fsl,imx6sll-usbphy
> + - const: fsl,imx6ul-usbphy
> + - const: fsl,imx23-usbphy
> + - items:
> + - const: fsl,imx8dxl-usbphy
> + - const: fsl,imx7ulp-usbphy
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + '#phy-cells':
> + const: 0
> +
> + power-domains:
> + maxItems: 1
> +
> + fsl,anatop:
> + description:
> + phandle for anatop register, it is only for imx6 SoC series.
> + $ref: /schemas/types.yaml#/definitions/phandle
> +
> + phy-3p0-supply:
> + description:
> + One of USB PHY's power supply. Can be used to keep a good signal
> + quality.
> +
> + fsl,tx-cal-45-dn-ohms:
> + description:
> + Resistance (in ohms) of switchable high-speed trimming resistor
> + connected in parallel with the 45 ohm resistor that terminates
> + the DN output signal.
> + minimum: 35
> + maximum: 54
> + default: 45
> +
> + fsl,tx-cal-45-dp-ohms:
> + description:
> + Resistance (in ohms) of switchable high-speed trimming resistor
> + connected in parallel with the 45 ohm resistor that terminates
> + the DP output signal.
> + minimum: 35
> + maximum: 54
> + default: 45
> +
> + fsl,tx-d-cal:
> + description:
> + Current trimming value (as a percentage) of the 17.78 mA TX
> + reference current.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 79
> + maximum: 119
> + default: 100
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + oneOf:
> + - enum:
> + - fsl,imx6q-usbphy
> + - fsl,imx6sl-usbphy
> + - fsl,imx6sx-usbphy
> + - fsl,imx6sll-usbphy
> + - fsl,vf610-usbphy
> + - items:
> + - const: fsl,imx6ul-usbphy
> + - const: fsl,imx23-usbphy
> + then:
> + required:
> + - fsl,anatop
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/imx6qdl-clock.h>
> +
> + usbphy1: usb-phy@20c9000 {
> + compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
> + reg = <0x020c9000 0x1000>;
> + clocks = <&clks IMX6QDL_CLK_USBPHY1>;
> + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
> + fsl,anatop = <&anatop>;
> + };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt b/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
> deleted file mode 100644
> index 70c813b0755f..000000000000
> --- a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -* Freescale MXS USB Phy Device
> -
> -Required properties:
> -- compatible: should contain:
> - * "fsl,imx23-usbphy" for imx23 and imx28
> - * "fsl,imx6q-usbphy" for imx6dq and imx6dl
> - * "fsl,imx6sl-usbphy" for imx6sl
> - * "fsl,vf610-usbphy" for Vybrid vf610
> - * "fsl,imx6sx-usbphy" for imx6sx
> - * "fsl,imx7ulp-usbphy" for imx7ulp
> - * "fsl,imx8dxl-usbphy" for imx8dxl
> - "fsl,imx23-usbphy" is still a fallback for other strings
> -- reg: Should contain registers location and length
> -- interrupts: Should contain phy interrupt
> -- fsl,anatop: phandle for anatop register, it is only for imx6 SoC series
> -
> -Optional properties:
> -- fsl,tx-cal-45-dn-ohms: Integer [35-54]. Resistance (in ohms) of switchable
> - high-speed trimming resistor connected in parallel with the 45 ohm resistor
> - that terminates the DN output signal. Default: 45
> -- fsl,tx-cal-45-dp-ohms: Integer [35-54]. Resistance (in ohms) of switchable
> - high-speed trimming resistor connected in parallel with the 45 ohm resistor
> - that terminates the DP output signal. Default: 45
> -- fsl,tx-d-cal: Integer [79-119]. Current trimming value (as a percentage) of
> - the 17.78mA TX reference current. Default: 100
> -
> -Example:
> -usbphy1: usb-phy@20c9000 {
> - compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
> - reg = <0x020c9000 0x1000>;
> - interrupts = <0 44 0x04>;
> - fsl,anatop = <&anatop>;
> -};
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
@ 2023-06-20 15:29 ` Rob Herring
0 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2023-06-20 15:29 UTC (permalink / raw)
To: Xu Yang
Cc: krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, linux-imx, linux-phy, devicetree, linux-arm-kernel,
linux-usb, jun.li
On Tue, Jun 13, 2023 at 04:34:44PM +0800, Xu Yang wrote:
> Convert the binding to DT schema format. Besides, this also add clocks,
> '#phy-cells', phy-3p0-supply and power-domains properties which are not
> contained in txt file due to txt file lack updates.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
>
> ---
> Changes in v2:
> - change filename to fsl,mxs-usbphy.yaml
> - add other optional properties
> - narrow fsl,anatop to imx6
> - use additionalProperties
> Changes in v3:
> - fix indentation
> - add clocks property to example
> Changes in v4:
> - remove [fsl,imx7ulp-usbphy, fsl,imx6ul-usbphy]
> - limit item of reg and interrupts to 1
> - sort enum items
> - modify commit message
> ---
> .../bindings/phy/fsl,mxs-usbphy.yaml | 125 ++++++++++++++++++
> .../devicetree/bindings/phy/mxs-usb-phy.txt | 33 -----
> 2 files changed, 125 insertions(+), 33 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
This should be applied by the PHY maintainers, but they weren't Cc'ed.
>
> diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> new file mode 100644
> index 000000000000..cc9f2bc7e6fb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> @@ -0,0 +1,125 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/fsl,mxs-usbphy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale MXS USB Phy Device
> +
> +maintainers:
> + - Xu Yang <xu.yang_2@nxp.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - fsl,imx23-usbphy
> + - fsl,imx7ulp-usbphy
> + - fsl,vf610-usbphy
> + - items:
> + - enum:
> + - fsl,imx28-usbphy
> + - fsl,imx6ul-usbphy
> + - fsl,imx6sl-usbphy
> + - fsl,imx6sx-usbphy
> + - fsl,imx6q-usbphy
> + - const: fsl,imx23-usbphy
> + - items:
> + - const: fsl,imx6sll-usbphy
> + - const: fsl,imx6ul-usbphy
> + - const: fsl,imx23-usbphy
> + - items:
> + - const: fsl,imx8dxl-usbphy
> + - const: fsl,imx7ulp-usbphy
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + '#phy-cells':
> + const: 0
> +
> + power-domains:
> + maxItems: 1
> +
> + fsl,anatop:
> + description:
> + phandle for anatop register, it is only for imx6 SoC series.
> + $ref: /schemas/types.yaml#/definitions/phandle
> +
> + phy-3p0-supply:
> + description:
> + One of USB PHY's power supply. Can be used to keep a good signal
> + quality.
> +
> + fsl,tx-cal-45-dn-ohms:
> + description:
> + Resistance (in ohms) of switchable high-speed trimming resistor
> + connected in parallel with the 45 ohm resistor that terminates
> + the DN output signal.
> + minimum: 35
> + maximum: 54
> + default: 45
> +
> + fsl,tx-cal-45-dp-ohms:
> + description:
> + Resistance (in ohms) of switchable high-speed trimming resistor
> + connected in parallel with the 45 ohm resistor that terminates
> + the DP output signal.
> + minimum: 35
> + maximum: 54
> + default: 45
> +
> + fsl,tx-d-cal:
> + description:
> + Current trimming value (as a percentage) of the 17.78 mA TX
> + reference current.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 79
> + maximum: 119
> + default: 100
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + oneOf:
> + - enum:
> + - fsl,imx6q-usbphy
> + - fsl,imx6sl-usbphy
> + - fsl,imx6sx-usbphy
> + - fsl,imx6sll-usbphy
> + - fsl,vf610-usbphy
> + - items:
> + - const: fsl,imx6ul-usbphy
> + - const: fsl,imx23-usbphy
> + then:
> + required:
> + - fsl,anatop
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/imx6qdl-clock.h>
> +
> + usbphy1: usb-phy@20c9000 {
> + compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
> + reg = <0x020c9000 0x1000>;
> + clocks = <&clks IMX6QDL_CLK_USBPHY1>;
> + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
> + fsl,anatop = <&anatop>;
> + };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt b/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
> deleted file mode 100644
> index 70c813b0755f..000000000000
> --- a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -* Freescale MXS USB Phy Device
> -
> -Required properties:
> -- compatible: should contain:
> - * "fsl,imx23-usbphy" for imx23 and imx28
> - * "fsl,imx6q-usbphy" for imx6dq and imx6dl
> - * "fsl,imx6sl-usbphy" for imx6sl
> - * "fsl,vf610-usbphy" for Vybrid vf610
> - * "fsl,imx6sx-usbphy" for imx6sx
> - * "fsl,imx7ulp-usbphy" for imx7ulp
> - * "fsl,imx8dxl-usbphy" for imx8dxl
> - "fsl,imx23-usbphy" is still a fallback for other strings
> -- reg: Should contain registers location and length
> -- interrupts: Should contain phy interrupt
> -- fsl,anatop: phandle for anatop register, it is only for imx6 SoC series
> -
> -Optional properties:
> -- fsl,tx-cal-45-dn-ohms: Integer [35-54]. Resistance (in ohms) of switchable
> - high-speed trimming resistor connected in parallel with the 45 ohm resistor
> - that terminates the DN output signal. Default: 45
> -- fsl,tx-cal-45-dp-ohms: Integer [35-54]. Resistance (in ohms) of switchable
> - high-speed trimming resistor connected in parallel with the 45 ohm resistor
> - that terminates the DP output signal. Default: 45
> -- fsl,tx-d-cal: Integer [79-119]. Current trimming value (as a percentage) of
> - the 17.78mA TX reference current. Default: 100
> -
> -Example:
> -usbphy1: usb-phy@20c9000 {
> - compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
> - reg = <0x020c9000 0x1000>;
> - interrupts = <0 44 0x04>;
> - fsl,anatop = <&anatop>;
> -};
> --
> 2.34.1
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v4 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
2023-06-13 8:34 ` Xu Yang
(?)
@ 2023-06-20 15:29 ` Rob Herring
-1 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2023-06-20 15:29 UTC (permalink / raw)
To: Xu Yang
Cc: linux-arm-kernel, linux-usb, s.hauer, jun.li, conor+dt, kernel,
linux-imx, shawnguo, krzysztof.kozlowski+dt, devicetree,
festevam, robh+dt, linux-phy
On Tue, 13 Jun 2023 16:34:45 +0800, Xu Yang wrote:
> The imx8ulp and imx8qm are compatible with imx8dxl. This will add such
> compatible.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
>
> ---
> Changes in v2:
> - no change
> Changes in v3:
> - no change
> Changes in v4:
> - no change
> ---
> Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v4 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
@ 2023-06-20 15:29 ` Rob Herring
0 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2023-06-20 15:29 UTC (permalink / raw)
To: Xu Yang
Cc: linux-arm-kernel, linux-usb, s.hauer, jun.li, conor+dt, kernel,
linux-imx, shawnguo, krzysztof.kozlowski+dt, devicetree,
festevam, robh+dt, linux-phy
On Tue, 13 Jun 2023 16:34:45 +0800, Xu Yang wrote:
> The imx8ulp and imx8qm are compatible with imx8dxl. This will add such
> compatible.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
>
> ---
> Changes in v2:
> - no change
> Changes in v3:
> - no change
> Changes in v4:
> - no change
> ---
> Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v4 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
@ 2023-06-20 15:29 ` Rob Herring
0 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2023-06-20 15:29 UTC (permalink / raw)
To: Xu Yang
Cc: linux-arm-kernel, linux-usb, s.hauer, jun.li, conor+dt, kernel,
linux-imx, shawnguo, krzysztof.kozlowski+dt, devicetree,
festevam, robh+dt, linux-phy
On Tue, 13 Jun 2023 16:34:45 +0800, Xu Yang wrote:
> The imx8ulp and imx8qm are compatible with imx8dxl. This will add such
> compatible.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
>
> ---
> Changes in v2:
> - no change
> Changes in v3:
> - no change
> Changes in v4:
> - no change
> ---
> Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [EXT] Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
2023-06-20 15:29 ` Rob Herring
(?)
@ 2023-06-21 2:16 ` Xu Yang
-1 siblings, 0 replies; 24+ messages in thread
From: Xu Yang @ 2023-06-21 2:16 UTC (permalink / raw)
To: Rob Herring, vkoul
Cc: krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, dl-linux-imx, linux-phy, devicetree, linux-arm-kernel,
linux-usb, Jun Li
++ Vinod Koul
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Tuesday, June 20, 2023 11:29 PM
> To: Xu Yang <xu.yang_2@nxp.com>
> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux-phy@lists.infradead.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-usb@vger.kernel.org; Jun Li <jun.li@nxp.com>
> Subject: [EXT] Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
>
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the
> message using the 'Report this email' button
>
>
> On Tue, Jun 13, 2023 at 04:34:44PM +0800, Xu Yang wrote:
> > Convert the binding to DT schema format. Besides, this also add clocks,
> > '#phy-cells', phy-3p0-supply and power-domains properties which are not
> > contained in txt file due to txt file lack updates.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> >
> > ---
> > Changes in v2:
> > - change filename to fsl,mxs-usbphy.yaml
> > - add other optional properties
> > - narrow fsl,anatop to imx6
> > - use additionalProperties
> > Changes in v3:
> > - fix indentation
> > - add clocks property to example
> > Changes in v4:
> > - remove [fsl,imx7ulp-usbphy, fsl,imx6ul-usbphy]
> > - limit item of reg and interrupts to 1
> > - sort enum items
> > - modify commit message
> > ---
> > .../bindings/phy/fsl,mxs-usbphy.yaml | 125 ++++++++++++++++++
> > .../devicetree/bindings/phy/mxs-usb-phy.txt | 33 -----
> > 2 files changed, 125 insertions(+), 33 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
>
> This should be applied by the PHY maintainers, but they weren't Cc'ed.
I see. Thanks for reminding.
Hi Vinod,
Could you please help to apply below two patches:
- [v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
- [v4,2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
The review process has been completed.
Many thanks in advance.
Thanks,
Xu Yang
>
> >
> > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > new file mode 100644
> > index 000000000000..cc9f2bc7e6fb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > @@ -0,0 +1,125 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> http://devicetree.org/schemas/phy/fsl,mxs-
> usbphy.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7Cac9c63d6d88543a24a8308db71a32171%7C686ea1d3bc2b4c
> 6fa92cd99c5c301635%7C0%7C0%7C638228717681736316%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjo
> iV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HB6IkZX%2BRcbpGNmFCYWOfPYYffoH5QPreo8
> A6jHjRz0%3D&reserved=0
> > +$schema: http://devicetree.org/meta-
> schemas%2Fcore.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7Cac9c63d6d88543a24a8308db71a32171%7C686ea1
> d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638228717681736316%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD
> AiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XZ8gZnd%2FCse%2FCFgFKyKganKz7cs
> Vyq6hdIJpRY4p8Fc%3D&reserved=0
> > +
> > +title: Freescale MXS USB Phy Device
> > +
> > +maintainers:
> > + - Xu Yang <xu.yang_2@nxp.com>
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - enum:
> > + - fsl,imx23-usbphy
> > + - fsl,imx7ulp-usbphy
> > + - fsl,vf610-usbphy
> > + - items:
> > + - enum:
> > + - fsl,imx28-usbphy
> > + - fsl,imx6ul-usbphy
> > + - fsl,imx6sl-usbphy
> > + - fsl,imx6sx-usbphy
> > + - fsl,imx6q-usbphy
> > + - const: fsl,imx23-usbphy
> > + - items:
> > + - const: fsl,imx6sll-usbphy
> > + - const: fsl,imx6ul-usbphy
> > + - const: fsl,imx23-usbphy
> > + - items:
> > + - const: fsl,imx8dxl-usbphy
> > + - const: fsl,imx7ulp-usbphy
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + '#phy-cells':
> > + const: 0
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + fsl,anatop:
> > + description:
> > + phandle for anatop register, it is only for imx6 SoC series.
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > +
> > + phy-3p0-supply:
> > + description:
> > + One of USB PHY's power supply. Can be used to keep a good signal
> > + quality.
> > +
> > + fsl,tx-cal-45-dn-ohms:
> > + description:
> > + Resistance (in ohms) of switchable high-speed trimming resistor
> > + connected in parallel with the 45 ohm resistor that terminates
> > + the DN output signal.
> > + minimum: 35
> > + maximum: 54
> > + default: 45
> > +
> > + fsl,tx-cal-45-dp-ohms:
> > + description:
> > + Resistance (in ohms) of switchable high-speed trimming resistor
> > + connected in parallel with the 45 ohm resistor that terminates
> > + the DP output signal.
> > + minimum: 35
> > + maximum: 54
> > + default: 45
> > +
> > + fsl,tx-d-cal:
> > + description:
> > + Current trimming value (as a percentage) of the 17.78 mA TX
> > + reference current.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 79
> > + maximum: 119
> > + default: 100
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > +
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + oneOf:
> > + - enum:
> > + - fsl,imx6q-usbphy
> > + - fsl,imx6sl-usbphy
> > + - fsl,imx6sx-usbphy
> > + - fsl,imx6sll-usbphy
> > + - fsl,vf610-usbphy
> > + - items:
> > + - const: fsl,imx6ul-usbphy
> > + - const: fsl,imx23-usbphy
> > + then:
> > + required:
> > + - fsl,anatop
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/clock/imx6qdl-clock.h>
> > +
> > + usbphy1: usb-phy@20c9000 {
> > + compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
> > + reg = <0x020c9000 0x1000>;
> > + clocks = <&clks IMX6QDL_CLK_USBPHY1>;
> > + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
> > + fsl,anatop = <&anatop>;
> > + };
> > +
> > +...
> > diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt b/Documentation/devicetree/bindings/phy/mxs-
> usb-phy.txt
> > deleted file mode 100644
> > index 70c813b0755f..000000000000
> > --- a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
> > +++ /dev/null
> > @@ -1,33 +0,0 @@
> > -* Freescale MXS USB Phy Device
> > -
> > -Required properties:
> > -- compatible: should contain:
> > - * "fsl,imx23-usbphy" for imx23 and imx28
> > - * "fsl,imx6q-usbphy" for imx6dq and imx6dl
> > - * "fsl,imx6sl-usbphy" for imx6sl
> > - * "fsl,vf610-usbphy" for Vybrid vf610
> > - * "fsl,imx6sx-usbphy" for imx6sx
> > - * "fsl,imx7ulp-usbphy" for imx7ulp
> > - * "fsl,imx8dxl-usbphy" for imx8dxl
> > - "fsl,imx23-usbphy" is still a fallback for other strings
> > -- reg: Should contain registers location and length
> > -- interrupts: Should contain phy interrupt
> > -- fsl,anatop: phandle for anatop register, it is only for imx6 SoC series
> > -
> > -Optional properties:
> > -- fsl,tx-cal-45-dn-ohms: Integer [35-54]. Resistance (in ohms) of switchable
> > - high-speed trimming resistor connected in parallel with the 45 ohm resistor
> > - that terminates the DN output signal. Default: 45
> > -- fsl,tx-cal-45-dp-ohms: Integer [35-54]. Resistance (in ohms) of switchable
> > - high-speed trimming resistor connected in parallel with the 45 ohm resistor
> > - that terminates the DP output signal. Default: 45
> > -- fsl,tx-d-cal: Integer [79-119]. Current trimming value (as a percentage) of
> > - the 17.78mA TX reference current. Default: 100
> > -
> > -Example:
> > -usbphy1: usb-phy@20c9000 {
> > - compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
> > - reg = <0x020c9000 0x1000>;
> > - interrupts = <0 44 0x04>;
> > - fsl,anatop = <&anatop>;
> > -};
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [EXT] Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
@ 2023-06-21 2:16 ` Xu Yang
0 siblings, 0 replies; 24+ messages in thread
From: Xu Yang @ 2023-06-21 2:16 UTC (permalink / raw)
To: Rob Herring, vkoul
Cc: krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, dl-linux-imx, linux-phy, devicetree, linux-arm-kernel,
linux-usb, Jun Li
++ Vinod Koul
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Tuesday, June 20, 2023 11:29 PM
> To: Xu Yang <xu.yang_2@nxp.com>
> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux-phy@lists.infradead.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-usb@vger.kernel.org; Jun Li <jun.li@nxp.com>
> Subject: [EXT] Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
>
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the
> message using the 'Report this email' button
>
>
> On Tue, Jun 13, 2023 at 04:34:44PM +0800, Xu Yang wrote:
> > Convert the binding to DT schema format. Besides, this also add clocks,
> > '#phy-cells', phy-3p0-supply and power-domains properties which are not
> > contained in txt file due to txt file lack updates.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> >
> > ---
> > Changes in v2:
> > - change filename to fsl,mxs-usbphy.yaml
> > - add other optional properties
> > - narrow fsl,anatop to imx6
> > - use additionalProperties
> > Changes in v3:
> > - fix indentation
> > - add clocks property to example
> > Changes in v4:
> > - remove [fsl,imx7ulp-usbphy, fsl,imx6ul-usbphy]
> > - limit item of reg and interrupts to 1
> > - sort enum items
> > - modify commit message
> > ---
> > .../bindings/phy/fsl,mxs-usbphy.yaml | 125 ++++++++++++++++++
> > .../devicetree/bindings/phy/mxs-usb-phy.txt | 33 -----
> > 2 files changed, 125 insertions(+), 33 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
>
> This should be applied by the PHY maintainers, but they weren't Cc'ed.
I see. Thanks for reminding.
Hi Vinod,
Could you please help to apply below two patches:
- [v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
- [v4,2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
The review process has been completed.
Many thanks in advance.
Thanks,
Xu Yang
>
> >
> > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > new file mode 100644
> > index 000000000000..cc9f2bc7e6fb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > @@ -0,0 +1,125 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> http://devicetree.org/schemas/phy/fsl,mxs-
> usbphy.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7Cac9c63d6d88543a24a8308db71a32171%7C686ea1d3bc2b4c
> 6fa92cd99c5c301635%7C0%7C0%7C638228717681736316%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjo
> iV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HB6IkZX%2BRcbpGNmFCYWOfPYYffoH5QPreo8
> A6jHjRz0%3D&reserved=0
> > +$schema: http://devicetree.org/meta-
> schemas%2Fcore.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7Cac9c63d6d88543a24a8308db71a32171%7C686ea1
> d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638228717681736316%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD
> AiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XZ8gZnd%2FCse%2FCFgFKyKganKz7cs
> Vyq6hdIJpRY4p8Fc%3D&reserved=0
> > +
> > +title: Freescale MXS USB Phy Device
> > +
> > +maintainers:
> > + - Xu Yang <xu.yang_2@nxp.com>
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - enum:
> > + - fsl,imx23-usbphy
> > + - fsl,imx7ulp-usbphy
> > + - fsl,vf610-usbphy
> > + - items:
> > + - enum:
> > + - fsl,imx28-usbphy
> > + - fsl,imx6ul-usbphy
> > + - fsl,imx6sl-usbphy
> > + - fsl,imx6sx-usbphy
> > + - fsl,imx6q-usbphy
> > + - const: fsl,imx23-usbphy
> > + - items:
> > + - const: fsl,imx6sll-usbphy
> > + - const: fsl,imx6ul-usbphy
> > + - const: fsl,imx23-usbphy
> > + - items:
> > + - const: fsl,imx8dxl-usbphy
> > + - const: fsl,imx7ulp-usbphy
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + '#phy-cells':
> > + const: 0
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + fsl,anatop:
> > + description:
> > + phandle for anatop register, it is only for imx6 SoC series.
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > +
> > + phy-3p0-supply:
> > + description:
> > + One of USB PHY's power supply. Can be used to keep a good signal
> > + quality.
> > +
> > + fsl,tx-cal-45-dn-ohms:
> > + description:
> > + Resistance (in ohms) of switchable high-speed trimming resistor
> > + connected in parallel with the 45 ohm resistor that terminates
> > + the DN output signal.
> > + minimum: 35
> > + maximum: 54
> > + default: 45
> > +
> > + fsl,tx-cal-45-dp-ohms:
> > + description:
> > + Resistance (in ohms) of switchable high-speed trimming resistor
> > + connected in parallel with the 45 ohm resistor that terminates
> > + the DP output signal.
> > + minimum: 35
> > + maximum: 54
> > + default: 45
> > +
> > + fsl,tx-d-cal:
> > + description:
> > + Current trimming value (as a percentage) of the 17.78 mA TX
> > + reference current.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 79
> > + maximum: 119
> > + default: 100
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > +
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + oneOf:
> > + - enum:
> > + - fsl,imx6q-usbphy
> > + - fsl,imx6sl-usbphy
> > + - fsl,imx6sx-usbphy
> > + - fsl,imx6sll-usbphy
> > + - fsl,vf610-usbphy
> > + - items:
> > + - const: fsl,imx6ul-usbphy
> > + - const: fsl,imx23-usbphy
> > + then:
> > + required:
> > + - fsl,anatop
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/clock/imx6qdl-clock.h>
> > +
> > + usbphy1: usb-phy@20c9000 {
> > + compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
> > + reg = <0x020c9000 0x1000>;
> > + clocks = <&clks IMX6QDL_CLK_USBPHY1>;
> > + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
> > + fsl,anatop = <&anatop>;
> > + };
> > +
> > +...
> > diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt b/Documentation/devicetree/bindings/phy/mxs-
> usb-phy.txt
> > deleted file mode 100644
> > index 70c813b0755f..000000000000
> > --- a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
> > +++ /dev/null
> > @@ -1,33 +0,0 @@
> > -* Freescale MXS USB Phy Device
> > -
> > -Required properties:
> > -- compatible: should contain:
> > - * "fsl,imx23-usbphy" for imx23 and imx28
> > - * "fsl,imx6q-usbphy" for imx6dq and imx6dl
> > - * "fsl,imx6sl-usbphy" for imx6sl
> > - * "fsl,vf610-usbphy" for Vybrid vf610
> > - * "fsl,imx6sx-usbphy" for imx6sx
> > - * "fsl,imx7ulp-usbphy" for imx7ulp
> > - * "fsl,imx8dxl-usbphy" for imx8dxl
> > - "fsl,imx23-usbphy" is still a fallback for other strings
> > -- reg: Should contain registers location and length
> > -- interrupts: Should contain phy interrupt
> > -- fsl,anatop: phandle for anatop register, it is only for imx6 SoC series
> > -
> > -Optional properties:
> > -- fsl,tx-cal-45-dn-ohms: Integer [35-54]. Resistance (in ohms) of switchable
> > - high-speed trimming resistor connected in parallel with the 45 ohm resistor
> > - that terminates the DN output signal. Default: 45
> > -- fsl,tx-cal-45-dp-ohms: Integer [35-54]. Resistance (in ohms) of switchable
> > - high-speed trimming resistor connected in parallel with the 45 ohm resistor
> > - that terminates the DP output signal. Default: 45
> > -- fsl,tx-d-cal: Integer [79-119]. Current trimming value (as a percentage) of
> > - the 17.78mA TX reference current. Default: 100
> > -
> > -Example:
> > -usbphy1: usb-phy@20c9000 {
> > - compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
> > - reg = <0x020c9000 0x1000>;
> > - interrupts = <0 44 0x04>;
> > - fsl,anatop = <&anatop>;
> > -};
> > --
> > 2.34.1
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [EXT] Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
@ 2023-06-21 2:16 ` Xu Yang
0 siblings, 0 replies; 24+ messages in thread
From: Xu Yang @ 2023-06-21 2:16 UTC (permalink / raw)
To: Rob Herring, vkoul
Cc: krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, dl-linux-imx, linux-phy, devicetree, linux-arm-kernel,
linux-usb, Jun Li
++ Vinod Koul
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Tuesday, June 20, 2023 11:29 PM
> To: Xu Yang <xu.yang_2@nxp.com>
> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux-phy@lists.infradead.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-usb@vger.kernel.org; Jun Li <jun.li@nxp.com>
> Subject: [EXT] Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
>
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the
> message using the 'Report this email' button
>
>
> On Tue, Jun 13, 2023 at 04:34:44PM +0800, Xu Yang wrote:
> > Convert the binding to DT schema format. Besides, this also add clocks,
> > '#phy-cells', phy-3p0-supply and power-domains properties which are not
> > contained in txt file due to txt file lack updates.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> >
> > ---
> > Changes in v2:
> > - change filename to fsl,mxs-usbphy.yaml
> > - add other optional properties
> > - narrow fsl,anatop to imx6
> > - use additionalProperties
> > Changes in v3:
> > - fix indentation
> > - add clocks property to example
> > Changes in v4:
> > - remove [fsl,imx7ulp-usbphy, fsl,imx6ul-usbphy]
> > - limit item of reg and interrupts to 1
> > - sort enum items
> > - modify commit message
> > ---
> > .../bindings/phy/fsl,mxs-usbphy.yaml | 125 ++++++++++++++++++
> > .../devicetree/bindings/phy/mxs-usb-phy.txt | 33 -----
> > 2 files changed, 125 insertions(+), 33 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
>
> This should be applied by the PHY maintainers, but they weren't Cc'ed.
I see. Thanks for reminding.
Hi Vinod,
Could you please help to apply below two patches:
- [v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
- [v4,2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
The review process has been completed.
Many thanks in advance.
Thanks,
Xu Yang
>
> >
> > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > new file mode 100644
> > index 000000000000..cc9f2bc7e6fb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > @@ -0,0 +1,125 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> http://devicetree.org/schemas/phy/fsl,mxs-
> usbphy.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7Cac9c63d6d88543a24a8308db71a32171%7C686ea1d3bc2b4c
> 6fa92cd99c5c301635%7C0%7C0%7C638228717681736316%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjo
> iV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HB6IkZX%2BRcbpGNmFCYWOfPYYffoH5QPreo8
> A6jHjRz0%3D&reserved=0
> > +$schema: http://devicetree.org/meta-
> schemas%2Fcore.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7Cac9c63d6d88543a24a8308db71a32171%7C686ea1
> d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638228717681736316%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD
> AiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XZ8gZnd%2FCse%2FCFgFKyKganKz7cs
> Vyq6hdIJpRY4p8Fc%3D&reserved=0
> > +
> > +title: Freescale MXS USB Phy Device
> > +
> > +maintainers:
> > + - Xu Yang <xu.yang_2@nxp.com>
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - enum:
> > + - fsl,imx23-usbphy
> > + - fsl,imx7ulp-usbphy
> > + - fsl,vf610-usbphy
> > + - items:
> > + - enum:
> > + - fsl,imx28-usbphy
> > + - fsl,imx6ul-usbphy
> > + - fsl,imx6sl-usbphy
> > + - fsl,imx6sx-usbphy
> > + - fsl,imx6q-usbphy
> > + - const: fsl,imx23-usbphy
> > + - items:
> > + - const: fsl,imx6sll-usbphy
> > + - const: fsl,imx6ul-usbphy
> > + - const: fsl,imx23-usbphy
> > + - items:
> > + - const: fsl,imx8dxl-usbphy
> > + - const: fsl,imx7ulp-usbphy
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + '#phy-cells':
> > + const: 0
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + fsl,anatop:
> > + description:
> > + phandle for anatop register, it is only for imx6 SoC series.
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > +
> > + phy-3p0-supply:
> > + description:
> > + One of USB PHY's power supply. Can be used to keep a good signal
> > + quality.
> > +
> > + fsl,tx-cal-45-dn-ohms:
> > + description:
> > + Resistance (in ohms) of switchable high-speed trimming resistor
> > + connected in parallel with the 45 ohm resistor that terminates
> > + the DN output signal.
> > + minimum: 35
> > + maximum: 54
> > + default: 45
> > +
> > + fsl,tx-cal-45-dp-ohms:
> > + description:
> > + Resistance (in ohms) of switchable high-speed trimming resistor
> > + connected in parallel with the 45 ohm resistor that terminates
> > + the DP output signal.
> > + minimum: 35
> > + maximum: 54
> > + default: 45
> > +
> > + fsl,tx-d-cal:
> > + description:
> > + Current trimming value (as a percentage) of the 17.78 mA TX
> > + reference current.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 79
> > + maximum: 119
> > + default: 100
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > +
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + oneOf:
> > + - enum:
> > + - fsl,imx6q-usbphy
> > + - fsl,imx6sl-usbphy
> > + - fsl,imx6sx-usbphy
> > + - fsl,imx6sll-usbphy
> > + - fsl,vf610-usbphy
> > + - items:
> > + - const: fsl,imx6ul-usbphy
> > + - const: fsl,imx23-usbphy
> > + then:
> > + required:
> > + - fsl,anatop
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/clock/imx6qdl-clock.h>
> > +
> > + usbphy1: usb-phy@20c9000 {
> > + compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
> > + reg = <0x020c9000 0x1000>;
> > + clocks = <&clks IMX6QDL_CLK_USBPHY1>;
> > + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
> > + fsl,anatop = <&anatop>;
> > + };
> > +
> > +...
> > diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt b/Documentation/devicetree/bindings/phy/mxs-
> usb-phy.txt
> > deleted file mode 100644
> > index 70c813b0755f..000000000000
> > --- a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
> > +++ /dev/null
> > @@ -1,33 +0,0 @@
> > -* Freescale MXS USB Phy Device
> > -
> > -Required properties:
> > -- compatible: should contain:
> > - * "fsl,imx23-usbphy" for imx23 and imx28
> > - * "fsl,imx6q-usbphy" for imx6dq and imx6dl
> > - * "fsl,imx6sl-usbphy" for imx6sl
> > - * "fsl,vf610-usbphy" for Vybrid vf610
> > - * "fsl,imx6sx-usbphy" for imx6sx
> > - * "fsl,imx7ulp-usbphy" for imx7ulp
> > - * "fsl,imx8dxl-usbphy" for imx8dxl
> > - "fsl,imx23-usbphy" is still a fallback for other strings
> > -- reg: Should contain registers location and length
> > -- interrupts: Should contain phy interrupt
> > -- fsl,anatop: phandle for anatop register, it is only for imx6 SoC series
> > -
> > -Optional properties:
> > -- fsl,tx-cal-45-dn-ohms: Integer [35-54]. Resistance (in ohms) of switchable
> > - high-speed trimming resistor connected in parallel with the 45 ohm resistor
> > - that terminates the DN output signal. Default: 45
> > -- fsl,tx-cal-45-dp-ohms: Integer [35-54]. Resistance (in ohms) of switchable
> > - high-speed trimming resistor connected in parallel with the 45 ohm resistor
> > - that terminates the DP output signal. Default: 45
> > -- fsl,tx-d-cal: Integer [79-119]. Current trimming value (as a percentage) of
> > - the 17.78mA TX reference current. Default: 100
> > -
> > -Example:
> > -usbphy1: usb-phy@20c9000 {
> > - compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
> > - reg = <0x020c9000 0x1000>;
> > - interrupts = <0 44 0x04>;
> > - fsl,anatop = <&anatop>;
> > -};
> > --
> > 2.34.1
> >
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [EXT] Re: [PATCH v4 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
2023-06-20 15:29 ` Rob Herring
(?)
@ 2023-06-21 2:18 ` Xu Yang
-1 siblings, 0 replies; 24+ messages in thread
From: Xu Yang @ 2023-06-21 2:18 UTC (permalink / raw)
To: Rob Herring, vkoul
Cc: linux-arm-kernel, linux-usb, s.hauer, Jun Li, conor+dt, kernel,
dl-linux-imx, shawnguo, krzysztof.kozlowski+dt, devicetree,
festevam, robh+dt, linux-phy
++ Vinod Koul
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Tuesday, June 20, 2023 11:29 PM
> To: Xu Yang <xu.yang_2@nxp.com>
> Cc: linux-arm-kernel@lists.infradead.org; linux-usb@vger.kernel.org; s.hauer@pengutronix.de; Jun Li <jun.li@nxp.com>;
> conor+dt@kernel.org; kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>; shawnguo@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; devicetree@vger.kernel.org; festevam@gmail.com; robh+dt@kernel.org; linux-
> phy@lists.infradead.org
> Subject: [EXT] Re: [PATCH v4 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
>
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the
> message using the 'Report this email' button
>
>
> On Tue, 13 Jun 2023 16:34:45 +0800, Xu Yang wrote:
> > The imx8ulp and imx8qm are compatible with imx8dxl. This will add such
> > compatible.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> >
> > ---
> > Changes in v2:
> > - no change
> > Changes in v3:
> > - no change
> > Changes in v4:
> > - no change
> > ---
> > Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
>
> Acked-by: Rob Herring <robh@kernel.org>
Hi Vinod,
Another one is here.
Thanks,
Xu Yang
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [EXT] Re: [PATCH v4 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
@ 2023-06-21 2:18 ` Xu Yang
0 siblings, 0 replies; 24+ messages in thread
From: Xu Yang @ 2023-06-21 2:18 UTC (permalink / raw)
To: Rob Herring, vkoul
Cc: linux-arm-kernel, linux-usb, s.hauer, Jun Li, conor+dt, kernel,
dl-linux-imx, shawnguo, krzysztof.kozlowski+dt, devicetree,
festevam, robh+dt, linux-phy
++ Vinod Koul
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Tuesday, June 20, 2023 11:29 PM
> To: Xu Yang <xu.yang_2@nxp.com>
> Cc: linux-arm-kernel@lists.infradead.org; linux-usb@vger.kernel.org; s.hauer@pengutronix.de; Jun Li <jun.li@nxp.com>;
> conor+dt@kernel.org; kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>; shawnguo@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; devicetree@vger.kernel.org; festevam@gmail.com; robh+dt@kernel.org; linux-
> phy@lists.infradead.org
> Subject: [EXT] Re: [PATCH v4 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
>
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the
> message using the 'Report this email' button
>
>
> On Tue, 13 Jun 2023 16:34:45 +0800, Xu Yang wrote:
> > The imx8ulp and imx8qm are compatible with imx8dxl. This will add such
> > compatible.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> >
> > ---
> > Changes in v2:
> > - no change
> > Changes in v3:
> > - no change
> > Changes in v4:
> > - no change
> > ---
> > Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
>
> Acked-by: Rob Herring <robh@kernel.org>
Hi Vinod,
Another one is here.
Thanks,
Xu Yang
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [EXT] Re: [PATCH v4 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
@ 2023-06-21 2:18 ` Xu Yang
0 siblings, 0 replies; 24+ messages in thread
From: Xu Yang @ 2023-06-21 2:18 UTC (permalink / raw)
To: Rob Herring, vkoul
Cc: linux-arm-kernel, linux-usb, s.hauer, Jun Li, conor+dt, kernel,
dl-linux-imx, shawnguo, krzysztof.kozlowski+dt, devicetree,
festevam, robh+dt, linux-phy
++ Vinod Koul
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Tuesday, June 20, 2023 11:29 PM
> To: Xu Yang <xu.yang_2@nxp.com>
> Cc: linux-arm-kernel@lists.infradead.org; linux-usb@vger.kernel.org; s.hauer@pengutronix.de; Jun Li <jun.li@nxp.com>;
> conor+dt@kernel.org; kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>; shawnguo@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; devicetree@vger.kernel.org; festevam@gmail.com; robh+dt@kernel.org; linux-
> phy@lists.infradead.org
> Subject: [EXT] Re: [PATCH v4 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
>
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the
> message using the 'Report this email' button
>
>
> On Tue, 13 Jun 2023 16:34:45 +0800, Xu Yang wrote:
> > The imx8ulp and imx8qm are compatible with imx8dxl. This will add such
> > compatible.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> >
> > ---
> > Changes in v2:
> > - no change
> > Changes in v3:
> > - no change
> > Changes in v4:
> > - no change
> > ---
> > Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
>
> Acked-by: Rob Herring <robh@kernel.org>
Hi Vinod,
Another one is here.
Thanks,
Xu Yang
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [EXT] Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
2023-06-21 2:16 ` Xu Yang
(?)
@ 2023-06-21 12:01 ` Vinod Koul
-1 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2023-06-21 12:01 UTC (permalink / raw)
To: Xu Yang
Cc: Rob Herring, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer,
kernel, festevam, dl-linux-imx, linux-phy, devicetree,
linux-arm-kernel, linux-usb, Jun Li
On 21-06-23, 02:16, Xu Yang wrote:
> ++ Vinod Koul
>
> > -----Original Message-----
> > From: Rob Herring <robh@kernel.org>
> > Sent: Tuesday, June 20, 2023 11:29 PM
> > To: Xu Yang <xu.yang_2@nxp.com>
> > Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> > kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux-phy@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-usb@vger.kernel.org; Jun Li <jun.li@nxp.com>
> > Subject: [EXT] Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
> >
> > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the
> > message using the 'Report this email' button
> >
> >
> > On Tue, Jun 13, 2023 at 04:34:44PM +0800, Xu Yang wrote:
> > > Convert the binding to DT schema format. Besides, this also add clocks,
> > > '#phy-cells', phy-3p0-supply and power-domains properties which are not
> > > contained in txt file due to txt file lack updates.
> > >
> > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > >
> > > ---
> > > Changes in v2:
> > > - change filename to fsl,mxs-usbphy.yaml
> > > - add other optional properties
> > > - narrow fsl,anatop to imx6
> > > - use additionalProperties
> > > Changes in v3:
> > > - fix indentation
> > > - add clocks property to example
> > > Changes in v4:
> > > - remove [fsl,imx7ulp-usbphy, fsl,imx6ul-usbphy]
> > > - limit item of reg and interrupts to 1
> > > - sort enum items
> > > - modify commit message
> > > ---
> > > .../bindings/phy/fsl,mxs-usbphy.yaml | 125 ++++++++++++++++++
> > > .../devicetree/bindings/phy/mxs-usb-phy.txt | 33 -----
> > > 2 files changed, 125 insertions(+), 33 deletions(-)
> > > create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > > delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
> >
> > This should be applied by the PHY maintainers, but they weren't Cc'ed.
>
> I see. Thanks for reminding.
>
> Hi Vinod,
>
> Could you please help to apply below two patches:
> - [v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
> - [v4,2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
> The review process has been completed.
> Many thanks in advance.
Applied now, please use get_maintainer.pl to find whom the patches
should be copied to
--
~Vinod
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [EXT] Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
@ 2023-06-21 12:01 ` Vinod Koul
0 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2023-06-21 12:01 UTC (permalink / raw)
To: Xu Yang
Cc: Rob Herring, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer,
kernel, festevam, dl-linux-imx, linux-phy, devicetree,
linux-arm-kernel, linux-usb, Jun Li
On 21-06-23, 02:16, Xu Yang wrote:
> ++ Vinod Koul
>
> > -----Original Message-----
> > From: Rob Herring <robh@kernel.org>
> > Sent: Tuesday, June 20, 2023 11:29 PM
> > To: Xu Yang <xu.yang_2@nxp.com>
> > Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> > kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux-phy@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-usb@vger.kernel.org; Jun Li <jun.li@nxp.com>
> > Subject: [EXT] Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
> >
> > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the
> > message using the 'Report this email' button
> >
> >
> > On Tue, Jun 13, 2023 at 04:34:44PM +0800, Xu Yang wrote:
> > > Convert the binding to DT schema format. Besides, this also add clocks,
> > > '#phy-cells', phy-3p0-supply and power-domains properties which are not
> > > contained in txt file due to txt file lack updates.
> > >
> > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > >
> > > ---
> > > Changes in v2:
> > > - change filename to fsl,mxs-usbphy.yaml
> > > - add other optional properties
> > > - narrow fsl,anatop to imx6
> > > - use additionalProperties
> > > Changes in v3:
> > > - fix indentation
> > > - add clocks property to example
> > > Changes in v4:
> > > - remove [fsl,imx7ulp-usbphy, fsl,imx6ul-usbphy]
> > > - limit item of reg and interrupts to 1
> > > - sort enum items
> > > - modify commit message
> > > ---
> > > .../bindings/phy/fsl,mxs-usbphy.yaml | 125 ++++++++++++++++++
> > > .../devicetree/bindings/phy/mxs-usb-phy.txt | 33 -----
> > > 2 files changed, 125 insertions(+), 33 deletions(-)
> > > create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > > delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
> >
> > This should be applied by the PHY maintainers, but they weren't Cc'ed.
>
> I see. Thanks for reminding.
>
> Hi Vinod,
>
> Could you please help to apply below two patches:
> - [v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
> - [v4,2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
> The review process has been completed.
> Many thanks in advance.
Applied now, please use get_maintainer.pl to find whom the patches
should be copied to
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [EXT] Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
@ 2023-06-21 12:01 ` Vinod Koul
0 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2023-06-21 12:01 UTC (permalink / raw)
To: Xu Yang
Cc: Rob Herring, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer,
kernel, festevam, dl-linux-imx, linux-phy, devicetree,
linux-arm-kernel, linux-usb, Jun Li
On 21-06-23, 02:16, Xu Yang wrote:
> ++ Vinod Koul
>
> > -----Original Message-----
> > From: Rob Herring <robh@kernel.org>
> > Sent: Tuesday, June 20, 2023 11:29 PM
> > To: Xu Yang <xu.yang_2@nxp.com>
> > Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> > kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux-phy@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-usb@vger.kernel.org; Jun Li <jun.li@nxp.com>
> > Subject: [EXT] Re: [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
> >
> > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the
> > message using the 'Report this email' button
> >
> >
> > On Tue, Jun 13, 2023 at 04:34:44PM +0800, Xu Yang wrote:
> > > Convert the binding to DT schema format. Besides, this also add clocks,
> > > '#phy-cells', phy-3p0-supply and power-domains properties which are not
> > > contained in txt file due to txt file lack updates.
> > >
> > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > >
> > > ---
> > > Changes in v2:
> > > - change filename to fsl,mxs-usbphy.yaml
> > > - add other optional properties
> > > - narrow fsl,anatop to imx6
> > > - use additionalProperties
> > > Changes in v3:
> > > - fix indentation
> > > - add clocks property to example
> > > Changes in v4:
> > > - remove [fsl,imx7ulp-usbphy, fsl,imx6ul-usbphy]
> > > - limit item of reg and interrupts to 1
> > > - sort enum items
> > > - modify commit message
> > > ---
> > > .../bindings/phy/fsl,mxs-usbphy.yaml | 125 ++++++++++++++++++
> > > .../devicetree/bindings/phy/mxs-usb-phy.txt | 33 -----
> > > 2 files changed, 125 insertions(+), 33 deletions(-)
> > > create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > > delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
> >
> > This should be applied by the PHY maintainers, but they weren't Cc'ed.
>
> I see. Thanks for reminding.
>
> Hi Vinod,
>
> Could you please help to apply below two patches:
> - [v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
> - [v4,2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
> The review process has been completed.
> Many thanks in advance.
Applied now, please use get_maintainer.pl to find whom the patches
should be copied to
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2023-06-21 12:01 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-13 8:34 [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format Xu Yang
2023-06-13 8:34 ` Xu Yang
2023-06-13 8:34 ` Xu Yang
2023-06-13 8:34 ` [PATCH v4 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible Xu Yang
2023-06-13 8:34 ` Xu Yang
2023-06-13 8:34 ` Xu Yang
2023-06-20 15:29 ` Rob Herring
2023-06-20 15:29 ` Rob Herring
2023-06-20 15:29 ` Rob Herring
2023-06-21 2:18 ` [EXT] " Xu Yang
2023-06-21 2:18 ` Xu Yang
2023-06-21 2:18 ` Xu Yang
2023-06-13 19:16 ` [PATCH v4 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format Krzysztof Kozlowski
2023-06-13 19:16 ` Krzysztof Kozlowski
2023-06-13 19:16 ` Krzysztof Kozlowski
2023-06-20 15:29 ` Rob Herring
2023-06-20 15:29 ` Rob Herring
2023-06-20 15:29 ` Rob Herring
2023-06-21 2:16 ` [EXT] " Xu Yang
2023-06-21 2:16 ` Xu Yang
2023-06-21 2:16 ` Xu Yang
2023-06-21 12:01 ` Vinod Koul
2023-06-21 12:01 ` Vinod Koul
2023-06-21 12:01 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.