[PATCH] commit: use strbuf_add() to add a length-limited string

[PATCH] commit: use strbuf_add() to add a length-limited string

[René Scharfe]

This is shorter and simpler.

Signed-off-by: René Scharfe <l.s.r@web.de>
---
 builtin/commit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/commit.c b/builtin/commit.c
index 294dc574cd..35a1fb9ad6 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -537,7 +537,7 @@ static void export_one(const char *var, const char *s, const char *e, int hack)
 	struct strbuf buf = STRBUF_INIT;
 	if (hack)
 		strbuf_addch(&buf, hack);
-	strbuf_addf(&buf, "%.*s", (int)(e - s), s);
+	strbuf_add(&buf, s, e - s);
 	setenv(var, buf.buf, 1);
 	strbuf_release(&buf);
 }
--
2.24.0

Re: [PATCH] commit: use strbuf_add() to add a length-limited string

[Derrick Stolee]

On 12/7/2019 6:16 AM, René Scharfe wrote:
> This is shorter and simpler.
> 
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
>  builtin/commit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/builtin/commit.c b/builtin/commit.c
> index 294dc574cd..35a1fb9ad6 100644
> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -537,7 +537,7 @@ static void export_one(const char *var, const char *s, const char *e, int hack)
>  	struct strbuf buf = STRBUF_INIT;
>  	if (hack)
>  		strbuf_addch(&buf, hack);
> -	strbuf_addf(&buf, "%.*s", (int)(e - s), s);
> +	strbuf_add(&buf, s, e - s);

I had to look up what "%.*s" does [1, 2] but this looks like
a behavior-equivalent (and possibly faster) way to do it.

-Stolee

[1] https://stackoverflow.com/a/49580164
[2] https://en.cppreference.com/w/c/io/fprintf

Re: [PATCH] commit: use strbuf_add() to add a length-limited string

[Junio C Hamano]

René Scharfe <l.s.r@web.de> writes:

> This is shorter and simpler.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---

Ack (this was from me abck in 2012).

>  builtin/commit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/commit.c b/builtin/commit.c
> index 294dc574cd..35a1fb9ad6 100644
> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -537,7 +537,7 @@ static void export_one(const char *var, const char *s, const char *e, int hack)
>  	struct strbuf buf = STRBUF_INIT;
>  	if (hack)
>  		strbuf_addch(&buf, hack);
> -	strbuf_addf(&buf, "%.*s", (int)(e - s), s);
> +	strbuf_add(&buf, s, e - s);
>  	setenv(var, buf.buf, 1);
>  	strbuf_release(&buf);
>  }
> --
> 2.24.0