From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"marex@denx.de" <marex@denx.de>, Leo Li <leoyang.li@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>
Subject: Re: [RFC PATCH v2 1/3] USB: use genalloc for USB HCs with local memory
Date: Wed, 15 May 2019 09:57:12 +0000 [thread overview]
Message-ID: <f4fc0151-5e49-77fd-7736-37cdfe57c268@nxp.com> (raw)
In-Reply-To: <20190514144210.GA14625@lst.de>
On 14.05.2019 17:42, Christoph Hellwig wrote:
>> @@ -136,6 +137,10 @@ void *hcd_buffer_alloc(
>> if (size <= pool_max[i])
>> return dma_pool_alloc(hcd->pool[i], mem_flags, dma);
>> }
>> +
>> + if (hcd->driver->flags & HCD_LOCAL_MEM)
>> + return gen_pool_dma_alloc(hcd->localmem_pool, size, dma);
>
> I think this check needs to be before the above code to use the dma
> pools, as we should always use the HCD local memory. Probably all the
> way up just below the size == 0 check, that way we can also remove the
> other HCD_LOCAL_MEM check.
Alright.
>> @@ -165,5 +170,10 @@ void hcd_buffer_free(
>> return;
>> }
>> }
>> - dma_free_coherent(hcd->self.sysdev, size, addr, dma);
>> +
>> + if (hcd->driver->flags & HCD_LOCAL_MEM)
>> + gen_pool_free(hcd->localmem_pool, (unsigned long)addr,
>> + size);
>> + else
>> + dma_free_coherent(hcd->self.sysdev, size, addr, dma);
>
> Same here.
Ok.
>> @@ -505,8 +506,15 @@ static int ohci_init (struct ohci_hcd *ohci)
>> timer_setup(&ohci->io_watchdog, io_watchdog_func, 0);
>> ohci->prev_frame_no = IO_WATCHDOG_OFF;
>>
>> - ohci->hcca = dma_alloc_coherent (hcd->self.controller,
>> - sizeof(*ohci->hcca), &ohci->hcca_dma, GFP_KERNEL);
>> + if (hcd->driver->flags & HCD_LOCAL_MEM)
>> + ohci->hcca = gen_pool_dma_alloc(hcd->localmem_pool,
>> + sizeof(*ohci->hcca),
>> + &ohci->hcca_dma);
>> + else
>> + ohci->hcca = dma_alloc_coherent(hcd->self.controller,
>> + sizeof(*ohci->hcca),
>> + &ohci->hcca_dma,
>> + GFP_KERNEL);
>
> I wonder if we could just use hcd_buffer_alloc/free here, althought
> that would require them to be exported. I'll leave that decision to
> the relevant maintainers, though.
>
> Except for this the series looks exactly what I had envisioned to
> get rid of the device local dma_declare_coherent use case, thanks!
Glad I could help. On the remoteproc_virtio.c case, I had a cursory look
and found out that the dma_declare_coherent_memory() usage was
introduced quite recently, by this patch:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=086d08725d34c6b3333db710344ae9c4fdafb2d5
---
Best Regards, Laurentiu
next prev parent reply other threads:[~2019-05-15 9:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 14:38 [RFC PATCH v2 0/3] prerequisites for device reserved local mem rework laurentiu.tudor
2019-05-14 14:38 ` [RFC PATCH v2 1/3] USB: use genalloc for USB HCs with local memory laurentiu.tudor
2019-05-14 14:42 ` Christoph Hellwig
2019-05-15 9:57 ` Laurentiu Tudor [this message]
2019-05-15 12:42 ` Christoph Hellwig
2019-05-14 14:38 ` [RFC PATCH v2 2/3] usb: host: ohci-sm501: init genalloc for " laurentiu.tudor
2019-05-14 14:38 ` [RFC PATCH v2 3/3] usb: host: ohci-tmio: " laurentiu.tudor
2019-05-14 15:17 ` [RFC PATCH v2 0/3] prerequisites for device reserved local mem rework Robin Murphy
2019-05-14 18:29 ` Fredrik Noring
2019-05-15 10:37 ` Laurentiu Tudor
2019-05-15 16:28 ` Fredrik Noring
2019-05-16 9:35 ` Laurentiu Tudor
2019-05-16 13:47 ` Fredrik Noring
2019-05-16 11:49 ` Laurentiu Tudor
2019-05-16 15:15 ` Fredrik Noring
2019-05-17 10:52 ` Laurentiu Tudor
2019-05-17 17:41 ` Fredrik Noring
2019-05-20 11:34 ` Laurentiu Tudor
2019-05-20 15:41 ` Fredrik Noring
2019-05-21 10:32 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4fc0151-5e49-77fd-7736-37cdfe57c268@nxp.com \
--to=laurentiu.tudor@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marex@denx.de \
--cc=robin.murphy@arm.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.