* [U-Boot] [PATCH] Kconfig: fix FIT offset prompt text
@ 2019-05-15 13:57 Ibai Erkiaga
2019-05-15 14:08 ` Marek Vasut
2019-05-15 21:15 ` Marek Vasut
0 siblings, 2 replies; 5+ messages in thread
From: Ibai Erkiaga @ 2019-05-15 13:57 UTC (permalink / raw)
To: u-boot
The current prompt text for FIT external offset is identical to
SYS_TEXT_BASE which might confuse the users. Provided more accurate
description for the prompt text.
Signed-off-by: Ibai Erkiaga <ibai.erkiaga-elorza@xilinx.com>
---
Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Kconfig b/Kconfig
index 91c1082..f490ee4 100644
--- a/Kconfig
+++ b/Kconfig
@@ -278,7 +278,7 @@ config FIT
if FIT
config FIT_EXTERNAL_OFFSET
- hex "Text Base"
+ hex "FIT External Offset"
default 0x0
help
This specifies a data offset in fit image.
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Kconfig: fix FIT offset prompt text
2019-05-15 13:57 [U-Boot] [PATCH] Kconfig: fix FIT offset prompt text Ibai Erkiaga
@ 2019-05-15 14:08 ` Marek Vasut
2019-05-15 21:09 ` Ibai Erkiaga Elorza
2019-05-15 21:15 ` Marek Vasut
1 sibling, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2019-05-15 14:08 UTC (permalink / raw)
To: u-boot
On 5/15/19 3:57 PM, Ibai Erkiaga wrote:
> The current prompt text for FIT external offset is identical to
> SYS_TEXT_BASE which might confuse the users. Provided more accurate
> description for the prompt text.
>
> Signed-off-by: Ibai Erkiaga <ibai.erkiaga-elorza@xilinx.com>
> ---
>
> Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Kconfig b/Kconfig
> index 91c1082..f490ee4 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -278,7 +278,7 @@ config FIT
> if FIT
>
> config FIT_EXTERNAL_OFFSET
> - hex "Text Base"
> + hex "FIT External Offset"
"FIT external data offset" then ?
> default 0x0
> help
> This specifies a data offset in fit image.
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Kconfig: fix FIT offset prompt text
2019-05-15 14:08 ` Marek Vasut
@ 2019-05-15 21:09 ` Ibai Erkiaga Elorza
0 siblings, 0 replies; 5+ messages in thread
From: Ibai Erkiaga Elorza @ 2019-05-15 21:09 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Marek Vasut <marex@denx.de>
> Sent: 15 May 2019 15:09
> To: Ibai Erkiaga Elorza <IBAIE@xilinx.com>; u-boot at lists.denx.de
> Cc: Michal Simek <michals@xilinx.com>; Simon Glass <sjg@chromium.org>;
> Masahiro Yamada <yamada.masahiro@socionext.com>; Peng Fan
> <peng.fan@nxp.com>; Chris Packham <judge.packham@gmail.com>; Jagan Teki
> <jagan@amarulasolutions.com>; Stefan Roese <sr@denx.de>
> Subject: Re: [U-Boot][PATCH] Kconfig: fix FIT offset prompt text
>
> On 5/15/19 3:57 PM, Ibai Erkiaga wrote:
> > The current prompt text for FIT external offset is identical to
> > SYS_TEXT_BASE which might confuse the users. Provided more accurate
> > description for the prompt text.
> >
> > Signed-off-by: Ibai Erkiaga <ibai.erkiaga-elorza@xilinx.com>
> > ---
> >
> > Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Kconfig b/Kconfig
> > index 91c1082..f490ee4 100644
> > --- a/Kconfig
> > +++ b/Kconfig
> > @@ -278,7 +278,7 @@ config FIT
> > if FIT
> >
> > config FIT_EXTERNAL_OFFSET
> > - hex "Text Base"
> > + hex "FIT External Offset"
>
> "FIT external data offset" then ?
>
Fair enough, let me send an updated patch
> > default 0x0
> > help
> > This specifies a data offset in fit image.
> >
>
>
> --
> Best regards,
> Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Kconfig: fix FIT offset prompt text
2019-05-15 13:57 [U-Boot] [PATCH] Kconfig: fix FIT offset prompt text Ibai Erkiaga
2019-05-15 14:08 ` Marek Vasut
@ 2019-05-15 21:15 ` Marek Vasut
2019-05-15 21:15 ` Marek Vasut
1 sibling, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2019-05-15 21:15 UTC (permalink / raw)
To: u-boot
On 5/15/19 3:57 PM, Ibai Erkiaga wrote:
> The current prompt text for FIT external offset is identical to
> SYS_TEXT_BASE which might confuse the users. Provided more accurate
> description for the prompt text.
>
> Signed-off-by: Ibai Erkiaga <ibai.erkiaga-elorza@xilinx.com>
> ---
>
> Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Kconfig b/Kconfig
> index 91c1082..f490ee4 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -278,7 +278,7 @@ config FIT
> if FIT
>
> config FIT_EXTERNAL_OFFSET
> - hex "Text Base"
> + hex "FIT External Offset"
What changed ? There's no changelog and the patch looks the same too ;-)
> default 0x0
> help
> This specifies a data offset in fit image.
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Kconfig: fix FIT offset prompt text
2019-05-15 21:15 ` Marek Vasut
@ 2019-05-15 21:15 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2019-05-15 21:15 UTC (permalink / raw)
To: u-boot
On 5/15/19 11:15 PM, Marek Vasut wrote:
> On 5/15/19 3:57 PM, Ibai Erkiaga wrote:
>> The current prompt text for FIT external offset is identical to
>> SYS_TEXT_BASE which might confuse the users. Provided more accurate
>> description for the prompt text.
>>
>> Signed-off-by: Ibai Erkiaga <ibai.erkiaga-elorza@xilinx.com>
>> ---
>>
>> Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Kconfig b/Kconfig
>> index 91c1082..f490ee4 100644
>> --- a/Kconfig
>> +++ b/Kconfig
>> @@ -278,7 +278,7 @@ config FIT
>> if FIT
>>
>> config FIT_EXTERNAL_OFFSET
>> - hex "Text Base"
>> + hex "FIT External Offset"
>
> What changed ? There's no changelog and the patch looks the same too ;-)
Argh, forget what I said, sorry.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-15 21:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-15 13:57 [U-Boot] [PATCH] Kconfig: fix FIT offset prompt text Ibai Erkiaga
2019-05-15 14:08 ` Marek Vasut
2019-05-15 21:09 ` Ibai Erkiaga Elorza
2019-05-15 21:15 ` Marek Vasut
2019-05-15 21:15 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.