* [Qemu-devel] [PATCH] Issue a deprecation warning if the user specifies the "-hdachs" option.
@ 2017-04-25 8:08 Thomas Huth
2017-04-25 13:20 ` Eric Blake
2017-04-26 13:44 ` Paolo Bonzini
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Huth @ 2017-04-25 8:08 UTC (permalink / raw)
To: qemu-devel, Kevin Wolf, Max Reitz; +Cc: qemu-block
If the user needs to specify the disk geometry, the corresponding
parameters of the "-drive" option should be used instead. "-hdachs"
is considered as deprecated and might be removed soon.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
vl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/vl.c b/vl.c
index 0b4ed52..0980213 100644
--- a/vl.c
+++ b/vl.c
@@ -3230,6 +3230,8 @@ int main(int argc, char **argv, char **envp)
}
}
}
+ error_report("'-hdachs' is deprecated. Please use '-drive"
+ " ...,cyls=c,heads=h,secs=s,trans=t' instead.");
break;
case QEMU_OPTION_numa:
opts = qemu_opts_parse_noisily(qemu_find_opts("numa"),
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Issue a deprecation warning if the user specifies the "-hdachs" option.
2017-04-25 8:08 [Qemu-devel] [PATCH] Issue a deprecation warning if the user specifies the "-hdachs" option Thomas Huth
@ 2017-04-25 13:20 ` Eric Blake
2017-04-26 13:44 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Eric Blake @ 2017-04-25 13:20 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Kevin Wolf, Max Reitz; +Cc: qemu-block
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
On 04/25/2017 03:08 AM, Thomas Huth wrote:
> If the user needs to specify the disk geometry, the corresponding
> parameters of the "-drive" option should be used instead. "-hdachs"
> is considered as deprecated and might be removed soon.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> vl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 0b4ed52..0980213 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3230,6 +3230,8 @@ int main(int argc, char **argv, char **envp)
> }
> }
> }
> + error_report("'-hdachs' is deprecated. Please use '-drive"
> + " ...,cyls=c,heads=h,secs=s,trans=t' instead.");
No trailing dot. With that fixed,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Issue a deprecation warning if the user specifies the "-hdachs" option.
2017-04-25 8:08 [Qemu-devel] [PATCH] Issue a deprecation warning if the user specifies the "-hdachs" option Thomas Huth
2017-04-25 13:20 ` Eric Blake
@ 2017-04-26 13:44 ` Paolo Bonzini
2017-04-27 3:09 ` Thomas Huth
1 sibling, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2017-04-26 13:44 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Kevin Wolf, Max Reitz; +Cc: qemu-block
On 25/04/2017 10:08, Thomas Huth wrote:
> If the user needs to specify the disk geometry, the corresponding
> parameters of the "-drive" option should be used instead. "-hdachs"
> is considered as deprecated and might be removed soon.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> vl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 0b4ed52..0980213 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3230,6 +3230,8 @@ int main(int argc, char **argv, char **envp)
> }
> }
> }
> + error_report("'-hdachs' is deprecated. Please use '-drive"
> + " ...,cyls=c,heads=h,secs=s,trans=t' instead.");
> break;
> case QEMU_OPTION_numa:
> opts = qemu_opts_parse_noisily(qemu_find_opts("numa"),
>
Not even this, which should also be deprecated; please suggest using
"-device ide-hd" instead.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Issue a deprecation warning if the user specifies the "-hdachs" option.
2017-04-26 13:44 ` Paolo Bonzini
@ 2017-04-27 3:09 ` Thomas Huth
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2017-04-27 3:09 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel, Kevin Wolf, Max Reitz; +Cc: qemu-block
On 26.04.2017 15:44, Paolo Bonzini wrote:
>
>
> On 25/04/2017 10:08, Thomas Huth wrote:
>> If the user needs to specify the disk geometry, the corresponding
>> parameters of the "-drive" option should be used instead. "-hdachs"
>> is considered as deprecated and might be removed soon.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> vl.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/vl.c b/vl.c
>> index 0b4ed52..0980213 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -3230,6 +3230,8 @@ int main(int argc, char **argv, char **envp)
>> }
>> }
>> }
>> + error_report("'-hdachs' is deprecated. Please use '-drive"
>> + " ...,cyls=c,heads=h,secs=s,trans=t' instead.");
>> break;
>> case QEMU_OPTION_numa:
>> opts = qemu_opts_parse_noisily(qemu_find_opts("numa"),
>>
>
> Not even this, which should also be deprecated; please suggest using
> "-device ide-hd" instead.
D'oh, you're right, of course ... I'll send a v3 ...
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-27 3:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-25 8:08 [Qemu-devel] [PATCH] Issue a deprecation warning if the user specifies the "-hdachs" option Thomas Huth
2017-04-25 13:20 ` Eric Blake
2017-04-26 13:44 ` Paolo Bonzini
2017-04-27 3:09 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.