[PATCH] dt-bindings: spi: zynqmp-qspi: Add power-domains and iommus properties

[PATCH] dt-bindings: spi: zynqmp-qspi: Add power-domains and iommus properties

[Michal Simek]

Describe optional power-domain property to fix dts_check warnings. The
similar change was done by commit 0aec3958c88f ("dt-bindings: gpio: zynq:
Add power-domains").
And also by commit 84fa8f159022 ("dt-bindings: arm: coresight-tmc: Add
'iommu' property") for iommus property.

Signed-off-by: Michal Simek <michal.simek@amd.com>
---

 Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
index 20f77246d365..226d8b493b57 100644
--- a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
@@ -32,6 +32,12 @@ properties:
   clocks:
     maxItems: 2
 
+  iommus:
+    maxItems: 1
+
+  power-domains:
+    maxItems: 1
+
 required:
   - compatible
   - reg
-- 
2.36.1

[PATCH] dt-bindings: spi: zynqmp-qspi: Add power-domains and iommus properties

[Michal Simek]

Describe optional power-domain property to fix dts_check warnings. The
similar change was done by commit 0aec3958c88f ("dt-bindings: gpio: zynq:
Add power-domains").
And also by commit 84fa8f159022 ("dt-bindings: arm: coresight-tmc: Add
'iommu' property") for iommus property.

Signed-off-by: Michal Simek <michal.simek@amd.com>
---

 Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
index 20f77246d365..226d8b493b57 100644
--- a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
@@ -32,6 +32,12 @@ properties:
   clocks:
     maxItems: 2
 
+  iommus:
+    maxItems: 1
+
+  power-domains:
+    maxItems: 1
+
 required:
   - compatible
   - reg
-- 
2.36.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] dt-bindings: spi: zynqmp-qspi: Add power-domains and iommus properties

[Krzysztof Kozlowski]

On 02/05/2023 15:47, Michal Simek wrote:
> Describe optional power-domain property to fix dts_check warnings. The
> similar change was done by commit 0aec3958c88f ("dt-bindings: gpio: zynq:
> Add power-domains").
> And also by commit 84fa8f159022 ("dt-bindings: arm: coresight-tmc: Add
> 'iommu' property") for iommus property.

I am a bit pedantic, but you cannot use such arguments for this change.
Just because some other unrelated device (Coresight or GPIO controller)
has IOMMU does not mean your device has it as well. You know, some
device has reset-gpios, so shall you add it here?

The argument could be something around: The foo bar uses IOMMU and
belongs to a power domain.

Please re-phrase the commit msg.


Best regards,
Krzysztof

Re: [PATCH] dt-bindings: spi: zynqmp-qspi: Add power-domains and iommus properties

[Krzysztof Kozlowski]

On 02/05/2023 15:47, Michal Simek wrote:
> Describe optional power-domain property to fix dts_check warnings. The
> similar change was done by commit 0aec3958c88f ("dt-bindings: gpio: zynq:
> Add power-domains").
> And also by commit 84fa8f159022 ("dt-bindings: arm: coresight-tmc: Add
> 'iommu' property") for iommus property.

I am a bit pedantic, but you cannot use such arguments for this change.
Just because some other unrelated device (Coresight or GPIO controller)
has IOMMU does not mean your device has it as well. You know, some
device has reset-gpios, so shall you add it here?

The argument could be something around: The foo bar uses IOMMU and
belongs to a power domain.

Please re-phrase the commit msg.


Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel