* [Nouveau] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when testing other planes @ 2021-03-17 22:44 ` Lyude 0 siblings, 0 replies; 12+ messages in thread From: Lyude @ 2021-03-17 22:44 UTC (permalink / raw) To: igt-dev, nouveau; +Cc: Ben Skeggs From: Lyude Paul <lyude@redhat.com> Currently, nouveau doesn't support having a CRTC without a primary FB set. We won't reject such configurations, but the behavior is undefined which will cause CRCs to become undefined. So, avoid clearing the primary FB while we're testing non-primary planes. Signed-off-by: Lyude Paul <lyude@redhat.com> Cc: Martin Peres <martin.peres@free.fr> Cc: Ben Skeggs <bskeggs@redhat.com> Cc: Jeremy Cline <jcline@redhat.com> --- tests/kms_plane.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/kms_plane.c b/tests/kms_plane.c index 298a9375..c87983a4 100644 --- a/tests/kms_plane.c +++ b/tests/kms_plane.c @@ -817,9 +817,10 @@ enum crc_set { PACKED_CRC_SET, MAX_CRC_SET }; static bool test_format_plane(data_t *data, enum pipe pipe, - igt_output_t *output, igt_plane_t *plane) + igt_output_t *output, igt_plane_t *plane, igt_fb_t *primary_fb) { struct igt_fb fb = {}; + struct igt_fb *clear_fb = plane->type == DRM_PLANE_TYPE_PRIMARY ? primary_fb : NULL; drmModeModeInfo *mode; uint32_t format, ref_format; uint64_t modifier, ref_modifier; @@ -879,7 +880,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe, height = test_fb.height; } - igt_plane_set_fb(plane, NULL); + igt_plane_set_fb(plane, clear_fb); igt_remove_fb(data->drm_fd, &test_fb); } @@ -937,7 +938,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe, igt_pipe_crc_stop(data->pipe_crc); - igt_plane_set_fb(plane, NULL); + igt_plane_set_fb(plane, clear_fb); igt_remove_fb(data->drm_fd, &fb); return result; @@ -1010,7 +1011,7 @@ test_pixel_formats(data_t *data, enum pipe pipe) for_each_plane_on_pipe(&data->display, pipe, plane) { if (skip_plane(data, plane)) continue; - result &= test_format_plane(data, pipe, output, plane); + result &= test_format_plane(data, pipe, output, plane, &primary_fb); } test_fini(data); -- 2.29.2 _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when testing other planes @ 2021-03-17 22:44 ` Lyude 0 siblings, 0 replies; 12+ messages in thread From: Lyude @ 2021-03-17 22:44 UTC (permalink / raw) To: igt-dev, nouveau; +Cc: Martin Peres, Ben Skeggs From: Lyude Paul <lyude@redhat.com> Currently, nouveau doesn't support having a CRTC without a primary FB set. We won't reject such configurations, but the behavior is undefined which will cause CRCs to become undefined. So, avoid clearing the primary FB while we're testing non-primary planes. Signed-off-by: Lyude Paul <lyude@redhat.com> Cc: Martin Peres <martin.peres@free.fr> Cc: Ben Skeggs <bskeggs@redhat.com> Cc: Jeremy Cline <jcline@redhat.com> --- tests/kms_plane.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/kms_plane.c b/tests/kms_plane.c index 298a9375..c87983a4 100644 --- a/tests/kms_plane.c +++ b/tests/kms_plane.c @@ -817,9 +817,10 @@ enum crc_set { PACKED_CRC_SET, MAX_CRC_SET }; static bool test_format_plane(data_t *data, enum pipe pipe, - igt_output_t *output, igt_plane_t *plane) + igt_output_t *output, igt_plane_t *plane, igt_fb_t *primary_fb) { struct igt_fb fb = {}; + struct igt_fb *clear_fb = plane->type == DRM_PLANE_TYPE_PRIMARY ? primary_fb : NULL; drmModeModeInfo *mode; uint32_t format, ref_format; uint64_t modifier, ref_modifier; @@ -879,7 +880,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe, height = test_fb.height; } - igt_plane_set_fb(plane, NULL); + igt_plane_set_fb(plane, clear_fb); igt_remove_fb(data->drm_fd, &test_fb); } @@ -937,7 +938,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe, igt_pipe_crc_stop(data->pipe_crc); - igt_plane_set_fb(plane, NULL); + igt_plane_set_fb(plane, clear_fb); igt_remove_fb(data->drm_fd, &fb); return result; @@ -1010,7 +1011,7 @@ test_pixel_formats(data_t *data, enum pipe pipe) for_each_plane_on_pipe(&data->display, pipe, plane) { if (skip_plane(data, plane)) continue; - result &= test_format_plane(data, pipe, output, plane); + result &= test_format_plane(data, pipe, output, plane, &primary_fb); } test_fini(data); -- 2.29.2 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane: Don't unset primary_fb when testing other planes 2021-03-17 22:44 ` [igt-dev] " Lyude (?) @ 2021-03-18 0:41 ` Patchwork -1 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2021-03-18 0:41 UTC (permalink / raw) To: Lyude Paul; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 2805 bytes --] == Series Details == Series: tests/kms_plane: Don't unset primary_fb when testing other planes URL : https://patchwork.freedesktop.org/series/88078/ State : success == Summary == CI Bug Log - changes from IGT_6035 -> IGTPW_5614 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/index.html Known issues ------------ Here are the changes found in IGTPW_5614 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@query-info: - fi-bsw-kefka: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/fi-bsw-kefka/igt@amdgpu/amd_basic@query-info.html * igt@amdgpu/amd_prime@amd-to-i915: - fi-kbl-8809g: NOTRUN -> [DMESG-WARN][2] ([i915#2947]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/fi-kbl-8809g/igt@amdgpu/amd_prime@amd-to-i915.html * igt@runner@aborted: - fi-kbl-8809g: NOTRUN -> [FAIL][3] ([i915#2947]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/fi-kbl-8809g/igt@runner@aborted.html #### Possible fixes #### * igt@gem_tiled_fence_blits@basic: - fi-kbl-8809g: [TIMEOUT][4] ([i915#3145]) -> [PASS][5] [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/fi-kbl-8809g/igt@gem_tiled_fence_blits@basic.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/fi-kbl-8809g/igt@gem_tiled_fence_blits@basic.html * igt@i915_selftest@live@execlists: - fi-bsw-kefka: [INCOMPLETE][6] ([i915#2940]) -> [PASS][7] [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/fi-bsw-kefka/igt@i915_selftest@live@execlists.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/fi-bsw-kefka/igt@i915_selftest@live@execlists.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940 [i915#2947]: https://gitlab.freedesktop.org/drm/intel/issues/2947 [i915#3145]: https://gitlab.freedesktop.org/drm/intel/issues/3145 Participating hosts (46 -> 40) ------------------------------ Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-dg1-1 fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_6035 -> IGTPW_5614 CI-20190529: 20190529 CI_DRM_9867: 5f7383f6c1c95be9758792da71084f8f2c0c5953 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_5614: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/index.html IGT_6035: ad5eb02eb3f10a41d0f1feba7efc02db87cd06b8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/index.html [-- Attachment #1.2: Type: text/html, Size: 3588 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane: Don't unset primary_fb when testing other planes 2021-03-17 22:44 ` [igt-dev] " Lyude (?) (?) @ 2021-03-18 3:43 ` Patchwork -1 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2021-03-18 3:43 UTC (permalink / raw) To: Lyude Paul; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 30283 bytes --] == Series Details == Series: tests/kms_plane: Don't unset primary_fb when testing other planes URL : https://patchwork.freedesktop.org/series/88078/ State : success == Summary == CI Bug Log - changes from IGT_6035_full -> IGTPW_5614_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/index.html Known issues ------------ Here are the changes found in IGTPW_5614_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_create@create-massive: - shard-iclb: NOTRUN -> [DMESG-WARN][1] ([i915#3002]) +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb8/igt@gem_create@create-massive.html - shard-snb: NOTRUN -> [DMESG-WARN][2] ([i915#3002]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-snb5/igt@gem_create@create-massive.html * igt@gem_ctx_param@set-priority-not-supported: - shard-tglb: NOTRUN -> [SKIP][3] ([fdo#109314]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb5/igt@gem_ctx_param@set-priority-not-supported.html * igt@gem_ctx_persistence@engines-hostile-preempt: - shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +3 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-snb2/igt@gem_ctx_persistence@engines-hostile-preempt.html * igt@gem_eio@unwedge-stress: - shard-tglb: [PASS][5] -> [TIMEOUT][6] ([i915#2369] / [i915#3063]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-tglb7/igt@gem_eio@unwedge-stress.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb7/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-none@vecs0: - shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2842]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-kbl7/igt@gem_exec_fair@basic-none@vecs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-kbl7/igt@gem_exec_fair@basic-none@vecs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglb: [PASS][9] -> [FAIL][10] ([i915#2842]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-glk: [PASS][11] -> [FAIL][12] ([i915#2842]) +2 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-glk7/igt@gem_exec_fair@basic-pace-solo@rcs0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-glk1/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-iclb: [PASS][13] -> [FAIL][14] ([i915#2842]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb4/igt@gem_exec_fair@basic-pace@rcs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb1/igt@gem_exec_fair@basic-pace@rcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: NOTRUN -> [FAIL][15] ([i915#2842]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-glk3/igt@gem_exec_fair@basic-throttle@rcs0.html - shard-tglb: NOTRUN -> [FAIL][16] ([i915#2842]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb3/igt@gem_exec_fair@basic-throttle@rcs0.html - shard-iclb: [PASS][17] -> [FAIL][18] ([i915#2849]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb1/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_params@no-vebox: - shard-iclb: NOTRUN -> [SKIP][19] ([fdo#109283]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb4/igt@gem_exec_params@no-vebox.html - shard-tglb: NOTRUN -> [SKIP][20] ([fdo#109283]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb5/igt@gem_exec_params@no-vebox.html * igt@gem_exec_params@secure-non-master: - shard-tglb: NOTRUN -> [SKIP][21] ([fdo#112283]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb7/igt@gem_exec_params@secure-non-master.html - shard-iclb: NOTRUN -> [SKIP][22] ([fdo#112283]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb7/igt@gem_exec_params@secure-non-master.html * igt@gem_exec_reloc@basic-wide-active@bcs0: - shard-apl: NOTRUN -> [FAIL][23] ([i915#2389]) +3 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl6/igt@gem_exec_reloc@basic-wide-active@bcs0.html * igt@gem_exec_reloc@basic-wide-active@rcs0: - shard-snb: NOTRUN -> [FAIL][24] ([i915#2389]) +2 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-snb7/igt@gem_exec_reloc@basic-wide-active@rcs0.html * igt@gem_exec_reloc@basic-wide-active@vcs1: - shard-iclb: NOTRUN -> [FAIL][25] ([i915#2389]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb2/igt@gem_exec_reloc@basic-wide-active@vcs1.html * igt@gem_huc_copy@huc-copy: - shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#2190]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl3/igt@gem_huc_copy@huc-copy.html - shard-glk: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#2190]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-glk7/igt@gem_huc_copy@huc-copy.html - shard-iclb: NOTRUN -> [SKIP][28] ([i915#2190]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb4/igt@gem_huc_copy@huc-copy.html - shard-kbl: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#2190]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-kbl6/igt@gem_huc_copy@huc-copy.html * igt@gem_mmap_gtt@coherency: - shard-tglb: NOTRUN -> [SKIP][30] ([fdo#111656]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb8/igt@gem_mmap_gtt@coherency.html * igt@gem_pwrite@basic-exhaustion: - shard-apl: NOTRUN -> [WARN][31] ([i915#2658]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl2/igt@gem_pwrite@basic-exhaustion.html * igt@gem_render_copy@y-tiled-mc-ccs-to-y-tiled-ccs: - shard-iclb: NOTRUN -> [SKIP][32] ([i915#768]) +2 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb2/igt@gem_render_copy@y-tiled-mc-ccs-to-y-tiled-ccs.html * igt@gem_userptr_blits@input-checking: - shard-tglb: NOTRUN -> [DMESG-WARN][33] ([i915#3002]) +1 similar issue [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb5/igt@gem_userptr_blits@input-checking.html - shard-apl: NOTRUN -> [DMESG-WARN][34] ([i915#3002]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl3/igt@gem_userptr_blits@input-checking.html - shard-glk: NOTRUN -> [DMESG-WARN][35] ([i915#3002]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-glk8/igt@gem_userptr_blits@input-checking.html - shard-kbl: NOTRUN -> [DMESG-WARN][36] ([i915#3002]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-kbl6/igt@gem_userptr_blits@input-checking.html * igt@gem_workarounds@suspend-resume-context: - shard-apl: NOTRUN -> [DMESG-WARN][37] ([i915#180]) +1 similar issue [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl3/igt@gem_workarounds@suspend-resume-context.html * igt@gen3_mixed_blits: - shard-tglb: NOTRUN -> [SKIP][38] ([fdo#109289]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb8/igt@gen3_mixed_blits.html * igt@gen9_exec_parse@basic-rejected-ctx-param: - shard-tglb: NOTRUN -> [SKIP][39] ([fdo#112306]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb1/igt@gen9_exec_parse@basic-rejected-ctx-param.html - shard-iclb: NOTRUN -> [SKIP][40] ([fdo#112306]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb3/igt@gen9_exec_parse@basic-rejected-ctx-param.html * igt@gen9_exec_parse@bb-oversize: - shard-tglb: NOTRUN -> [SKIP][41] ([i915#2527]) +1 similar issue [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb5/igt@gen9_exec_parse@bb-oversize.html - shard-iclb: NOTRUN -> [SKIP][42] ([i915#2527]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb5/igt@gen9_exec_parse@bb-oversize.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [PASS][43] -> [FAIL][44] ([i915#454]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb3/igt@i915_pm_dc@dc6-psr.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb6/igt@i915_pm_dc@dc6-psr.html * igt@i915_selftest@live@hangcheck: - shard-snb: NOTRUN -> [INCOMPLETE][45] ([i915#2782]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-snb2/igt@i915_selftest@live@hangcheck.html * igt@kms_big_fb@linear-16bpp-rotate-90: - shard-apl: NOTRUN -> [SKIP][46] ([fdo#109271]) +219 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl3/igt@kms_big_fb@linear-16bpp-rotate-90.html * igt@kms_big_fb@x-tiled-32bpp-rotate-90: - shard-tglb: NOTRUN -> [SKIP][47] ([fdo#111614]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb8/igt@kms_big_fb@x-tiled-32bpp-rotate-90.html * igt@kms_big_fb@yf-tiled-16bpp-rotate-90: - shard-tglb: NOTRUN -> [SKIP][48] ([fdo#111615]) +3 similar issues [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb3/igt@kms_big_fb@yf-tiled-16bpp-rotate-90.html * igt@kms_big_joiner@invalid-modeset: - shard-apl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#2705]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl1/igt@kms_big_joiner@invalid-modeset.html * igt@kms_chamelium@dp-edid-change-during-suspend: - shard-apl: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +21 similar issues [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl6/igt@kms_chamelium@dp-edid-change-during-suspend.html * igt@kms_chamelium@hdmi-mode-timings: - shard-snb: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +23 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-snb7/igt@kms_chamelium@hdmi-mode-timings.html * igt@kms_color_chamelium@pipe-a-ctm-0-75: - shard-kbl: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +6 similar issues [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-kbl6/igt@kms_color_chamelium@pipe-a-ctm-0-75.html * igt@kms_color_chamelium@pipe-a-ctm-limited-range: - shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109284] / [fdo#111827]) +3 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb7/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html * igt@kms_color_chamelium@pipe-d-ctm-0-75: - shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109278] / [fdo#109284] / [fdo#111827]) +1 similar issue [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb2/igt@kms_color_chamelium@pipe-d-ctm-0-75.html * igt@kms_color_chamelium@pipe-d-degamma: - shard-glk: NOTRUN -> [SKIP][55] ([fdo#109271] / [fdo#111827]) +9 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-glk7/igt@kms_color_chamelium@pipe-d-degamma.html - shard-tglb: NOTRUN -> [SKIP][56] ([fdo#109284] / [fdo#111827]) +10 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb7/igt@kms_color_chamelium@pipe-d-degamma.html * igt@kms_content_protection@atomic-dpms: - shard-tglb: NOTRUN -> [SKIP][57] ([fdo#111828]) +1 similar issue [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb8/igt@kms_content_protection@atomic-dpms.html * igt@kms_content_protection@lic: - shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109300] / [fdo#111066]) +1 similar issue [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb3/igt@kms_content_protection@lic.html - shard-kbl: NOTRUN -> [TIMEOUT][59] ([i915#1319]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-kbl1/igt@kms_content_protection@lic.html * igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen: - shard-kbl: [PASS][60] -> [FAIL][61] ([i915#54]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html - shard-apl: [PASS][62] -> [FAIL][63] ([i915#54]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl7/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-apl: [PASS][64] -> [DMESG-WARN][65] ([i915#180]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-apl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen: - shard-iclb: NOTRUN -> [SKIP][66] ([fdo#109278] / [fdo#109279]) +1 similar issue [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb4/igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen.html * igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement: - shard-tglb: NOTRUN -> [SKIP][67] ([fdo#109279]) +3 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb3/igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement.html * igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge: - shard-snb: NOTRUN -> [SKIP][68] ([fdo#109271]) +397 similar issues [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-snb7/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html * igt@kms_cursor_legacy@cursorb-vs-flipb-toggle: - shard-iclb: NOTRUN -> [SKIP][69] ([fdo#109274] / [fdo#109278]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb1/igt@kms_cursor_legacy@cursorb-vs-flipb-toggle.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic: - shard-tglb: [PASS][70] -> [FAIL][71] ([i915#2346]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-tglb8/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb3/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-iclb: NOTRUN -> [FAIL][72] ([i915#2346]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html - shard-glk: NOTRUN -> [FAIL][73] ([i915#2346] / [i915#533]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic: - shard-apl: NOTRUN -> [DMESG-FAIL][74] ([IGT#6]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl8/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html * igt@kms_dp_tiled_display@basic-test-pattern: - shard-iclb: NOTRUN -> [SKIP][75] ([i915#426]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb2/igt@kms_dp_tiled_display@basic-test-pattern.html - shard-tglb: NOTRUN -> [SKIP][76] ([i915#426]) [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb5/igt@kms_dp_tiled_display@basic-test-pattern.html * igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset: - shard-iclb: NOTRUN -> [SKIP][77] ([fdo#109274]) +1 similar issue [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb5/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset.html * igt@kms_flip@flip-vs-expired-vblank@a-edp1: - shard-tglb: [PASS][78] -> [FAIL][79] ([i915#2598]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-tglb7/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [PASS][80] -> [DMESG-WARN][81] ([i915#180]) +5 similar issues [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile: - shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#2642]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile: - shard-apl: NOTRUN -> [FAIL][83] ([i915#2641]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl8/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html * igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt: - shard-iclb: NOTRUN -> [SKIP][84] ([fdo#109280]) +13 similar issues [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu: - shard-kbl: NOTRUN -> [SKIP][85] ([fdo#109271]) +69 similar issues [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-kbl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-cpu: - shard-tglb: NOTRUN -> [SKIP][86] ([fdo#111825]) +27 similar issues [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-cpu.html * igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu: - shard-glk: NOTRUN -> [SKIP][87] ([fdo#109271]) +68 similar issues [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-glk6/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html * igt@kms_hdr@bpc-switch-suspend: - shard-iclb: [PASS][88] -> [INCOMPLETE][89] ([i915#1185] / [i915#1373] / [i915#2828]) [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb3/igt@kms_hdr@bpc-switch-suspend.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb3/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_hdr@static-toggle: - shard-iclb: NOTRUN -> [SKIP][90] ([i915#1187]) [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb8/igt@kms_hdr@static-toggle.html - shard-tglb: NOTRUN -> [SKIP][91] ([i915#1187]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb3/igt@kms_hdr@static-toggle.html * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb: - shard-apl: NOTRUN -> [FAIL][92] ([fdo#108145] / [i915#265]) +3 similar issues [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb: - shard-apl: NOTRUN -> [FAIL][93] ([i915#265]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl1/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-c-alpha-7efc: - shard-kbl: NOTRUN -> [FAIL][94] ([fdo#108145] / [i915#265]) [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-kbl4/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max: - shard-glk: NOTRUN -> [FAIL][95] ([fdo#108145] / [i915#265]) [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-glk7/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html * igt@kms_plane_cursor@pipe-d-overlay-size-256: - shard-iclb: NOTRUN -> [SKIP][96] ([fdo#109278]) +11 similar issues [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb3/igt@kms_plane_cursor@pipe-d-overlay-size-256.html * igt@kms_plane_lowres@pipe-d-tiling-yf: - shard-tglb: NOTRUN -> [SKIP][97] ([fdo#112054]) [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb7/igt@kms_plane_lowres@pipe-d-tiling-yf.html * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping: - shard-apl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#2733]) [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl3/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4: - shard-kbl: NOTRUN -> [SKIP][99] ([fdo#109271] / [i915#658]) [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-kbl4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4: - shard-apl: NOTRUN -> [SKIP][100] ([fdo#109271] / [i915#658]) +5 similar issues [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html * igt@kms_psr2_su@page_flip: - shard-glk: NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#658]) +2 similar issues [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-glk3/igt@kms_psr2_su@page_flip.html - shard-iclb: [PASS][102] -> [SKIP][103] ([fdo#109642] / [fdo#111068] / [i915#658]) [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb2/igt@kms_psr2_su@page_flip.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb1/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_primary_blt: - shard-iclb: NOTRUN -> [SKIP][104] ([fdo#109441]) +1 similar issue [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb6/igt@kms_psr@psr2_primary_blt.html * igt@kms_psr@psr2_suspend: - shard-iclb: [PASS][105] -> [SKIP][106] ([fdo#109441]) +1 similar issue [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb2/igt@kms_psr@psr2_suspend.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb8/igt@kms_psr@psr2_suspend.html * igt@kms_setmode@basic: - shard-snb: NOTRUN -> [FAIL][107] ([i915#31]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-snb6/igt@kms_setmode@basic.html * igt@nouveau_crc@pipe-d-ctx-flip-detection: - shard-tglb: NOTRUN -> [SKIP][108] ([i915#2530]) +1 similar issue [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb3/igt@nouveau_crc@pipe-d-ctx-flip-detection.html - shard-iclb: NOTRUN -> [SKIP][109] ([fdo#109278] / [i915#2530]) [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb7/igt@nouveau_crc@pipe-d-ctx-flip-detection.html * igt@prime_nv_pcopy@test3_2: - shard-tglb: NOTRUN -> [SKIP][110] ([fdo#109291]) +5 similar issues [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb1/igt@prime_nv_pcopy@test3_2.html * igt@prime_nv_test@nv_i915_sharing: - shard-iclb: NOTRUN -> [SKIP][111] ([fdo#109291]) +3 similar issues [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb6/igt@prime_nv_test@nv_i915_sharing.html * igt@sysfs_clients@recycle-many: - shard-snb: NOTRUN -> [FAIL][112] ([i915#3028]) [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-snb6/igt@sysfs_clients@recycle-many.html * igt@sysfs_clients@sema-10@vcs0: - shard-apl: NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#3026]) +2 similar issues [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl1/igt@sysfs_clients@sema-10@vcs0.html * igt@sysfs_clients@split-10@bcs0: - shard-glk: [PASS][114] -> [SKIP][115] ([fdo#109271] / [i915#3026]) [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-glk4/igt@sysfs_clients@split-10@bcs0.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-glk8/igt@sysfs_clients@split-10@bcs0.html - shard-apl: [PASS][116] -> [SKIP][117] ([fdo#109271] / [i915#3026]) [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-apl1/igt@sysfs_clients@split-10@bcs0.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-apl3/igt@sysfs_clients@split-10@bcs0.html #### Possible fixes #### * igt@gem_exec_balancer@hang: - shard-iclb: [INCOMPLETE][118] ([i915#1895] / [i915#3031]) -> [PASS][119] [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb4/igt@gem_exec_balancer@hang.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-iclb3/igt@gem_exec_balancer@hang.html * igt@gem_exec_fair@basic-none@vcs0: - shard-glk: [FAIL][120] ([i915#2842]) -> [PASS][121] [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-glk3/igt@gem_exec_fair@basic-none@vcs0.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-glk6/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-kbl: [FAIL][122] ([i915#2851]) -> [PASS][123] [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-kbl3/igt@gem_exec_fair@basic-pace@rcs0.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-kbl7/igt@gem_exec_fair@basic-pace@rcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-tglb: [FAIL][124] ([i915#2842]) -> [PASS][125] [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-tglb7/igt@gem_exec_fair@basic-pace@vcs1.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb1/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_exec_reloc@basic-many-active@rcs0: - shard-glk: [FAIL][126] ([i915#2389]) -> [PASS][127] [126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-glk8/igt@gem_exec_reloc@basic-many-active@rcs0.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-glk2/igt@gem_exec_reloc@basic-many-active@rcs0.html * igt@gem_exec_schedule@u-fairslice@rcs0: - shard-glk: [DMESG-WARN][128] ([i915#1610] / [i915#2803]) -> [PASS][129] [128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-glk3/igt@gem_exec_schedule@u-fairslice@rcs0.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-glk8/igt@gem_exec_schedule@u-fairslice@rcs0.html - shard-tglb: [DMESG-WARN][130] ([i915#2803]) -> [PASS][131] [130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-tglb3/igt@gem_exec_schedule@u-fairslice@rcs0.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb7/igt@gem_exec_schedule@u-fairslice@rcs0.html * igt@gem_vm_create@destroy-race: - shard-tglb: [TIMEOUT][132] ([i915#2795]) -> [PASS][133] [132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-tglb7/igt@gem_vm_create@destroy-race.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb5/igt@gem_vm_create@destroy-race.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [INCOMPLETE][134] ([i915#155]) -> [PASS][135] [134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_legacy@flip-vs-cursor-varying-size: - shard-tglb: [FAIL][136] ([i915#2346]) -> [PASS][137] [136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-tglb1/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-tglb1/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html * igt@kms_flip@flip-vs-suspend@c-dp1: - shard-kbl: [DMESG-WARN][138] ([i915#180]) -> [PASS][139] +2 similar issues [138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-kbl7/igt@kms_flip@flip-vs-suspend@c-dp1.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-kbl4/igt@kms_flip@flip-vs-suspend@c-dp1.html * igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a1: - shard-glk: [FAIL][140] ([i915#2122]) -> [PASS][141] [140]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-glk2/igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a1.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-glk6/igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a1.html * igt@kms_frontbuffer_tracking@fbc-stridechange: - shard-glk: [FAIL][142] ([i915#49]) -> [PASS][143] [142]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-glk5/igt@kms_frontbuffer_tracking@fbc-stridechange.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shard-glk8/igt@kms_frontbuffer_tracking@fbc-stridechange.html - shard-apl: [FAIL][144] ([i915#49]) -> [PASS][145] [144]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-apl1/igt@kms_frontbuffer_tracking@fbc-stridechange.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/index.html [-- Attachment #1.2: Type: text/html, Size: 33819 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when testing other planes 2021-03-17 22:44 ` [igt-dev] " Lyude @ 2021-03-18 6:41 ` Martin Peres -1 siblings, 0 replies; 12+ messages in thread From: Martin Peres @ 2021-03-18 6:41 UTC (permalink / raw) To: Lyude, igt-dev, nouveau; +Cc: Ben Skeggs On 18/03/2021 00:44, Lyude wrote: > From: Lyude Paul <lyude@redhat.com> > > Currently, nouveau doesn't support having a CRTC without a primary FB set. We > won't reject such configurations, but the behavior is undefined which will cause > CRCs to become undefined. So, avoid clearing the primary FB while we're testing > non-primary planes. Looks good to me: Reviewed-by: Martin Peres <martin.peres@mupuf.org> > > Signed-off-by: Lyude Paul <lyude@redhat.com> > Cc: Martin Peres <martin.peres@free.fr> > Cc: Ben Skeggs <bskeggs@redhat.com> > Cc: Jeremy Cline <jcline@redhat.com> > --- > tests/kms_plane.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/tests/kms_plane.c b/tests/kms_plane.c > index 298a9375..c87983a4 100644 > --- a/tests/kms_plane.c > +++ b/tests/kms_plane.c > @@ -817,9 +817,10 @@ enum crc_set { PACKED_CRC_SET, > MAX_CRC_SET }; > > static bool test_format_plane(data_t *data, enum pipe pipe, > - igt_output_t *output, igt_plane_t *plane) > + igt_output_t *output, igt_plane_t *plane, igt_fb_t *primary_fb) > { > struct igt_fb fb = {}; > + struct igt_fb *clear_fb = plane->type == DRM_PLANE_TYPE_PRIMARY ? primary_fb : NULL; > drmModeModeInfo *mode; > uint32_t format, ref_format; > uint64_t modifier, ref_modifier; > @@ -879,7 +880,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe, > height = test_fb.height; > } > > - igt_plane_set_fb(plane, NULL); > + igt_plane_set_fb(plane, clear_fb); > > igt_remove_fb(data->drm_fd, &test_fb); > } > @@ -937,7 +938,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe, > > igt_pipe_crc_stop(data->pipe_crc); > > - igt_plane_set_fb(plane, NULL); > + igt_plane_set_fb(plane, clear_fb); > igt_remove_fb(data->drm_fd, &fb); > > return result; > @@ -1010,7 +1011,7 @@ test_pixel_formats(data_t *data, enum pipe pipe) > for_each_plane_on_pipe(&data->display, pipe, plane) { > if (skip_plane(data, plane)) > continue; > - result &= test_format_plane(data, pipe, output, plane); > + result &= test_format_plane(data, pipe, output, plane, &primary_fb); > } > > test_fini(data); > _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when testing other planes @ 2021-03-18 6:41 ` Martin Peres 0 siblings, 0 replies; 12+ messages in thread From: Martin Peres @ 2021-03-18 6:41 UTC (permalink / raw) To: Lyude, igt-dev, nouveau; +Cc: Martin Peres, Ben Skeggs On 18/03/2021 00:44, Lyude wrote: > From: Lyude Paul <lyude@redhat.com> > > Currently, nouveau doesn't support having a CRTC without a primary FB set. We > won't reject such configurations, but the behavior is undefined which will cause > CRCs to become undefined. So, avoid clearing the primary FB while we're testing > non-primary planes. Looks good to me: Reviewed-by: Martin Peres <martin.peres@mupuf.org> > > Signed-off-by: Lyude Paul <lyude@redhat.com> > Cc: Martin Peres <martin.peres@free.fr> > Cc: Ben Skeggs <bskeggs@redhat.com> > Cc: Jeremy Cline <jcline@redhat.com> > --- > tests/kms_plane.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/tests/kms_plane.c b/tests/kms_plane.c > index 298a9375..c87983a4 100644 > --- a/tests/kms_plane.c > +++ b/tests/kms_plane.c > @@ -817,9 +817,10 @@ enum crc_set { PACKED_CRC_SET, > MAX_CRC_SET }; > > static bool test_format_plane(data_t *data, enum pipe pipe, > - igt_output_t *output, igt_plane_t *plane) > + igt_output_t *output, igt_plane_t *plane, igt_fb_t *primary_fb) > { > struct igt_fb fb = {}; > + struct igt_fb *clear_fb = plane->type == DRM_PLANE_TYPE_PRIMARY ? primary_fb : NULL; > drmModeModeInfo *mode; > uint32_t format, ref_format; > uint64_t modifier, ref_modifier; > @@ -879,7 +880,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe, > height = test_fb.height; > } > > - igt_plane_set_fb(plane, NULL); > + igt_plane_set_fb(plane, clear_fb); > > igt_remove_fb(data->drm_fd, &test_fb); > } > @@ -937,7 +938,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe, > > igt_pipe_crc_stop(data->pipe_crc); > > - igt_plane_set_fb(plane, NULL); > + igt_plane_set_fb(plane, clear_fb); > igt_remove_fb(data->drm_fd, &fb); > > return result; > @@ -1010,7 +1011,7 @@ test_pixel_formats(data_t *data, enum pipe pipe) > for_each_plane_on_pipe(&data->display, pipe, plane) { > if (skip_plane(data, plane)) > continue; > - result &= test_format_plane(data, pipe, output, plane); > + result &= test_format_plane(data, pipe, output, plane, &primary_fb); > } > > test_fini(data); > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when testing other planes 2021-03-18 6:41 ` Martin Peres @ 2021-03-21 20:02 ` Juha-Pekka Heikkila -1 siblings, 0 replies; 12+ messages in thread From: Juha-Pekka Heikkila @ 2021-03-21 20:02 UTC (permalink / raw) To: Martin Peres, Lyude, igt-dev, nouveau; +Cc: Lisovskiy, Stanislav, Ben Skeggs On 18.3.2021 8.41, Martin Peres wrote: > On 18/03/2021 00:44, Lyude wrote: >> From: Lyude Paul <lyude@redhat.com> >> >> Currently, nouveau doesn't support having a CRTC without a primary FB >> set. We >> won't reject such configurations, but the behavior is undefined which >> will cause >> CRCs to become undefined. So, avoid clearing the primary FB while >> we're testing >> non-primary planes. > > Looks good to me: > > Reviewed-by: Martin Peres <martin.peres@mupuf.org> > This doesn't look good at all. Code changes were never run on ci, see this: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shards-all.html?testfilter=kms_plane@pixel-format This happen because of: igt-gpu-tools$ git blame tests/intel-ci/blacklist-pre-merge.txt -L 173,+1 3e686098d9 (Martin Peres 2020-02-21 11:00:47 +0200 173) igt@kms_plane@pixel-format-pipe-[a-d]-planes(-source-clamping)? You'll need to include something like this to test and review what did change on pixel format tests: https://patchwork.freedesktop.org/patch/404706/?series=84370&rev=1 but as this patch seems to be already merged as untested we now have pixel format tests failing reliably ever since: https://intel-gfx-ci.01.org/tree/drm-tip/index.html?testfilter=kms_plane@pixel-format&hosts=tgl%7Cicl I have only intel icl at hand so I have no suggestions for fix. Though, looking at those failures Stan (CCd) may have some interest on them. /Juha-Pekka >> >> Signed-off-by: Lyude Paul <lyude@redhat.com> >> Cc: Martin Peres <martin.peres@free.fr> >> Cc: Ben Skeggs <bskeggs@redhat.com> >> Cc: Jeremy Cline <jcline@redhat.com> >> --- >> tests/kms_plane.c | 9 +++++---- >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/tests/kms_plane.c b/tests/kms_plane.c >> index 298a9375..c87983a4 100644 >> --- a/tests/kms_plane.c >> +++ b/tests/kms_plane.c >> @@ -817,9 +817,10 @@ enum crc_set { PACKED_CRC_SET, >> MAX_CRC_SET }; >> static bool test_format_plane(data_t *data, enum pipe pipe, >> - igt_output_t *output, igt_plane_t *plane) >> + igt_output_t *output, igt_plane_t *plane, igt_fb_t >> *primary_fb) >> { >> struct igt_fb fb = {}; >> + struct igt_fb *clear_fb = plane->type == DRM_PLANE_TYPE_PRIMARY ? >> primary_fb : NULL; >> drmModeModeInfo *mode; >> uint32_t format, ref_format; >> uint64_t modifier, ref_modifier; >> @@ -879,7 +880,7 @@ static bool test_format_plane(data_t *data, enum >> pipe pipe, >> height = test_fb.height; >> } >> - igt_plane_set_fb(plane, NULL); >> + igt_plane_set_fb(plane, clear_fb); >> igt_remove_fb(data->drm_fd, &test_fb); >> } >> @@ -937,7 +938,7 @@ static bool test_format_plane(data_t *data, enum >> pipe pipe, >> igt_pipe_crc_stop(data->pipe_crc); >> - igt_plane_set_fb(plane, NULL); >> + igt_plane_set_fb(plane, clear_fb); >> igt_remove_fb(data->drm_fd, &fb); >> return result; >> @@ -1010,7 +1011,7 @@ test_pixel_formats(data_t *data, enum pipe pipe) >> for_each_plane_on_pipe(&data->display, pipe, plane) { >> if (skip_plane(data, plane)) >> continue; >> - result &= test_format_plane(data, pipe, output, plane); >> + result &= test_format_plane(data, pipe, output, plane, >> &primary_fb); >> } >> test_fini(data); >> > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when testing other planes @ 2021-03-21 20:02 ` Juha-Pekka Heikkila 0 siblings, 0 replies; 12+ messages in thread From: Juha-Pekka Heikkila @ 2021-03-21 20:02 UTC (permalink / raw) To: Martin Peres, Lyude, igt-dev, nouveau; +Cc: Martin Peres, Ben Skeggs On 18.3.2021 8.41, Martin Peres wrote: > On 18/03/2021 00:44, Lyude wrote: >> From: Lyude Paul <lyude@redhat.com> >> >> Currently, nouveau doesn't support having a CRTC without a primary FB >> set. We >> won't reject such configurations, but the behavior is undefined which >> will cause >> CRCs to become undefined. So, avoid clearing the primary FB while >> we're testing >> non-primary planes. > > Looks good to me: > > Reviewed-by: Martin Peres <martin.peres@mupuf.org> > This doesn't look good at all. Code changes were never run on ci, see this: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shards-all.html?testfilter=kms_plane@pixel-format This happen because of: igt-gpu-tools$ git blame tests/intel-ci/blacklist-pre-merge.txt -L 173,+1 3e686098d9 (Martin Peres 2020-02-21 11:00:47 +0200 173) igt@kms_plane@pixel-format-pipe-[a-d]-planes(-source-clamping)? You'll need to include something like this to test and review what did change on pixel format tests: https://patchwork.freedesktop.org/patch/404706/?series=84370&rev=1 but as this patch seems to be already merged as untested we now have pixel format tests failing reliably ever since: https://intel-gfx-ci.01.org/tree/drm-tip/index.html?testfilter=kms_plane@pixel-format&hosts=tgl%7Cicl I have only intel icl at hand so I have no suggestions for fix. Though, looking at those failures Stan (CCd) may have some interest on them. /Juha-Pekka >> >> Signed-off-by: Lyude Paul <lyude@redhat.com> >> Cc: Martin Peres <martin.peres@free.fr> >> Cc: Ben Skeggs <bskeggs@redhat.com> >> Cc: Jeremy Cline <jcline@redhat.com> >> --- >> tests/kms_plane.c | 9 +++++---- >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/tests/kms_plane.c b/tests/kms_plane.c >> index 298a9375..c87983a4 100644 >> --- a/tests/kms_plane.c >> +++ b/tests/kms_plane.c >> @@ -817,9 +817,10 @@ enum crc_set { PACKED_CRC_SET, >> MAX_CRC_SET }; >> static bool test_format_plane(data_t *data, enum pipe pipe, >> - igt_output_t *output, igt_plane_t *plane) >> + igt_output_t *output, igt_plane_t *plane, igt_fb_t >> *primary_fb) >> { >> struct igt_fb fb = {}; >> + struct igt_fb *clear_fb = plane->type == DRM_PLANE_TYPE_PRIMARY ? >> primary_fb : NULL; >> drmModeModeInfo *mode; >> uint32_t format, ref_format; >> uint64_t modifier, ref_modifier; >> @@ -879,7 +880,7 @@ static bool test_format_plane(data_t *data, enum >> pipe pipe, >> height = test_fb.height; >> } >> - igt_plane_set_fb(plane, NULL); >> + igt_plane_set_fb(plane, clear_fb); >> igt_remove_fb(data->drm_fd, &test_fb); >> } >> @@ -937,7 +938,7 @@ static bool test_format_plane(data_t *data, enum >> pipe pipe, >> igt_pipe_crc_stop(data->pipe_crc); >> - igt_plane_set_fb(plane, NULL); >> + igt_plane_set_fb(plane, clear_fb); >> igt_remove_fb(data->drm_fd, &fb); >> return result; >> @@ -1010,7 +1011,7 @@ test_pixel_formats(data_t *data, enum pipe pipe) >> for_each_plane_on_pipe(&data->display, pipe, plane) { >> if (skip_plane(data, plane)) >> continue; >> - result &= test_format_plane(data, pipe, output, plane); >> + result &= test_format_plane(data, pipe, output, plane, >> &primary_fb); >> } >> test_fini(data); >> > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when testing other planes 2021-03-21 20:02 ` Juha-Pekka Heikkila @ 2021-03-22 6:53 ` Martin Peres -1 siblings, 0 replies; 12+ messages in thread From: Martin Peres @ 2021-03-22 6:53 UTC (permalink / raw) To: juhapekka.heikkila, Lyude, igt-dev, nouveau Cc: Lisovskiy, Stanislav, Ben Skeggs On 21/03/2021 22:02, Juha-Pekka Heikkila wrote: > On 18.3.2021 8.41, Martin Peres wrote: >> On 18/03/2021 00:44, Lyude wrote: >>> From: Lyude Paul <lyude@redhat.com> >>> >>> Currently, nouveau doesn't support having a CRTC without a primary FB >>> set. We >>> won't reject such configurations, but the behavior is undefined which >>> will cause >>> CRCs to become undefined. So, avoid clearing the primary FB while >>> we're testing >>> non-primary planes. >> >> Looks good to me: >> >> Reviewed-by: Martin Peres <martin.peres@mupuf.org> >> > > This doesn't look good at all. Code changes were never run on ci, see this: > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shards-all.html?testfilter=kms_plane@pixel-format > > > This happen because of: > igt-gpu-tools$ git blame tests/intel-ci/blacklist-pre-merge.txt -L 173,+1 > 3e686098d9 (Martin Peres 2020-02-21 11:00:47 +0200 173) > igt@kms_plane@pixel-format-pipe-[a-d]-planes(-source-clamping)? Killed by my own creation, isn't it quaint? Thanks a lot for investigating the regression, and I'll be wearing my brown bag today :s > > You'll need to include something like this to test and review what did > change on pixel format tests: > https://patchwork.freedesktop.org/patch/404706/?series=84370&rev=1 > > but as this patch seems to be already merged as untested we now have > pixel format tests failing reliably ever since: > https://intel-gfx-ci.01.org/tree/drm-tip/index.html?testfilter=kms_plane@pixel-format&hosts=tgl%7Cicl > > > I have only intel icl at hand so I have no suggestions for fix. Though, > looking at those failures Stan (CCd) may have some interest on them. I would indeed like to hear if this sounds like a kernel bug, a violation of the KMS spec, or the spec is not clear-enough on this. If I don't hear back on this today, I'll send a revert while the situation is investigated. Martin > > /Juha-Pekka > >>> >>> Signed-off-by: Lyude Paul <lyude@redhat.com> >>> Cc: Martin Peres <martin.peres@free.fr> >>> Cc: Ben Skeggs <bskeggs@redhat.com> >>> Cc: Jeremy Cline <jcline@redhat.com> >>> --- >>> tests/kms_plane.c | 9 +++++---- >>> 1 file changed, 5 insertions(+), 4 deletions(-) >>> >>> diff --git a/tests/kms_plane.c b/tests/kms_plane.c >>> index 298a9375..c87983a4 100644 >>> --- a/tests/kms_plane.c >>> +++ b/tests/kms_plane.c >>> @@ -817,9 +817,10 @@ enum crc_set { PACKED_CRC_SET, >>> MAX_CRC_SET }; >>> static bool test_format_plane(data_t *data, enum pipe pipe, >>> - igt_output_t *output, igt_plane_t *plane) >>> + igt_output_t *output, igt_plane_t *plane, igt_fb_t >>> *primary_fb) >>> { >>> struct igt_fb fb = {}; >>> + struct igt_fb *clear_fb = plane->type == DRM_PLANE_TYPE_PRIMARY >>> ? primary_fb : NULL; >>> drmModeModeInfo *mode; >>> uint32_t format, ref_format; >>> uint64_t modifier, ref_modifier; >>> @@ -879,7 +880,7 @@ static bool test_format_plane(data_t *data, enum >>> pipe pipe, >>> height = test_fb.height; >>> } >>> - igt_plane_set_fb(plane, NULL); >>> + igt_plane_set_fb(plane, clear_fb); >>> igt_remove_fb(data->drm_fd, &test_fb); >>> } >>> @@ -937,7 +938,7 @@ static bool test_format_plane(data_t *data, enum >>> pipe pipe, >>> igt_pipe_crc_stop(data->pipe_crc); >>> - igt_plane_set_fb(plane, NULL); >>> + igt_plane_set_fb(plane, clear_fb); >>> igt_remove_fb(data->drm_fd, &fb); >>> return result; >>> @@ -1010,7 +1011,7 @@ test_pixel_formats(data_t *data, enum pipe pipe) >>> for_each_plane_on_pipe(&data->display, pipe, plane) { >>> if (skip_plane(data, plane)) >>> continue; >>> - result &= test_format_plane(data, pipe, output, plane); >>> + result &= test_format_plane(data, pipe, output, plane, >>> &primary_fb); >>> } >>> test_fini(data); >>> >> _______________________________________________ >> igt-dev mailing list >> igt-dev@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/igt-dev > _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when testing other planes @ 2021-03-22 6:53 ` Martin Peres 0 siblings, 0 replies; 12+ messages in thread From: Martin Peres @ 2021-03-22 6:53 UTC (permalink / raw) To: juhapekka.heikkila, Lyude, igt-dev, nouveau; +Cc: Martin Peres, Ben Skeggs On 21/03/2021 22:02, Juha-Pekka Heikkila wrote: > On 18.3.2021 8.41, Martin Peres wrote: >> On 18/03/2021 00:44, Lyude wrote: >>> From: Lyude Paul <lyude@redhat.com> >>> >>> Currently, nouveau doesn't support having a CRTC without a primary FB >>> set. We >>> won't reject such configurations, but the behavior is undefined which >>> will cause >>> CRCs to become undefined. So, avoid clearing the primary FB while >>> we're testing >>> non-primary planes. >> >> Looks good to me: >> >> Reviewed-by: Martin Peres <martin.peres@mupuf.org> >> > > This doesn't look good at all. Code changes were never run on ci, see this: > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shards-all.html?testfilter=kms_plane@pixel-format > > > This happen because of: > igt-gpu-tools$ git blame tests/intel-ci/blacklist-pre-merge.txt -L 173,+1 > 3e686098d9 (Martin Peres 2020-02-21 11:00:47 +0200 173) > igt@kms_plane@pixel-format-pipe-[a-d]-planes(-source-clamping)? Killed by my own creation, isn't it quaint? Thanks a lot for investigating the regression, and I'll be wearing my brown bag today :s > > You'll need to include something like this to test and review what did > change on pixel format tests: > https://patchwork.freedesktop.org/patch/404706/?series=84370&rev=1 > > but as this patch seems to be already merged as untested we now have > pixel format tests failing reliably ever since: > https://intel-gfx-ci.01.org/tree/drm-tip/index.html?testfilter=kms_plane@pixel-format&hosts=tgl%7Cicl > > > I have only intel icl at hand so I have no suggestions for fix. Though, > looking at those failures Stan (CCd) may have some interest on them. I would indeed like to hear if this sounds like a kernel bug, a violation of the KMS spec, or the spec is not clear-enough on this. If I don't hear back on this today, I'll send a revert while the situation is investigated. Martin > > /Juha-Pekka > >>> >>> Signed-off-by: Lyude Paul <lyude@redhat.com> >>> Cc: Martin Peres <martin.peres@free.fr> >>> Cc: Ben Skeggs <bskeggs@redhat.com> >>> Cc: Jeremy Cline <jcline@redhat.com> >>> --- >>> tests/kms_plane.c | 9 +++++---- >>> 1 file changed, 5 insertions(+), 4 deletions(-) >>> >>> diff --git a/tests/kms_plane.c b/tests/kms_plane.c >>> index 298a9375..c87983a4 100644 >>> --- a/tests/kms_plane.c >>> +++ b/tests/kms_plane.c >>> @@ -817,9 +817,10 @@ enum crc_set { PACKED_CRC_SET, >>> MAX_CRC_SET }; >>> static bool test_format_plane(data_t *data, enum pipe pipe, >>> - igt_output_t *output, igt_plane_t *plane) >>> + igt_output_t *output, igt_plane_t *plane, igt_fb_t >>> *primary_fb) >>> { >>> struct igt_fb fb = {}; >>> + struct igt_fb *clear_fb = plane->type == DRM_PLANE_TYPE_PRIMARY >>> ? primary_fb : NULL; >>> drmModeModeInfo *mode; >>> uint32_t format, ref_format; >>> uint64_t modifier, ref_modifier; >>> @@ -879,7 +880,7 @@ static bool test_format_plane(data_t *data, enum >>> pipe pipe, >>> height = test_fb.height; >>> } >>> - igt_plane_set_fb(plane, NULL); >>> + igt_plane_set_fb(plane, clear_fb); >>> igt_remove_fb(data->drm_fd, &test_fb); >>> } >>> @@ -937,7 +938,7 @@ static bool test_format_plane(data_t *data, enum >>> pipe pipe, >>> igt_pipe_crc_stop(data->pipe_crc); >>> - igt_plane_set_fb(plane, NULL); >>> + igt_plane_set_fb(plane, clear_fb); >>> igt_remove_fb(data->drm_fd, &fb); >>> return result; >>> @@ -1010,7 +1011,7 @@ test_pixel_formats(data_t *data, enum pipe pipe) >>> for_each_plane_on_pipe(&data->display, pipe, plane) { >>> if (skip_plane(data, plane)) >>> continue; >>> - result &= test_format_plane(data, pipe, output, plane); >>> + result &= test_format_plane(data, pipe, output, plane, >>> &primary_fb); >>> } >>> test_fini(data); >>> >> _______________________________________________ >> igt-dev mailing list >> igt-dev@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/igt-dev > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when testing other planes 2021-03-21 20:02 ` Juha-Pekka Heikkila @ 2021-03-22 8:12 ` Saarinen, Jani -1 siblings, 0 replies; 12+ messages in thread From: Saarinen, Jani @ 2021-03-22 8:12 UTC (permalink / raw) To: juhapekka.heikkila, Martin Peres, Lyude, igt-dev, nouveau; +Cc: Ben Skeggs Hi, > -----Original Message----- > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Juha-Pekka > Heikkila > Sent: sunnuntai 21. maaliskuuta 2021 22.03 > To: Martin Peres <martin.peres@mupuf.org>; Lyude <lyude@redhat.com>; igt- > dev@lists.freedesktop.org; nouveau@lists.freedesktop.org > Cc: Martin Peres <martin.peres@free.fr>; Ben Skeggs <bskeggs@redhat.com> > Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when > testing other planes > > On 18.3.2021 8.41, Martin Peres wrote: > > On 18/03/2021 00:44, Lyude wrote: > >> From: Lyude Paul <lyude@redhat.com> > >> > >> Currently, nouveau doesn't support having a CRTC without a primary FB > >> set. We won't reject such configurations, but the behavior is > >> undefined which will cause CRCs to become undefined. So, avoid > >> clearing the primary FB while we're testing non-primary planes. > > > > Looks good to me: > > > > Reviewed-by: Martin Peres <martin.peres@mupuf.org> > > > > This doesn't look good at all. Code changes were never run on ci, see this: > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shards- > all.html?testfilter=kms_plane@pixel-format > > This happen because of: > igt-gpu-tools$ git blame tests/intel-ci/blacklist-pre-merge.txt -L 173,+1 > 3e686098d9 (Martin Peres 2020-02-21 11:00:47 +0200 173) igt@kms_plane@pixel- > format-pipe-[a-d]-planes(-source-clamping)? > > You'll need to include something like this to test and review what did change on pixel > format tests: > https://patchwork.freedesktop.org/patch/404706/?series=84370&rev=1 > > but as this patch seems to be already merged as untested we now have pixel format > tests failing reliably ever since: > https://intel-gfx-ci.01.org/tree/drm-tip/index.html?testfilter=kms_plane@pixel- > format&hosts=tgl%7Cicl > > I have only intel icl at hand so I have no suggestions for fix. Though, looking at those > failures Stan (CCd) may have some interest on them. Can we just simply revert until fixed properly? > > /Juha-Pekka > > >> > >> Signed-off-by: Lyude Paul <lyude@redhat.com> > >> Cc: Martin Peres <martin.peres@free.fr> > >> Cc: Ben Skeggs <bskeggs@redhat.com> > >> Cc: Jeremy Cline <jcline@redhat.com> > >> --- > >> tests/kms_plane.c | 9 +++++---- > >> 1 file changed, 5 insertions(+), 4 deletions(-) > >> > >> diff --git a/tests/kms_plane.c b/tests/kms_plane.c index > >> 298a9375..c87983a4 100644 > >> --- a/tests/kms_plane.c > >> +++ b/tests/kms_plane.c > >> @@ -817,9 +817,10 @@ enum crc_set { PACKED_CRC_SET, > >> MAX_CRC_SET }; > >> static bool test_format_plane(data_t *data, enum pipe pipe, > >> - igt_output_t *output, igt_plane_t *plane) > >> + igt_output_t *output, igt_plane_t *plane, igt_fb_t > >> *primary_fb) > >> { > >> struct igt_fb fb = {}; > >> + struct igt_fb *clear_fb = plane->type == DRM_PLANE_TYPE_PRIMARY ? > >> primary_fb : NULL; > >> drmModeModeInfo *mode; > >> uint32_t format, ref_format; > >> uint64_t modifier, ref_modifier; @@ -879,7 +880,7 @@ static > >> bool test_format_plane(data_t *data, enum pipe pipe, > >> height = test_fb.height; > >> } > >> - igt_plane_set_fb(plane, NULL); > >> + igt_plane_set_fb(plane, clear_fb); > >> igt_remove_fb(data->drm_fd, &test_fb); > >> } > >> @@ -937,7 +938,7 @@ static bool test_format_plane(data_t *data, enum > >> pipe pipe, > >> igt_pipe_crc_stop(data->pipe_crc); > >> - igt_plane_set_fb(plane, NULL); > >> + igt_plane_set_fb(plane, clear_fb); > >> igt_remove_fb(data->drm_fd, &fb); > >> return result; > >> @@ -1010,7 +1011,7 @@ test_pixel_formats(data_t *data, enum pipe > >> pipe) > >> for_each_plane_on_pipe(&data->display, pipe, plane) { > >> if (skip_plane(data, plane)) > >> continue; > >> - result &= test_format_plane(data, pipe, output, plane); > >> + result &= test_format_plane(data, pipe, output, plane, > >> &primary_fb); > >> } > >> test_fini(data); > >> > > _______________________________________________ > > igt-dev mailing list > > igt-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/igt-dev > > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when testing other planes @ 2021-03-22 8:12 ` Saarinen, Jani 0 siblings, 0 replies; 12+ messages in thread From: Saarinen, Jani @ 2021-03-22 8:12 UTC (permalink / raw) To: juhapekka.heikkila, Martin Peres, Lyude, igt-dev, nouveau Cc: Martin Peres, Ben Skeggs Hi, > -----Original Message----- > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Juha-Pekka > Heikkila > Sent: sunnuntai 21. maaliskuuta 2021 22.03 > To: Martin Peres <martin.peres@mupuf.org>; Lyude <lyude@redhat.com>; igt- > dev@lists.freedesktop.org; nouveau@lists.freedesktop.org > Cc: Martin Peres <martin.peres@free.fr>; Ben Skeggs <bskeggs@redhat.com> > Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when > testing other planes > > On 18.3.2021 8.41, Martin Peres wrote: > > On 18/03/2021 00:44, Lyude wrote: > >> From: Lyude Paul <lyude@redhat.com> > >> > >> Currently, nouveau doesn't support having a CRTC without a primary FB > >> set. We won't reject such configurations, but the behavior is > >> undefined which will cause CRCs to become undefined. So, avoid > >> clearing the primary FB while we're testing non-primary planes. > > > > Looks good to me: > > > > Reviewed-by: Martin Peres <martin.peres@mupuf.org> > > > > This doesn't look good at all. Code changes were never run on ci, see this: > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5614/shards- > all.html?testfilter=kms_plane@pixel-format > > This happen because of: > igt-gpu-tools$ git blame tests/intel-ci/blacklist-pre-merge.txt -L 173,+1 > 3e686098d9 (Martin Peres 2020-02-21 11:00:47 +0200 173) igt@kms_plane@pixel- > format-pipe-[a-d]-planes(-source-clamping)? > > You'll need to include something like this to test and review what did change on pixel > format tests: > https://patchwork.freedesktop.org/patch/404706/?series=84370&rev=1 > > but as this patch seems to be already merged as untested we now have pixel format > tests failing reliably ever since: > https://intel-gfx-ci.01.org/tree/drm-tip/index.html?testfilter=kms_plane@pixel- > format&hosts=tgl%7Cicl > > I have only intel icl at hand so I have no suggestions for fix. Though, looking at those > failures Stan (CCd) may have some interest on them. Can we just simply revert until fixed properly? > > /Juha-Pekka > > >> > >> Signed-off-by: Lyude Paul <lyude@redhat.com> > >> Cc: Martin Peres <martin.peres@free.fr> > >> Cc: Ben Skeggs <bskeggs@redhat.com> > >> Cc: Jeremy Cline <jcline@redhat.com> > >> --- > >> tests/kms_plane.c | 9 +++++---- > >> 1 file changed, 5 insertions(+), 4 deletions(-) > >> > >> diff --git a/tests/kms_plane.c b/tests/kms_plane.c index > >> 298a9375..c87983a4 100644 > >> --- a/tests/kms_plane.c > >> +++ b/tests/kms_plane.c > >> @@ -817,9 +817,10 @@ enum crc_set { PACKED_CRC_SET, > >> MAX_CRC_SET }; > >> static bool test_format_plane(data_t *data, enum pipe pipe, > >> - igt_output_t *output, igt_plane_t *plane) > >> + igt_output_t *output, igt_plane_t *plane, igt_fb_t > >> *primary_fb) > >> { > >> struct igt_fb fb = {}; > >> + struct igt_fb *clear_fb = plane->type == DRM_PLANE_TYPE_PRIMARY ? > >> primary_fb : NULL; > >> drmModeModeInfo *mode; > >> uint32_t format, ref_format; > >> uint64_t modifier, ref_modifier; @@ -879,7 +880,7 @@ static > >> bool test_format_plane(data_t *data, enum pipe pipe, > >> height = test_fb.height; > >> } > >> - igt_plane_set_fb(plane, NULL); > >> + igt_plane_set_fb(plane, clear_fb); > >> igt_remove_fb(data->drm_fd, &test_fb); > >> } > >> @@ -937,7 +938,7 @@ static bool test_format_plane(data_t *data, enum > >> pipe pipe, > >> igt_pipe_crc_stop(data->pipe_crc); > >> - igt_plane_set_fb(plane, NULL); > >> + igt_plane_set_fb(plane, clear_fb); > >> igt_remove_fb(data->drm_fd, &fb); > >> return result; > >> @@ -1010,7 +1011,7 @@ test_pixel_formats(data_t *data, enum pipe > >> pipe) > >> for_each_plane_on_pipe(&data->display, pipe, plane) { > >> if (skip_plane(data, plane)) > >> continue; > >> - result &= test_format_plane(data, pipe, output, plane); > >> + result &= test_format_plane(data, pipe, output, plane, > >> &primary_fb); > >> } > >> test_fini(data); > >> > > _______________________________________________ > > igt-dev mailing list > > igt-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/igt-dev > > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-03-22 13:09 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-03-17 22:44 [Nouveau] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when testing other planes Lyude 2021-03-17 22:44 ` [igt-dev] " Lyude 2021-03-18 0:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2021-03-18 3:43 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2021-03-18 6:41 ` [Nouveau] [igt-dev] [PATCH i-g-t] " Martin Peres 2021-03-18 6:41 ` Martin Peres 2021-03-21 20:02 ` [Nouveau] " Juha-Pekka Heikkila 2021-03-21 20:02 ` Juha-Pekka Heikkila 2021-03-22 6:53 ` [Nouveau] " Martin Peres 2021-03-22 6:53 ` Martin Peres 2021-03-22 8:12 ` [Nouveau] " Saarinen, Jani 2021-03-22 8:12 ` Saarinen, Jani
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.