All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [FIX HTML PATCH] ltp-genhtml
@ 2009-06-17 20:17 naresh kamboju
  2009-06-18  9:10 ` Francesco RUNDO
  0 siblings, 1 reply; 6+ messages in thread
From: naresh kamboju @ 2009-06-17 20:17 UTC (permalink / raw)
  To: ltp-list
  Cc: maxin john, brinda_mn, Manas Kumar Nayak, Oleg Nesterov, rohit.170309

[-- Attachment #1: Type: text/plain, Size: 1552 bytes --]

Hi,

I have noticed following issue and fixed.
1.   Kernel Version
2.   Machine Architecture.

Please find the patch below and as attachment.

Best regards
Naresh Kamboju

Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com >

diff -Naurb a/tools/genhtml.pl b/tools/genhtml.pl
--- a/tools/genhtml.pl	2009-04-02 12:07:28.000000000 +0530
+++ b/tools/genhtml.pl	2009-06-18 00:33:46.000000000 +0530
@@ -246,8 +246,12 @@
 print "<tr><td><strong>Total Test TWARN</strong></td><td><strong>
$warn_test_counter </strong></td></tr>\n";
 print "<tr><td><strong>Total Test TRETR</strong></td><td><strong>
$retr_test_counter </strong></td></tr>\n";
 print "<tr><td><strong>Total Test TCONF</strong></td><td><strong>
$conf_test_counter </strong></td></tr>\n";
-print "<tr><td><strong>Kernel Version</strong></td><td><strong>
$ENV{KERNEL_VERSION}  </strong></td></tr>\n";
-print "<tr><td><strong>Machine Architecture</strong></td><td><strong>
$ENV{MACHINE_ARCH} </strong></td></tr>\n";
+print "<tr><td><strong>Kernel_Version</strong>  </td> <td><strong>";
+$kernel_version=system("uname -r");             chop($kernel_version);
+print " $kernel_version </strong></td></tr>\n";
+print "<tr><td><strong>Machine_Arch</strong>  </td> <td><strong>";
+$machine_arch=system("uname -m");             chop($machine_arch);
+print " $machine_arch </strong></td></tr>\n";
 print "<tr><td><strong>Hostname</strong>  </td> <td><strong>";
 $hostname=system("uname -n");             chop($hostname);
 print " $hostname </strong></td></tr></tbody></table></div></body></html>\n";

[-- Attachment #2: ltp-fix-genhtml.patch --]
[-- Type: application/octet-stream, Size: 1324 bytes --]

diff -Naurb a/tools/genhtml.pl b/tools/genhtml.pl
--- a/tools/genhtml.pl	2009-04-02 12:07:28.000000000 +0530
+++ b/tools/genhtml.pl	2009-06-18 00:33:46.000000000 +0530
@@ -246,8 +246,12 @@
 print "<tr><td><strong>Total Test TWARN</strong></td><td><strong> $warn_test_counter </strong></td></tr>\n";
 print "<tr><td><strong>Total Test TRETR</strong></td><td><strong> $retr_test_counter </strong></td></tr>\n";
 print "<tr><td><strong>Total Test TCONF</strong></td><td><strong> $conf_test_counter </strong></td></tr>\n";
-print "<tr><td><strong>Kernel Version</strong></td><td><strong> $ENV{KERNEL_VERSION}  </strong></td></tr>\n";
-print "<tr><td><strong>Machine Architecture</strong></td><td><strong> $ENV{MACHINE_ARCH} </strong></td></tr>\n";
+print "<tr><td><strong>Kernel_Version</strong>  </td> <td><strong>";
+$kernel_version=system("uname -r");             chop($kernel_version); 
+print " $kernel_version </strong></td></tr>\n";
+print "<tr><td><strong>Machine_Arch</strong>  </td> <td><strong>";
+$machine_arch=system("uname -m");             chop($machine_arch); 
+print " $machine_arch </strong></td></tr>\n";
 print "<tr><td><strong>Hostname</strong>  </td> <td><strong>";
 $hostname=system("uname -n");             chop($hostname); 
 print " $hostname </strong></td></tr></tbody></table></div></body></html>\n";

[-- Attachment #3: Type: text/plain, Size: 332 bytes --]

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [LTP] [FIX HTML PATCH] ltp-genhtml
  2009-06-17 20:17 [LTP] [FIX HTML PATCH] ltp-genhtml naresh kamboju
@ 2009-06-18  9:10 ` Francesco RUNDO
  2009-06-18 15:08   ` naresh kamboju
  0 siblings, 1 reply; 6+ messages in thread
From: Francesco RUNDO @ 2009-06-18  9:10 UTC (permalink / raw)
  To: naresh kamboju
  Cc: ltp-list, maxin john, brinda_mn, Manas Kumar Nayak,
	Oleg Nesterov, rohit.170309

Hi,

I'm not sure about your patch.

I've introduced the usage of such env variables to support cross-build 
of LTP.

In fact, in case the results of LTP session was related to 
cross-execution, the infiormation about KERNEL_VERSION and 
MACHINE_ARCHITECTURE have to be referred to the target and not to the 
host. Do you agree ?

With your fix, by using "uname -r" and "uname -m", to avoid to report 
wrong information, you have to run the "genhtml.pl" script over the 
target system because if you run the genhtml.pl on the host, you will 
get wrong information about the kernel version and machine architecture.

Moreover, the assumption to run genhtml.pl over the target is not safe 
as often the target systems are embedded systems which do not support PERL.

With the fix I've proposed and accepted, the LTP-user by means of the 
simple env variables, can define the right information to be reported on 
the LTP results table about kernel version and machine architecture.

Now, by taking into account what above mentioned, I've to suggest  to do 
not apply your proposal patch.

Best Regards,
Francesco

naresh kamboju wrote:

>Hi,
>
>I have noticed following issue and fixed.
>1.   Kernel Version
>2.   Machine Architecture.
>
>Please find the patch below and as attachment.
>
>Best regards
>Naresh Kamboju
>
>Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com >
>
>diff -Naurb a/tools/genhtml.pl b/tools/genhtml.pl
>--- a/tools/genhtml.pl	2009-04-02 12:07:28.000000000 +0530
>+++ b/tools/genhtml.pl	2009-06-18 00:33:46.000000000 +0530
>@@ -246,8 +246,12 @@
> print "<tr><td><strong>Total Test TWARN</strong></td><td><strong>
>$warn_test_counter </strong></td></tr>\n";
> print "<tr><td><strong>Total Test TRETR</strong></td><td><strong>
>$retr_test_counter </strong></td></tr>\n";
> print "<tr><td><strong>Total Test TCONF</strong></td><td><strong>
>$conf_test_counter </strong></td></tr>\n";
>-print "<tr><td><strong>Kernel Version</strong></td><td><strong>
>$ENV{KERNEL_VERSION}  </strong></td></tr>\n";
>-print "<tr><td><strong>Machine Architecture</strong></td><td><strong>
>$ENV{MACHINE_ARCH} </strong></td></tr>\n";
>+print "<tr><td><strong>Kernel_Version</strong>  </td> <td><strong>";
>+$kernel_version=system("uname -r");             chop($kernel_version);
>+print " $kernel_version </strong></td></tr>\n";
>+print "<tr><td><strong>Machine_Arch</strong>  </td> <td><strong>";
>+$machine_arch=system("uname -m");             chop($machine_arch);
>+print " $machine_arch </strong></td></tr>\n";
> print "<tr><td><strong>Hostname</strong>  </td> <td><strong>";
> $hostname=system("uname -n");             chop($hostname);
> print " $hostname </strong></td></tr></tbody></table></div></body></html>\n";
>  
>


------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [LTP] [FIX HTML PATCH] ltp-genhtml
  2009-06-18  9:10 ` Francesco RUNDO
@ 2009-06-18 15:08   ` naresh kamboju
  2009-06-19  9:02     ` Francesco RUNDO
  0 siblings, 1 reply; 6+ messages in thread
From: naresh kamboju @ 2009-06-18 15:08 UTC (permalink / raw)
  To: Francesco RUNDO
  Cc: ltp-list, maxin john, brinda_mn, Manas Kumar Nayak,
	Oleg Nesterov, rohit.170309

[-- Attachment #1: Type: text/plain, Size: 6026 bytes --]

Hi Francesco,

>I'm not sure about your patch.

>I've introduced the usage of such env variables to support cross-build of LTP.
Yes I have reviewed your patch.

>In fact, in case the results of LTP session was related to cross-execution, the >infiormation about KERNEL_VERSION and MACHINE_ARCHITECTURE have to >be referred to the target and not to the host. Do you agree ?
Yes.
I agree with you.
I have been using LTP for Target Board executions not on Host Machine.
As per my understating KERNEL_VERSION and MACHINE_ARCHITECTURE are
should come from env right?
But I could not print these variables in HTML file.
Please refer the results published in LTP download page for 31-May-2009 release.
http://sourceforge.net/project/platformdownload.php?group_id=3382


LTP Results:

ltp-full-20090531_results_kernel-2.6.18-128.el5_architecture-ppc64.tgz
ltp-full-20090531_results_kernel-2.6.18-128.el5_architecture-x86_64.tgz
ltp-full-20090531_results_kernel-2.6.18-128.el5PAE_architecture-i386.tgz
ltp-full-20090531_results_kernel-2.6.23.13_architecture-ia64.tgz
ltp-full-20090531_results_kernel-2.6.27.19-5-default_architecture-i386.tgz

None of the above results got printed these two KERNEL_VERSION and
MACHINE_ARCHITECTURE variables in HTML.


>With your fix, by using "uname -r" and "uname -m", to avoid to report wrong >information, you have to run the "genhtml.pl" script over the target system because if >you run the genhtml.pl on the host, you will get wrong information about the kernel >version and machine architecture.
No.
As per my understanding to make generic script “uname -r" and "uname
-m" are best way of use. All the target Machines are wont have full
“env” support to extract KERNEL_VERSION and MACHINE_ARCHITECTURE info.
Ofcourse my target Machine can not extract these variables.

"uname -r" and "uname -m" are from target not from Host I guess.
Because runltp script will runs on target so obviously genhtml.pl will
run when –g option is  specified. “ #sh runltp –g
ltp-full-results-file.html”


>Moreover, the assumption to run genhtml.pl over the target is not safe as often the target >systems are embedded systems which do not support PERL.

Yes. That is true.
When we run runltp with –g option to create HTML file the person using
this option should have knowledge that this script will use PERL
script if there is no PERL no HTML file will generate right?

>With the fix I've proposed and accepted, the LTP-user by means of the simple env >variables, can define the right information to be reported on the LTP results table about >kernel version and machine architecture.
I have attached my HTML output file after and before patch.
Please share your commands for ltp executions and results HTML file
and other files.
Before and after your patch.

if i miss something please let me know.

Best regards,
Naresh

>Now, by taking into account what above mentioned, I've to suggest to do not apply your >proposal patch.

>Best Regards,
>Francesco


On Thu, Jun 18, 2009 at 2:40 PM, Francesco RUNDO<francesco.rundo@st.com> wrote:
> Hi,
>
> I'm not sure about your patch.
>
> I've introduced the usage of such env variables to support cross-build of
> LTP.
>
> In fact, in case the results of LTP session was related to cross-execution,
> the infiormation about KERNEL_VERSION and MACHINE_ARCHITECTURE have to be
> referred to the target and not to the host. Do you agree ?
>
> With your fix, by using "uname -r" and "uname -m", to avoid to report wrong
> information, you have to run the "genhtml.pl" script over the target system
> because if you run the genhtml.pl on the host, you will get wrong
> information about the kernel version and machine architecture.
>
> Moreover, the assumption to run genhtml.pl over the target is not safe as
> often the target systems are embedded systems which do not support PERL.
>
> With the fix I've proposed and accepted, the LTP-user by means of the simple
> env variables, can define the right information to be reported on the LTP
> results table about kernel version and machine architecture.
>
> Now, by taking into account what above mentioned, I've to suggest  to do not
> apply your proposal patch.
>
> Best Regards,
> Francesco
>
> naresh kamboju wrote:
>
>> Hi,
>>
>> I have noticed following issue and fixed.
>> 1.   Kernel Version
>> 2.   Machine Architecture.
>>
>> Please find the patch below and as attachment.
>>
>> Best regards
>> Naresh Kamboju
>>
>> Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com >
>>
>> diff -Naurb a/tools/genhtml.pl b/tools/genhtml.pl
>> --- a/tools/genhtml.pl  2009-04-02 12:07:28.000000000 +0530
>> +++ b/tools/genhtml.pl  2009-06-18 00:33:46.000000000 +0530
>> @@ -246,8 +246,12 @@
>> print "<tr><td><strong>Total Test TWARN</strong></td><td><strong>
>> $warn_test_counter </strong></td></tr>\n";
>> print "<tr><td><strong>Total Test TRETR</strong></td><td><strong>
>> $retr_test_counter </strong></td></tr>\n";
>> print "<tr><td><strong>Total Test TCONF</strong></td><td><strong>
>> $conf_test_counter </strong></td></tr>\n";
>> -print "<tr><td><strong>Kernel Version</strong></td><td><strong>
>> $ENV{KERNEL_VERSION}  </strong></td></tr>\n";
>> -print "<tr><td><strong>Machine Architecture</strong></td><td><strong>
>> $ENV{MACHINE_ARCH} </strong></td></tr>\n";
>> +print "<tr><td><strong>Kernel_Version</strong>  </td> <td><strong>";
>> +$kernel_version=system("uname -r");             chop($kernel_version);
>> +print " $kernel_version </strong></td></tr>\n";
>> +print "<tr><td><strong>Machine_Arch</strong>  </td> <td><strong>";
>> +$machine_arch=system("uname -m");             chop($machine_arch);
>> +print " $machine_arch </strong></td></tr>\n";
>> print "<tr><td><strong>Hostname</strong>  </td> <td><strong>";
>> $hostname=system("uname -n");             chop($hostname);
>> print " $hostname
>> </strong></td></tr></tbody></table></div></body></html>\n";
>>
>
>

[-- Attachment #2: After_LTP-armv6l-2.6.29.1-alp_nl-kzm-arm11-2009_Jun_18-20h_26m_17s.html --]
[-- Type: text/html, Size: 5751 bytes --]

[-- Attachment #3: Before_LTP-armv6l-2.6.29.1-alp_nl-kzm-arm11-2009_Jun_18-20h_22m_29s.html --]
[-- Type: text/html, Size: 5719 bytes --]

[-- Attachment #4: Type: text/plain, Size: 332 bytes --]

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects

[-- Attachment #5: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [LTP] [FIX HTML PATCH] ltp-genhtml
  2009-06-18 15:08   ` naresh kamboju
@ 2009-06-19  9:02     ` Francesco RUNDO
  2009-06-19 10:12       ` naresh kamboju
  0 siblings, 1 reply; 6+ messages in thread
From: Francesco RUNDO @ 2009-06-19  9:02 UTC (permalink / raw)
  To: naresh kamboju
  Cc: ltp-list, maxin john, brinda_mn, Manas Kumar Nayak,
	Oleg Nesterov, rohit.170309


[-- Attachment #1.1: Type: text/plain, Size: 4360 bytes --]

Hi Naresh,

thanks for your reply. Below some considerations:

naresh kamboju wrote:

>Hi Francesco,
>
>  
>
>>In fact, in case the results of LTP session was related to cross-execution, the >infiormation about KERNEL_VERSION and MACHINE_ARCHITECTURE have to >be referred to the target and not to the host. Do you agree ?
>>    
>>
>Yes.
>I agree with you.
>I have been using LTP for Target Board executions not on Host Machine.
>As per my understating KERNEL_VERSION and MACHINE_ARCHITECTURE are
>should come from env right?
>
Yes.


>But I could not print these variables in HTML file.
>

Why not ?
By means of (before to run genhtml.pl on the HOST):
export KERNEL_VERSION=" xxxxxxxxxxxxxxxx"
export MACHINE_ARCH=" xxxxxxxxxxxxxxxxxxxxx"
you will be able to export on the final HTML file the info contained in 
the above env variables.
The attached HTML log shows a typical summary (I report only subset of 
info related to the env variables).

>Please refer the results published in LTP download page for 31-May-2009 release.
>http://sourceforge.net/project/platformdownload.php?group_id=3382
>
>
>LTP Results:
>
>ltp-full-20090531_results_kernel-2.6.18-128.el5_architecture-ppc64.tgz
>ltp-full-20090531_results_kernel-2.6.18-128.el5_architecture-x86_64.tgz
>ltp-full-20090531_results_kernel-2.6.18-128.el5PAE_architecture-i386.tgz
>ltp-full-20090531_results_kernel-2.6.23.13_architecture-ia64.tgz
>ltp-full-20090531_results_kernel-2.6.27.19-5-default_architecture-i386.tgz
>
>None of the above results got printed these two KERNEL_VERSION and
>MACHINE_ARCHITECTURE variables in HTML.
>

Probably because they haven't been defined the env variables.

>
>
>  
>
>>With your fix, by using "uname -r" and "uname -m", to avoid to report wrong >information, you have to run the "genhtml.pl" script over the target system because if >you run the genhtml.pl on the host, you will get wrong information about the kernel >version and machine architecture.
>>    
>>
>No.
>As per my understanding to make generic script “uname -r" and "uname
>-m" are best way of use. All the target Machines are wont have full
>“env” support to extract KERNEL_VERSION and MACHINE_ARCHITECTURE info.
>Ofcourse my target Machine can not extract these variables.
>

No env variables have to be processed in the target. The env variables 
will be used on the HOST execution of genthml.pl.

>
>"uname -r" and "uname -m" are from target not from Host I guess.
>Because runltp script will runs on target so obviously genhtml.pl will
>run when –g option is  specified. “ #sh runltp –g
>ltp-full-results-file.html”
>  
>
>>Moreover, the assumption to run genhtml.pl over the target is not safe as often the target >systems are embedded systems which do not support PERL.
>>    
>>
>
>Yes. That is true.
>When we run runltp with –g option to create HTML file the person using
>this option should have knowledge that this script will use PERL
>script if there is no PERL no HTML file will generate right?
>  
>

No, with the usage of env variables on the "genhtml.pl", you can have 
HTML file even though PERL is not supported on your target. This is an 
advantage!

Moreover, you can manage and process "off-line" LTP report without 
having the risk to add in the report HOST information instead of TARGET 
ones.

>  
>
>>With the fix I've proposed and accepted, the LTP-user by means of the simple env >variables, can define the right information to be reported on the LTP results table about >kernel version and machine architecture.
>>    
>>
>I have attached my HTML output file after and before patch.
>Please share your commands for ltp executions and results HTML file
>and other files.
>Before and after your patch.
>
The steps I follow are simply:

1) runltp >> LTP.log (run on the TARGET platform);

2)  export KERNEL_VERSION=" xxxxxxxxxxxxxxxx"
     export MACHINE_ARCH=" xxxxxxxxxxxxxxxxxxxxx"
     ...................... (run on the HOST platform)

3) genhtml.pl LTP.log LTP.html (run on the HOST platform);

In this way I avoid to make assumptions about TARGET requirements (PERL, 
HTML, etc...).

The piece of attached LTP-log.html shows what I got.

I confirm my opinion to keep the current policy to generate HTML summary 
info.

Best Regards,
FR



[-- Attachment #1.2: Type: text/html, Size: 6120 bytes --]

[-- Attachment #2: LTP-log.html --]
[-- Type: text/html, Size: 1848 bytes --]

[-- Attachment #3: Type: text/plain, Size: 332 bytes --]

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [LTP] [FIX HTML PATCH] ltp-genhtml
  2009-06-19  9:02     ` Francesco RUNDO
@ 2009-06-19 10:12       ` naresh kamboju
  2009-06-19 12:19         ` Francesco RUNDO
  0 siblings, 1 reply; 6+ messages in thread
From: naresh kamboju @ 2009-06-19 10:12 UTC (permalink / raw)
  To: Francesco RUNDO, subrata
  Cc: ltp-list, maxin john, brinda_mn, Manas Kumar Nayak,
	Oleg Nesterov, rohit.170309

Hi Francesco,

Thanks for your comments.

I have few questions
1. Are you compiling LTP on Host Machine and running on target boards?
Could explain your compilation and execution procedure?
2. Is it cross complication with different tool chains?
3. Do you export KERNEL_VERSION and MACHINE_ARCHITECTURE on Host or target?

At my end I am compile with cross tool chains and copy the LTP
complied source on target and executing the “runltp”.
In my case I don’t get any variables from Host.
I am not exporting Any Macros on target.

I guess. Most of our LTP users do same.
Of course, I will not export KERNEL_VERSION and MACHINE_ARCHITECTURE
either on target or on Host.

I was not aware of exporting these variables.

Thanks for your info.

Is there any other way with out exporting these variables can I get
KERNEL_VERSION and MACHINE_ARCHITECTURE?
I mean the design modification of PERL script to auto extracting of commands.

As per my understanding the people use direct target machine for LTP
execution are getting this problem

 Francesco,

I want to have generic script to solve this issue.
could you help in this?

Subrata,


In the published results logs under this URL are not having
KERNEL_VERSION and MACHINE_ARCHITECTURE in HTML.
I have also faced same problem and made a patch for that.

Please refer the results published in LTP download page for May release.
http://sourceforge.net/project/platformdownload.php?group_id=3382

LTP Results:

ltp-full-20090531_results_kernel-2.6.18-128.el5_architecture-ppc64.tgz
ltp-full-20090531_results_kernel-2.6.18-128.el5_architecture-x86_64.tgz
ltp-full-20090531_results_kernel-2.6.18-128.el5PAE_architecture-i386.tgz
ltp-full-20090531_results_kernel-2.6.23.13_architecture-ia64.tgz
ltp-full-20090531_results_kernel-2.6.27.19-5-default_architecture-i386.tgz

None of the above results got printed these two KERNEL_VERSION and
MACHINE_ARCHITECTURE variables in HTML.


Please give me the procedure of ltp execution at your end.
Because there is confusion about generating HTML with KERNEL_VERSION
and MACHINE_ARCHITECTURE, so we want to have a generic method of
extracting.

Do you export KERNEL_VERSION and MACHINE_ARCHITECTURE before ltp
execution as a standard procedure?

I want to know the majority of people
A) Cross compile on host and run LTP on target
B) Compile on Host and run on LTP from Host Machine.
C) Compile and execute on HOST.

Your suggestions are welcome :)


Best regards
Naresh Kamboju


On Fri, Jun 19, 2009 at 2:32 PM, Francesco RUNDO<francesco.rundo@st.com> wrote:
> Hi Naresh,
>
> thanks for your reply. Below some considerations:
>
> naresh kamboju wrote:
>
> Hi Francesco,
>
>
>
> In fact, in case the results of LTP session was related to cross-execution,
> the >infiormation about KERNEL_VERSION and MACHINE_ARCHITECTURE have to >be
> referred to the target and not to the host. Do you agree ?
>
>
> Yes.
> I agree with you.
> I have been using LTP for Target Board executions not on Host Machine.
> As per my understating KERNEL_VERSION and MACHINE_ARCHITECTURE are
> should come from env right?
>
> Yes.
>
>
> But I could not print these variables in HTML file.
>
> Why not ?
> By means of (before to run genhtml.pl on the HOST):
> export KERNEL_VERSION=" xxxxxxxxxxxxxxxx"
> export MACHINE_ARCH=" xxxxxxxxxxxxxxxxxxxxx"
> you will be able to export on the final HTML file the info contained in the
> above env variables.
> The attached HTML log shows a typical summary (I report only subset of info
> related to the env variables).
>
> Please refer the results published in LTP download page for 31-May-2009
> release.
> http://sourceforge.net/project/platformdownload.php?group_id=3382
>
>
> LTP Results:
>
> ltp-full-20090531_results_kernel-2.6.18-128.el5_architecture-ppc64.tgz
> ltp-full-20090531_results_kernel-2.6.18-128.el5_architecture-x86_64.tgz
> ltp-full-20090531_results_kernel-2.6.18-128.el5PAE_architecture-i386.tgz
> ltp-full-20090531_results_kernel-2.6.23.13_architecture-ia64.tgz
> ltp-full-20090531_results_kernel-2.6.27.19-5-default_architecture-i386.tgz
>
> None of the above results got printed these two KERNEL_VERSION and
> MACHINE_ARCHITECTURE variables in HTML.
>
> Probably because they haven't been defined the env variables.
>
>
>
>
> With your fix, by using "uname -r" and "uname -m", to avoid to report wrong
>>information, you have to run the "genhtml.pl" script over the target system
> because if >you run the genhtml.pl on the host, you will get wrong
> information about the kernel >version and machine architecture.
>
>
> No.
> As per my understanding to make generic script “uname -r" and "uname
> -m" are best way of use. All the target Machines are wont have full
> “env” support to extract KERNEL_VERSION and MACHINE_ARCHITECTURE info.
> Ofcourse my target Machine can not extract these variables.
>
> No env variables have to be processed in the target. The env variables will
> be used on the HOST execution of genthml.pl.
>
>
> "uname -r" and "uname -m" are from target not from Host I guess.
> Because runltp script will runs on target so obviously genhtml.pl will
> run when –g option is  specified. “ #sh runltp –g
> ltp-full-results-file.html”
>
>
> Moreover, the assumption to run genhtml.pl over the target is not safe as
> often the target >systems are embedded systems which do not support PERL.
>
>
> Yes. That is true.
> When we run runltp with –g option to create HTML file the person using
> this option should have knowledge that this script will use PERL
> script if there is no PERL no HTML file will generate right?
>
>
> No, with the usage of env variables on the "genhtml.pl", you can have HTML
> file even though PERL is not supported on your target. This is an advantage!
>
> Moreover, you can manage and process "off-line" LTP report without having
> the risk to add in the report HOST information instead of TARGET ones.
>
>
>
> With the fix I've proposed and accepted, the LTP-user by means of the simple
> env >variables, can define the right information to be reported on the LTP
> results table about >kernel version and machine architecture.
>
>
> I have attached my HTML output file after and before patch.
> Please share your commands for ltp executions and results HTML file
> and other files.
> Before and after your patch.
>
> The steps I follow are simply:
>
> 1) runltp >> LTP.log (run on the TARGET platform);
>
> 2)  export KERNEL_VERSION=" xxxxxxxxxxxxxxxx"
>      export MACHINE_ARCH=" xxxxxxxxxxxxxxxxxxxxx"
>      ...................... (run on the HOST platform)
>
> 3) genhtml.pl LTP.log LTP.html (run on the HOST platform);
>
> In this way I avoid to make assumptions about TARGET requirements (PERL,
> HTML, etc...).
>
> The piece of attached LTP-log.html shows what I got.
>
> I confirm my opinion to keep the current policy to generate HTML summary
> info.
>
> Best Regards,
> FR
>
>
>
> Summary Report
>
> Test SummaryPan reported all Test Pass
> LTP Version ltp-full-20090430
> Start Time Fri May 22, 2009 - 2.44 pm
> End Time Fri May 22, 2009 - 2.44 pm
> Log Result http://www.stlinux.com/drupal/
> Output/Failed Result http://www.stlinux.com/drupal/
> Total Tests
> Total Test TPASS:
> Total Test TFAIL:
> Total Test TBROK
> Total Test TWARN
> Total Test TRETR
> Total Test TCONF 7
> Kernel Version linux-sh4-2.6.23_stm23_120
> Machine Architecture SuperH(SH) - STBi7100c3 reference board -mb442-
> Hostname STSLX02
> Click Here for Detailed Report
>
>

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [LTP] [FIX HTML PATCH] ltp-genhtml
  2009-06-19 10:12       ` naresh kamboju
@ 2009-06-19 12:19         ` Francesco RUNDO
  0 siblings, 0 replies; 6+ messages in thread
From: Francesco RUNDO @ 2009-06-19 12:19 UTC (permalink / raw)
  To: naresh kamboju
  Cc: ltp-list, maxin john, brinda_mn, Manas Kumar Nayak,
	Oleg Nesterov, rohit.170309

Hi Naresh,

naresh kamboju wrote:

>Hi Francesco,
>
>Thanks for your comments.
>
>I have few questions
>1. Are you compiling LTP on Host Machine and running on target boards?
>
Yes, precisely, I cross-build LTP on the HOST and run it on a different 
TARGET machine.

>
>2. Is it cross complication with different tool chains?
>
Yes. I cross-compile for SH based platforms. See 
http://www.stlinux.com/drupal for more details.

>3. Do you export KERNEL_VERSION and MACHINE_ARCHITECTURE on Host or target?
>
On the HOST when I process the LTP-log to generate the corresponding 
HTML file.

>
>At my end I am compile with cross tool chains and copy the LTP
>complied source on target and executing the “runltp”.
>In my case I don’t get any variables from Host.
>I am not exporting Any Macros on target.
>
>I guess. Most of our LTP users do same.
>

I'm not sure about LTP users use the above approach, but what I think 
should be taken into account is """what is better for all the LTP users""".
Do you agree ?
Now, can I do an advantages/disadavantages analysis of the methods (mine 
and yours) ?

Yours (with usage of "uname -x"):
=====================

ADVANTAGES:
*) Automatic generation of information (of course, more safe!).
DISADVANTAGES:
*) Need PERL on the TARGET machine;
*) No flexible (I can't modify the info by adding more info....I have to 
keep what "uname -x" provides);
*) Can be executed only on the TARGET (on the HOST it provides wrong 
information);

Mine(with usage of "env variables"):
========================

ADVANTAGES:
*) No PERL is needed on the TARGET;
*) Flexible (I could use the output provided by "uname -x" executed on 
the TARGET or I can add more info if needed);
*) Can be run both on the HOST and on the TARGET;
DISADVANTAGES:
*) Is not automatic as the user can properly define/export the relaetd 
env variables.

Now, from above analysis I think should be taken a final decision.

>
>Thanks for your info.
>
No problem.

Best Regards
Francesco Rundo


------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2009-06-19 13:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-17 20:17 [LTP] [FIX HTML PATCH] ltp-genhtml naresh kamboju
2009-06-18  9:10 ` Francesco RUNDO
2009-06-18 15:08   ` naresh kamboju
2009-06-19  9:02     ` Francesco RUNDO
2009-06-19 10:12       ` naresh kamboju
2009-06-19 12:19         ` Francesco RUNDO

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.