From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Alex Elder <elder@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Kalle Valo <kvalo@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: <linux-arm-msm@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] slimbus: qcom-ngd-ctrl: Make QMI message rules const
Date: Fri, 16 Sep 2022 08:20:42 -0700 [thread overview]
Message-ID: <f5b2eaa8-70eb-21b2-e2e7-485aaa927a5d@quicinc.com> (raw)
In-Reply-To: <65f11ed1-f09f-e0a2-91f5-891394160c96@linaro.org>
On 9/16/2022 6:06 AM, Srinivas Kandagatla wrote:
>
>
> On 13/09/2022 00:25, Jeff Johnson wrote:
>> Commit ff6d365898d ("soc: qcom: qmi: use con
>
> SHA ID should be at least 12 chars long.
>
> Same comment for all the patches in the series.
>
>
> st for struct
>> qmi_elem_info") allows QMI message encoding/decoding rules to be
>> const, so do that for qcom-ngd-ctrl.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>
> Other than that it LGTM,
> Once fixed:
>
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
>
> --srini
that was corrected in v2. thx for the ack
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Alex Elder <elder@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Kalle Valo <kvalo@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 3/4] slimbus: qcom-ngd-ctrl: Make QMI message rules const
Date: Fri, 16 Sep 2022 08:20:42 -0700 [thread overview]
Message-ID: <f5b2eaa8-70eb-21b2-e2e7-485aaa927a5d@quicinc.com> (raw)
In-Reply-To: <65f11ed1-f09f-e0a2-91f5-891394160c96@linaro.org>
On 9/16/2022 6:06 AM, Srinivas Kandagatla wrote:
>
>
> On 13/09/2022 00:25, Jeff Johnson wrote:
>> Commit ff6d365898d ("soc: qcom: qmi: use con
>
> SHA ID should be at least 12 chars long.
>
> Same comment for all the patches in the series.
>
>
> st for struct
>> qmi_elem_info") allows QMI message encoding/decoding rules to be
>> const, so do that for qcom-ngd-ctrl.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>
> Other than that it LGTM,
> Once fixed:
>
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
>
> --srini
that was corrected in v2. thx for the ack
next prev parent reply other threads:[~2022-09-16 15:21 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 23:25 [PATCH 0/4] Make QMI message rules const Jeff Johnson
2022-09-12 23:25 ` Jeff Johnson
2022-09-12 23:25 ` [PATCH 1/4] net: ipa: " Jeff Johnson
2022-09-12 23:25 ` Jeff Johnson
2022-09-12 23:25 ` [PATCH 2/4] remoteproc: sysmon: " Jeff Johnson
2022-09-12 23:25 ` Jeff Johnson
2022-09-12 23:25 ` [PATCH 3/4] slimbus: qcom-ngd-ctrl: " Jeff Johnson
2022-09-12 23:25 ` Jeff Johnson
2022-09-12 23:25 ` [PATCH 4/4] soc: qcom: pdr: " Jeff Johnson
2022-09-12 23:25 ` Jeff Johnson
2022-09-14 10:18 ` Sibi Sankar
2022-09-14 10:18 ` Sibi Sankar
2022-09-14 10:26 ` [PATCH 3/4] slimbus: qcom-ngd-ctrl: " Sibi Sankar
2022-09-14 10:26 ` Sibi Sankar
2022-09-16 13:06 ` Srinivas Kandagatla
2022-09-16 13:06 ` Srinivas Kandagatla
2022-09-16 15:20 ` Jeff Johnson [this message]
2022-09-16 15:20 ` Jeff Johnson
2022-09-14 10:24 ` [PATCH 2/4] remoteproc: sysmon: " Sibi Sankar
2022-09-14 10:24 ` Sibi Sankar
2022-09-14 10:22 ` [PATCH 1/4] net: ipa: " Sibi Sankar
2022-09-14 10:22 ` Sibi Sankar
2022-09-13 13:58 ` [PATCH 0/4] " Alex Elder
2022-09-13 13:58 ` Alex Elder
2022-09-13 18:51 ` Jeff Johnson
2022-09-13 18:51 ` Jeff Johnson
2022-09-13 20:21 ` Alex Elder
2022-09-13 20:21 ` Alex Elder
2022-09-13 22:19 ` Jeff Johnson
2022-09-13 22:19 ` Jeff Johnson
2022-09-15 18:47 ` Jeff Johnson
2022-09-15 18:47 ` Jeff Johnson
2022-09-14 23:47 ` [PATCH v2 " Jeff Johnson
2022-09-14 23:47 ` Jeff Johnson
2022-09-14 23:47 ` [PATCH v2 1/4] net: ipa: " Jeff Johnson
2022-09-14 23:47 ` Jeff Johnson
2022-10-18 21:17 ` [RESEND PATCH net-next] " Jeff Johnson
2022-10-21 12:20 ` patchwork-bot+netdevbpf
2022-09-14 23:47 ` [PATCH v2 2/4] remoteproc: sysmon: " Jeff Johnson
2022-09-14 23:47 ` Jeff Johnson
2022-10-18 20:44 ` [RESEND PATCH] " Jeff Johnson
2022-09-14 23:47 ` [PATCH v2 3/4] slimbus: qcom-ngd-ctrl: " Jeff Johnson
2022-09-14 23:47 ` Jeff Johnson
2022-10-18 22:25 ` [RESEND PATCH] " Jeff Johnson
2022-10-18 22:25 ` Jeff Johnson
2022-09-14 23:47 ` [PATCH v2 4/4] soc: qcom: pdr: " Jeff Johnson
2022-09-14 23:47 ` Jeff Johnson
2022-10-05 20:54 ` [RESEND] " Jeff Johnson
2022-10-18 3:14 ` [PATCH v2 0/4] " Bjorn Andersson
2022-10-18 3:14 ` Bjorn Andersson
2022-12-07 15:53 ` Bjorn Andersson
2022-12-07 15:53 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5b2eaa8-70eb-21b2-e2e7-485aaa927a5d@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.