All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4] Staging: iio: Fix coding style issues.
@ 2016-03-21  7:36 Sandhya Bankar
  2016-03-21  7:41 ` [PATCH 1/4] Staging: iio: ade7758_core: Fix open parentheses alignment issues Sandhya Bankar
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Sandhya Bankar @ 2016-03-21  7:36 UTC (permalink / raw)
  To: outreachy-kernel

Fix coding style issues.These issues are detected by checkpatch.pl script.

Sandhya Bankar (4):
  Staging: iio: ade7758_core: Fix open parentheses alignment issues.
  Staging: iio: ade7758_core: Remove unnecessary blank line.
  Staging: iio: ade7758: Use a blank line after function/struct declarations.
  Staging: iio: ade7758: Fix open parentheses alignment issues.

 drivers/staging/iio/meter/ade7758.h      | 16 ++++---
 drivers/staging/iio/meter/ade7758_core.c | 74 +++++++++++---------------------
 2 files changed, 35 insertions(+), 55 deletions(-)

-- 
1.8.3.4



^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH 1/4] Staging: iio: ade7758_core: Fix open parentheses alignment issues.
  2016-03-21  7:36 [PATCH 0/4] Staging: iio: Fix coding style issues Sandhya Bankar
@ 2016-03-21  7:41 ` Sandhya Bankar
  2016-03-21  7:43 ` [PATCH 2/4] Staging: iio: ade7758_core: Remove unnecessary blank line Sandhya Bankar
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Sandhya Bankar @ 2016-03-21  7:41 UTC (permalink / raw)
  To: outreachy-kernel

Fix open parentheses alignment issues.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/iio/meter/ade7758_core.c | 73 ++++++++++++--------------------
 1 file changed, 26 insertions(+), 47 deletions(-)

diff --git a/drivers/staging/iio/meter/ade7758_core.c b/drivers/staging/iio/meter/ade7758_core.c
index 40f5afa..d6e35c7 100644
--- a/drivers/staging/iio/meter/ade7758_core.c
+++ b/drivers/staging/iio/meter/ade7758_core.c
@@ -24,9 +24,7 @@
 #include "meter.h"
 #include "ade7758.h"
 
-int ade7758_spi_write_reg_8(struct device *dev,
-		u8 reg_address,
-		u8 val)
+int ade7758_spi_write_reg_8(struct device *dev, u8 reg_address, u8 val)
 {
 	int ret;
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -42,9 +40,8 @@ int ade7758_spi_write_reg_8(struct device *dev,
 	return ret;
 }
 
-static int ade7758_spi_write_reg_16(struct device *dev,
-		u8 reg_address,
-		u16 value)
+static int ade7758_spi_write_reg_16(struct device *dev, u8 reg_address,
+				    u16 value)
 {
 	int ret;
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -68,9 +65,8 @@ static int ade7758_spi_write_reg_16(struct device *dev,
 	return ret;
 }
 
-static int ade7758_spi_write_reg_24(struct device *dev,
-		u8 reg_address,
-		u32 value)
+static int ade7758_spi_write_reg_24(struct device *dev, u8 reg_address,
+				    u32 value)
 {
 	int ret;
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -95,9 +91,7 @@ static int ade7758_spi_write_reg_24(struct device *dev,
 	return ret;
 }
 
-int ade7758_spi_read_reg_8(struct device *dev,
-		u8 reg_address,
-		u8 *val)
+int ade7758_spi_read_reg_8(struct device *dev, u8 reg_address, u8 *val)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ade7758_state *st = iio_priv(indio_dev);
@@ -124,7 +118,7 @@ int ade7758_spi_read_reg_8(struct device *dev,
 	ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
 	if (ret) {
 		dev_err(&st->us->dev, "problem when reading 8 bit register 0x%02X",
-				reg_address);
+			reg_address);
 		goto error_ret;
 	}
 	*val = st->rx[0];
@@ -134,9 +128,8 @@ error_ret:
 	return ret;
 }
 
-static int ade7758_spi_read_reg_16(struct device *dev,
-		u8 reg_address,
-		u16 *val)
+static int ade7758_spi_read_reg_16(struct device *dev, u8 reg_address,
+				   u16 *val)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ade7758_state *st = iio_priv(indio_dev);
@@ -165,7 +158,7 @@ static int ade7758_spi_read_reg_16(struct device *dev,
 	ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
 	if (ret) {
 		dev_err(&st->us->dev, "problem when reading 16 bit register 0x%02X",
-				reg_address);
+			reg_address);
 		goto error_ret;
 	}
 
@@ -176,9 +169,8 @@ error_ret:
 	return ret;
 }
 
-static int ade7758_spi_read_reg_24(struct device *dev,
-		u8 reg_address,
-		u32 *val)
+static int ade7758_spi_read_reg_24(struct device *dev, u8 reg_address,
+				   u32 *val)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ade7758_state *st = iio_priv(indio_dev);
@@ -207,7 +199,7 @@ static int ade7758_spi_read_reg_24(struct device *dev,
 	ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
 	if (ret) {
 		dev_err(&st->us->dev, "problem when reading 24 bit register 0x%02X",
-				reg_address);
+			reg_address);
 		goto error_ret;
 	}
 	*val = (st->rx[0] << 16) | (st->rx[1] << 8) | st->rx[2];
@@ -218,8 +210,7 @@ error_ret:
 }
 
 static ssize_t ade7758_read_8bit(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				 struct device_attribute *attr, char *buf)
 {
 	int ret;
 	u8 val = 0;
@@ -233,8 +224,7 @@ static ssize_t ade7758_read_8bit(struct device *dev,
 }
 
 static ssize_t ade7758_read_16bit(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				  struct device_attribute *attr, char *buf)
 {
 	int ret;
 	u16 val = 0;
@@ -248,8 +238,7 @@ static ssize_t ade7758_read_16bit(struct device *dev,
 }
 
 static ssize_t ade7758_read_24bit(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				  struct device_attribute *attr, char *buf)
 {
 	int ret;
 	u32 val = 0;
@@ -263,9 +252,8 @@ static ssize_t ade7758_read_24bit(struct device *dev,
 }
 
 static ssize_t ade7758_write_8bit(struct device *dev,
-		struct device_attribute *attr,
-		const char *buf,
-		size_t len)
+				  struct device_attribute *attr,
+				  const char *buf, size_t len)
 {
 	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
 	int ret;
@@ -281,9 +269,8 @@ error_ret:
 }
 
 static ssize_t ade7758_write_16bit(struct device *dev,
-		struct device_attribute *attr,
-		const char *buf,
-		size_t len)
+				   struct device_attribute *attr,
+				   const char *buf, size_t len)
 {
 	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
 	int ret;
@@ -479,16 +466,13 @@ err_ret:
 }
 
 static ssize_t ade7758_read_frequency(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				      struct device_attribute *attr, char *buf)
 {
 	int ret;
 	u8 t;
 	int sps;
 
-	ret = ade7758_spi_read_reg_8(dev,
-			ADE7758_WAVMODE,
-			&t);
+	ret = ade7758_spi_read_reg_8(dev, ADE7758_WAVMODE, &t);
 	if (ret)
 		return ret;
 
@@ -499,9 +483,8 @@ static ssize_t ade7758_read_frequency(struct device *dev,
 }
 
 static ssize_t ade7758_write_frequency(struct device *dev,
-		struct device_attribute *attr,
-		const char *buf,
-		size_t len)
+				       struct device_attribute *attr,
+				       const char *buf, size_t len)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	u16 val;
@@ -532,18 +515,14 @@ static ssize_t ade7758_write_frequency(struct device *dev,
 		goto out;
 	}
 
-	ret = ade7758_spi_read_reg_8(dev,
-			ADE7758_WAVMODE,
-			&reg);
+	ret = ade7758_spi_read_reg_8(dev, ADE7758_WAVMODE, &reg);
 	if (ret)
 		goto out;
 
 	reg &= ~(5 << 3);
 	reg |= t << 5;
 
-	ret = ade7758_spi_write_reg_8(dev,
-			ADE7758_WAVMODE,
-			reg);
+	ret = ade7758_spi_write_reg_8(dev, ADE7758_WAVMODE, reg);
 
 out:
 	mutex_unlock(&indio_dev->mlock);
-- 
1.8.3.4



^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH 2/4] Staging: iio: ade7758_core: Remove unnecessary blank line.
  2016-03-21  7:36 [PATCH 0/4] Staging: iio: Fix coding style issues Sandhya Bankar
  2016-03-21  7:41 ` [PATCH 1/4] Staging: iio: ade7758_core: Fix open parentheses alignment issues Sandhya Bankar
@ 2016-03-21  7:43 ` Sandhya Bankar
  2016-03-21  7:45 ` [PATCH 3/4] Staging: iio: ade7758: Use a blank line after function/struct declarations Sandhya Bankar
  2016-03-21  7:47 ` [PATCH 4/4] Staging: iio: ade7758: Fix open parentheses alignment issues Sandhya Bankar
  3 siblings, 0 replies; 5+ messages in thread
From: Sandhya Bankar @ 2016-03-21  7:43 UTC (permalink / raw)
  To: outreachy-kernel

Remove unnecessary blank line.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/iio/meter/ade7758_core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/iio/meter/ade7758_core.c b/drivers/staging/iio/meter/ade7758_core.c
index d6e35c7..3102965 100644
--- a/drivers/staging/iio/meter/ade7758_core.c
+++ b/drivers/staging/iio/meter/ade7758_core.c
@@ -149,7 +149,6 @@ static int ade7758_spi_read_reg_16(struct device *dev, u8 reg_address,
 		},
 	};
 
-
 	mutex_lock(&st->buf_lock);
 	st->tx[0] = ADE7758_READ_REG(reg_address);
 	st->tx[1] = 0;
-- 
1.8.3.4



^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH 3/4] Staging: iio: ade7758: Use a blank line after function/struct declarations.
  2016-03-21  7:36 [PATCH 0/4] Staging: iio: Fix coding style issues Sandhya Bankar
  2016-03-21  7:41 ` [PATCH 1/4] Staging: iio: ade7758_core: Fix open parentheses alignment issues Sandhya Bankar
  2016-03-21  7:43 ` [PATCH 2/4] Staging: iio: ade7758_core: Remove unnecessary blank line Sandhya Bankar
@ 2016-03-21  7:45 ` Sandhya Bankar
  2016-03-21  7:47 ` [PATCH 4/4] Staging: iio: ade7758: Fix open parentheses alignment issues Sandhya Bankar
  3 siblings, 0 replies; 5+ messages in thread
From: Sandhya Bankar @ 2016-03-21  7:45 UTC (permalink / raw)
  To: outreachy-kernel

Use a blank line after function/struct declarations.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/iio/meter/ade7758.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/staging/iio/meter/ade7758.h b/drivers/staging/iio/meter/ade7758.h
index f6739e2..ff7c764 100644
--- a/drivers/staging/iio/meter/ade7758.h
+++ b/drivers/staging/iio/meter/ade7758.h
@@ -129,6 +129,7 @@ struct ade7758_state {
 	unsigned char		tx_buf[8];
 
 };
+
 #ifdef CONFIG_IIO_BUFFER
 /* At the moment triggers are only used for ring buffer
  * filling. This may change!
@@ -157,6 +158,7 @@ int ade7758_spi_read_reg_8(struct device *dev,
 static inline void ade7758_remove_trigger(struct iio_dev *indio_dev)
 {
 }
+
 static inline int ade7758_probe_trigger(struct iio_dev *indio_dev)
 {
 	return 0;
@@ -166,16 +168,20 @@ static int ade7758_configure_ring(struct iio_dev *indio_dev)
 {
 	return 0;
 }
+
 static inline void ade7758_unconfigure_ring(struct iio_dev *indio_dev)
 {
 }
+
 static inline int ade7758_initialize_ring(struct iio_ring_buffer *ring)
 {
 	return 0;
 }
+
 static inline void ade7758_uninitialize_ring(struct iio_dev *indio_dev)
 {
 }
+
 #endif /* CONFIG_IIO_BUFFER */
 
 #endif
-- 
1.8.3.4



^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH 4/4] Staging: iio: ade7758: Fix open parentheses alignment issues.
  2016-03-21  7:36 [PATCH 0/4] Staging: iio: Fix coding style issues Sandhya Bankar
                   ` (2 preceding siblings ...)
  2016-03-21  7:45 ` [PATCH 3/4] Staging: iio: ade7758: Use a blank line after function/struct declarations Sandhya Bankar
@ 2016-03-21  7:47 ` Sandhya Bankar
  3 siblings, 0 replies; 5+ messages in thread
From: Sandhya Bankar @ 2016-03-21  7:47 UTC (permalink / raw)
  To: outreachy-kernel

Fix open parentheses alignment issues.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/iio/meter/ade7758.h | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/iio/meter/ade7758.h b/drivers/staging/iio/meter/ade7758.h
index ff7c764..1d04ec9 100644
--- a/drivers/staging/iio/meter/ade7758.h
+++ b/drivers/staging/iio/meter/ade7758.h
@@ -139,19 +139,15 @@ void ade7758_remove_trigger(struct iio_dev *indio_dev);
 int ade7758_probe_trigger(struct iio_dev *indio_dev);
 
 ssize_t ade7758_read_data_from_ring(struct device *dev,
-		struct device_attribute *attr,
-		char *buf);
-
+				    struct device_attribute *attr, char *buf);
 
 int ade7758_configure_ring(struct iio_dev *indio_dev);
 void ade7758_unconfigure_ring(struct iio_dev *indio_dev);
 
 int ade7758_set_irq(struct device *dev, bool enable);
 
-int ade7758_spi_write_reg_8(struct device *dev,
-		u8 reg_address, u8 val);
-int ade7758_spi_read_reg_8(struct device *dev,
-		u8 reg_address, u8 *val);
+int ade7758_spi_write_reg_8(struct device *dev, u8 reg_address, u8 val);
+int ade7758_spi_read_reg_8(struct device *dev, u8 reg_address, u8 *val);
 
 #else /* CONFIG_IIO_BUFFER */
 
-- 
1.8.3.4



^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-21 14:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-21  7:36 [PATCH 0/4] Staging: iio: Fix coding style issues Sandhya Bankar
2016-03-21  7:41 ` [PATCH 1/4] Staging: iio: ade7758_core: Fix open parentheses alignment issues Sandhya Bankar
2016-03-21  7:43 ` [PATCH 2/4] Staging: iio: ade7758_core: Remove unnecessary blank line Sandhya Bankar
2016-03-21  7:45 ` [PATCH 3/4] Staging: iio: ade7758: Use a blank line after function/struct declarations Sandhya Bankar
2016-03-21  7:47 ` [PATCH 4/4] Staging: iio: ade7758: Fix open parentheses alignment issues Sandhya Bankar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.