From: Jeff Johnson <jjohnson@codeaurora.org> To: Maharaja Kennadyrajan <mkenna@codeaurora.org> Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, ath11k <ath11k-bounces@lists.infradead.org> Subject: Re: [PATCH v5 3/3] ath11k: Add support for beacon tx mode Date: Tue, 10 Aug 2021 08:54:37 -0700 [thread overview] Message-ID: <f5df29c9e3322a82198bf21689779326@codeaurora.org> (raw) In-Reply-To: <1628585783-21139-4-git-send-email-mkenna@codeaurora.org> On 2021-08-10 01:56, Maharaja Kennadyrajan wrote: > Add support to configure the beacon tx mode in > the driver. > > Beacons can be sent out in burst(continuously in a single shot > one after another) or staggered (equally spread out over beacon > interval) mode. > > Use the below configuration in the hostapd/wpa_supplicant > for AP/MESH mode to configure the beacon tx mode. > > "beacon_tx_mode=N", where N = 1 for STAGGERED beacon mode > and N = 2 for BURST beacon mode. > > Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-00480-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Maharaja Kennadyrajan <mkenna@codeaurora.org> > --- > drivers/net/wireless/ath/ath11k/mac.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath11k/mac.c > b/drivers/net/wireless/ath/ath11k/mac.c > index e9b3689..2eda788 100644 > --- a/drivers/net/wireless/ath/ath11k/mac.c > +++ b/drivers/net/wireless/ath/ath11k/mac.c > @@ -2136,7 +2136,10 @@ static void > ath11k_mac_op_bss_info_changed(struct > ieee80211_hw *hw, > > if (changed & BSS_CHANGED_BEACON) { > param_id = WMI_PDEV_PARAM_BEACON_TX_MODE; > - param_value = WMI_BEACON_STAGGERED_MODE; > + if (info->beacon_tx_mode == NL80211_BEACON_BURST_MODE) > + param_value = WMI_BEACON_BURST_MODE; > + else > + param_value = WMI_BEACON_STAGGERED_MODE; > ret = ath11k_wmi_pdev_set_param(ar, param_id, > param_value, > ar->pdev->pdev_id); > if (ret) > @@ -2144,8 +2147,9 @@ static void ath11k_mac_op_bss_info_changed(struct > ieee80211_hw *hw, > arvif->vdev_id); > else > ath11k_dbg(ar->ab, ATH11K_DBG_MAC, > - "Set staggered beacon mode for VDEV: > %d\n", > - arvif->vdev_id); > + "Set %s beacon mode for VDEV: %d mode: > %d\n", > + param_value ? "burst" : "staggered", Suggest this should be param_value == WMI_BEACON_BURST_MODE ? or other similar logic since ideally code should avoid making assumptions about the values assigned to enumerators > + arvif->vdev_id, param_value); > > ret = ath11k_mac_setup_bcn_tmpl(arvif); > if (ret) > -- > 2.7.4 -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Johnson <jjohnson@codeaurora.org> To: Maharaja Kennadyrajan <mkenna@codeaurora.org> Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, ath11k <ath11k-bounces@lists.infradead.org> Subject: Re: [PATCH v5 3/3] ath11k: Add support for beacon tx mode Date: Tue, 10 Aug 2021 08:54:37 -0700 [thread overview] Message-ID: <f5df29c9e3322a82198bf21689779326@codeaurora.org> (raw) In-Reply-To: <1628585783-21139-4-git-send-email-mkenna@codeaurora.org> On 2021-08-10 01:56, Maharaja Kennadyrajan wrote: > Add support to configure the beacon tx mode in > the driver. > > Beacons can be sent out in burst(continuously in a single shot > one after another) or staggered (equally spread out over beacon > interval) mode. > > Use the below configuration in the hostapd/wpa_supplicant > for AP/MESH mode to configure the beacon tx mode. > > "beacon_tx_mode=N", where N = 1 for STAGGERED beacon mode > and N = 2 for BURST beacon mode. > > Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-00480-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Maharaja Kennadyrajan <mkenna@codeaurora.org> > --- > drivers/net/wireless/ath/ath11k/mac.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath11k/mac.c > b/drivers/net/wireless/ath/ath11k/mac.c > index e9b3689..2eda788 100644 > --- a/drivers/net/wireless/ath/ath11k/mac.c > +++ b/drivers/net/wireless/ath/ath11k/mac.c > @@ -2136,7 +2136,10 @@ static void > ath11k_mac_op_bss_info_changed(struct > ieee80211_hw *hw, > > if (changed & BSS_CHANGED_BEACON) { > param_id = WMI_PDEV_PARAM_BEACON_TX_MODE; > - param_value = WMI_BEACON_STAGGERED_MODE; > + if (info->beacon_tx_mode == NL80211_BEACON_BURST_MODE) > + param_value = WMI_BEACON_BURST_MODE; > + else > + param_value = WMI_BEACON_STAGGERED_MODE; > ret = ath11k_wmi_pdev_set_param(ar, param_id, > param_value, > ar->pdev->pdev_id); > if (ret) > @@ -2144,8 +2147,9 @@ static void ath11k_mac_op_bss_info_changed(struct > ieee80211_hw *hw, > arvif->vdev_id); > else > ath11k_dbg(ar->ab, ATH11K_DBG_MAC, > - "Set staggered beacon mode for VDEV: > %d\n", > - arvif->vdev_id); > + "Set %s beacon mode for VDEV: %d mode: > %d\n", > + param_value ? "burst" : "staggered", Suggest this should be param_value == WMI_BEACON_BURST_MODE ? or other similar logic since ideally code should avoid making assumptions about the values assigned to enumerators > + arvif->vdev_id, param_value); > > ret = ath11k_mac_setup_bcn_tmpl(arvif); > if (ret) > -- > 2.7.4 -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2021-08-10 15:54 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-10 8:56 [PATCH v5 0/3] Add support to configure beacon tx mode Maharaja Kennadyrajan 2021-08-10 8:56 ` Maharaja Kennadyrajan 2021-08-10 8:56 ` [PATCH v5 1/3] nl80211: Add support for " Maharaja Kennadyrajan 2021-08-10 8:56 ` Maharaja Kennadyrajan 2021-08-10 10:14 ` Felix Fietkau 2021-08-10 10:14 ` Felix Fietkau 2021-08-10 12:02 ` Maharaja Kennadyrajan 2021-08-10 12:02 ` Maharaja Kennadyrajan 2021-08-10 14:33 ` Felix Fietkau 2021-08-10 14:33 ` Felix Fietkau 2021-08-10 10:52 ` Sven Eckelmann 2021-08-10 10:52 ` Sven Eckelmann 2022-03-24 18:10 ` Maharaja Kennadyrajan 2022-03-24 18:10 ` Maharaja Kennadyrajan 2022-03-25 7:26 ` Sven Eckelmann 2022-03-25 7:26 ` Sven Eckelmann 2021-08-10 15:43 ` Jeff Johnson 2021-08-10 15:43 ` Jeff Johnson 2021-08-10 8:56 ` [PATCH v5 2/3] mac80211: " Maharaja Kennadyrajan 2021-08-10 8:56 ` Maharaja Kennadyrajan 2021-08-10 8:56 ` [PATCH v5 3/3] ath11k: " Maharaja Kennadyrajan 2021-08-10 8:56 ` Maharaja Kennadyrajan 2021-08-10 15:54 ` Jeff Johnson [this message] 2021-08-10 15:54 ` Jeff Johnson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f5df29c9e3322a82198bf21689779326@codeaurora.org \ --to=jjohnson@codeaurora.org \ --cc=ath11k-bounces@lists.infradead.org \ --cc=ath11k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ --cc=mkenna@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.