* [PATCH net v1] net/smc: Add warning about remote memory exposure
@ 2017-05-16 6:51 Leon Romanovsky
[not found] ` <20170516065138.24789-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Leon Romanovsky @ 2017-05-16 6:51 UTC (permalink / raw)
To: davem; +Cc: ubraun, netdev, iinux-rdma, Christoph Hellwig
From: Christoph Hellwig <hch@lst.de>
The driver explicitly bypasses APIs to register all memory once a
connection is made, and thus allows remote access to memory.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
---
Dave,
Can you please forward this patch to stable?
Thanks
---
Changes from v0:
* Remove BROKEN Kconfig option as a followup of this discussion
https://patchwork.ozlabs.org/patch/760454/
* Refine commit message
---
net/smc/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/net/smc/Kconfig b/net/smc/Kconfig
index c717ef0896aa..33954852f3f8 100644
--- a/net/smc/Kconfig
+++ b/net/smc/Kconfig
@@ -8,6 +8,10 @@ config SMC
The Linux implementation of the SMC-R solution is designed as
a separate socket family SMC.
+ Warning: SMC will expose all memory for remote reads and writes
+ once a connection is established. Don't enable this option except
+ for tightly controlled lab environment.
+
Select this option if you want to run SMC socket applications
config SMC_DIAG
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net v1] net/smc: Add warning about remote memory exposure
[not found] ` <20170516065138.24789-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2017-05-16 7:03 ` Leon Romanovsky
0 siblings, 0 replies; 4+ messages in thread
From: Leon Romanovsky @ 2017-05-16 7:03 UTC (permalink / raw)
To: davem-fT/PcQaiUtIeIZ0/mPfg9Q
Cc: ubraun-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8,
netdev-u79uwXL29TY76Z2rM5mHXA, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
Christoph Hellwig
[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]
+ linux-rdma ML.
On Tue, May 16, 2017 at 09:51:38AM +0300, Leon Romanovsky wrote:
> From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
>
> The driver explicitly bypasses APIs to register all memory once a
> connection is made, and thus allows remote access to memory.
>
> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> Dave,
> Can you please forward this patch to stable?
> Thanks
> ---
> Changes from v0:
> * Remove BROKEN Kconfig option as a followup of this discussion
> https://patchwork.ozlabs.org/patch/760454/
> * Refine commit message
> ---
> net/smc/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/net/smc/Kconfig b/net/smc/Kconfig
> index c717ef0896aa..33954852f3f8 100644
> --- a/net/smc/Kconfig
> +++ b/net/smc/Kconfig
> @@ -8,6 +8,10 @@ config SMC
> The Linux implementation of the SMC-R solution is designed as
> a separate socket family SMC.
>
> + Warning: SMC will expose all memory for remote reads and writes
> + once a connection is established. Don't enable this option except
> + for tightly controlled lab environment.
> +
> Select this option if you want to run SMC socket applications
>
> config SMC_DIAG
> --
> 2.12.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v1] net/smc: Add warning about remote memory exposure
2017-05-16 6:51 [PATCH net v1] net/smc: Add warning about remote memory exposure Leon Romanovsky
[not found] ` <20170516065138.24789-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2017-05-16 15:04 ` Ursula Braun
2017-05-16 18:53 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Ursula Braun @ 2017-05-16 15:04 UTC (permalink / raw)
To: Leon Romanovsky, davem; +Cc: netdev, iinux-rdma, Christoph Hellwig
On 05/16/2017 08:51 AM, Leon Romanovsky wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> The driver explicitly bypasses APIs to register all memory once a
> connection is made, and thus allows remote access to memory.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Leon Romanovsky <leon@kernel.org>
> ---
> Dave,
> Can you please forward this patch to stable?
> Thanks
> ---
> Changes from v0:
> * Remove BROKEN Kconfig option as a followup of this discussion
> https://patchwork.ozlabs.org/patch/760454/
> * Refine commit message
> ---
> net/smc/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/net/smc/Kconfig b/net/smc/Kconfig
> index c717ef0896aa..33954852f3f8 100644
> --- a/net/smc/Kconfig
> +++ b/net/smc/Kconfig
> @@ -8,6 +8,10 @@ config SMC
> The Linux implementation of the SMC-R solution is designed as
> a separate socket family SMC.
>
> + Warning: SMC will expose all memory for remote reads and writes
> + once a connection is established. Don't enable this option except
> + for tightly controlled lab environment.
> +
> Select this option if you want to run SMC socket applications
>
> config SMC_DIAG
> --
> 2.12.2
>
Acked-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v1] net/smc: Add warning about remote memory exposure
2017-05-16 6:51 [PATCH net v1] net/smc: Add warning about remote memory exposure Leon Romanovsky
[not found] ` <20170516065138.24789-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-05-16 15:04 ` Ursula Braun
@ 2017-05-16 18:53 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-05-16 18:53 UTC (permalink / raw)
To: leon; +Cc: ubraun, netdev, iinux-rdma, hch
From: Leon Romanovsky <leon@kernel.org>
Date: Tue, 16 May 2017 09:51:38 +0300
> From: Christoph Hellwig <hch@lst.de>
>
> The driver explicitly bypasses APIs to register all memory once a
> connection is made, and thus allows remote access to memory.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Leon Romanovsky <leon@kernel.org>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-16 18:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-16 6:51 [PATCH net v1] net/smc: Add warning about remote memory exposure Leon Romanovsky
[not found] ` <20170516065138.24789-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-05-16 7:03 ` Leon Romanovsky
2017-05-16 15:04 ` Ursula Braun
2017-05-16 18:53 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.