All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Kucheria <amit.kucheria@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org,
	viresh.kumar@linaro.org, edubezval@gmail.com,
	andy.gross@linaro.org, tdas@codeaurora.org, swboyd@chromium.org,
	dianders@chromium.org, mka@chromium.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"open list:CPU FREQUENCY DRIVERS" <linux-pm@vger.kernel.org>
Subject: [PATCH v1 4/7] cpufreq: qcom-hw: Move to device_initcall
Date: Thu, 10 Jan 2019 05:30:53 +0530	[thread overview]
Message-ID: <f62562bb1f8ffc021a814707e0c74a91d5d0746f.1547078153.git.amit.kucheria@linaro.org> (raw)
In-Reply-To: <cover.1547078153.git.amit.kucheria@linaro.org>
In-Reply-To: <cover.1547078153.git.amit.kucheria@linaro.org>

subsys_initcall causes problems registering the driver as a thermal
cooling device.

If "faster boot" is the main reason for doing subsys_initcall, this
should be handled in the bootloader or another boot constraint
framework.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 drivers/cpufreq/qcom-cpufreq-hw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c
index d83939a1b3d4..649dddd72749 100644
--- a/drivers/cpufreq/qcom-cpufreq-hw.c
+++ b/drivers/cpufreq/qcom-cpufreq-hw.c
@@ -296,7 +296,7 @@ static int __init qcom_cpufreq_hw_init(void)
 {
 	return platform_driver_register(&qcom_cpufreq_hw_driver);
 }
-subsys_initcall(qcom_cpufreq_hw_init);
+device_initcall(qcom_cpufreq_hw_init);
 
 static void __exit qcom_cpufreq_hw_exit(void)
 {
-- 
2.17.1

WARNING: multiple messages have this Message-ID (diff)
From: Amit Kucheria <amit.kucheria@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org,
	viresh.kumar@linaro.org, edubezval@gmail.com,
	andy.gross@linaro.org, tdas@codeaurora.org, swboyd@chromium.org,
	dianders@chromium.org, mka@chromium.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-pm@vger.kernel.org (open list:CPU FREQUENCY DRIVERS)
Subject: [PATCH v1 4/7] cpufreq: qcom-hw: Move to device_initcall
Date: Thu, 10 Jan 2019 05:30:53 +0530	[thread overview]
Message-ID: <f62562bb1f8ffc021a814707e0c74a91d5d0746f.1547078153.git.amit.kucheria@linaro.org> (raw)
In-Reply-To: <cover.1547078153.git.amit.kucheria@linaro.org>
In-Reply-To: <cover.1547078153.git.amit.kucheria@linaro.org>

subsys_initcall causes problems registering the driver as a thermal
cooling device.

If "faster boot" is the main reason for doing subsys_initcall, this
should be handled in the bootloader or another boot constraint
framework.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 drivers/cpufreq/qcom-cpufreq-hw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c
index d83939a1b3d4..649dddd72749 100644
--- a/drivers/cpufreq/qcom-cpufreq-hw.c
+++ b/drivers/cpufreq/qcom-cpufreq-hw.c
@@ -296,7 +296,7 @@ static int __init qcom_cpufreq_hw_init(void)
 {
 	return platform_driver_register(&qcom_cpufreq_hw_driver);
 }
-subsys_initcall(qcom_cpufreq_hw_init);
+device_initcall(qcom_cpufreq_hw_init);
 
 static void __exit qcom_cpufreq_hw_exit(void)
 {
-- 
2.17.1


  parent reply	other threads:[~2019-01-10  0:00 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10  0:00 [PATCH v1 0/7] Thermal throttling for SDM845 Amit Kucheria
2019-01-10  0:00 ` Amit Kucheria
2019-01-10  0:00 ` [PATCH v1 1/7] drivers: thermal: of-thermal: Print name of device node with error Amit Kucheria
2019-01-10  0:00   ` Amit Kucheria
2019-01-10  0:15   ` Stephen Boyd
2019-01-10  0:00 ` [PATCH v1 2/7] drivers: cpufreq: Add thermal_cooling_device pointer to struct cpufreq_policy Amit Kucheria
2019-01-10  0:00   ` Amit Kucheria
2019-01-10  1:01   ` Matthias Kaehlcke
2019-01-10  0:00 ` [PATCH v1 3/7] cpu_cooling: Add generic driver ready callback Amit Kucheria
2019-01-10  0:00   ` Amit Kucheria
2019-01-10  6:14   ` Viresh Kumar
2019-01-10  0:00 ` Amit Kucheria [this message]
2019-01-10  0:00   ` [PATCH v1 4/7] cpufreq: qcom-hw: Move to device_initcall Amit Kucheria
2019-01-10  6:44   ` Viresh Kumar
2019-01-10  0:00 ` [PATCH v1 5/7] cpufreq: qcom-hw: Register as a cpufreq cooling device Amit Kucheria
2019-01-10  0:00   ` Amit Kucheria
2019-01-10  6:12   ` Viresh Kumar
2019-01-10  9:03     ` Amit Kucheria
2019-01-10  9:32     ` Rafael J. Wysocki
2019-01-10  0:00 ` [PATCH v1 6/7] arm64: dts: sdm845: Increase alert trip point to 95 degrees Amit Kucheria
2019-01-10  0:00   ` Amit Kucheria
2019-01-10  0:29   ` Stephen Boyd
2019-01-10 17:14     ` Doug Anderson
2019-01-10 17:14       ` Doug Anderson
2019-01-10 20:06     ` Amit Kucheria
2019-01-10 20:06       ` Amit Kucheria
2019-01-10  1:15   ` Matthias Kaehlcke
2019-01-10  1:15     ` Matthias Kaehlcke
2019-01-10  2:15     ` Matthias Kaehlcke
2019-01-10  2:15       ` Matthias Kaehlcke
2019-01-10 19:45       ` Amit Kucheria
2019-01-10 19:45         ` Amit Kucheria
2019-01-10 20:00         ` Matthias Kaehlcke
2019-01-10 20:00           ` Matthias Kaehlcke
2019-01-11  3:32           ` Viresh Kumar
2019-01-11  3:32             ` Viresh Kumar
2019-01-11 10:24     ` Amit Kucheria
2019-01-11 10:24       ` Amit Kucheria
2019-01-11 18:30       ` Matthias Kaehlcke
2019-01-11 18:30         ` Matthias Kaehlcke
2019-01-10  0:00 ` [PATCH v1 7/7] arm64: dts: sdm845: wireup the thermal trip points to cpufreq Amit Kucheria
2019-01-10  0:00   ` Amit Kucheria
2019-01-10  0:28   ` Stephen Boyd
2019-01-10 12:28     ` Amit Kucheria
2019-01-10 12:28       ` Amit Kucheria
2019-01-10  2:22   ` Matthias Kaehlcke
2019-01-10  2:22     ` Matthias Kaehlcke
2019-01-10  6:23     ` Viresh Kumar
2019-01-10  6:23       ` Viresh Kumar
2019-01-10 18:42       ` Matthias Kaehlcke
2019-01-10 18:42         ` Matthias Kaehlcke
2019-01-11  3:46         ` Viresh Kumar
2019-01-11  3:46           ` Viresh Kumar
2019-01-11 19:58           ` Matthias Kaehlcke
2019-01-11 19:58             ` Matthias Kaehlcke
2019-01-14  5:59             ` Viresh Kumar
2019-01-14  5:59               ` Viresh Kumar
2019-01-11  0:30   ` Matthias Kaehlcke
2019-01-11  0:30     ` Matthias Kaehlcke
2019-01-11 11:17     ` Amit Kucheria
2019-01-11 11:17       ` Amit Kucheria
2019-01-11 20:36       ` Matthias Kaehlcke
2019-01-11 20:36         ` Matthias Kaehlcke
2019-01-14  8:22         ` Amit Kucheria
2019-01-14  8:22           ` Amit Kucheria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f62562bb1f8ffc021a814707e0c74a91d5d0746f.1547078153.git.amit.kucheria@linaro.org \
    --to=amit.kucheria@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=edubezval@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=rjw@rjwysocki.net \
    --cc=swboyd@chromium.org \
    --cc=tdas@codeaurora.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.