* [PATCH] AMD/IOMMU: don't increase perms when splitting superpage
@ 2021-08-19 8:04 Jan Beulich
2021-08-19 18:54 ` Paul Durrant
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2021-08-19 8:04 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Paul Durrant
The old (super)page's permissions ought to be propagated, rather than
blindly allowing both reads and writes.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -231,7 +231,7 @@ static int iommu_pde_from_dfn(struct dom
next_table_mfn = mfn_x(page_to_mfn(table));
set_iommu_ptes_present(next_table_mfn, pfn, mfn, PTE_PER_TABLE_SIZE,
- next_level, true, true);
+ next_level, pde->iw, pde->ir);
smp_wmb();
set_iommu_pde_present(pde, next_table_mfn, next_level, true,
true);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] AMD/IOMMU: don't increase perms when splitting superpage
2021-08-19 8:04 [PATCH] AMD/IOMMU: don't increase perms when splitting superpage Jan Beulich
@ 2021-08-19 18:54 ` Paul Durrant
0 siblings, 0 replies; 2+ messages in thread
From: Paul Durrant @ 2021-08-19 18:54 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Andrew Cooper
On 19/08/2021 09:04, Jan Beulich wrote:
> The old (super)page's permissions ought to be propagated, rather than
> blindly allowing both reads and writes.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Paul Durrant <paul@xen.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-19 18:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-19 8:04 [PATCH] AMD/IOMMU: don't increase perms when splitting superpage Jan Beulich
2021-08-19 18:54 ` Paul Durrant
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.