All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Arvind Sankar <nivedita@alum.mit.edu>,
	x86@kernel.org, Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-sh@vger.kernel.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	sparclinux@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] sh/mm: Drop unused MAX_PHYSADDR_BITS
Date: Fri, 24 Jul 2020 08:22:41 +0000	[thread overview]
Message-ID: <f65927b5-ded7-fdd2-c7c1-c2419ded6a2c@redhat.com> (raw)
In-Reply-To: <20200723231544.17274-3-nivedita@alum.mit.edu>

On 24.07.20 01:15, Arvind Sankar wrote:
> The macro is not used anywhere, so remove the definition.
> 
> Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
> ---
>  arch/sh/include/asm/sparsemem.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/sh/include/asm/sparsemem.h b/arch/sh/include/asm/sparsemem.h
> index 4eb899751e45..084706bb8cca 100644
> --- a/arch/sh/include/asm/sparsemem.h
> +++ b/arch/sh/include/asm/sparsemem.h
> @@ -5,11 +5,9 @@
>  #ifdef __KERNEL__
>  /*
>   * SECTION_SIZE_BITS		2^N: how big each section will be
> - * MAX_PHYSADDR_BITS		2^N: how much physical address space we have
> - * MAX_PHYSMEM_BITS		2^N: how much memory we can have in that space
> + * MAX_PHYSMEM_BITS		2^N: how much physical address space we have
>   */
>  #define SECTION_SIZE_BITS	26
> -#define MAX_PHYSADDR_BITS	32
>  #define MAX_PHYSMEM_BITS	32
>  
>  #endif
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb

WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: Arvind Sankar <nivedita@alum.mit.edu>,
	x86@kernel.org, Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-sh@vger.kernel.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	sparclinux@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] sh/mm: Drop unused MAX_PHYSADDR_BITS
Date: Fri, 24 Jul 2020 10:22:41 +0200	[thread overview]
Message-ID: <f65927b5-ded7-fdd2-c7c1-c2419ded6a2c@redhat.com> (raw)
In-Reply-To: <20200723231544.17274-3-nivedita@alum.mit.edu>

On 24.07.20 01:15, Arvind Sankar wrote:
> The macro is not used anywhere, so remove the definition.
> 
> Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
> ---
>  arch/sh/include/asm/sparsemem.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/sh/include/asm/sparsemem.h b/arch/sh/include/asm/sparsemem.h
> index 4eb899751e45..084706bb8cca 100644
> --- a/arch/sh/include/asm/sparsemem.h
> +++ b/arch/sh/include/asm/sparsemem.h
> @@ -5,11 +5,9 @@
>  #ifdef __KERNEL__
>  /*
>   * SECTION_SIZE_BITS		2^N: how big each section will be
> - * MAX_PHYSADDR_BITS		2^N: how much physical address space we have
> - * MAX_PHYSMEM_BITS		2^N: how much memory we can have in that space
> + * MAX_PHYSMEM_BITS		2^N: how much physical address space we have
>   */
>  #define SECTION_SIZE_BITS	26
> -#define MAX_PHYSADDR_BITS	32
>  #define MAX_PHYSMEM_BITS	32
>  
>  #endif
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb


  reply	other threads:[~2020-07-24  8:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23 23:15 [PATCH 0/3] Drop unused MAX_PHYSADDR_BITS Arvind Sankar
2020-07-23 23:15 ` Arvind Sankar
2020-07-23 23:15 ` [PATCH 1/3] x86/mm: " Arvind Sankar
2020-07-23 23:15   ` Arvind Sankar
2020-07-24  7:56   ` [tip: x86/cleanups] " tip-bot2 for Arvind Sankar
2020-07-24  8:22   ` [PATCH 1/3] " David Hildenbrand
2020-07-24  8:22     ` David Hildenbrand
2020-07-23 23:15 ` [PATCH 2/3] sh/mm: " Arvind Sankar
2020-07-23 23:15   ` Arvind Sankar
2020-07-24  8:22   ` David Hildenbrand [this message]
2020-07-24  8:22     ` David Hildenbrand
2020-07-23 23:15 ` [PATCH 3/3] sparc: " Arvind Sankar
2020-07-23 23:15   ` Arvind Sankar
2020-07-24  8:22   ` David Hildenbrand
2020-07-24  8:22     ` David Hildenbrand
2020-07-24 23:37   ` David Miller
2020-07-24 23:37     ` David Miller
2020-07-24 15:04 ` [PATCH 0/3] " Dave Hansen
2020-07-24 15:04   ` Dave Hansen
2020-07-26  6:48 ` Mike Rapoport
2020-07-26  6:48   ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f65927b5-ded7-fdd2-c7c1-c2419ded6a2c@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dalias@libc.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=nivedita@alum.mit.edu \
    --cc=peterz@infradead.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=x86@kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.