Re: [PATCH] media: siano: Use the correct style for SPDX License Identifier

From: Joe Perches <joe@perches.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Nishad Kamdar" <nishadkamdar@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: siano: Use the correct style for SPDX License Identifier
Date: Thu, 05 Sep 2019 02:28:05 -0700	[thread overview]
Message-ID: <f65bf8e7bc3234358d5956f94e3b4df81bc204e6.camel@perches.com> (raw)
In-Reply-To: <20190905055614.7958918b@coco.lan>

On Thu, 2019-09-05 at 05:56 -0300, Mauro Carvalho Chehab wrote:
> I'll accept
> this patch and keep such rule in mind for next SPDX changes.
> 
> Anyway, with regards to script, we need to change the rules in order to
> allow adding SPDX for python scripts, as otherwise the addition of SPDX
> headers may cause regressions.

Not really.

$ git grep -n '^# SPDX-License-Identifier' -- '*.py' | wc -l
62
$ git grep -n '^# SPDX-License-Identifier' -- '*.py' | \
  cut -f2 -d: | sort | uniq -c
     32 1
     27 2
      3 3
$ git grep -n '^# SPDX-License-Identifier' -- '*.py' | \
  cut -f1 -d: | xargs ./scripts/spdxcheck.py --verbose

License files:               14
Exception files:              2
License IDs                  19
Exception IDs                 2

Files checked:               62
Lines checked:               95
Files with SPDX:             62
Files with errors:            0